219616 2020-12-07 14:54:49 -0800 [ESNext] op_put_private_name is wrong 2020-12-08 06:53:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1712629 0 ticaiolima 2020-12-07 14:54:49 -0800 ... 1712633 1 415590 ticaiolima 2020-12-07 14:57:00 -0800 Created attachment 415590 Patch 1712637 2 415590 tzagallo 2020-12-07 15:09:47 -0800 Comment on attachment 415590 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415590&action=review r=me with a small nit > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1796 > + bqneq t3, t1, .opPutPrivateNameSlow Should't this be a `bpneq`? 1712751 3 415629 ticaiolima 2020-12-08 05:50:08 -0800 Created attachment 415629 Patch 1712753 4 415629 ticaiolima 2020-12-08 05:51:14 -0800 Comment on attachment 415629 Patch Thank you very much for the review! 1712778 5 ews-feeder 2020-12-08 06:52:18 -0800 Committed r270537: <https://trac.webkit.org/changeset/270537> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415629. 1712779 6 webkit-bug-importer 2020-12-08 06:53:14 -0800 <rdar://problem/72091196> 415590 2020-12-07 14:57:00 -0800 2020-12-08 05:50:04 -0800 Patch bug-219616-20201207195659.patch text/plain 1589 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw N2QxZDdlOWFjMDUwM2U3MzEzZWIzZTQ1ZjVkYjVlNjAwNmFhZTcwLi5kNGU3ZmYxYzkzM2JkYzc0 OTEzMTljMjE0NzAxNWJiMjdjNTZiZmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0xMi0wNyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0VTTmV4dF0gb3BfcHV0X3ByaXZhdGVfbmFtZSBpcyB3cm9uZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NjE2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgYG1fcHJvcGVy dHlgIGlzIGEgSlNDZWxsIHBvaW50ZXIsIHdlIG5lZWQgdG8gdXNlIGJvdGggYGxvYWRwYAorICAg ICAgICBhbmQgYGJxbmVxYCBvbiBgb3BfcHV0X3ByaXZhdGVfbmFtZWAuCisKKyAgICAgICAgKiBs bGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOgorCiAyMDIwLTEyLTA3ICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBSZW1vdmUgV0VC S0lUX1dSQVBfU09VUkNFTElTVApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQppbmRleCA1MzRlMGRmM2RlMzAwMDYyZjc1ZjE1 Y2JlNTEzNjQ5YTdkYWE3YTBkLi45YmFmODhlOWY2NTQ5NWFmMjdmMDc4Nzk2NzI1NjhhYzc2M2Yz NjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlcjY0LmFzbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlcjY0LmFzbQpAQCAtMTc5Miw4ICsxNzkyLDggQEAgbGxpbnRPcFdpdGhNZXRhZGF0 YShvcF9wdXRfcHJpdmF0ZV9uYW1lLCBPcFB1dFByaXZhdGVOYW1lLCBtYWNybyAoc2l6ZSwgZ2V0 LCBkaXMKICAgICBsb2FkaSBPcFB1dFByaXZhdGVOYW1lOjpNZXRhZGF0YTo6bV9vbGRTdHJ1Y3R1 cmVJRFt0NV0sIHQyCiAgICAgYmluZXEgdDIsIEpTQ2VsbDo6bV9zdHJ1Y3R1cmVJRFt0MF0sIC5v cFB1dFByaXZhdGVOYW1lU2xvdwogCi0gICAgbG9hZGkgT3BQdXRQcml2YXRlTmFtZTo6TWV0YWRh dGE6Om1fcHJvcGVydHlbdDVdLCB0MwotICAgIGJpbmVxIHQzLCB0MSwgLm9wUHV0UHJpdmF0ZU5h bWVTbG93CisgICAgbG9hZHAgT3BQdXRQcml2YXRlTmFtZTo6TWV0YWRhdGE6Om1fcHJvcGVydHlb dDVdLCB0MworICAgIGJxbmVxIHQzLCB0MSwgLm9wUHV0UHJpdmF0ZU5hbWVTbG93CiAKICAgICAj IEF0IHRoaXMgcG9pbnQsIHdlIGhhdmU6CiAgICAgIyB0MCAtPiBvYmplY3QgYmFzZQo= 415629 2020-12-08 05:50:08 -0800 2020-12-08 06:52:19 -0800 Patch bug-219616-20201208105007.patch text/plain 1588 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw N2QxZDdlOWFjMDUwM2U3MzEzZWIzZTQ1ZjVkYjVlNjAwNmFhZTcwLi5lZTlmZGM2YWY2ZDJjNDU2 OWY3NmMxMjkxOTdmNDNhMWMwYjM5MmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0xMi0wNyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0VTTmV4dF0gb3BfcHV0X3ByaXZhdGVfbmFtZSBpcyB3cm9uZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NjE2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgVGFkZXUgWmFnYWxsby4KKworICAgICAgICBTaW5jZSBgbV9wcm9wZXJ0 eWAgaXMgYSBKU0NlbGwgcG9pbnRlciwgd2UgbmVlZCB0byB1c2UgYm90aCBgbG9hZHBgCisgICAg ICAgIGFuZCBgYnBuZXFgIG9uIGBvcF9wdXRfcHJpdmF0ZV9uYW1lYC4KKworICAgICAgICAqIGxs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc206CisKIDIwMjAtMTItMDcgIERvbiBPbG1zdGVh ZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIFJlbW92ZSBXRUJL SVRfV1JBUF9TT1VSQ0VMSVNUCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCmluZGV4IDUzNGUwZGYzZGUzMDAwNjJmNzVmMTVj YmU1MTM2NDlhN2RhYTdhMGQuLjBkY2ExZjgxMjc2ZDg0NGUzMzIzNWRiNTk0YmI5NjkyODAwZjI4 YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyNjQuYXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyNjQuYXNtCkBAIC0xNzkyLDggKzE3OTIsOCBAQCBsbGludE9wV2l0aE1ldGFkYXRh KG9wX3B1dF9wcml2YXRlX25hbWUsIE9wUHV0UHJpdmF0ZU5hbWUsIG1hY3JvIChzaXplLCBnZXQs IGRpcwogICAgIGxvYWRpIE9wUHV0UHJpdmF0ZU5hbWU6Ok1ldGFkYXRhOjptX29sZFN0cnVjdHVy ZUlEW3Q1XSwgdDIKICAgICBiaW5lcSB0MiwgSlNDZWxsOjptX3N0cnVjdHVyZUlEW3QwXSwgLm9w UHV0UHJpdmF0ZU5hbWVTbG93CiAKLSAgICBsb2FkaSBPcFB1dFByaXZhdGVOYW1lOjpNZXRhZGF0 YTo6bV9wcm9wZXJ0eVt0NV0sIHQzCi0gICAgYmluZXEgdDMsIHQxLCAub3BQdXRQcml2YXRlTmFt ZVNsb3cKKyAgICBsb2FkcCBPcFB1dFByaXZhdGVOYW1lOjpNZXRhZGF0YTo6bV9wcm9wZXJ0eVt0 NV0sIHQzCisgICAgYnBuZXEgdDMsIHQxLCAub3BQdXRQcml2YXRlTmFtZVNsb3cKIAogICAgICMg QXQgdGhpcyBwb2ludCwgd2UgaGF2ZToKICAgICAjIHQwIC0+IG9iamVjdCBiYXNlCg==