219610 2020-12-07 12:38:50 -0800 REGRESSION (r270507): ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) under WebCore::RTCRtpSFrameTransformer::updateEncryptionKey 2020-12-07 12:59:55 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=219598 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1712552 0 ryanhaddad 2020-12-07 12:38:50 -0800 TestWebKitAPI.RTCRtpSFrameTransformer.EncryptDecryptKeyID0 ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) /Volumes/Data/slave/catalina-debug/build/WebKitBuild/Debug/usr/local/include/wtf/HashTable.h(649) : void WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::checkKey(const T &) [Key = unsigned long long, Value = WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> >, Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >, HashFunctions = WTF::DefaultHash<unsigned long long>, Traits = WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >::KeyValuePairTraits, KeyTraits = WTF::HashTraits<unsigned long long>, HashTranslator = WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::DefaultHash<unsigned long long> >, T = unsigned long long] 1 0x1047d8cc9 WTFCrash 2 0x121c1720b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x123e7a0ab void WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::checkKey<WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::DefaultHash<unsigned long long> >, unsigned long long>(unsigned long long const&) 4 0x123e79d3f WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::add<WTF::HashMapTranslator<WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::DefaultHash<unsigned long long> >, unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 5 0x123e79cc4 WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::inlineAdd<unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 6 0x123e79c08 WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::inlineSet<unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 7 0x123e4ab9f WTF::HashTableAddResult<WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> > > WTF::HashMap<unsigned long long, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> > >::set<WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&>(unsigned long long const&, WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 8 0x123e4a930 WebCore::RTCRtpSFrameTransformer::updateEncryptionKey(WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::Optional<unsigned long long>, WebCore::RTCRtpSFrameTransformer::ShouldUpdateKeys) 9 0x123e4917d WebCore::RTCRtpSFrameTransformer::setEncryptionKey(WTF::Vector<unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::Optional<unsigned long long>) 10 0x1025ce8b3 TestWebKitAPI::RTCRtpSFrameTransformer_EncryptDecryptKeyID0_Test::TestBody() 11 0x102a22af4 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 12 0x1029f12bb void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 13 0x1029f11f6 testing::Test::Run() 14 0x1029f238a testing::TestInfo::Run() 15 0x1029f3274 testing::TestCase::Run() 16 0x1029fe928 testing::internal::UnitTestImpl::RunAllTests() 17 0x102a27af4 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 18 0x1029fe41b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 19 0x1029fe2ed testing::UnitTest::Run() 20 0x1027ae971 RUN_ALL_TESTS() 21 0x1027ae902 TestWebKitAPI::TestsController::run(int, char**) 22 0x1029bc0b5 main 23 0x7fff6d82fcc9 start 24 0x2 https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/8095/steps/run-api-tests/logs/stdio 1712553 1 ryanhaddad 2020-12-07 12:40:26 -0800 I think this regressed with https://trac.webkit.org/changeset/270507/webkit 1712554 2 webkit-bug-importer 2020-12-07 12:40:41 -0800 <rdar://problem/72059408> 1712556 3 youennf 2020-12-07 12:42:58 -0800 Oh right, we should revert the change. 1712559 4 ryanhaddad 2020-12-07 12:47:39 -0800 Also affected these tests: http/wpt/webrtc/sframe-transform.html webrtc/audio-sframe.html webrtc/sframe-keys.html webrtc/video-sframe.html 1712563 5 ryanhaddad 2020-12-07 12:49:12 -0800 Reverted in https://trac.webkit.org/changeset/270518 1712568 6 youennf 2020-12-07 12:59:55 -0800 Thanks