219608 2020-12-07 12:07:40 -0800 [ews] commit-queue should use only the first email from contributors.json to validate committers and reviewers 2020-12-08 07:19:24 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap ews-watchlist glenn graouts jbedard justin_michaud webkit-bug-importer oldest_to_newest 1712535 0 aakash_jain 2020-12-07 12:07:40 -0800 commit-queue should use only the first email from contributors.json to validate committers and reviewers. Currently contributors.json can have multiple email addresses for any user. However, allowing the committer and reviewer permissions to all those emails isn't very secure. Additional email addresses might be old emails, which can have expired domains that someone could register and become a committer illegitimately. 1712543 1 webkit-bug-importer 2020-12-07 12:25:27 -0800 <rdar://problem/72058809> 1712572 2 415574 aakash_jain 2020-12-07 13:24:44 -0800 Created attachment 415574 Patch 1712574 3 415574 ap 2020-12-07 13:26:31 -0800 Comment on attachment 415574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415574&action=review > Tools/ChangeLog:9 > + (ValidateCommiterAndReviewer.load_contributors): Use only first email for validating commiters and reviewers. Did you verify that this won't break CQ for active contributors at least? 1712576 4 415574 ap 2020-12-07 13:27:57 -0800 Comment on attachment 415574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415574&action=review > Tools/CISupport/ews-build/steps.py:760 > + bugzilla_email = emails[0].lower() # We're assuming the first email is a valid bugzilla email I think that this is more like requiring than assuming. Also, valid is probably not the best word here, as it's unclear to me hoe a Bugzilla email can be invalid. Lastly, please put a period at the end of the sentence. 1712577 5 aakash_jain 2020-12-07 13:29:57 -0800 (In reply to Alexey Proskuryakov from comment #3) > Did you verify that this won't break CQ for active contributors at least? Haven't verified yet if all the active contributors have their primary Bugzilla email as the first email in contributors.json (in case of multiple emails). We should do that verification before landing this patch. 1712580 6 aakash_jain 2020-12-07 13:31:32 -0800 (In reply to Alexey Proskuryakov from comment #4) > I think that this is more like requiring than assuming. Also, valid is probably not the best word here, as it's unclear to me how a Bugzilla email can be invalid. Yeah, I simply copied this line from https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/committers.py#L71, will re-word it. 1712625 7 jbedard 2020-12-07 14:40:40 -0800 Far as I can tell, only two contributors would have been broken by this: Antoine Quint graouts@webkit.org Justin Michaud justin@justinmichaud.com feel like we should just fix those two cases. 1712772 8 415637 jbedard 2020-12-08 06:39:38 -0800 Created attachment 415637 Patch 1712775 9 415637 aakash_jain 2020-12-08 06:44:16 -0800 Comment on attachment 415637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415637&action=review > Tools/ChangeLog:1 > +2020-12-08 Aakash Jain <aakash_jain@apple.com> This might need to be updated. 1712777 10 415638 jbedard 2020-12-08 06:48:38 -0800 Created attachment 415638 Patch for landing 1712788 11 ews-feeder 2020-12-08 07:19:23 -0800 Committed r270538: <https://trac.webkit.org/changeset/270538> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415638. 415574 2020-12-07 13:24:44 -0800 2020-12-08 06:39:35 -0800 Patch bug-219608-20201207162443.patch text/plain 1560 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDUyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTEyLTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIHVzZSBvbmx5IHRoZSBmaXJz dCBlbWFpbCBmcm9tIGNvbnRyaWJ1dG9ycy5qc29uIHRvIHZhbGlkYXRlIGNvbW1pdHRlcnMgYW5k IHJldmlld2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE5NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoVmFsaWRhdGVDb21t aXRlckFuZFJldmlld2VyLmxvYWRfY29udHJpYnV0b3JzKTogVXNlIG9ubHkgZmlyc3QgZW1haWwg Zm9yIHZhbGlkYXRpbmcgY29tbWl0ZXJzIGFuZCByZXZpZXdlcnMuCisKIDIwMjAtMTItMDQgIFJ5 YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBB UEkgdGVzdCBnYXJkZW5pbmcsIGRpc2FibGUgZmFpbGluZyB0ZXN0cyBvbiBCaWcgU3VyLgpJbmRl eDogVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNzA1MjApCisrKyBUb29s cy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03NTYsOCAr NzU2LDkgQEAgY2xhc3MgVmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyKGJ1aWxkcwogICAgICAg ICBjb250cmlidXRvcnMgPSB7fQogICAgICAgICBmb3Iga2V5LCB2YWx1ZSBpbiBjb250cmlidXRv cnNfanNvbi5pdGVyaXRlbXMoKToKICAgICAgICAgICAgIGVtYWlscyA9IHZhbHVlLmdldCgnZW1h aWxzJykKLSAgICAgICAgICAgIGZvciBlbWFpbCBpbiBlbWFpbHM6Ci0gICAgICAgICAgICAgICAg Y29udHJpYnV0b3JzW2VtYWlsLmxvd2VyKCldID0geyduYW1lJzoga2V5LCAnc3RhdHVzJzogdmFs dWUuZ2V0KCdzdGF0dXMnKX0KKyAgICAgICAgICAgIGlmIGVtYWlsczoKKyAgICAgICAgICAgICAg ICBidWd6aWxsYV9lbWFpbCA9IGVtYWlsc1swXS5sb3dlcigpICAjIFdlJ3JlIGFzc3VtaW5nIHRo ZSBmaXJzdCBlbWFpbCBpcyBhIHZhbGlkIGJ1Z3ppbGxhIGVtYWlsCisgICAgICAgICAgICAgICAg Y29udHJpYnV0b3JzW2J1Z3ppbGxhX2VtYWlsXSA9IHsnbmFtZSc6IGtleSwgJ3N0YXR1cyc6IHZh bHVlLmdldCgnc3RhdHVzJyl9CiAgICAgICAgIHJldHVybiBjb250cmlidXRvcnMKIAogICAgIEBk ZWZlci5pbmxpbmVDYWxsYmFja3MK 415637 2020-12-08 06:39:38 -0800 2020-12-08 06:48:35 -0800 Patch bug-219608-20201208083937.patch text/plain 2465 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDUzNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTEyLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIHVzZSBvbmx5IHRoZSBmaXJz dCBlbWFpbCBmcm9tIGNvbnRyaWJ1dG9ycy5qc29uIHRvIHZhbGlkYXRlIGNvbW1pdHRlcnMgYW5k IHJldmlld2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE5NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoVmFsaWRhdGVDb21t aXRlckFuZFJldmlld2VyLmxvYWRfY29udHJpYnV0b3JzKTogVXNlIG9ubHkgZmlyc3QgZW1haWwg Zm9yIHZhbGlkYXRpbmcgY29tbWl0ZXJzIGFuZCByZXZpZXdlcnMuCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uOiBDb3JyZWN0IEFudG9p bmUgUXVpbnQncyBhbmQgSnVzdGluIE1pY2hhdWQncyBhY3RpdmUgYWNjb3VudHMuCisKIDIwMjAt MTItMDcgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBzb3J0LVhjb2RlLXByb2plY3QtZmlsZQpJbmRleDogVG9vbHMvQ0lTdXBw b3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNzA1MjQpCisrKyBUb29scy9DSVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03NTYsOCArNzU2LDkgQEAgY2xhc3Mg VmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyKGJ1aWxkcwogICAgICAgICBjb250cmlidXRvcnMg PSB7fQogICAgICAgICBmb3Iga2V5LCB2YWx1ZSBpbiBjb250cmlidXRvcnNfanNvbi5pdGVyaXRl bXMoKToKICAgICAgICAgICAgIGVtYWlscyA9IHZhbHVlLmdldCgnZW1haWxzJykKLSAgICAgICAg ICAgIGZvciBlbWFpbCBpbiBlbWFpbHM6Ci0gICAgICAgICAgICAgICAgY29udHJpYnV0b3JzW2Vt YWlsLmxvd2VyKCldID0geyduYW1lJzoga2V5LCAnc3RhdHVzJzogdmFsdWUuZ2V0KCdzdGF0dXMn KX0KKyAgICAgICAgICAgIGlmIGVtYWlsczoKKyAgICAgICAgICAgICAgICBidWd6aWxsYV9lbWFp bCA9IGVtYWlsc1swXS5sb3dlcigpICAjIFdlJ3JlIHJlcXVpcmluZyB0aGF0IHRoZSBmaXJzdCBl bWFpbCBpcyB0aGUgcHJpbWFyeSBidWd6aWxsYSBlbWFpbAorICAgICAgICAgICAgICAgIGNvbnRy aWJ1dG9yc1tidWd6aWxsYV9lbWFpbF0gPSB7J25hbWUnOiBrZXksICdzdGF0dXMnOiB2YWx1ZS5n ZXQoJ3N0YXR1cycpfQogICAgICAgICByZXR1cm4gY29udHJpYnV0b3JzCiAKICAgICBAZGVmZXIu aW5saW5lQ2FsbGJhY2tzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25m aWcvY29udHJpYnV0b3JzLmpzb24KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uCShyZXZpc2lvbiAyNzA1MjQpCisrKyBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24JKHdv cmtpbmcgY29weSkKQEAgLTY1OSw4ICs2NTksOCBAQAogICAgfSwKICAgICJBbnRvaW5lIFF1aW50 IiA6IHsKICAgICAgICJlbWFpbHMiIDogWwotICAgICAgICAgImdyYW91dHNAYXBwbGUuY29tIiwK LSAgICAgICAgICJncmFvdXRzQHdlYmtpdC5vcmciCisgICAgICAgICAiZ3Jhb3V0c0B3ZWJraXQu b3JnIiwKKyAgICAgICAgICJncmFvdXRzQGFwcGxlLmNvbSIKICAgICAgIF0sCiAgICAgICAibmlj a3MiIDogWwogICAgICAgICAgImdyYW91dHMiCkBAIC0zMjI4LDggKzMyMjgsOCBAQAogICAgfSwK ICAgICJKdXN0aW4gTWljaGF1ZCIgOiB7CiAgICAgICAiZW1haWxzIiA6IFsKLSAgICAgICAgICJq dXN0aW5fbWljaGF1ZEBhcHBsZS5jb20iLAotICAgICAgICAgImp1c3RpbkBqdXN0aW5taWNoYXVk LmNvbSIKKyAgICAgICAgICJqdXN0aW5AanVzdGlubWljaGF1ZC5jb20iLAorICAgICAgICAgImp1 c3Rpbl9taWNoYXVkQGFwcGxlLmNvbSIKICAgICAgIF0sCiAgICAgICAic3RhdHVzIiA6ICJjb21t aXR0ZXIiCiAgICB9LAo= 415638 2020-12-08 06:48:38 -0800 2020-12-08 07:19:23 -0800 Patch for landing bug-219608-20201208084837.patch text/plain 2466 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDUzNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTEyLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIHVzZSBvbmx5IHRoZSBmaXJz dCBlbWFpbCBmcm9tIGNvbnRyaWJ1dG9ycy5qc29uIHRvIHZhbGlkYXRlIGNvbW1pdHRlcnMgYW5k IHJldmlld2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE5NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9uYXRoYW4gQmVkYXJkLgorCisgICAg ICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKFZhbGlkYXRlQ29t bWl0ZXJBbmRSZXZpZXdlci5sb2FkX2NvbnRyaWJ1dG9ycyk6IFVzZSBvbmx5IGZpcnN0IGVtYWls IGZvciB2YWxpZGF0aW5nIGNvbW1pdGVycyBhbmQgcmV2aWV3ZXJzLgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbjogQ29ycmVjdCBBbnRv aW5lIFF1aW50J3MgYW5kIEp1c3RpbiBNaWNoYXVkJ3MgYWN0aXZlIGFjY291bnRzLgorCiAyMDIw LTEyLTA3ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgc29ydC1YY29kZS1wcm9qZWN0LWZpbGUKSW5kZXg6IFRvb2xzL0NJU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2V3 cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjcwNTI0KQorKysgVG9vbHMvQ0lTdXBwb3J0L2V3 cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNzU2LDggKzc1Niw5IEBAIGNsYXNz IFZhbGlkYXRlQ29tbWl0ZXJBbmRSZXZpZXdlcihidWlsZHMKICAgICAgICAgY29udHJpYnV0b3Jz ID0ge30KICAgICAgICAgZm9yIGtleSwgdmFsdWUgaW4gY29udHJpYnV0b3JzX2pzb24uaXRlcml0 ZW1zKCk6CiAgICAgICAgICAgICBlbWFpbHMgPSB2YWx1ZS5nZXQoJ2VtYWlscycpCi0gICAgICAg ICAgICBmb3IgZW1haWwgaW4gZW1haWxzOgotICAgICAgICAgICAgICAgIGNvbnRyaWJ1dG9yc1tl bWFpbC5sb3dlcigpXSA9IHsnbmFtZSc6IGtleSwgJ3N0YXR1cyc6IHZhbHVlLmdldCgnc3RhdHVz Jyl9CisgICAgICAgICAgICBpZiBlbWFpbHM6CisgICAgICAgICAgICAgICAgYnVnemlsbGFfZW1h aWwgPSBlbWFpbHNbMF0ubG93ZXIoKSAgIyBXZSdyZSByZXF1aXJpbmcgdGhhdCB0aGUgZmlyc3Qg ZW1haWwgaXMgdGhlIHByaW1hcnkgYnVnemlsbGEgZW1haWwKKyAgICAgICAgICAgICAgICBjb250 cmlidXRvcnNbYnVnemlsbGFfZW1haWxdID0geyduYW1lJzoga2V5LCAnc3RhdHVzJzogdmFsdWUu Z2V0KCdzdGF0dXMnKX0KICAgICAgICAgcmV0dXJuIGNvbnRyaWJ1dG9ycwogCiAgICAgQGRlZmVy LmlubGluZUNhbGxiYWNrcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29u ZmlnL2NvbnRyaWJ1dG9ycy5qc29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgkocmV2aXNpb24gMjcwNTI0KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uCSh3 b3JraW5nIGNvcHkpCkBAIC02NTksOCArNjU5LDggQEAKICAgIH0sCiAgICAiQW50b2luZSBRdWlu dCIgOiB7CiAgICAgICAiZW1haWxzIiA6IFsKLSAgICAgICAgICJncmFvdXRzQGFwcGxlLmNvbSIs Ci0gICAgICAgICAiZ3Jhb3V0c0B3ZWJraXQub3JnIgorICAgICAgICAgImdyYW91dHNAd2Via2l0 Lm9yZyIsCisgICAgICAgICAiZ3Jhb3V0c0BhcHBsZS5jb20iCiAgICAgICBdLAogICAgICAgIm5p Y2tzIiA6IFsKICAgICAgICAgICJncmFvdXRzIgpAQCAtMzIyOCw4ICszMjI4LDggQEAKICAgIH0s CiAgICAiSnVzdGluIE1pY2hhdWQiIDogewogICAgICAgImVtYWlscyIgOiBbCi0gICAgICAgICAi anVzdGluX21pY2hhdWRAYXBwbGUuY29tIiwKLSAgICAgICAgICJqdXN0aW5AanVzdGlubWljaGF1 ZC5jb20iCisgICAgICAgICAianVzdGluQGp1c3Rpbm1pY2hhdWQuY29tIiwKKyAgICAgICAgICJq dXN0aW5fbWljaGF1ZEBhcHBsZS5jb20iCiAgICAgICBdLAogICAgICAgInN0YXR1cyIgOiAiY29t bWl0dGVyIgogICAgfSwK