219593 2020-12-07 02:15:51 -0800 [WTF] RunLoop::TimerBase should not hold reference to the target RunLoop 2021-01-20 07:39:09 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=219232 InRadar P2 Normal --- 1 zan webkit-unassigned ggaren mcatanzaro webkit-bug-importer oldest_to_newest 1712407 0 zan 2020-12-07 02:15:51 -0800 Spun from bug #219232. Problems described in bugs #219232 and #219591 show that it would be ideal to avoid keeping a RunLoop reference on TimerBase. 1712408 1 415541 zan 2020-12-07 02:16:09 -0800 Created attachment 415541 Provisional changes for GLib implementation 1714399 2 webkit-bug-importer 2020-12-14 02:16:51 -0800 <rdar://problem/72289506> 415541 2020-12-07 02:16:09 -0800 2020-12-07 02:16:09 -0800 Provisional changes for GLib implementation runloop-glib.patch text/plain 3252 zan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3AuaCBiL1NvdXJjZS9XVEYvd3RmL1J1 bkxvb3AuaAppbmRleCAwNDY2ZDQ0NTlkNmIuLmIyZWNhNzZkYzA2ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvUnVuTG9vcC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3AuaApAQCAt MTQwLDggKzE0MCw2IEBAIHB1YmxpYzoKICAgICBwcml2YXRlOgogICAgICAgICBXVEZfRVhQT1JU X1BSSVZBVEUgdm9pZCBzdGFydChTZWNvbmRzIGludGVydmFsLCBib29sIHJlcGVhdCk7CiAKLSAg ICAgICAgUmVmPFJ1bkxvb3A+IG1fcnVuTG9vcDsKLQogI2lmIFVTRShXSU5ET1dTX0VWRU5UX0xP T1ApCiAgICAgICAgIGJvb2wgaXNBY3RpdmUoY29uc3QgQWJzdHJhY3RMb2NrZXImKSBjb25zdDsK ICAgICAgICAgdm9pZCB0aW1lckZpcmVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9n bGliL1J1bkxvb3BHTGliLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvUnVuTG9vcEdMaWIuY3Bw CmluZGV4IDAyN2FhMTA5NjRmMS4uY2UzZmMzNWJlNDUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9nbGliL1J1bkxvb3BHTGliLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9nbGliL1J1bkxv b3BHTGliLmNwcApAQCAtMzMsMTEgKzMzLDYgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKLXR5cGVk ZWYgc3RydWN0IHsKLSAgICBHU291cmNlIHNvdXJjZTsKLSAgICBSdW5Mb29wKiBydW5Mb29wOwot fSBSdW5Mb29wU291cmNlOwotCiBHU291cmNlRnVuY3MgUnVuTG9vcDo6c19ydW5Mb29wU291cmNl RnVuY3Rpb25zID0gewogICAgIG51bGxwdHIsIC8vIHByZXBhcmUKICAgICBudWxscHRyLCAvLyBj aGVjawpAQCAtNDgsMTAgKzQzLDEyIEBAIEdTb3VyY2VGdW5jcyBSdW5Mb29wOjpzX3J1bkxvb3BT b3VyY2VGdW5jdGlvbnMgPSB7CiAgICAgICAgICAgICByZXR1cm4gR19TT1VSQ0VfQ09OVElOVUU7 CiAgICAgICAgIGdfc291cmNlX3NldF9yZWFkeV90aW1lKHNvdXJjZSwgLTEpOwogICAgICAgICBj b25zdCBjaGFyKiBuYW1lID0gZ19zb3VyY2VfZ2V0X25hbWUoc291cmNlKTsKLSAgICAgICAgYXV0 byYgcnVuTG9vcFNvdXJjZSA9ICpyZWludGVycHJldF9jYXN0PFJ1bkxvb3BTb3VyY2UqPihzb3Vy Y2UpOwotICAgICAgICBydW5Mb29wU291cmNlLnJ1bkxvb3AtPm5vdGlmeShSdW5Mb29wOjpFdmVu dDo6V2lsbERpc3BhdGNoLCBuYW1lKTsKKworICAgICAgICBhdXRvJiBydW5Mb29wID0gUnVuTG9v cDo6Y3VycmVudCgpOworICAgICAgICBydW5Mb29wLm5vdGlmeShSdW5Mb29wOjpFdmVudDo6V2ls bERpc3BhdGNoLCBuYW1lKTsKICAgICAgICAgYXV0byByZXR1cm5WYWx1ZSA9IGNhbGxiYWNrKHVz ZXJEYXRhKTsKLSAgICAgICAgcnVuTG9vcFNvdXJjZS5ydW5Mb29wLT5ub3RpZnkoUnVuTG9vcDo6 RXZlbnQ6OkRpZERpc3BhdGNoLCBuYW1lKTsKKyAgICAgICAgcnVuTG9vcC5ub3RpZnkoUnVuTG9v cDo6RXZlbnQ6OkRpZERpc3BhdGNoLCBuYW1lKTsKKwogICAgICAgICByZXR1cm4gcmV0dXJuVmFs dWU7CiAgICAgfSwKICAgICBudWxscHRyLCAvLyBmaW5hbGl6ZQpAQCAtNzAsOSArNjcsNyBAQCBS dW5Mb29wOjpSdW5Mb29wKCkKICAgICBBU1NFUlQoaW5uZXJtb3N0TG9vcCk7CiAgICAgbV9tYWlu TG9vcHMuYXBwZW5kKGlubmVybW9zdExvb3ApOwogCi0gICAgbV9zb3VyY2UgPSBhZG9wdEdSZWYo Z19zb3VyY2VfbmV3KCZSdW5Mb29wOjpzX3J1bkxvb3BTb3VyY2VGdW5jdGlvbnMsIHNpemVvZihS dW5Mb29wU291cmNlKSkpOwotICAgIGF1dG8mIHJ1bkxvb3BTb3VyY2UgPSAqcmVpbnRlcnByZXRf Y2FzdDxSdW5Mb29wU291cmNlKj4obV9zb3VyY2UuZ2V0KCkpOwotICAgIHJ1bkxvb3BTb3VyY2Uu cnVuTG9vcCA9IHRoaXM7CisgICAgbV9zb3VyY2UgPSBhZG9wdEdSZWYoZ19zb3VyY2VfbmV3KCZS dW5Mb29wOjpzX3J1bkxvb3BTb3VyY2VGdW5jdGlvbnMsIHNpemVvZihHU291cmNlKSkpOwogICAg IGdfc291cmNlX3NldF9wcmlvcml0eShtX3NvdXJjZS5nZXQoKSwgUnVuTG9vcFNvdXJjZVByaW9y aXR5OjpSdW5Mb29wRGlzcGF0Y2hlcik7CiAgICAgZ19zb3VyY2Vfc2V0X25hbWUobV9zb3VyY2Uu Z2V0KCksICJbV2ViS2l0XSBSdW5Mb29wIHdvcmsiKTsKICAgICBnX3NvdXJjZV9zZXRfY2FuX3Jl Y3Vyc2UobV9zb3VyY2UuZ2V0KCksIFRSVUUpOwpAQCAtMTU4LDEyICsxNTMsOCBAQCB2b2lkIFJ1 bkxvb3A6Om5vdGlmeShSdW5Mb29wOjpFdmVudCBldmVudCwgY29uc3QgY2hhciogbmFtZSkKIH0K IAogUnVuTG9vcDo6VGltZXJCYXNlOjpUaW1lckJhc2UoUnVuTG9vcCYgcnVuTG9vcCkKLSAgICA6 IG1fcnVuTG9vcChydW5Mb29wKQotICAgICwgbV9zb3VyY2UoYWRvcHRHUmVmKGdfc291cmNlX25l dygmUnVuTG9vcDo6c19ydW5Mb29wU291cmNlRnVuY3Rpb25zLCBzaXplb2YoUnVuTG9vcFNvdXJj ZSkpKSkKKyAgICA6IG1fc291cmNlKGFkb3B0R1JlZihnX3NvdXJjZV9uZXcoJlJ1bkxvb3A6OnNf cnVuTG9vcFNvdXJjZUZ1bmN0aW9ucywgc2l6ZW9mKEdTb3VyY2UpKSkpCiB7Ci0gICAgYXV0byYg cnVuTG9vcFNvdXJjZSA9ICpyZWludGVycHJldF9jYXN0PFJ1bkxvb3BTb3VyY2UqPihtX3NvdXJj ZS5nZXQoKSk7Ci0gICAgcnVuTG9vcFNvdXJjZS5ydW5Mb29wID0gbV9ydW5Mb29wLnB0cigpOwot CiAgICAgZ19zb3VyY2Vfc2V0X3ByaW9yaXR5KG1fc291cmNlLmdldCgpLCBSdW5Mb29wU291cmNl UHJpb3JpdHk6OlJ1bkxvb3BUaW1lcik7CiAgICAgZ19zb3VyY2Vfc2V0X25hbWUobV9zb3VyY2Uu Z2V0KCksICJbV2ViS2l0XSBSdW5Mb29wOjpUaW1lciB3b3JrIik7CiAgICAgZ19zb3VyY2Vfc2V0 X2NhbGxiYWNrKG1fc291cmNlLmdldCgpLCBbXShncG9pbnRlciB1c2VyRGF0YSkgLT4gZ2Jvb2xl YW4gewpAQCAtMTc5LDcgKzE3MCw3IEBAIFJ1bkxvb3A6OlRpbWVyQmFzZTo6VGltZXJCYXNlKFJ1 bkxvb3AmIHJ1bkxvb3ApCiAgICAgICAgICAgICByZXR1cm4gR19TT1VSQ0VfUkVNT1ZFOwogICAg ICAgICByZXR1cm4gR19TT1VSQ0VfQ09OVElOVUU7CiAgICAgfSwgdGhpcywgbnVsbHB0cik7Ci0g ICAgZ19zb3VyY2VfYXR0YWNoKG1fc291cmNlLmdldCgpLCBtX3J1bkxvb3AtPm1fbWFpbkNvbnRl eHQuZ2V0KCkpOworICAgIGdfc291cmNlX2F0dGFjaChtX3NvdXJjZS5nZXQoKSwgcnVuTG9vcC5t X21haW5Db250ZXh0LmdldCgpKTsKIH0KIAogUnVuTG9vcDo6VGltZXJCYXNlOjp+VGltZXJCYXNl KCkK