219580 2020-12-06 08:54:24 -0800 [WebKit] Fix build when GPU_PROCESS is disabled 2020-12-07 05:52:40 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 219578 P2 Normal --- 1 samuel.thibault webkit-unassigned fujii youennf oldest_to_newest 1712324 0 415517 samuel.thibault 2020-12-06 08:54:24 -0800 Created attachment 415517 proposed fix When GPU_PROCESS is disabled, RemoteMediaEngineConfigurationFactoryProxy is disabled in the .h file but not in the .cpp file and its reference. 1712346 1 fujii 2020-12-06 11:58:10 -0800 Thank you very much for taking time to report bug and submit your proposed patch. Could you follow the contribution workflow? https://webkit.org/contributing-code/ 1712348 2 samuel.thibault 2020-12-06 12:03:04 -0800 Well, that is what I did? 1712349 3 fujii 2020-12-06 12:08:42 -0800 Please use prepare-ChangeLog and 'webkit-patch upload' scripts. 1712362 4 415528 samuel.thibault 2020-12-06 13:03:44 -0800 Created attachment 415528 Patch 1712441 5 youennf 2020-12-07 05:52:33 -0800 Thanks Samuel for the patch. A similar fix was done in https://bugs.webkit.org/show_bug.cgi?id=219578. Closing this one as duplicate. *** This bug has been marked as a duplicate of bug 219578 *** 415517 2020-12-06 08:54:24 -0800 2020-12-06 13:03:38 -0800 proposed fix patch text/plain 1761 samuel.thibault MjAyMC0xMi0wNiAgU2FtdWVsIFRoaWJhdWx0ICA8c2FtdWVsLnRoaWJhdWx0QGVucy1seW9uLm9y Zz4KCltXZWJLaXRdIEZpeCBXZWJQcm9jZXNzIGJ1aWxkIHdoZW4gR1BVX1BST0NFU1MgaXMgZGlz YWJsZWQKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKV2hlbiBHUFVfUFJPQ0VTUyBpcyBk aXNhYmxlZCwgUmVtb3RlTWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeVByb3h5LmggZ2V0 cwplbXB0eSBhbmQgZG9lcyBub3QgZGVmaW5lIFJlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlv bkZhY3RvcnkuCgoqIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKFdl YlByb2Nlc3M6OldlYlByb2Nlc3MpOiBXaGVuIEdQVV9QUk9DRVNTIGlzIG5vdCBlbmFibGVkLCBk byBub3QgYWRkClJlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3Rvcnkgc3VwcGxlbWVu dC4KKiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90ZU1lZGlhRW5naW5l Q29uZmlndXJhdGlvbkZhY3RvcnkuY3BwOgpXaGVuIEdQVV9QUk9DRVNTIGlzIG5vdCBlbmFibGVk LCBkbyBub3QgY29tcGlsZSBhbnl0aGluZy4KCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUHJvY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlByb2Nlc3MuY3BwCShyZXZpc2lvbiAyNzA0NzApCisrKyBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4NCw3ICsyODQsOSBAQCBX ZWJQcm9jZXNzOjpXZWJQcm9jZXNzKCkKICAgICBhZGRTdXBwbGVtZW50PEF1ZGlvU2Vzc2lvblJv dXRpbmdBcmJpdHJhdG9yPigpOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoR1BVX1BST0NFU1MpCiAg ICAgYWRkU3VwcGxlbWVudDxSZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5Pigp OworI2VuZGlmCiAKICAgICBHaWdhY2FnZTo6Zm9yYmlkRGlzYWJsaW5nUHJpbWl0aXZlR2lnYWNh Z2UoKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3Rl TWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRp b25GYWN0b3J5LmNwcAkocmV2aXNpb24gMjcwNDcwKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0dQVS9tZWRpYS9SZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2lu Y2x1ZGUgIlJlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3RvcnkuaCIKIAorI2lmIEVO QUJMRShHUFVfUFJPQ0VTUykKKwogI2luY2x1ZGUgIkdQVVByb2Nlc3NDb25uZWN0aW9uLmgiCiAj aW5jbHVkZSAiUmVtb3RlTWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeVByb3h5TWVzc2Fn ZXMuaCIKICNpbmNsdWRlICJXZWJQcm9jZXNzLmgiCkBAIC05MywzICs5NSw1IEBAIHZvaWQgUmVt b3RlTWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG8KIH0KIAogfQorCisjZW5kaWYK 415528 2020-12-06 13:03:44 -0800 2020-12-07 05:52:40 -0800 Patch bug-219580-20201206220342.patch text/plain 2249 samuel.thibault SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzA0ODcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEyLTA2ICBTYW11ZWwgVGhp YmF1bHQgIDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPgorCisgICAgICAgIFtXZWJLaXRd IEZpeCBXZWJQcm9jZXNzIGJ1aWxkIHdoZW4gR1BVX1BST0NFU1MgaXMgZGlzYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTU4MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gR1BVX1BST0NF U1MgaXMgZGlzYWJsZWQsCisgICAgICAgIFJlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZh Y3RvcnlQcm94eS5oIGdldHMgZW1wdHkgYW5kIGRvZXMgbm90CisgICAgICAgIGRlZmluZSBSZW1v dGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5LgorCisgICAgICAgICogV2ViUHJvY2Vz cy9HUFUvbWVkaWEvUmVtb3RlTWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeS5jcHA6IFdo ZW4KKyAgICAgICAgR1BVX1BST0NFU1MgaXMgbm90IGVuYWJsZWQsIGRvIG5vdCBjb21waWxlIGFu eXRoaW5nLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChX ZWJQcm9jZXNzOjpXZWJQcm9jZXNzKTogV2hlbiBHUFVfUFJPQ0VTUyBpcyBub3QgZW5hYmxlZCwg ZG8gbm90IGFkZAorICAgICAgICBSZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5 IHN1cHBsZW1lbnQuCisKIDIwMjAtMTItMDYgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkIG1pc3NpbmcgR1BVX1BST0NFU1MgZ3VhcmRz IGFyb3VuZCBSZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5IGFmdGVyIHIyNzA0 NjIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAJKHJldmlzaW9u IDI3MDQ4MCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjg0LDcgKzI4NCw5IEBAIFdlYlByb2Nlc3M6OldlYlByb2Nlc3MoKQog ICAgIGFkZFN1cHBsZW1lbnQ8QXVkaW9TZXNzaW9uUm91dGluZ0FyYml0cmF0b3I+KCk7CiAjZW5k aWYKIAorI2lmIEVOQUJMRShHUFVfUFJPQ0VTUykKICAgICBhZGRTdXBwbGVtZW50PFJlbW90ZU1l ZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3Rvcnk+KCk7CisjZW5kaWYKIAogICAgIEdpZ2FjYWdl Ojpmb3JiaWREaXNhYmxpbmdQcmltaXRpdmVHaWdhY2FnZSgpOwogfQpJbmRleDogU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25G YWN0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21l ZGlhL1JlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3RvcnkuY3BwCShyZXZpc2lvbiAy NzA0ODApCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90ZU1lZGlh RW5naW5lQ29uZmlndXJhdGlvbkZhY3RvcnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsy Niw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiUmVtb3RlTWVkaWFFbmdpbmVD b25maWd1cmF0aW9uRmFjdG9yeS5oIgogCisjaWYgRU5BQkxFKEdQVV9QUk9DRVNTKQorCiAjaW5j bHVkZSAiR1BVUHJvY2Vzc0Nvbm5lY3Rpb24uaCIKICNpbmNsdWRlICJSZW1vdGVNZWRpYUVuZ2lu ZUNvbmZpZ3VyYXRpb25GYWN0b3J5UHJveHlNZXNzYWdlcy5oIgogI2luY2x1ZGUgIldlYlByb2Nl c3MuaCIKQEAgLTkzLDMgKzk1LDUgQEAgdm9pZCBSZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRp b25GYWN0bwogfQogCiB9CisKKyNlbmRpZgo=