21958 2008-10-29 15:22:13 -0700 The size of the StructureID can be reduced by efficiently ordering members 2008-10-29 15:28:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 97054 0 sam 2008-10-29 15:22:13 -0700 Bit packing can reduce the size of the StructureID. 97055 1 24757 sam 2008-10-29 15:23:37 -0700 Created attachment 24757 pack 97056 2 24757 zwarich 2008-10-29 15:27:07 -0700 Comment on attachment 24757 pack r=me 97057 3 sam 2008-10-29 15:28:10 -0700 Fixed in r37981. 24757 2008-10-29 15:23:37 -0700 2008-10-29 15:27:07 -0700 pack pack.diff text/plain 4776 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3OTgw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMTAt MjkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTk1OAorICAgICAgICBQYWNrIGJpdHMgaW4gU3RydWN0dXJlSUQg dG8gcmVkdWNlIHRoZSBzaXplIG9mIGVhY2ggU3RydWN0dXJlSUQgYnkgMiB3b3Jkcy4KKworICAg ICAgICAqIHJ1bnRpbWUvUHJvcGVydHlNYXAuaDoKKyAgICAgICAgKEpTQzo6UHJvcGVydHlNYXA6 OnByb3BlcnR5TWFwU2l6ZSk6CisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmVJRC5jcHA6Cisg ICAgICAgIChKU0M6OlN0cnVjdHVyZUlEOjpkdW1wU3RhdGlzdGljcyk6IEFkZCBhZGRpdGlvbmFs IHNpemUgc3RhdGlzdGljcyB3aGVuIGR1bXBpbmcuCisgICAgICAgIChKU0M6OlN0cnVjdHVyZUlE OjpTdHJ1Y3R1cmVJRCk6CisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmVJRC5oOgorCiAyMDA4 LTEwLTI5ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAg ICAgIHd4IGJ1aWxkIGZpeGVzIGFmdGVyIGFkZGl0aW9uIG9mIHJ1bnRpbWUgYW5kIEltYWdlQnVm ZmVyIGNoYW5nZXMuCkluZGV4OiBydW50aW1lL1Byb3BlcnR5TWFwLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g cnVudGltZS9Qcm9wZXJ0eU1hcC5oCShyZXZpc2lvbiAzNzk3MykKKysrIHJ1bnRpbWUvUHJvcGVy dHlNYXAuaAkod29ya2luZyBjb3B5KQpAQCAtMTAzLDYgKzEwMywxMSBAQCBuYW1lc3BhY2UgSlND IHsKICAgICAgICAgYm9vbCBpc0VtcHR5KCkgeyByZXR1cm4gIW1fdGFibGU7IH0KICAgICAgICAg dW5zaWduZWQgc3RvcmFnZVNpemUoKSBjb25zdCB7IHJldHVybiBtX3RhYmxlID8gbV90YWJsZS0+ a2V5Q291bnQgKyBtX2RlbGV0ZWRPZmZzZXRzLnNpemUoKSA6IDA7IH0KIAorICAgICAgICBzaXpl X3QgcHJvcGVydHlNYXBTaXplKCkgY29uc3QKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJu IHNpemVvZihQcm9wZXJ0eU1hcCkgKyAobV90YWJsZSA/IFByb3BlcnR5TWFwSGFzaFRhYmxlOjph bGxvY2F0aW9uU2l6ZShtX3RhYmxlLT5zaXplKSA6IDApOworICAgICAgICB9CisKICAgICAgICAg c3RhdGljIGNvbnN0IHVuc2lnbmVkIGVtcHR5RW50cnlJbmRleCA9IDA7CiAKICAgICBwcml2YXRl OgpJbmRleDogcnVudGltZS9TdHJ1Y3R1cmVJRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcnVudGltZS9T dHJ1Y3R1cmVJRC5jcHAJKHJldmlzaW9uIDM3OTczKQorKysgcnVudGltZS9TdHJ1Y3R1cmVJRC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDcgQEAgdm9pZCBTdHJ1Y3R1cmVJRDo6ZHVt cFN0YXRpc3RpY3MoKQogICAgIHVuc2lnbmVkIG51bWJlckxlYWYgPSAwOwogICAgIHVuc2lnbmVk IG51bWJlclVzaW5nU2luZ2xlU2xvdCA9IDA7CiAgICAgdW5zaWduZWQgbnVtYmVyU2luZ2xldG9u cyA9IDA7CisgICAgdW5zaWduZWQgdG90YWxQcm9wZXJ0eU1hcHNTaXplID0gMDsKIAogICAgIEhh c2hTZXQ8U3RydWN0dXJlSUQqPjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbGl2ZVN0cnVjdHVyZUlE U2V0LmVuZCgpOwogICAgIGZvciAoSGFzaFNldDxTdHJ1Y3R1cmVJRCo+Ojpjb25zdF9pdGVyYXRv ciBpdCA9IGxpdmVTdHJ1Y3R1cmVJRFNldC5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKQEAg LTczLDI3ICs3NCwzNCBAQCB2b2lkIFN0cnVjdHVyZUlEOjpkdW1wU3RhdGlzdGljcygpCiAgICAg ICAgICAgIGlmICghc3RydWN0dXJlSUQtPm1fcHJldmlvdXMgJiYgIXN0cnVjdHVyZUlELT5tX3Ry YW5zaXRpb25zLnNpbmdsZVRyYW5zaXRpb24pCiAgICAgICAgICAgICAgICAgKytudW1iZXJTaW5n bGV0b25zOwogICAgICAgICB9CisKKyAgICAgICAgdG90YWxQcm9wZXJ0eU1hcHNTaXplICs9IHN0 cnVjdHVyZUlELT5wcm9wZXJ0eU1hcCgpLnByb3BlcnR5TWFwU2l6ZSgpOwogICAgIH0KIAogICAg IHByaW50ZigiTnVtYmVyIG9mIGxpdmUgU3RydWN0dXJlSURzOiAlZFxuIiwgbGl2ZVN0cnVjdHVy ZUlEU2V0LnNpemUoKSk7CiAgICAgcHJpbnRmKCJOdW1iZXIgb2YgU3RydWN0dXJlSURzIHVzaW5n IHRoZSBzaW5nbGUgaXRlbSBvcHRpbWl6YXRpb24gZm9yIHRyYW5zaXRpb24gbWFwOiAlZFxuIiwg bnVtYmVyVXNpbmdTaW5nbGVTbG90KTsKICAgICBwcmludGYoIk51bWJlciBvZiBTdHJ1Y3R1cmVJ RHMgdGhhdCBhcmUgbGVhZiBub2RlczogJWRcbiIsIG51bWJlckxlYWYpOwogICAgIHByaW50Zigi TnVtYmVyIG9mIFN0cnVjdHVyZUlEcyB0aGF0IHNpbmdsZXRvbnM6ICVkXG4iLCBudW1iZXJTaW5n bGV0b25zKTsKKworICAgIHByaW50ZigiU2l6ZSBvZiBhIHNpbmdsZSBTdHJ1Y3R1cmVJRHM6ICVk XG4iLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oc2l6ZW9mKFN0cnVjdHVyZUlEKSkpOworICAgIHBy aW50ZigiU2l6ZSBvZiBzdW0gb2YgYWxsIHByb3BlcnR5IG1hcHM6ICVkXG4iLCB0b3RhbFByb3Bl cnR5TWFwc1NpemUpOworICAgIHByaW50ZigiU2l6ZSBvZiBhdmVyYWdlIG9mIGFsbCBwcm9wZXJ0 eSBtYXBzOiAlZlxuIiwgc3RhdGljX2Nhc3Q8ZG91YmxlPih0b3RhbFByb3BlcnR5TWFwc1NpemUp IC8gc3RhdGljX2Nhc3Q8ZG91YmxlPihsaXZlU3RydWN0dXJlSURTZXQuc2l6ZSgpKSk7CiB9CiAj ZW5kaWYKIAogU3RydWN0dXJlSUQ6OlN0cnVjdHVyZUlEKEpTVmFsdWUqIHByb3RvdHlwZSwgY29u c3QgVHlwZUluZm8mIHR5cGVJbmZvKQogICAgIDogbV90eXBlSW5mbyh0eXBlSW5mbykKLSAgICAs IG1faXNEaWN0aW9uYXJ5KGZhbHNlKQotICAgICwgbV9oYXNHZXR0ZXJTZXR0ZXJQcm9wZXJ0aWVz KGZhbHNlKQogICAgICwgbV9wcm90b3R5cGUocHJvdG90eXBlKQogICAgICwgbV9jYWNoZWRQcm90 b3R5cGVDaGFpbigwKQogICAgICwgbV9wcmV2aW91cygwKQogICAgICwgbV9uYW1lSW5QcmV2aW91 cygwKQogICAgICwgbV90cmFuc2l0aW9uQ291bnQoMCkKLSAgICAsIG1fdXNpbmdTaW5nbGVUcmFu c2l0aW9uU2xvdCh0cnVlKQogICAgICwgbV9wcm9wZXJ0eVN0b3JhZ2VDYXBhY2l0eShKU09iamVj dDo6aW5saW5lU3RvcmFnZUNhcGFjaXR5KQogICAgICwgbV9jYWNoZWRUcmFuc2lzdGlvbk9mZnNl dChXVEY6Om5vdEZvdW5kKQorICAgICwgbV9pc0RpY3Rpb25hcnkoZmFsc2UpCisgICAgLCBtX2hh c0dldHRlclNldHRlclByb3BlcnRpZXMoZmFsc2UpCisgICAgLCBtX3VzaW5nU2luZ2xlVHJhbnNp dGlvblNsb3QodHJ1ZSkKKyAgICAsIG1fYXR0cmlidXRlc0luUHJldmlvdXMoMCkKIHsKICAgICBB U1NFUlQobV9wcm90b3R5cGUpOwogICAgIEFTU0VSVChtX3Byb3RvdHlwZS0+aXNPYmplY3QoKSB8 fCBtX3Byb3RvdHlwZS0+aXNOdWxsKCkpOwpJbmRleDogcnVudGltZS9TdHJ1Y3R1cmVJRC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHJ1bnRpbWUvU3RydWN0dXJlSUQuaAkocmV2aXNpb24gMzc5NzMpCisrKyBy dW50aW1lL1N0cnVjdHVyZUlELmgJKHdvcmtpbmcgY29weSkKQEAgLTE0OSwxOSArMTQ5LDEzIEBA IG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIFR5cGVJbmZvIG1fdHlwZUluZm87CiAKLSAgICAg ICAgYm9vbCBtX2lzRGljdGlvbmFyeTsKLQotICAgICAgICBib29sIG1faGFzR2V0dGVyU2V0dGVy UHJvcGVydGllczsKLQogICAgICAgICBKU1ZhbHVlKiBtX3Byb3RvdHlwZTsKICAgICAgICAgUmVm UHRyPFN0cnVjdHVyZUlEQ2hhaW4+IG1fY2FjaGVkUHJvdG90eXBlQ2hhaW47CiAKICAgICAgICAg UmVmUHRyPFN0cnVjdHVyZUlEPiBtX3ByZXZpb3VzOwogICAgICAgICBVU3RyaW5nOjpSZXAqIG1f bmFtZUluUHJldmlvdXM7Ci0gICAgICAgIHVuc2lnbmVkIG1fYXR0cmlidXRlc0luUHJldmlvdXM7 CiAKICAgICAgICAgc2l6ZV90IG1fdHJhbnNpdGlvbkNvdW50OwotICAgICAgICBib29sIG1fdXNp bmdTaW5nbGVUcmFuc2l0aW9uU2xvdDsKICAgICAgICAgdW5pb24gewogICAgICAgICAgICAgU3Ry dWN0dXJlSUQqIHNpbmdsZVRyYW5zaXRpb247CiAgICAgICAgICAgICBUcmFuc2l0aW9uVGFibGUq IHRhYmxlOwpAQCAtMTczLDYgKzE2NywxMSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgc2l6 ZV90IG1fcHJvcGVydHlTdG9yYWdlQ2FwYWNpdHk7CiAKICAgICAgICAgc2l6ZV90IG1fY2FjaGVk VHJhbnNpc3Rpb25PZmZzZXQ7CisKKyAgICAgICAgYm9vbCBtX2lzRGljdGlvbmFyeSA6IDE7Cisg ICAgICAgIGJvb2wgbV9oYXNHZXR0ZXJTZXR0ZXJQcm9wZXJ0aWVzIDogMTsKKyAgICAgICAgYm9v bCBtX3VzaW5nU2luZ2xlVHJhbnNpdGlvblNsb3QgOiAxOworICAgICAgICB1bnNpZ25lZCBtX2F0 dHJpYnV0ZXNJblByZXZpb3VzIDogNTsKICAgICB9OwogCiAgICAgY2xhc3MgU3RydWN0dXJlSURD aGFpbiA6IHB1YmxpYyBSZWZDb3VudGVkPFN0cnVjdHVyZUlEQ2hhaW4+IHsK