219572 2020-12-05 15:49:29 -0800 [WebCore] Fix build without PATH_MAX 2025-01-12 09:19:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 samuel.thibault webkit-unassigned darin don.olmstead fpizlo fujii keith_miller mark.lam smoley webkit-bug-importer youennf ysuzuki oldest_to_newest 1712287 0 415505 samuel.thibault 2020-12-05 15:49:29 -0800 Created attachment 415505 proposed fix This fixes build on GNU/Hurd, which does not have a PATH_MAX limitation. 1712359 1 415526 samuel.thibault 2020-12-06 12:59:00 -0800 Created attachment 415526 Patch 1712460 2 don.olmstead 2020-12-07 08:25:03 -0800 I feel like it'd be safer to do a check in the CMake code for realpath which would create a HAVE_REALPATH variable. See Source/cmake/OptionsCommon.cmake for the other HAVE checks. 1712596 3 webkit-bug-importer 2020-12-07 13:51:30 -0800 <rdar://problem/72062538> 1712663 4 fujii 2020-12-07 18:02:41 -0800 (In reply to Don Olmstead from comment #2) > I feel like it'd be safer to do a check in the CMake code for realpath which > would create a HAVE_REALPATH variable. I think adding HAVE_REALPATH can't solve this problem. I don't know which Unix WebKit is supporting, but Linux and FreeBSD can take NULL as the second argument of realpath, as far as I read the documents. I think it's better to remove the old code. 1712866 5 415526 ysuzuki 2020-12-08 12:29:56 -0800 Comment on attachment 415526 Patch Setting r- based on Hironori's comment. Could you update the patch :D ? 1712870 6 415663 samuel.thibault 2020-12-08 12:39:31 -0800 Created attachment 415663 Patch 1712871 7 samuel.thibault 2020-12-08 12:40:19 -0800 I have done so 1712872 8 darin 2020-12-08 12:41:09 -0800 This idiom occurs in other places, not just HyphenationLibHyphen.cpp. I found it in SandboxUtilities.mm, SandboxInitializationParametersCocoa.mm, AuxiliaryProcessMac.mm, FileSystemPOSIX.cpp, and StdFilesystem.cpp. I think it’s peculiar to do this in only one place. 1716428 9 415663 fujii 2020-12-22 19:55:39 -0800 Comment on attachment 415663 Patch r- for comment#8. 2086639 10 samuel.thibault 2025-01-12 09:19:00 -0800 Apparently this fell in the cracks of my todo-list. I have reworked the patch, submitted to https://github.com/WebKit/WebKit/pull/38913 , along other pull requests that fix building on GNU/Hurd (https://bugs.webkit.org/show_bug.cgi?id=285806) 415505 2020-12-05 15:49:29 -0800 2020-12-06 12:58:54 -0800 proposed fix patch text/plain 1680 samuel.thibault MjAyMC0xMi0wNiAgU2FtdWVsIFRoaWJhdWx0ICA8c2FtdWVsLnRoaWJhdWx0QGVucy1seW9uLm9y Zz4KCltXZWJDb3JlXSBMZXQgcmVhbHBhdGggYWxsb2NhdGUgcGF0aCB3aGVuIGl0IGNhbgoKUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpyZWFscGF0aCBpcyBub3QgbGltaXRlZCBieSBQQVRI X01BWCBhbnkgbW9yZSBzaW5jZSBQb3NpeCAyMDAxCgoqIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3RleHQvaHlwaGVuL0h5cGhlbmF0aW9uTGliSHlwaGVuLmNwcDoKKHNjYW5EaXJlY3RvcnlGb3JE aWN0aW9uYXJpZXMpOiBQYXNzIE5VTEwgdG8gcmVhbHBhdGgoKSB0byBsZXQgaXQgYWxsb2NhdGUg dGhlCnBhdGggd2hlbiBfUE9TSVhfVkVSU0lPTiA+PSAyMDAxMTIuCgpJbmRleDogU291cmNlL1dU Ri93dGYvUkFNU2l6ZS5jcHAKCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5 cGhlbi9IeXBoZW5hdGlvbkxpYkh5cGhlbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJIeXBoZW4uY3BwCShyZXZpc2lv biAyNzA0NzApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9IeXBoZW5h dGlvbkxpYkh5cGhlbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3LDExICs2NywyMSBAQCBzdGF0 aWMgdm9pZCBzY2FuRGlyZWN0b3J5Rm9yRGljdGlvbmFyaWVzCiAgICAgZm9yIChhdXRvJiBmaWxl UGF0aCA6IEZpbGVTeXN0ZW06Omxpc3REaXJlY3RvcnkoZGlyZWN0b3J5UGF0aCwgImh5cGhfKi5k aWMiKSkgewogICAgICAgICBTdHJpbmcgbG9jYWxlID0gZXh0cmFjdExvY2FsZUZyb21EaWN0aW9u YXJ5RmlsZVBhdGgoZmlsZVBhdGgpLmNvbnZlcnRUb0FTQ0lJTG93ZXJjYXNlKCk7CiAKKyNpZiBf UE9TSVhfVkVSU0lPTiA+PSAyMDAxMTIKKyAgICAgICAgY2hhciAqbm9ybWFsaXplZFBhdGggPSBy ZWFscGF0aChGaWxlU3lzdGVtOjpmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oZmlsZVBhdGgpLmRh dGEoKSwgTlVMTCk7CisgICAgICAgIGlmICghbm9ybWFsaXplZFBhdGgpCisgICAgICAgICAgICBj b250aW51ZTsKKworICAgICAgICBmaWxlUGF0aCA9IEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21GaWxl U3lzdGVtUmVwcmVzZW50YXRpb24obm9ybWFsaXplZFBhdGgpOworICAgICAgICBmcmVlKG5vcm1h bGl6ZWRQYXRoKTsKKyNlbHNlCiAgICAgICAgIGNoYXIgbm9ybWFsaXplZFBhdGhbUEFUSF9NQVhd OwogICAgICAgICBpZiAoIXJlYWxwYXRoKEZpbGVTeXN0ZW06OmZpbGVTeXN0ZW1SZXByZXNlbnRh dGlvbihmaWxlUGF0aCkuZGF0YSgpLCBub3JtYWxpemVkUGF0aCkpCiAgICAgICAgICAgICBjb250 aW51ZTsKIAogICAgICAgICBmaWxlUGF0aCA9IEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21GaWxlU3lz dGVtUmVwcmVzZW50YXRpb24obm9ybWFsaXplZFBhdGgpOworI2VuZGlmCisKICAgICAgICAgYXZh aWxhYmxlTG9jYWxlcy5hZGQobG9jYWxlLCBWZWN0b3I8U3RyaW5nPigpKS5pdGVyYXRvci0+dmFs dWUuYXBwZW5kKGZpbGVQYXRoKTsKIAogICAgICAgICBTdHJpbmcgbG9jYWxlUmVwbGFjaW5nVW5k ZXJzY29yZXMgPSBTdHJpbmcobG9jYWxlKTsK 415526 2020-12-06 12:59:00 -0800 2020-12-08 12:39:25 -0800 Patch bug-219572-20201206215859.patch text/plain 2065 samuel.thibault SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MDQ4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTEyLTA2ICBTYW11ZWwg VGhpYmF1bHQgIDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPgorCisgICAgICAgIFtXZWJD b3JlXSBMZXQgcmVhbHBhdGggYWxsb2NhdGUgcGF0aCB3aGVuIGl0IGNhbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NTcyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmVhbHBhdGggaXMgbm90IGxpbWl0 ZWQgYnkgUEFUSF9NQVggYW55IG1vcmUgc2luY2UgUG9zaXggMjAwMQorCisgICAgICAgICogcGxh dGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJIeXBoZW4uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c2NhbkRpcmVjdG9yeUZvckRpY3Rpb25hcmllcyk6IFBhc3MgTlVMTCB0byByZWFscGF0 aCgpIHRvIGxldAorICAgICAgICBpdCBhbGxvY2F0ZSB0aGUgcGF0aCB3aGVuIF9QT1NJWF9WRVJT SU9OID49IDIwMDExMi4KKwogMjAyMC0xMi0wNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIFJUQ1J0cFNlbmRlcjo6c2V0U3RyZWFt cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25M aWJIeXBoZW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv aHlwaGVuL0h5cGhlbmF0aW9uTGliSHlwaGVuLmNwcAkocmV2aXNpb24gMjcwNDgwKQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJIeXBoZW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02NywxMSArNjcsMjEgQEAgc3RhdGljIHZvaWQgc2NhbkRpcmVj dG9yeUZvckRpY3Rpb25hcmllcwogICAgIGZvciAoYXV0byYgZmlsZVBhdGggOiBGaWxlU3lzdGVt OjpsaXN0RGlyZWN0b3J5KGRpcmVjdG9yeVBhdGgsICJoeXBoXyouZGljIikpIHsKICAgICAgICAg U3RyaW5nIGxvY2FsZSA9IGV4dHJhY3RMb2NhbGVGcm9tRGljdGlvbmFyeUZpbGVQYXRoKGZpbGVQ YXRoKS5jb252ZXJ0VG9BU0NJSUxvd2VyY2FzZSgpOwogCisjaWYgX1BPU0lYX1ZFUlNJT04gPj0g MjAwMTEyCisgICAgICAgIGNoYXIqIG5vcm1hbGl6ZWRQYXRoID0gcmVhbHBhdGgoRmlsZVN5c3Rl bTo6ZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGZpbGVQYXRoKS5kYXRhKCksIG51bGxwdHIpOwor ICAgICAgICBpZiAoIW5vcm1hbGl6ZWRQYXRoKQorICAgICAgICAgICAgY29udGludWU7CisKKyAg ICAgICAgZmlsZVBhdGggPSBGaWxlU3lzdGVtOjpzdHJpbmdGcm9tRmlsZVN5c3RlbVJlcHJlc2Vu dGF0aW9uKG5vcm1hbGl6ZWRQYXRoKTsKKyAgICAgICAgZnJlZShub3JtYWxpemVkUGF0aCk7Cisj ZWxzZQogICAgICAgICBjaGFyIG5vcm1hbGl6ZWRQYXRoW1BBVEhfTUFYXTsKICAgICAgICAgaWYg KCFyZWFscGF0aChGaWxlU3lzdGVtOjpmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oZmlsZVBhdGgp LmRhdGEoKSwgbm9ybWFsaXplZFBhdGgpKQogICAgICAgICAgICAgY29udGludWU7CiAKICAgICAg ICAgZmlsZVBhdGggPSBGaWxlU3lzdGVtOjpzdHJpbmdGcm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0 aW9uKG5vcm1hbGl6ZWRQYXRoKTsKKyNlbmRpZgorCiAgICAgICAgIGF2YWlsYWJsZUxvY2FsZXMu YWRkKGxvY2FsZSwgVmVjdG9yPFN0cmluZz4oKSkuaXRlcmF0b3ItPnZhbHVlLmFwcGVuZChmaWxl UGF0aCk7CiAKICAgICAgICAgU3RyaW5nIGxvY2FsZVJlcGxhY2luZ1VuZGVyc2NvcmVzID0gU3Ry aW5nKGxvY2FsZSk7Cg== 415663 2020-12-08 12:39:31 -0800 2020-12-22 19:55:39 -0800 Patch bug-219572-20201208213930.patch text/plain 1920 samuel.thibault SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MDU1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEyLTA2ICBTYW11ZWwg VGhpYmF1bHQgIDxzYW11ZWwudGhpYmF1bHRAZW5zLWx5b24ub3JnPgorCisgICAgICAgIFtXZWJD b3JlXSBMZXQgcmVhbHBhdGggYWxsb2NhdGUgcGF0aCBpdHNlbGYKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTU3MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJlYWxwYXRoIGlzIG5vdCBsaW1pdGVkIGJ5 IFBBVEhfTUFYIGFueSBtb3JlIHNpbmNlIFBvc2l4IDIwMDEsIGJ5CisgICAgICAgIGxldHRpbmcg aXQgYWxsb2NhdGUgdGhlIHN0cmluZworCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9oeXBoZW4v SHlwaGVuYXRpb25MaWJIeXBoZW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2NhbkRpcmVjdG9y eUZvckRpY3Rpb25hcmllcyk6IFBhc3MgTlVMTCB0byByZWFscGF0aCgpIHRvIGxldAorICAgICAg ICBpdCBhbGxvY2F0ZSB0aGUgcGF0aC4KKwogMjAyMC0xMi0wOCAgUm9iIEJ1aXMgIDxyYnVpc0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFN1cHBvcnQgYXNwZWN0LXJhdGlvIG9uIG5vbi1yZXBsYWNl ZCBlbGVtZW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlw aGVuYXRpb25MaWJIeXBoZW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvaHlwaGVuL0h5cGhlbmF0aW9uTGliSHlwaGVuLmNwcAkocmV2aXNpb24gMjcwNTUx KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJI eXBoZW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NywxMSArNjcsMTMgQEAgc3RhdGljIHZvaWQg c2NhbkRpcmVjdG9yeUZvckRpY3Rpb25hcmllcwogICAgIGZvciAoYXV0byYgZmlsZVBhdGggOiBG aWxlU3lzdGVtOjpsaXN0RGlyZWN0b3J5KGRpcmVjdG9yeVBhdGgsICJoeXBoXyouZGljIikpIHsK ICAgICAgICAgU3RyaW5nIGxvY2FsZSA9IGV4dHJhY3RMb2NhbGVGcm9tRGljdGlvbmFyeUZpbGVQ YXRoKGZpbGVQYXRoKS5jb252ZXJ0VG9BU0NJSUxvd2VyY2FzZSgpOwogCi0gICAgICAgIGNoYXIg bm9ybWFsaXplZFBhdGhbUEFUSF9NQVhdOwotICAgICAgICBpZiAoIXJlYWxwYXRoKEZpbGVTeXN0 ZW06OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihmaWxlUGF0aCkuZGF0YSgpLCBub3JtYWxpemVk UGF0aCkpCisgICAgICAgIGNoYXIqIG5vcm1hbGl6ZWRQYXRoID0gcmVhbHBhdGgoRmlsZVN5c3Rl bTo6ZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGZpbGVQYXRoKS5kYXRhKCksIG51bGxwdHIpOwor ICAgICAgICBpZiAoIW5vcm1hbGl6ZWRQYXRoKQogICAgICAgICAgICAgY29udGludWU7CiAKICAg ICAgICAgZmlsZVBhdGggPSBGaWxlU3lzdGVtOjpzdHJpbmdGcm9tRmlsZVN5c3RlbVJlcHJlc2Vu dGF0aW9uKG5vcm1hbGl6ZWRQYXRoKTsKKyAgICAgICAgZnJlZShub3JtYWxpemVkUGF0aCk7CisK ICAgICAgICAgYXZhaWxhYmxlTG9jYWxlcy5hZGQobG9jYWxlLCBWZWN0b3I8U3RyaW5nPigpKS5p dGVyYXRvci0+dmFsdWUuYXBwZW5kKGZpbGVQYXRoKTsKIAogICAgICAgICBTdHJpbmcgbG9jYWxl UmVwbGFjaW5nVW5kZXJzY29yZXMgPSBTdHJpbmcobG9jYWxlKTsK