219558 2020-12-04 15:40:50 -0800 [GPU Process] Rename imageBuffer::flushDrawingContextAndCommit() to commitDrawingContext() 2020-12-23 12:11:59 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 220126 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa cdumez changseok dino esprehn+autocc ews-watchlist gyuyoung.kim simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1712197 0 sabouhallawa 2020-12-04 15:40:50 -0800 To make the name of replaying back the DisplayList functions consistent and more clear, we will adopt the following scheme: -- submitDisplayList(): Replays back a DisplayList. If the replay back happens in GPUP, no message confirming the replay back will be sent to WebP. -- commitDrawingContext(): Replays back the DisplayList of DrawingContext. If the replay back happens in GPUP, a message confirming the replay back will be sent to WebP. WebP will not be blocked till this message is sent. -- flushDrawingContext(): Same as commitDrawingContext() but if the commit happens in GPUP, and WebP will wait for the confirming message. 1712198 1 415468 sabouhallawa 2020-12-04 15:42:42 -0800 Created attachment 415468 Patch 1712201 2 415468 thorton 2020-12-04 15:58:48 -0800 Comment on attachment 415468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415468&action=review Regardless of which way you go, this is better than the current name. > Source/WebCore/platform/graphics/ImageBuffer.h:82 > + virtual void commitDrawingContext() { } > virtual void submitDisplayList(const DisplayList::DisplayList&) { } should we go with submit, like submitDisplayList? That is what this is, right? Submit outstanding pending work? There's no synchronization here, so not sure about the "commit" word. 1712204 3 415468 simon.fraser 2020-12-04 16:08:32 -0800 Comment on attachment 415468 Patch I think we can improve these names. 1712206 4 415468 simon.fraser 2020-12-04 16:14:07 -0800 Comment on attachment 415468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415468&action=review > Source/WebCore/ChangeLog:13 > + -- submitDisplayList(): Replays back a DisplayList. If the replay back > + happens in GPUP, no message confirming the replay back will be sent > + to WebP. Can this just be submit()? The argument is a display list. Does this ever involve IPC of the display list to the GPUP? > Source/WebCore/ChangeLog:21 > + -- commitDrawingContext(): Replays back the DisplayList of DrawingContext. > + If the replay back happens in GPUP, a message confirming the replay > + back will be sent to WebP. WebP will not be blocked till this message > + is sent. > + > + -- flushDrawingContext(): Same as commitDrawingContext() but if the commit > + happens in GPUP, and WebP will wait for the confirming message. If these are similar they should have similar names. Maybe flush() and flushSync()? And are we flushing display lists to the GPUP, flushing display lists in the GPUP, or doing CGContextFlush, or all of those things? 1712232 5 415468 sabouhallawa 2020-12-04 19:31:56 -0800 Comment on attachment 415468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415468&action=review >> Source/WebCore/ChangeLog:13 >> + to WebP. > > Can this just be submit()? The argument is a display list. > > Does this ever involve IPC of the display list to the GPUP? Yes. See RemoteImageBufferProxy::submitDisplayList() and RemoteRenderingBackendProxy::submitDisplayList(). >> Source/WebCore/ChangeLog:21 >> + happens in GPUP, and WebP will wait for the confirming message. > > If these are similar they should have similar names. Maybe flush() and flushSync()? And are we flushing display lists to the GPUP, flushing display lists in the GPUP, or doing CGContextFlush, or all of those things? They does flush the DisplayList only to the GPU. CGContextFlush() is called automatically in the GPUP side when you want the pixels of the backend. For example RemoteRenderingBackend::getImageData() calls RemoteImageBuffer::getImageData() which inherits the implementation from ConcreteImageBuffer. ConcreteImageBuffer::getImageData() eventually calls ImageBufferIOSurfaceBackend::flushContext() via ConcreteImageBuffer::flushContext(). 1714127 6 webkit-bug-importer 2020-12-11 15:41:14 -0800 <rdar://problem/72241697> 1716500 7 sabouhallawa 2020-12-23 12:11:59 -0800 submitDisplayList() was deleted so we need to rename flushDrawingContextAndCommit() only. Renaming this function is part of the patch in bug 220126. *** This bug has been marked as a duplicate of bug 220126 *** 415468 2020-12-04 15:42:42 -0800 2020-12-04 15:58:48 -0800 Patch bug-219558-20201204154241.patch text/plain 5579 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAyMDMwZWIwY2UzZDAy ODUwZWIxNzlhZmFmMTliZDFlZTg3MjEwYy4uZjdmMWU4YjM3OTk3ZTA0NDhmYzUxNGMzZjQxOWMz NzRhYzdkZjFkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIwLTEyLTA0ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g UmVuYW1lIGltYWdlQnVmZmVyOjpmbHVzaERyYXdpbmdDb250ZXh0QW5kQ29tbWl0KCkgdG8gY29t bWl0RHJhd2luZ0NvbnRleHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE5NTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVG8gbWFrZSB0aGUgbmFtZSBvZiByZXBsYXlpbmcgYmFjayB0aGUgRGlzcGxh eUxpc3QgZnVuY3Rpb25zIGNvbnNpc3RlbnQKKyAgICAgICAgYW5kIG1vcmUgY2xlYXIsIHdlIHdp bGwgYWRvcHQgdGhlIGZvbGxvd2luZyBzY2hlbWU6CisKKyAgICAgICAgLS0gc3VibWl0RGlzcGxh eUxpc3QoKTogUmVwbGF5cyBiYWNrIGEgRGlzcGxheUxpc3QuIElmIHRoZSByZXBsYXkgYmFjawor ICAgICAgICAgICBoYXBwZW5zIGluIEdQVVAsIG5vIG1lc3NhZ2UgY29uZmlybWluZyB0aGUgcmVw bGF5IGJhY2sgd2lsbCBiZSBzZW50CisgICAgICAgICAgIHRvIFdlYlAuCisKKyAgICAgICAgLS0g Y29tbWl0RHJhd2luZ0NvbnRleHQoKTogUmVwbGF5cyBiYWNrIHRoZSBEaXNwbGF5TGlzdCBvZiBE cmF3aW5nQ29udGV4dC4KKyAgICAgICAgICAgSWYgdGhlIHJlcGxheSBiYWNrIGhhcHBlbnMgaW4g R1BVUCwgYSBtZXNzYWdlIGNvbmZpcm1pbmcgdGhlIHJlcGxheQorICAgICAgICAgICBiYWNrIHdp bGwgYmUgc2VudCB0byBXZWJQLiBXZWJQIHdpbGwgbm90IGJlIGJsb2NrZWQgdGlsbCB0aGlzIG1l c3NhZ2UKKyAgICAgICAgICAgaXMgc2VudC4KKworICAgICAgICAtLSBmbHVzaERyYXdpbmdDb250 ZXh0KCk6IFNhbWUgYXMgY29tbWl0RHJhd2luZ0NvbnRleHQoKSBidXQgaWYgdGhlIGNvbW1pdAor ICAgICAgICAgICBoYXBwZW5zIGluIEdQVVAsIGFuZCBXZWJQIHdpbGwgd2FpdCBmb3IgdGhlIGNv bmZpcm1pbmcgbWVzc2FnZS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmlu Z0NvbnRleHQyREJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29u dGV4dDJEQmFzZTo6cHJlcGFyZUZvckRpc3BsYXkpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL0ltYWdlQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Y29tbWl0 RHJhd2luZ0NvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OmZsdXNoRHJh d2luZ0NvbnRleHRBbmRDb21taXQpOiBEZWxldGVkLgorCiAyMDIwLTEyLTA0ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCBjb25zdHJ1Y3RpbmcgdW5uZWNl c3NhcnkgQXVkaW9CdXMgaW4gU2luY1Jlc2FtcGxlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBiMTkxYTlkNDk3YmMx NTY2ZDUyNGViZTExZjNkNWM1NTllZjY2OTM3Li43OTRiYzdhNDU4MDE1YmQxMGIyOTU2MjQ4NTk1 M2E2ZTI4N2U0OTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTEyLTA0ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g UmVuYW1lIGltYWdlQnVmZmVyOjpmbHVzaERyYXdpbmdDb250ZXh0QW5kQ29tbWl0KCkgdG8gY29t bWl0RHJhd2luZ0NvbnRleHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE5NTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVyQmFja2luZ1N0 b3JlLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6ZGlzcGxh eSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQ cm94eS5oOgorCiAyMDIwLTEyLTA0ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29t PgogCiAgICAgICAgIFtHUFUgUHJvY2Vzc10gQ2xlYW4gdXAgcmVjcmVhdGluZyB0aGUgSW1hZ2VC dWZmZXJCYWNrZW5kIGJlY2F1c2Ugb2YgR1BVIGNyYXNoaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3Bw CmluZGV4IGNmZjdlNDc4ZmUzNjkzZmRhMmU1MGI1YTZhMjdiNjMyY2YyNWFmYmEuLmFkOTgzZWE4 OWZmNjkyYjNmZTdlZWM0YjNiODZiNTM2MmJkOWY2MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3Bw CkBAIC0yMDQyLDcgKzIwNDIsNyBAQCBHcmFwaGljc0NvbnRleHQqIENhbnZhc1JlbmRlcmluZ0Nv bnRleHQyREJhc2U6OmRyYXdpbmdDb250ZXh0KCkgY29uc3QKIHZvaWQgQ2FudmFzUmVuZGVyaW5n Q29udGV4dDJEQmFzZTo6cHJlcGFyZUZvckRpc3BsYXkoKQogewogICAgIGlmIChhdXRvIGJ1ZmZl ciA9IGNhbnZhc0Jhc2UoKS5idWZmZXIoKSkKLSAgICAgICAgYnVmZmVyLT5mbHVzaERyYXdpbmdD b250ZXh0QW5kQ29tbWl0KCk7CisgICAgICAgIGJ1ZmZlci0+Y29tbWl0RHJhd2luZ0NvbnRleHQo KTsKIH0KIAogYm9vbCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpuZWVkc1ByZXBhcmF0 aW9uRm9yRGlzcGxheSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvSW1hZ2VCdWZmZXIuaAppbmRleCA5OGIyMmVlOGFlMDc4NDI1OWE0NmNiYjFmYjJmNGJlMDJm MTIwOGJlLi42NDFmMGI5YzI2ZTFkMzQ5NjhhYjA3NGRmMzhiYzFjYTNmYzdkYmI2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmgKQEAgLTc4LDcg Kzc4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgRGlzcGxheUxpc3Q6OkRyYXdpbmdDb250ZXh0 KiBkcmF3aW5nQ29udGV4dCgpIHsgcmV0dXJuIG51bGxwdHI7IH0KICAgICB2aXJ0dWFsIGJvb2wg cHJlZmVyc1ByZXBhcmF0aW9uRm9yRGlzcGxheSgpIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmly dHVhbCB2b2lkIGZsdXNoRHJhd2luZ0NvbnRleHQoKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgZmx1 c2hEcmF3aW5nQ29udGV4dEFuZENvbW1pdCgpIHsgfQorICAgIHZpcnR1YWwgdm9pZCBjb21taXRE cmF3aW5nQ29udGV4dCgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCBzdWJtaXREaXNwbGF5TGlzdChj b25zdCBEaXNwbGF5TGlzdDo6RGlzcGxheUxpc3QmKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlk Rmx1c2goRGlzcGxheUxpc3Q6OkZsdXNoSWRlbnRpZmllcikgeyB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllckJhY2tpbmdTdG9y ZS5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllckJh Y2tpbmdTdG9yZS5tbQppbmRleCBmMmFlYmNmMmE5ODkzZTgwNmYxYzcwZDFkZDVhMTc0MGYzMGVl N2ZlLi5mMDRkOTRjYjZiNzFhZmM3YzUzMDhhM2EyMWI5YzI2ODFkYzczM2FiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJCYWNraW5n U3RvcmUubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90 ZUxheWVyQmFja2luZ1N0b3JlLm1tCkBAIC0zMTcsOCArMzE3LDcgQEAgYm9vbCBSZW1vdGVMYXll ckJhY2tpbmdTdG9yZTo6ZGlzcGxheSgpCiAKICAgICBtX2xheWVyLT5vd25lcigpLT5wbGF0Zm9y bUNBTGF5ZXJMYXllckRpZERpc3BsYXkobV9sYXllcik7CiAKLSAgICAvLyBGSVhNRTogVGhpcyBt ZXRob2QgaGFzIGEgd2VpcmQgbmFtZS4gVGhpcyBpcyAic3VibWl0IHdvcmsiLgotICAgIG1fZnJv bnRCdWZmZXIuaW1hZ2VCdWZmZXItPmZsdXNoRHJhd2luZ0NvbnRleHRBbmRDb21taXQoKTsKKyAg ICBtX2Zyb250QnVmZmVyLmltYWdlQnVmZmVyLT5jb21taXREcmF3aW5nQ29udGV4dCgpOwogCiAg ICAgbV9mcm9udEJ1ZmZlckZsdXNoZXIgPSBtX2Zyb250QnVmZmVyLmltYWdlQnVmZmVyLT5jcmVh dGVGbHVzaGVyKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUv Z3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZlclByb3h5LmgKaW5kZXggMjI4MmUxM2Fh YmY1M2Q2NDJlODQ0ZDQyNzAxZTA2NjVjMWQ1NDM4My4uYWFlZjAxMDExMjA1M2YxMTFlMjdjMGQ3 MzRiNDE3NzVkODVmYWIzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQ VS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZlclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZlclByb3h5LmgKQEAgLTE2Nywx MSArMTY3LDExIEBAIHByb3RlY3RlZDoKICAgICB2b2lkIGZsdXNoRHJhd2luZ0NvbnRleHQoKSBv dmVycmlkZQogICAgIHsKICAgICAgICAgVHJhY2VTY29wZSB0cmFjaW5nU2NvcGUoRmx1c2hSZW1v dGVJbWFnZUJ1ZmZlclN0YXJ0LCBGbHVzaFJlbW90ZUltYWdlQnVmZmVyRW5kKTsKLSAgICAgICAg Zmx1c2hEcmF3aW5nQ29udGV4dEFuZENvbW1pdCgpOworICAgICAgICBjb21taXREcmF3aW5nQ29u dGV4dCgpOwogICAgICAgICB3YWl0Rm9yRGlkRmx1c2hXaXRoVGltZW91dCgpOwogICAgIH0KIAot ICAgIHZvaWQgZmx1c2hEcmF3aW5nQ29udGV4dEFuZENvbW1pdCgpIG92ZXJyaWRlCisgICAgdm9p ZCBjb21taXREcmF3aW5nQ29udGV4dCgpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBpZiAoIW1f cmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5KQogICAgICAgICAgICAgcmV0dXJuOwo=