219553 2020-12-04 13:39:54 -0800 Stop constructing unnecessary AudioBus in SincResampler 2020-12-04 14:40:27 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1712141 0 cdumez 2020-12-04 13:39:54 -0800 Stop constructing unnecessary AudioBus in SincResampler. Instead, pass the float* buffer to the lambda directly. 1712144 1 415455 cdumez 2020-12-04 13:44:53 -0800 Created attachment 415455 Patch 1712169 2 415455 darin 2020-12-04 14:31:58 -0800 Comment on attachment 415455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415455&action=review > Source/WebCore/platform/audio/MultiChannelResampler.cpp:56 > + void provideInputForChannel(float* buffer, size_t framesToProcess, unsigned channelIndex) Surprised that this function can just return and do nothing, with no indication to the caller. But that’s not new. 1712170 3 415455 cdumez 2020-12-04 14:34:15 -0800 Comment on attachment 415455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415455&action=review >> Source/WebCore/platform/audio/MultiChannelResampler.cpp:56 >> + void provideInputForChannel(float* buffer, size_t framesToProcess, unsigned channelIndex) > > Surprised that this function can just return and do nothing, with no indication to the caller. But that’s not new. I actually does not in practice. You can see that there are assertions for all conditions where we early return. For some reason though, the person who wrote this code did both assertions and early return in release if the assertion would have failed. 1712174 4 415455 cdumez 2020-12-04 14:39:40 -0800 Comment on attachment 415455 Patch Clearing flags on attachment: 415455 Committed r270460: <https://trac.webkit.org/changeset/270460> 1712175 5 cdumez 2020-12-04 14:39:42 -0800 All reviewed patches have been landed. Closing bug. 1712176 6 webkit-bug-importer 2020-12-04 14:40:27 -0800 <rdar://problem/71994027> 415455 2020-12-04 13:44:53 -0800 2020-12-04 14:39:40 -0800 Patch bug-219553-20201204134452.patch text/plain 8781 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBlYTU2YzBiYmIyOTY2 NDA5OTY4YWZkMWI5Y2M4MWQ1ZjU5ZmE4Zi4uODU0ZmRlMmQ1MGNhZjE3MWNiODFkNjQ5ODBmNzQ2 OTZmNThkZDZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTEyLTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCBjb25zdHJ1Y3Rpbmcg dW5uZWNlc3NhcnkgQXVkaW9CdXMgaW4gU2luY1Jlc2FtcGxlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NTUzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCBjb25zdHJ1Y3RpbmcgdW5uZWNlc3Nh cnkgQXVkaW9CdXMgaW4gU2luY1Jlc2FtcGxlci4gSW5zdGVhZCwgcGFzcyB0aGUgZmxvYXQqIGJ1 ZmZlcgorICAgICAgICB0byB0aGUgbGFtYmRhIGRpcmVjdGx5LgorCisgICAgICAgICogcGxhdGZv cm0vYXVkaW8vTXVsdGlDaGFubmVsUmVzYW1wbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok11 bHRpQ2hhbm5lbFJlc2FtcGxlcjo6Q2hhbm5lbFByb3ZpZGVyOjpwcm92aWRlSW5wdXRGb3JDaGFu bmVsKToKKyAgICAgICAgKFdlYkNvcmU6Ok11bHRpQ2hhbm5lbFJlc2FtcGxlcjo6cHJvY2Vzcyk6 CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTaW5jUmVzYW1wbGVyOjpjb25zdW1lU291cmNlKToKKyAgICAgICAgKFdlYkNvcmU6 OlNpbmNSZXNhbXBsZXI6OnByb2Nlc3MpOgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL1NpbmNS ZXNhbXBsZXIuaDoKKwogMjAyMC0xMi0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIEltcHJvdmUgdmVjdG9yaXphdGlvbiBpbiBTaW5jUmVzYW1wbGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NdWx0aUNoYW5uZWxSZXNhbXBs ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vTXVsdGlDaGFubmVsUmVzYW1w bGVyLmNwcAppbmRleCBhNWVmODUzODkzYjUyZGZjNDQ1ZWIyMjU2OTdmNTY2ZGJlODc4YzExLi5k MzRmYjc4OWI2YmM5ZDM3OWZjOTRhYTM5YzJhNWFjMzhiZjAxZTU1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9NdWx0aUNoYW5uZWxSZXNhbXBsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL011bHRpQ2hhbm5lbFJlc2FtcGxlci5jcHAK QEAgLTUzLDE4ICs1MywxMyBAQCBwdWJsaWM6CiAKICAgICAvLyBwcm92aWRlSW5wdXQoKSB3aWxs IGJlIGNhbGxlZCBvbmNlIGZvciBlYWNoIGNoYW5uZWwsIHN0YXJ0aW5nIHdpdGggdGhlIGZpcnN0 IGNoYW5uZWwuCiAgICAgLy8gRWFjaCB0aW1lIGl0J3MgY2FsbGVkLCBpdCB3aWxsIHByb3ZpZGUg dGhlIG5leHQgY2hhbm5lbCBvZiBkYXRhLgotICAgIHZvaWQgcHJvdmlkZUlucHV0Rm9yQ2hhbm5l bChBdWRpb0J1cyogYnVzLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNzLCB1bnNpZ25lZCBjaGFubmVs SW5kZXgpCisgICAgdm9pZCBwcm92aWRlSW5wdXRGb3JDaGFubmVsKGZsb2F0KiBidWZmZXIsIHNp emVfdCBmcmFtZXNUb1Byb2Nlc3MsIHVuc2lnbmVkIGNoYW5uZWxJbmRleCkKICAgICB7CiAgICAg ICAgIEFTU0VSVChjaGFubmVsSW5kZXggPCBtX211bHRpQ2hhbm5lbEJ1cy0+bnVtYmVyT2ZDaGFu bmVscygpKTsKICAgICAgICAgQVNTRVJUKGZyYW1lc1RvUHJvY2VzcyA8PSBtX211bHRpQ2hhbm5l bEJ1cy0+bGVuZ3RoKCkpOwogICAgICAgICBpZiAoZnJhbWVzVG9Qcm9jZXNzID4gbV9tdWx0aUNo YW5uZWxCdXMtPmxlbmd0aCgpKQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGJvb2wg aXNCdXNHb29kID0gYnVzICYmIGJ1cy0+bnVtYmVyT2ZDaGFubmVscygpID09IDE7Ci0gICAgICAg IEFTU0VSVChpc0J1c0dvb2QpOwotICAgICAgICBpZiAoIWlzQnVzR29vZCkKLSAgICAgICAgICAg IHJldHVybjsKLQogICAgICAgICAvLyBHZXQgdGhlIGRhdGEgZnJvbSB0aGUgbXVsdGktY2hhbm5l bCBwcm92aWRlciB3aGVuIHRoZSBmaXJzdCBjaGFubmVsIGFza3MgZm9yIGl0LgogICAgICAgICAv LyBGb3Igc3Vic2VxdWVudCBjaGFubmVscywgd2UgY2FuIGp1c3QgZGlzaCBvdXQgdGhlIGNoYW5u ZWwgZGF0YSBmcm9tIHRoYXQgKHN0b3JlZCBpbiBtX211bHRpQ2hhbm5lbEJ1cykuCiAgICAgICAg IGlmICghY2hhbm5lbEluZGV4KSB7CkBAIC03OSw3ICs3NCw3IEBAIHB1YmxpYzoKICAgICAgICAg ICAgIHJldHVybjsKIAogICAgICAgICAvLyBDb3B5IHRoZSBjaGFubmVsIGRhdGEgZnJvbSB3aGF0 IHdlIHJlY2VpdmVkIGZyb20gbV9tdWx0aUNoYW5uZWxQcm92aWRlci4KLSAgICAgICAgbWVtY3B5 KGJ1cy0+Y2hhbm5lbCgwKS0+bXV0YWJsZURhdGEoKSwgbV9tdWx0aUNoYW5uZWxCdXMtPmNoYW5u ZWwoY2hhbm5lbEluZGV4KS0+ZGF0YSgpLCBzaXplb2YoZmxvYXQpICogZnJhbWVzVG9Qcm9jZXNz KTsKKyAgICAgICAgbWVtY3B5KGJ1ZmZlciwgbV9tdWx0aUNoYW5uZWxCdXMtPmNoYW5uZWwoY2hh bm5lbEluZGV4KS0+ZGF0YSgpLCBzaXplb2YoZmxvYXQpICogZnJhbWVzVG9Qcm9jZXNzKTsKICAg ICB9CiAKIHByaXZhdGU6CkBAIC0xMTksMTAgKzExNCwxMCBAQCB2b2lkIE11bHRpQ2hhbm5lbFJl c2FtcGxlcjo6cHJvY2VzcyhBdWRpb1NvdXJjZVByb3ZpZGVyKiBwcm92aWRlciwgQXVkaW9CdXMq IGRlcwogICAgICAgICBmb3IgKHVuc2lnbmVkIGNoYW5uZWxJbmRleCA9IDA7IGNoYW5uZWxJbmRl eCA8IG1fbnVtYmVyT2ZDaGFubmVsczsgKytjaGFubmVsSW5kZXgpIHsKICAgICAgICAgICAgIEFT U0VSVChjaHVua1NpemUgPT0gbV9rZXJuZWxzW2NoYW5uZWxJbmRleF0tPmNodW5rU2l6ZSgpKTsK ICAgICAgICAgICAgIGJvb2wgd2FzUHJvdmlkZUlucHV0Q2FsbGVkID0gZmFsc2U7Ci0gICAgICAg ICAgICBtX2tlcm5lbHNbY2hhbm5lbEluZGV4XS0+cHJvY2VzcyhkZXN0aW5hdGlvbi0+Y2hhbm5l bChjaGFubmVsSW5kZXgpLT5tdXRhYmxlRGF0YSgpICsgbV9vdXRwdXRGcmFtZXNSZWFkeSwgZnJh bWVzVGhpc1RpbWUsIFt0aGlzLCBjaGFubmVsSW5kZXgsICZ3YXNQcm92aWRlSW5wdXRDYWxsZWRd KEF1ZGlvQnVzKiBidXMsIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpIHsKKyAgICAgICAgICAgIG1f a2VybmVsc1tjaGFubmVsSW5kZXhdLT5wcm9jZXNzKGRlc3RpbmF0aW9uLT5jaGFubmVsKGNoYW5u ZWxJbmRleCktPm11dGFibGVEYXRhKCkgKyBtX291dHB1dEZyYW1lc1JlYWR5LCBmcmFtZXNUaGlz VGltZSwgW3RoaXMsIGNoYW5uZWxJbmRleCwgJndhc1Byb3ZpZGVJbnB1dENhbGxlZF0oZmxvYXQq IGJ1ZmZlciwgc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykgewogICAgICAgICAgICAgICAgIEFTU0VS VF9XSVRIX01FU1NBR0UoIXdhc1Byb3ZpZGVJbnB1dENhbGxlZCwgInByb3ZpZGVJbnB1dEZvckNo YW5uZWwgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIG9uY2UiKTsKICAgICAgICAgICAgICAgICB3YXNQ cm92aWRlSW5wdXRDYWxsZWQgPSB0cnVlOwotICAgICAgICAgICAgICAgIG1fY2hhbm5lbFByb3Zp ZGVyLT5wcm92aWRlSW5wdXRGb3JDaGFubmVsKGJ1cywgZnJhbWVzVG9Qcm9jZXNzLCBjaGFubmVs SW5kZXgpOworICAgICAgICAgICAgICAgIG1fY2hhbm5lbFByb3ZpZGVyLT5wcm92aWRlSW5wdXRG b3JDaGFubmVsKGJ1ZmZlciwgZnJhbWVzVG9Qcm9jZXNzLCBjaGFubmVsSW5kZXgpOwogICAgICAg ICAgICAgfSk7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vU2luY1Jlc2FtcGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9TaW5jUmVzYW1wbGVyLmNwcAppbmRleCA4NDhkZTZiZmJlZmRkMzYzNjJjZTVjZWU1NjIyNDYz ZjViZGY5NWFhLi4zMzdmYTY0NDk4YzRlYmFmMmNmYmJmOWVlNmViZTI5NmMxODZiNDEyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1wbGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1wbGVyLmNwcApAQCAt MTk3LDIyICsxOTcsNiBAQCB2b2lkIFNpbmNSZXNhbXBsZXI6OmluaXRpYWxpemVLZXJuZWwoKQog ICAgIH0KIH0KIAotdm9pZCBTaW5jUmVzYW1wbGVyOjpjb25zdW1lU291cmNlKGZsb2F0KiBidWZm ZXIsIHVuc2lnbmVkIG51bWJlck9mU291cmNlRnJhbWVzLCBjb25zdCBGdW5jdGlvbjx2b2lkKEF1 ZGlvQnVzKiBidXMsIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpPiYgcHJvdmlkZUlucHV0KQotewot ICAgIEFTU0VSVChwcm92aWRlSW5wdXQpOwotICAgIGlmICghcHJvdmlkZUlucHV0KQotICAgICAg ICByZXR1cm47Ci0KLSAgICAvLyBXcmFwIHRoZSBwcm92aWRlZCBidWZmZXIgYnkgYW4gQXVkaW9C dXMgZm9yIHVzZSBieSB0aGUgc291cmNlIHByb3ZpZGVyLgotICAgIGlmICghbV9pbnRlcm5hbEJ1 cyB8fCBtX2ludGVybmFsQnVzLT5sZW5ndGgoKSAhPSBudW1iZXJPZlNvdXJjZUZyYW1lcykKLSAg ICAgICAgbV9pbnRlcm5hbEJ1cyA9IEF1ZGlvQnVzOjpjcmVhdGUoMSwgbnVtYmVyT2ZTb3VyY2VG cmFtZXMsIGZhbHNlKTsKLQotICAgIC8vIEZJWE1FOiBGaW5kIGEgd2F5IHRvIG1ha2UgdGhlIGZv bGxvd2luZyBjb25zdC1jb3JyZWN0OgotICAgIG1faW50ZXJuYWxCdXMtPnNldENoYW5uZWxNZW1v cnkoMCwgYnVmZmVyLCBudW1iZXJPZlNvdXJjZUZyYW1lcyk7Ci0gICAgCi0gICAgcHJvdmlkZUlu cHV0KG1faW50ZXJuYWxCdXMuZ2V0KCksIG51bWJlck9mU291cmNlRnJhbWVzKTsKLX0KLQogbmFt ZXNwYWNlIHsKIAogLy8gQnVmZmVyU291cmNlUHJvdmlkZXIgaXMgYW4gYXVkaW8gc291cmNlIHBy b3ZpZGVyIHdyYXBwaW5nIGFuIGluLW1lbW9yeSBidWZmZXIuCkBAIC0yMjYsMTMgKzIxMCwxMSBA QCBwdWJsaWM6CiAgICAgfQogICAgIAogICAgIC8vIENvbnN1bWVzIHNhbXBsZXMgZnJvbSB0aGUg aW4tbWVtb3J5IGJ1ZmZlci4KLSAgICB2b2lkIHByb3ZpZGVJbnB1dChBdWRpb0J1cyogYnVzLCBz aXplX3QgZnJhbWVzVG9Qcm9jZXNzKQorICAgIHZvaWQgcHJvdmlkZUlucHV0KGZsb2F0KiBidWZm ZXIsIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpCiAgICAgewotICAgICAgICBBU1NFUlQobV9zb3Vy Y2UgJiYgYnVzKTsKLSAgICAgICAgaWYgKCFtX3NvdXJjZSB8fCAhYnVzKQorICAgICAgICBBU1NF UlQobV9zb3VyY2UgJiYgYnVmZmVyKTsKKyAgICAgICAgaWYgKCFtX3NvdXJjZSB8fCAhYnVmZmVy KQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgCi0gICAgICAgIGZsb2F0KiBidWZm ZXIgPSBidXMtPmNoYW5uZWwoMCktPm11dGFibGVEYXRhKCk7CiAKICAgICAgICAgLy8gQ2xhbXAg dG8gbnVtYmVyIG9mIGZyYW1lcyBhdmFpbGFibGUgYW5kIHplcm8tcGFkLgogICAgICAgICBzaXpl X3QgZnJhbWVzVG9Db3B5ID0gc3RkOjptaW4obV9zb3VyY2VGcmFtZXNBdmFpbGFibGUsIGZyYW1l c1RvUHJvY2Vzcyk7CkBAIC0yNjMsOCArMjQ1LDggQEAgdm9pZCBTaW5jUmVzYW1wbGVyOjpwcm9j ZXNzKGNvbnN0IGZsb2F0KiBzb3VyY2UsIGZsb2F0KiBkZXN0aW5hdGlvbiwgdW5zaWduZWQgbnUK ICAgICAKICAgICB3aGlsZSAocmVtYWluaW5nKSB7CiAgICAgICAgIHVuc2lnbmVkIGZyYW1lc1Ro aXNUaW1lID0gc3RkOjptaW4ocmVtYWluaW5nLCBtX3JlcXVlc3RGcmFtZXMpOwotICAgICAgICBw cm9jZXNzKGRlc3RpbmF0aW9uLCBmcmFtZXNUaGlzVGltZSwgWyZzb3VyY2VQcm92aWRlcl0oQXVk aW9CdXMqIGJ1cywgc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykgewotICAgICAgICAgICAgc291cmNl UHJvdmlkZXIucHJvdmlkZUlucHV0KGJ1cywgZnJhbWVzVG9Qcm9jZXNzKTsKKyAgICAgICAgcHJv Y2VzcyhkZXN0aW5hdGlvbiwgZnJhbWVzVGhpc1RpbWUsIFsmc291cmNlUHJvdmlkZXJdKGZsb2F0 KiBidWZmZXIsIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpIHsKKyAgICAgICAgICAgIHNvdXJjZVBy b3ZpZGVyLnByb3ZpZGVJbnB1dChidWZmZXIsIGZyYW1lc1RvUHJvY2Vzcyk7CiAgICAgICAgIH0p OwogICAgICAgICAKICAgICAgICAgZGVzdGluYXRpb24gKz0gZnJhbWVzVGhpc1RpbWU7CkBAIC0y NzIsNyArMjU0LDcgQEAgdm9pZCBTaW5jUmVzYW1wbGVyOjpwcm9jZXNzKGNvbnN0IGZsb2F0KiBz b3VyY2UsIGZsb2F0KiBkZXN0aW5hdGlvbiwgdW5zaWduZWQgbnUKICAgICB9CiB9CiAKLXZvaWQg U2luY1Jlc2FtcGxlcjo6cHJvY2VzcyhmbG9hdCogZGVzdGluYXRpb24sIHNpemVfdCBmcmFtZXNU b1Byb2Nlc3MsIGNvbnN0IEZ1bmN0aW9uPHZvaWQoQXVkaW9CdXMqIGJ1cywgc2l6ZV90IGZyYW1l c1RvUHJvY2Vzcyk+JiBwcm92aWRlSW5wdXQpCit2b2lkIFNpbmNSZXNhbXBsZXI6OnByb2Nlc3Mo ZmxvYXQqIGRlc3RpbmF0aW9uLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNzLCBjb25zdCBGdW5jdGlv bjx2b2lkKGZsb2F0KiBidWZmZXIsIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpPiYgcHJvdmlkZUlu cHV0KQogewogICAgIEFTU0VSVChwcm92aWRlSW5wdXQpOwogICAgIGlmICghcHJvdmlkZUlucHV0 KQpAQCAtMjgzLDcgKzI2NSw3IEBAIHZvaWQgU2luY1Jlc2FtcGxlcjo6cHJvY2VzcyhmbG9hdCog ZGVzdGluYXRpb24sIHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MsIGNvbnN0IEZ1CiAgICAgLy8gU3Rl cCAoMSkKICAgICAvLyBQcmltZSB0aGUgaW5wdXQgYnVmZmVyIGF0IHRoZSBzdGFydCBvZiB0aGUg aW5wdXQgc3RyZWFtLgogICAgIGlmICghbV9pc0J1ZmZlclByaW1lZCkgewotICAgICAgICBjb25z dW1lU291cmNlKG1fcjAsIG1fcmVxdWVzdEZyYW1lcywgcHJvdmlkZUlucHV0KTsKKyAgICAgICAg cHJvdmlkZUlucHV0KG1fcjAsIG1fcmVxdWVzdEZyYW1lcyk7CiAgICAgICAgIG1faXNCdWZmZXJQ cmltZWQgPSB0cnVlOwogICAgIH0KICAgICAKQEAgLTMzNSw3ICszMTcsNyBAQCB2b2lkIFNpbmNS ZXNhbXBsZXI6OnByb2Nlc3MoZmxvYXQqIGRlc3RpbmF0aW9uLCBzaXplX3QgZnJhbWVzVG9Qcm9j ZXNzLCBjb25zdCBGdQogCiAgICAgICAgIC8vIFN0ZXAgKDUpCiAgICAgICAgIC8vIFJlZnJlc2gg dGhlIGJ1ZmZlciB3aXRoIG1vcmUgaW5wdXQuCi0gICAgICAgIGNvbnN1bWVTb3VyY2UobV9yMCwg bV9yZXF1ZXN0RnJhbWVzLCBwcm92aWRlSW5wdXQpOworICAgICAgICBwcm92aWRlSW5wdXQobV9y MCwgbV9yZXF1ZXN0RnJhbWVzKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2F1ZGlvL1NpbmNSZXNhbXBsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL1NpbmNSZXNhbXBsZXIuaAppbmRleCBiMWY2NzczMjYyNzZlOTlkZjZlMzdmNDZk MjU2MzM1MjdlZDc4NTAwLi44ZTlmNzZjOTYyNWM1OTFlNDc4YjA3ZGRiNzU2M2M2ZjlkNzc3ZDRl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1wbGVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5oCkBA IC01MywxMSArNTMsMTAgQEAgcHVibGljOgogICAgIHZvaWQgcHJvY2Vzcyhjb25zdCBmbG9hdCog c291cmNlLCBmbG9hdCogZGVzdGluYXRpb24sIHVuc2lnbmVkIG51bWJlck9mU291cmNlRnJhbWVz KTsKIAogICAgIC8vIFByb2Nlc3Mgd2l0aCBwcm92aWRlSW5wdXQgY2FsbGJhY2sgZnVuY3Rpb24g Zm9yIHN0cmVhbWluZyBhcHBsaWNhdGlvbnMuCi0gICAgdm9pZCBwcm9jZXNzKGZsb2F0KiBkZXN0 aW5hdGlvbiwgc2l6ZV90IGZyYW1lc1RvUHJvY2VzcywgY29uc3QgRnVuY3Rpb248dm9pZChBdWRp b0J1cyogYnVzLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNzKT4mIHByb3ZpZGVJbnB1dCk7CisgICAg dm9pZCBwcm9jZXNzKGZsb2F0KiBkZXN0aW5hdGlvbiwgc2l6ZV90IGZyYW1lc1RvUHJvY2Vzcywg Y29uc3QgRnVuY3Rpb248dm9pZChmbG9hdCogYnVmZmVyLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNz KT4mIHByb3ZpZGVJbnB1dCk7CiAKIHByb3RlY3RlZDoKICAgICB2b2lkIGluaXRpYWxpemVLZXJu ZWwoKTsKLSAgICB2b2lkIGNvbnN1bWVTb3VyY2UoZmxvYXQqIGJ1ZmZlciwgdW5zaWduZWQgbnVt YmVyT2ZTb3VyY2VGcmFtZXMsIGNvbnN0IEZ1bmN0aW9uPHZvaWQoQXVkaW9CdXMqIGJ1cywgc2l6 ZV90IGZyYW1lc1RvUHJvY2Vzcyk+JiBwcm92aWRlSW5wdXQpOwogICAgIHZvaWQgdXBkYXRlUmVn aW9ucyhib29sIGlzU2Vjb25kTG9hZCk7CiAKICAgICBmbG9hdCBjb252b2x2ZShjb25zdCBmbG9h dCogaW5wdXRQLCBjb25zdCBmbG9hdCogazEsIGNvbnN0IGZsb2F0KiBrMiwgZmxvYXQga2VybmVs SW50ZXJwb2xhdGlvbkZhY3Rvcik7CkBAIC05Niw4ICs5NSw2IEBAIHByb3RlY3RlZDoKIAogICAg IC8vIFRoZSBidWZmZXIgaXMgcHJpbWVkIG9uY2UgYXQgdGhlIHZlcnkgYmVnaW5uaW5nIG9mIHBy b2Nlc3NpbmcuCiAgICAgYm9vbCBtX2lzQnVmZmVyUHJpbWVkIHsgZmFsc2UgfTsKLQotICAgIFJl ZlB0cjxBdWRpb0J1cz4gbV9pbnRlcm5hbEJ1czsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUK