219547 2020-12-04 11:37:53 -0800 REGRESSION(r270425) [GTK] wheel scrolling stopped working 2021-02-15 12:46:10 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218764 https://bugs.webkit.org/show_bug.cgi?id=219726 InRadar P2 Normal --- 218764 1 lmoura lmoura alex alicem bugs-noreply cgarcia clord fujii jan.brummer jmason mcatanzaro pnormand simon.fraser thorton webkit-bug-importer oldest_to_newest 1712090 0 lmoura 2020-12-04 11:37:53 -0800 # Timeouts fast/events/remove-child-onscroll.html fast/events/wheel/wheel-event-destroys-frame.html fast/events/wheel/wheel-event-destroys-overflow.html fast/events/wheel/wheel-event-outside-body.html fast/events/wheel/wheelevent-basic.html fast/events/wheel/wheelevent-in-text-node.html fast/events/wheel/wheelevent-mousewheel-interaction.html fast/scrolling/iframe-scrollable-after-back.html fast/scrolling/overflow-scrollable-after-back.html pointer-lock/mouse-event-delivery.html scrollbars/scroll-rtl-or-bt-layer.html # Failures fast/events/wheel/continuous-platform-wheelevent-in-scrolling-div.html fast/frames/flattening/scrolling-in-object.html fast/scrolling/rtl-scrollbars-listbox-scroll.html Using the MiniBrowser, I can't scroll anything when async scrolling is enabled. Could not test disabling it yet, though. 1712093 1 lmoura 2020-12-04 11:45:31 -0800 Gardened in r270443. 1712821 2 lmoura 2020-12-08 09:58:14 -0800 *** Bug 219646 has been marked as a duplicate of this bug. *** 1713428 3 415835 lmoura 2020-12-09 22:21:01 -0800 Created attachment 415835 Tentative patch 1713429 4 415835 lmoura 2020-12-09 22:23:01 -0800 Comment on attachment 415835 Tentative patch View in context: https://bugs.webkit.org/attachment.cgi?id=415835&action=review > LayoutTests/platform/gtk/fast/scrolling/overflow-scrollable-after-back-expected.txt:4 > +PASS: mouseWheel caused scrolling Not sure if this extra scroll is right, though. The test sends 4 scroll phases (begin, changed, changed, ended), and the 3 first ones happen to trigger the callbacks. 1713438 5 415835 simon.fraser 2020-12-09 23:04:48 -0800 Comment on attachment 415835 Tentative patch View in context: https://bugs.webkit.org/attachment.cgi?id=415835&action=review > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:168 > + auto scrollingTree = m_scrollingTrees.get(pageID); > + if (!scrollingTree) > + dispatchWheelEventViaMainThread(pageID, wheelEvent, processingSteps); How does GTK work with ENABLE(SCROLLING_THREAD) but no scrolling tree? That combination makes no sense. 1713894 6 cgarcia 2020-12-11 06:45:47 -0800 Async scrolling depends on accelerated compositing mode being enabled. In the GTK port, we have an accelerate compositing policy setting, that is ondemand by default, which means we enable AC mode when the page requires to enter in AC mode. Async scrolling requires AC mode to be always enabled, so we only enable it when the AC policy is set to always. 1717082 7 pnormand 2021-01-04 02:16:51 -0800 Ping reviewers 1717135 8 mcatanzaro 2021-01-04 08:56:29 -0800 Hm, I think I'm not the right person to review this. But I understand that all scrolling is totally broken for a month now, so would be good to land. I guess we have not been testing trunk very much in December. :P 1717244 9 alicem 2021-01-05 01:37:42 -0800 All non-async scrolling* Which means that at the very least it never happens with GTK4, so scrolling worked there the whole time. So if you switch hardware acceleration policy to always and then open a new tab in minibrowser, it will work. 1717945 10 ews-feeder 2021-01-07 07:58:43 -0800 Committed r271235: <https://trac.webkit.org/changeset/271235> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415835. 1717946 11 webkit-bug-importer 2021-01-07 07:59:37 -0800 <rdar://problem/72889749> 1726528 12 fujii 2021-02-07 18:38:47 -0800 This fix isn't perfect. Filed: Bug 221067 – [GTK] Page scrolling by wheel events doesn't work in non-AC mode pages if Hardware Acceleration Policy is changed dynamically from "always" to "never" 1726530 13 415835 fujii 2021-02-07 19:30:02 -0800 Comment on attachment 415835 Tentative patch View in context: https://bugs.webkit.org/attachment.cgi?id=415835&action=review > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:166 > + auto scrollingTree = m_scrollingTrees.get(pageID); You are accessing m_scrollingTrees without locking m_scrollingTreesMutex. Is this OK? 1729259 14 fujii 2021-02-15 11:17:28 -0800 (In reply to Fujii Hironori from comment #13) > Comment on attachment 415835 [details] > Tentative patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415835&action=review > > > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:166 > > + auto scrollingTree = m_scrollingTrees.get(pageID); > > You are accessing m_scrollingTrees without locking m_scrollingTreesMutex. Is > this OK? r272867 removed the suspicious code. 1729299 15 pnormand 2021-02-15 12:32:41 -0800 Thanks! I'll test this, I noticed wheel scrolling wasn't working anymore in the WPE MiniBrowser (and Cog). I'll open a new bug if the issue is still present. 1729305 16 fujii 2021-02-15 12:46:10 -0800 (In reply to Philippe Normand from comment #15) > Thanks! I'll test this, I noticed wheel scrolling wasn't working anymore in > the WPE MiniBrowser (and Cog). I'll open a new bug if the issue is still > present. r271235 and r272867 are fixes for non-AC mode (the case of no scrolling tree). WPE seems to have a different issue. 415835 2020-12-09 22:21:01 -0800 2021-01-07 07:58:47 -0800 Tentative patch bug-219547-20201210032059.patch text/plain 4545 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVmYzc2ODg4ZDU4NDVj ZTg3MTQyOWI0ZjVlOTkxZDEyYzM0NzViZi4uYjgyMTc3MTAyMDBmZjQ3ODkxYjRkZDUxMGM2Zjg0 ZjRlYzk4NDE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEyLTA5ICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3MDQy NSkgW0dUS10gd2hlZWwgc2Nyb2xsaW5nIHN0b3BwZWQgd29ya2luZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NTQ3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlmIHRoZSBmcmFt ZSB3YXMgYWxyZWFkeSBkZWxldGVkLgorCisgICAgICAgIE5lZWRlZCBmb3IgZmFzdC9ldmVudHMv d2hlZWwtZXZlbnQtZGVzdHJveXMtZnJhbWUuaHRtbAorCisgICAgICAgICogcGFnZS9FdmVudEhh bmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjp3aGVlbEV2ZW50V2Fz UHJvY2Vzc2VkQnlNYWluVGhyZWFkKToKKwogMjAyMC0xMi0wOSAgUGVuZyBMaXUgIDxwZW5nLmxp dTZAYXBwbGUuY29tPgogCiAgICAgICAgIFtNZWRpYSBpbiBHUFUgUHJvY2Vzc11bTVNFXSBJbXBs ZW1lbnQgYmFzaWMgdmlkZW8gcGxheWJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZjk0MmU2OGQ3MDI0ZDI4YTQ2 MzVkOWM1MzEwYTNhMWU3MDBjOWUwMS4uMWU3MjFiMmI5Mzc0Y2Q1MWU0YTI2MmFlZTYwOTRmZDNm Y2QxZDRlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAyMC0xMi0wOSAgTGF1cm8gTW91 cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNzA0MjUpIFtH VEtdIHdoZWVsIHNjcm9sbGluZyBzdG9wcGVkIHdvcmtpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTU0NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEdUSyB3ZSBtYXkgaGF2ZSB0aGUgY2FzZSB3 aGVyZSB0aGUgYXN5bmMgc2Nyb2xsaW5nIGlzIGRpc2FibGVkIGF0CisgICAgICAgIHJ1bnRpbWUg ZGVzcGl0ZSBiZWluZyBjb21waWxlZCB3aXRoIEFTWU5DX1NDUk9MTElORy9TQ1JPTExJTkdfVEhS RUFELgorICAgICAgICBJbiB0aGVzZSBjYXNlcywgdGhlIHdoZWVsIGV2ZW50cyBzdGlsbCBuZWVk IHRvIGJlIGRpc3BhdGNoZWQgdGhyb3VnaAorICAgICAgICB0aGUgbWFpbiB0aHJlYWQuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRXZlbnREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6RXZlbnREaXNwYXRjaGVyOjp3aGVlbEV2ZW50KToKKwogMjAyMC0xMi0wOSAgUGVu ZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAgIFtNZWRpYSBpbiBHUFUgUHJv Y2Vzc11bTVNFXSBJbXBsZW1lbnQgYmFzaWMgdmlkZW8gcGxheWJhY2sKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcAppbmRleCA1NjMyM2I4NWI1YmUwZTg4OWRhMThiZWFmNTAxNDhmYWFi YjgxMWQzLi5lNjhjN2JmYzkxNzc5ZjRiN2Y1NmViNWY5ODVlZjQ1NjYyNzg1ODEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0yNzM2LDYgKzI3MzYsMTAgQEAgdm9pZCBF dmVudEhhbmRsZXI6OndoZWVsRXZlbnRXYXNQcm9jZXNzZWRCeU1haW5UaHJlYWQoY29uc3QgUGxh dGZvcm1XaGVlbEV2ZW50JgogICAgIHVwZGF0ZVdoZWVsR2VzdHVyZVN0YXRlKHdoZWVsRXZlbnQs IGV2ZW50SGFuZGxpbmcpOwogCiAjaWYgRU5BQkxFKEFTWU5DX1NDUk9MTElORykKKworICAgIGlm ICghbV9mcmFtZS5wYWdlKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIEZyYW1lVmlldyogdmll dyA9IG1fZnJhbWUudmlldygpOwogICAgIGlmIChhdXRvIHNjcm9sbGluZ0Nvb3JkaW5hdG9yID0g bV9mcmFtZS5wYWdlKCktPnNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkpIHsKICAgICAgICAgaWYgKHNj cm9sbGluZ0Nvb3JkaW5hdG9yLT5jb29yZGluYXRlc1Njcm9sbGluZ0ZvckZyYW1lVmlldygqdmll dykpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERp c3BhdGNoZXIuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvRXZlbnREaXNw YXRjaGVyLmNwcAppbmRleCAzZGExY2ZlMDQ1ZDg3OWIzMjc5ZWZlOWRiMmM1MDNkMzk5NWU1YTk1 Li41N2Y3OWZmZDRhMzI5NGEzZjc3YTUxNDQ4YzE3YWJmN2MyOGZlZDM0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0V2ZW50RGlzcGF0Y2hlci5jcHAKQEAg LTE2Miw2ICsxNjIsMTAgQEAgdm9pZCBFdmVudERpc3BhdGNoZXI6OndoZWVsRXZlbnQoUGFnZUlk ZW50aWZpZXIgcGFnZUlELCBjb25zdCBXZWJXaGVlbEV2ZW50JiB3aGUKIAogICAgICAgICByZXR1 cm4gcHJvY2Vzc2luZ1N0ZXBzOwogICAgIH0oKTsKKworICAgIGF1dG8gc2Nyb2xsaW5nVHJlZSA9 IG1fc2Nyb2xsaW5nVHJlZXMuZ2V0KHBhZ2VJRCk7CisgICAgaWYgKCFzY3JvbGxpbmdUcmVlKQor ICAgICAgICBkaXNwYXRjaFdoZWVsRXZlbnRWaWFNYWluVGhyZWFkKHBhZ2VJRCwgd2hlZWxFdmVu dCwgcHJvY2Vzc2luZ1N0ZXBzKTsKICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKGNhblJ1YmJlckJh bmRBdExlZnQpOwogICAgIFVOVVNFRF9QQVJBTShjYW5SdWJiZXJCYW5kQXRSaWdodCk7CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggZTczMzFjMzBiNWNkZWQ5MzMyYjEyZDA4YjI0MTIzNmZhMzVkNDJkMy4uNTZlNWI5YjdiNjgx NmYzYTgxNjgzNDI1NzViZGNhY2YyZjNkOTc2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIw LTEyLTA5ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JF U1NJT04ocjI3MDQyNSkgW0dUS10gd2hlZWwgc2Nyb2xsaW5nIHN0b3BwZWQgd29ya2luZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NTQ3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGsvZmFzdC9zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsYWJsZS1hZnRlci1iYWNrLWV4cGVjdGVk LnR4dDoKKyAgICAgICAgUmViYXNlbGluZSB3aXRoIHRoZSBleHRyYSBzY3JvbGwgZXZlbnRzIGFy cml2aW5nCisKIDIwMjAtMTItMDkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4K IAogICAgICAgICBNYXJrZWQgc29tZSBXUFQgd29ya2xldCB0ZXN0cyBhcyBmbGFreQpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3Qvc2Nyb2xsaW5nL292ZXJmbG93LXNj cm9sbGFibGUtYWZ0ZXItYmFjay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvZmFzdC9zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsYWJsZS1hZnRlci1iYWNrLWV4cGVjdGVk LnR4dAppbmRleCA2Njc3YzFjZmI0NmQzYjAxZjYwYTljMDc2YWFjZGZiZWNkYWFlNGNhLi5lMTlk ODFlZWRlYTMxM2M3MmI0MjcxMGY0NmY0ZmI1NjU5YWYwZTgyIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsYWJsZS1hZnRl ci1iYWNrLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9z Y3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsYWJsZS1hZnRlci1iYWNrLWV4cGVjdGVkLnR4dApAQCAt MSw2ICsxLDEwIEBACiBTZW5kaW5nIG1vdXNlV2hlZWwgZXZlbnRzCiBQQVNTOiBtb3VzZVdoZWVs IGNhdXNlZCBzY3JvbGxpbmcKIFBBU1M6IG1vdXNlV2hlZWwgY2F1c2VkIHNjcm9sbGluZworUEFT UzogbW91c2VXaGVlbCBjYXVzZWQgc2Nyb2xsaW5nCisKK05hdmlnYXRpbmcgZm9yd2FyZCB0aGVu IGJhY2sKKwogCiBOYXZpZ2F0aW5nIGZvcndhcmQgdGhlbiBiYWNrCiAK