219540 2020-12-04 07:02:53 -0800 [macOS] Create sandbox extension for audio service when Media in GPU process is not enabled 2020-12-08 11:21:17 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1712010 0 pvollan 2020-12-04 07:02:53 -0800 Create sandbox extension for com.apple.audio.SandboxHelper when Media in GPU process is not enabled. 1712011 1 webkit-bug-importer 2020-12-04 07:03:49 -0800 <rdar://problem/71978050> 1712012 2 415411 pvollan 2020-12-04 07:06:20 -0800 Created attachment 415411 Patch 1712831 3 415411 bfulgham 2020-12-08 10:37:54 -0800 Comment on attachment 415411 Patch r=me 1712832 4 415411 bfulgham 2020-12-08 10:38:33 -0800 Comment on attachment 415411 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415411&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1301 > + "com.apple.accessibility.mediaaccessibilityd" "com.apple.audio.SandboxHelper" "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.videodecoder" "com.apple.coremedia.videoencoder" Do we need to remove 'com.apple.audio.SandboxHelper' from another part of the sandbox, or make it a 'with-report' so we can be sure it's going through the new flow? 1712839 5 pvollan 2020-12-08 11:09:05 -0800 (In reply to Brent Fulgham from comment #4) > Comment on attachment 415411 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415411&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1301 > > + "com.apple.accessibility.mediaaccessibilityd" "com.apple.audio.SandboxHelper" "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.videodecoder" "com.apple.coremedia.videoencoder" > > Do we need to remove 'com.apple.audio.SandboxHelper' from another part of > the sandbox, or make it a 'with-report' so we can be sure it's going through > the new flow? I was thinking we could gather telemetry with the other rule after we switch over to GPU, and then eventually remove it. Does that sound ok? Or would you prefer to remove it now? Thanks for reviewing! 1712844 6 ews-feeder 2020-12-08 11:21:16 -0800 Committed r270545: <https://trac.webkit.org/changeset/270545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415411. 415411 2020-12-04 07:06:20 -0800 2020-12-08 11:21:16 -0800 Patch bug-219540-20201204160618.patch text/plain 2739 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzA0MjkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEyLTA0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyZWF0ZSBzYW5k Ym94IGV4dGVuc2lvbiBmb3IgYXVkaW8gc2VydmljZSB3aGVuIE1lZGlhIGluIEdQVSBwcm9jZXNz IGlzIG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTk1NDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcxOTc4MDUwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSBzYW5kYm94 IGV4dGVuc2lvbiBmb3IgY29tLmFwcGxlLmF1ZGlvLlNhbmRib3hIZWxwZXIgd2hlbiBNZWRpYSBp biBHUFUgcHJvY2VzcyBpcyBub3QgZW5hYmxlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjptZWRpYVJlbGF0ZWRNYWNoU2VydmljZXMp OgorICAgICAgICAqIFdlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIw MjAtMTItMDMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgT25seSB0aGUgZmlyc3Qgd2hlZWwgZXZlbnQgaW4gYSBnZXN0dXJlIHNob3VsZCBiZSBjYW5j ZWxhYmxlCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJl dmlzaW9uIDI3MDQyNSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTc4MDksNyArNzgwOSw3IEBAIHN0YXRpYyBjb25zdCBWZWN0 b3I8QVNDSUlMaXRlcmFsPiYgbWVkaWEKICAgICAgICAgImNvbS5hcHBsZS5hdWRpby5BVVJlbW90 ZUlPU2VydmVyIl9zLAogI2VuZGlmCiAjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShNQUND QVRBTFlTVCkKLSAgICAgICAgImNvbS5hcHBsZS5hdWRpby5hdWRpb2hhbGQiX3MsICJjb20uYXBw bGUuY29yZW1lZGlhLmVuZHBvaW50c3RyZWFtLnhwYyJfcywgImNvbS5hcHBsZS5jb3JlbWVkaWEu ZW5kcG9pbnRwbGF5YmFja3Nlc3Npb24ueHBjIl9zLAorICAgICAgICAiY29tLmFwcGxlLmF1ZGlv LmF1ZGlvaGFsZCJfcywgImNvbS5hcHBsZS5hdWRpby5TYW5kYm94SGVscGVyIl9zLCAiY29tLmFw cGxlLmNvcmVtZWRpYS5lbmRwb2ludHN0cmVhbS54cGMiX3MsICJjb20uYXBwbGUuY29yZW1lZGlh LmVuZHBvaW50cGxheWJhY2tzZXNzaW9uLnhwYyJfcywKICAgICAgICAgImNvbS5hcHBsZS5jb3Jl bWVkaWEuZW5kcG9pbnRyZW1vdGVjb250cm9sc2Vzc2lvbi54cGMiX3MsICJjb20uYXBwbGUuY29y ZW1lZGlhLnZpZGVvZGVjb2RlciJfcywKICAgICAgICAgImNvbS5hcHBsZS5jb3JlbWVkaWEudmlk ZW9lbmNvZGVyIl9zLCAiY29tLmFwcGxlLmxza2RkIl9zLCAiY29tLmFwcGxlLnRydXN0ZC5hZ2Vu dCJfcywgImNvbS5hcHBsZS5CbHVldG9vdGhTZXJ2aWNlcyJfcywKICNlbmRpZgpJbmRleDogU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5p bgkocmV2aXNpb24gMjcwNDI1KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBs ZS5XZWJQcm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xMjk4LDcgKzEyOTgsNyBAQAog ICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUud2Via2l0LmV4dGVuc2lvbi5tYWNoIikKICAg ICAgICAgKHhwYy1zZXJ2aWNlLW5hbWUKICAgICAgICAgICAgIDs7OyBGSVhNRSgyMDc3MTYpOiBU aGUgZm9sbG93aW5nIHNob3VsZCBiZSByZW1vdmVkIHdoZW4gdGhlIEdQVSBwcm9jZXNzIGlzIGNv bXBsZXRlCi0gICAgICAgICAgICAiY29tLmFwcGxlLmFjY2Vzc2liaWxpdHkubWVkaWFhY2Nlc3Np YmlsaXR5ZCIgImNvbS5hcHBsZS5hdWRpby50b29sYm94LnJlcG9ydGluZy5zZXJ2aWNlIiAiY29t LmFwcGxlLmNvcmVtZWRpYS52aWRlb2RlY29kZXIiICJjb20uYXBwbGUuY29yZW1lZGlhLnZpZGVv ZW5jb2RlciIKKyAgICAgICAgICAgICJjb20uYXBwbGUuYWNjZXNzaWJpbGl0eS5tZWRpYWFjY2Vz c2liaWxpdHlkIiAiY29tLmFwcGxlLmF1ZGlvLlNhbmRib3hIZWxwZXIiICJjb20uYXBwbGUuYXVk aW8udG9vbGJveC5yZXBvcnRpbmcuc2VydmljZSIgImNvbS5hcHBsZS5jb3JlbWVkaWEudmlkZW9k ZWNvZGVyIiAiY29tLmFwcGxlLmNvcmVtZWRpYS52aWRlb2VuY29kZXIiCiAgICAgICAgICAgICA7 OzsgRklYTUUoMjA3NzE2KTogRW5kIHNlcnZpY2VzIHRvIHJlbW92ZS4KICAgICAgICAgKQogICAg ICkK