21951 2008-10-29 12:18:22 -0700 SVGElementInstance.cpp does not compile under v8 2008-12-02 12:25:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned sam oldest_to_newest 97014 0 eric 2008-10-29 12:18:22 -0700 SVGElementInstance.cpp does not compile under v8 v8 has no GCController.h (and doesn't work with quite the same bindings/gc model), so the gcController() calls in SVGElementInstance.cpp should be jsc only. This is also a JSC-only hack anyway (as the comment makes clear). 97015 1 24752 eric 2008-10-29 12:20:16 -0700 Created attachment 24752 Fix the v8 build WebCore/ChangeLog | 10 ++++++++++ WebCore/svg/SVGElementInstance.cpp | 9 +++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) 97027 2 24752 darin 2008-10-29 13:17:18 -0700 Comment on attachment 24752 Fix the v8 build Looks fine. r=me 101038 3 eric 2008-12-02 12:25:31 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/svg/SVGElementInstance.cpp Committed r38909 24752 2008-10-29 12:20:16 -0700 2008-10-29 13:17:18 -0700 Fix the v8 build Fix-the-v8-build.patch text/plain 2017 eric OTRkMWYwNDYzMmE3NzQ3YjU5MzY2M2E4NmJmN2UzMzc1Mjc1YmU5MwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMDQ4Y2JkLi5kOTA5NmE5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDA4LTEwLTI5ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXcmFw IGEgSlNDLW9ubHkgaGFjayBpbiBhIFVTRShKU0MpIGJsb2NrIHRvIGZpeCB0aGUgdjggYnVpbGQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk1MQor CisgICAgICAgICogc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTVkdFbGVtZW50SW5zdGFuY2U6OmZvcmdldFdyYXBwZXIpOgorCiAyMDA4LTEwLTI4ICBDYW1l cm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50SW5zdGFuY2UuY3BwIGIvV2ViQ29y ZS9zdmcvU1ZHRWxlbWVudEluc3RhbmNlLmNwcAppbmRleCBlNGY1NmQ4Li5kZjcwMTAyIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50SW5zdGFuY2UuY3BwCisrKyBiL1dlYkNvcmUv c3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5jcHAKQEAgLTMxLDEyICszMSwxNSBAQAogI2luY2x1ZGUg IkV2ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAiRnJh bWVWaWV3LmgiCi0jaW5jbHVkZSAiR0NDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU1ZHRWxlbWVu dEluc3RhbmNlTGlzdC5oIgogI2luY2x1ZGUgIlNWR1VzZUVsZW1lbnQuaCIKIAogI2luY2x1ZGUg PHd0Zi9SZWZDb3VudGVkTGVha0NvdW50ZXIuaD4KIAorI2lmIFVTRShKU0MpCisjaW5jbHVkZSAi R0NDb250cm9sbGVyLmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBu YW1lc3BhY2UgRXZlbnROYW1lczsKQEAgLTkwLDYgKzkzLDcgQEAgdm9pZCBTVkdFbGVtZW50SW5z dGFuY2U6OnNldFNoYWRvd1RyZWVFbGVtZW50KFNWR0VsZW1lbnQqIGVsZW1lbnQpCiAKIHZvaWQg U1ZHRWxlbWVudEluc3RhbmNlOjpmb3JnZXRXcmFwcGVyKCkKIHsKKyNpZiBVU0UoSlNDKQogICAg IC8vIEZJWE1FOiBUaGlzIGlzIGZyYWdpbGUsIGFzIGRpc2N1c3NlZCB3aXRoIFNhbS4gTmVlZCB0 byBmaW5kIGEgYmV0dGVyIHNvbHV0aW9uLgogICAgIC8vIFRoaW5rIGFib3V0IHRoZSBjYXNlIHdo ZXJlIEpTIGV4cGxpY2l0ZWx5IGhvbGRzICJ2YXIgcm9vdCA9IHVzZUVsZW1lbnQuaW5zdGFuY2VS b290OyIuCiAgICAgLy8gV2Ugc3RpbGwgaGF2ZSB0byByZWNyZWF0ZSB0aGlzIHdyYXBwZXIgc29t ZWhvdy4gVGhlIGdjIGNvbGxlY3Rpb24gYmVsb3csIHdvbid0IGNhdGNoIGl0LgpAQCAtOTcsNyAr MTAxLDggQEAgdm9pZCBTVkdFbGVtZW50SW5zdGFuY2U6OmZvcmdldFdyYXBwZXIoKQogICAgIC8v IElmIHRoZSB1c2Ugc2hhZG93IHRyZWUgaGFzIGJlZW4gcmVidWlsdCwganVzdCB0aGUgSlNTVkdF bGVtZW50SW5zdGFuY2Ugb2JqZWN0cwogICAgIC8vIGFyZSBzdGlsbCBob2xkaW5nIFJlZlB0cnMg b2YgU1ZHRWxlbWVudEluc3RhbmNlIG9iamVjdHMsIHdoaWNoIHByZXZlbnQgdXMgdG8KICAgICAv LyBiZSBkZWxldGVkIChhbmQgdGhlIHNoYWRvdyB0cmVlIGlzIG5vdCBkZXN0cnVjdGVkIGFzIHdl bGwpLiBGb3JjZSBKUyBHQy4KLSAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdE5vdygp OyAgICAKKyAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdE5vdygpOworI2VuZGlmCiB9 CiAKIHZvaWQgU1ZHRWxlbWVudEluc3RhbmNlOjphcHBlbmRDaGlsZChQYXNzUmVmUHRyPFNWR0Vs ZW1lbnRJbnN0YW5jZT4gY2hpbGQpCg==