219509 2020-12-03 14:44:21 -0800 [webkitscmpy] Incorrect identifier on remote SVN branches 2020-12-03 15:35:09 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu slewis webkit-bug-importer oldest_to_newest 1711836 0 jbedard 2020-12-03 14:44:21 -0800 When using a remote SVN repository, we are including too many commits in our history. This results in us computing the wrong identifiers for branch commits. 1711837 1 webkit-bug-importer 2020-12-03 14:44:38 -0800 <rdar://problem/71953465> 1711838 2 jbedard 2020-12-03 14:46:31 -0800 Not sure there is much we could do in testing to prevent this, other than having a set of tests that compare the results on an actual checkout with those of an actual remote, which is something we have traditionally tried to avoid. 1711842 3 415352 jbedard 2020-12-03 14:50:27 -0800 Created attachment 415352 Patch 1711846 4 jbedard 2020-12-03 15:03:16 -0800 From a Slack conversation explaining the motivation: The request being modified here was reverse engineered from inspecting packets sent by the svn binary. I had stripped a few pieces out that I thought we didn't need so we had less data being transferred, but it appears I stripped out a piece we did need (that is, the "<S:path></S:path>" bit) 1711850 5 415355 jbedard 2020-12-03 15:08:11 -0800 Created attachment 415355 Patch for landing 1711864 6 ews-feeder 2020-12-03 15:35:08 -0800 Committed r270412: <https://trac.webkit.org/changeset/270412> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415355. 415352 2020-12-03 14:50:27 -0800 2020-12-03 15:08:09 -0800 Patch bug-219509-20201203165027.patch text/plain 2220 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDQwOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTEyLTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIEluY29ycmVjdCBpZGVudGlmaWVyIG9uIHJlbW90 ZSBTVk4gYnJhbmNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxOTUwOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzE5NTM0NjU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogQnVtcCB2ZXJzaW9uLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3JlbW90 ZS9zdm4ucHk6CisgICAgICAgIChTdm4uX2NhY2hlX3JldmlzaW9ucyk6IENsYXJpZnkgdGhhdCBy ZXZpc2lvbnMgc2hvdWxkIG9ubHkgY29tZSBmcm9tIHRoZSBzcGVjaWZpZWQgYnJhbmNoLgorCiAy MDIwLTEyLTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIE1hbnkgZGlmZmVyZW50IGFzc2VydGlvbiBmYWlsdXJlcyBvbiB0aGUgR1BVIHByb2Nlc3Mg Ym90IGFmdGVyIHIyNzAzNjYKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNj bXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv bGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAy NzA0MDcpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21w eS9fX2luaXRfXy5weQkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCBleGNlcHQgSW1w b3J0RXJyb3I6CiAgICAgICAgICJQbGVhc2UgaW5zdGFsbCB3ZWJraXRjb3JlcHkgd2l0aCBgcGlw IGluc3RhbGwgd2Via2l0Y29yZXB5IC0tZXh0cmEtaW5kZXgtdXJsIDxwYWNrYWdlIGluZGV4IFVS TD5gIgogICAgICkKIAotdmVyc2lvbiA9IFZlcnNpb24oMCwgNCwgNCkKK3ZlcnNpb24gPSBWZXJz aW9uKDAsIDQsIDUpCiAKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2RhdGV1dGlsJywg VmVyc2lvbigyLCA4LCAxKSwgcHlwaV9uYW1lPSdweXRob24tZGF0ZXV0aWwnKSkKIEF1dG9JbnN0 YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3JlbW90 ZS9zdm4ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2Nt cHkvd2Via2l0c2NtcHkvcmVtb3RlL3N2bi5weQkocmV2aXNpb24gMjcwNDA3KQorKysgVG9vbHMv U2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcmVtb3RlL3N2bi5weQko d29ya2luZyBjb3B5KQpAQCAtMjI2LDcgKzIyNiw3IEBAIGNsYXNzIFN2bihTY20pOgogICAgICAg ICAgICAgfSwgZGF0YT0nPFM6bG9nLXJlcG9ydCB4bWxuczpTPSJzdm46Ij5cbicKICAgICAgICAg ICAgICAgICAnPFM6c3RhcnQtcmV2aXNpb24+e3JldmlzaW9ufTwvUzpzdGFydC1yZXZpc2lvbj5c bicKICAgICAgICAgICAgICAgICAnPFM6ZW5kLXJldmlzaW9uPjA8L1M6ZW5kLXJldmlzaW9uPlxu JwotICAgICAgICAgICAgICAgICc8UzpyZXZwcm9wPnN2bjpkYXRlPC9TOnJldnByb3A+XG4nCisg ICAgICAgICAgICAgICAgJzxTOnBhdGg+PC9TOnBhdGg+XG4nCiAgICAgICAgICAgICAgICAgJzwv Uzpsb2ctcmVwb3J0PlxuJy5mb3JtYXQocmV2aXNpb249bGF0ZXN0KSwKICAgICAgICAgKSBhcyBy ZXNwb25zZToKICAgICAgICAgICAgIGlmIHJlc3BvbnNlLnN0YXR1c19jb2RlICE9IDIwMDoK 415355 2020-12-03 15:08:11 -0800 2020-12-03 15:35:08 -0800 Patch for landing bug-219509-20201203170810.patch text/plain 2313 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDQwOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTEyLTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIEluY29ycmVjdCBpZGVudGlmaWVyIG9uIHJlbW90 ZSBTVk4gYnJhbmNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxOTUwOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzE5NTM0NjU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgU3RlcGhhbmllIExld2lzLgorCisgICAgICAgIFJlcXVlc3QgcmVjb25z dHJ1Y3RlZCBmcm9tIHBhY2tldCBpbnNwZWN0aW9uIG9mIHJlcXVlc3RzIHNlbnQgYnkgdGhlIHN2 biBiaW5hcnkuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJr aXRzY21weS9fX2luaXRfXy5weTogQnVtcCB2ZXJzaW9uLgorICAgICAgICAqIFNjcmlwdHMvbGli cmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3JlbW90ZS9zdm4ucHk6CisgICAgICAgIChT dm4uX2NhY2hlX3JldmlzaW9ucyk6IENsYXJpZnkgdGhhdCByZXZpc2lvbnMgc2hvdWxkIG9ubHkg Y29tZSBmcm9tIHRoZSBzcGVjaWZpZWQgYnJhbmNoLgorCiAyMDIwLTEyLTAyICBUaW0gSG9ydG9u ICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIE1hbnkgZGlmZmVyZW50IGFz c2VydGlvbiBmYWlsdXJlcyBvbiB0aGUgR1BVIHByb2Nlc3MgYm90IGFmdGVyIHIyNzAzNjYKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5p dF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzA0MDgpCisrKyBUb29scy9TY3Jp cHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weQkod29ya2lu ZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCBleGNlcHQgSW1wb3J0RXJyb3I6CiAgICAgICAgICJQ bGVhc2UgaW5zdGFsbCB3ZWJraXRjb3JlcHkgd2l0aCBgcGlwIGluc3RhbGwgd2Via2l0Y29yZXB5 IC0tZXh0cmEtaW5kZXgtdXJsIDxwYWNrYWdlIGluZGV4IFVSTD5gIgogICAgICkKIAotdmVyc2lv biA9IFZlcnNpb24oMCwgNCwgNCkKK3ZlcnNpb24gPSBWZXJzaW9uKDAsIDQsIDUpCiAKIEF1dG9J bnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2RhdGV1dGlsJywgVmVyc2lvbigyLCA4LCAxKSwgcHlw aV9uYW1lPSdweXRob24tZGF0ZXV0aWwnKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2Uo J2Zhc3RlbmVycycsIFZlcnNpb24oMCwgMTUsIDApKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGli cmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3JlbW90ZS9zdm4ucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcmVtb3Rl L3N2bi5weQkocmV2aXNpb24gMjcwNDA4KQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Vi a2l0c2NtcHkvd2Via2l0c2NtcHkvcmVtb3RlL3N2bi5weQkod29ya2luZyBjb3B5KQpAQCAtMjI2 LDcgKzIyNiw3IEBAIGNsYXNzIFN2bihTY20pOgogICAgICAgICAgICAgfSwgZGF0YT0nPFM6bG9n LXJlcG9ydCB4bWxuczpTPSJzdm46Ij5cbicKICAgICAgICAgICAgICAgICAnPFM6c3RhcnQtcmV2 aXNpb24+e3JldmlzaW9ufTwvUzpzdGFydC1yZXZpc2lvbj5cbicKICAgICAgICAgICAgICAgICAn PFM6ZW5kLXJldmlzaW9uPjA8L1M6ZW5kLXJldmlzaW9uPlxuJwotICAgICAgICAgICAgICAgICc8 UzpyZXZwcm9wPnN2bjpkYXRlPC9TOnJldnByb3A+XG4nCisgICAgICAgICAgICAgICAgJzxTOnBh dGg+PC9TOnBhdGg+XG4nCiAgICAgICAgICAgICAgICAgJzwvUzpsb2ctcmVwb3J0PlxuJy5mb3Jt YXQocmV2aXNpb249bGF0ZXN0KSwKICAgICAgICAgKSBhcyByZXNwb25zZToKICAgICAgICAgICAg IGlmIHJlc3BvbnNlLnN0YXR1c19jb2RlICE9IDIwMDoK