219502 2020-12-03 12:06:43 -0800 [JSC] not using std::make_pair for workaround of (possibly) ASan bug 2020-12-06 11:05:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ap ddkilzer ews-watchlist keith_miller mark.lam msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1711751 0 ysuzuki 2020-12-03 12:06:43 -0800 [JSC] not using std::make_pair for workaround of (possibly) ASan bug 1711753 1 415320 ysuzuki 2020-12-03 12:09:47 -0800 Created attachment 415320 Patch 1711755 2 415320 rmorisset 2020-12-03 12:12:01 -0800 Comment on attachment 415320 Patch r=me 1711758 3 mark.lam 2020-12-03 12:20:41 -0800 r=me too 1711759 4 ysuzuki 2020-12-03 12:24:33 -0800 <rdar://problem/71642789> 1711855 5 ysuzuki 2020-12-03 15:17:20 -0800 imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-in-worker-transfer.html is flaky test. 1711856 6 ews-feeder 2020-12-03 15:20:39 -0800 Committed r270411: <https://trac.webkit.org/changeset/270411> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415320. 1712337 7 415320 ap 2020-12-06 11:05:26 -0800 Comment on attachment 415320 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415320&action=review > Source/JavaScriptCore/ChangeLog:10 > + However, this is inside std::make_pair, and it looks like a bug in ASan. This would be quite unusual. Are you planning to file a bug to investigate the root cause? 415320 2020-12-03 12:09:47 -0800 2020-12-03 15:20:40 -0800 Patch bug-219502-20201203120946.patch text/plain 6331 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 Y2JkNjViZTUxY2Q3ZjVjN2I4MWEzYjQwZmMwODY4NjZlMzY1Y2JhLi4yYmJmY2EwM2E1NmZmNTRh NDkwYmExMWJhMjNkZGZjNWE2ZmQzZGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0xMi0wMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIG5vdCB1c2luZyBzdGQ6Om1ha2VfcGFpciBmb3Igd29ya2Fyb3Vu ZCBvZiAocG9zc2libHkpIEFTYW4gYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTk1MDIKKyAgICAgICAgPHJkYXI6Ly83MTY0Mjc4OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgZ2V0dGlu ZyBBU2FuIGNyYXNoIGluIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2FycmF5LXVuaXQt dGVzdHMuaHRtbCBhZnRlciByMjY5NTc0LgorICAgICAgICBIb3dldmVyLCB0aGlzIGlzIGluc2lk ZSBzdGQ6Om1ha2VfcGFpciwgYW5kIGl0IGxvb2tzIGxpa2UgYSBidWcgaW4gQVNhbi4KKyAgICAg ICAgVG8gd29ya2Fyb3VuZCB0aGlzIGZvciBub3csIHdlIGF2b2lkIHVzaW5nIHN0ZDo6bWFrZV9w YWlyIGFuZCBpbnN0ZWFkIGp1c3QgdXNpbmcgQysrIHVuaWZvcm0gaW5pdGlhbGl6YXRpb24uCisK KyAgICAgICAgKiBydW50aW1lL0pTQXJyYXlCdWZmZXJQcm90b3R5cGUuY3BwOgorCiAyMDIwLTEy LTAzICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXVEZdIEF2 b2lkIEpTT05WYWx1ZTo6Y3JlYXRlIHdpdGggcmF3IHN0cmluZyBmYWxsaW5nIHRvIGJvb2wgb3Zl cmxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXlC dWZmZXJQcm90b3R5cGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJh eUJ1ZmZlclByb3RvdHlwZS5jcHAKaW5kZXggMDViMzQzYmY2ZTNlOTgyYmVlNDNlOGRlZDZlYWQ1 MjRjYWMzMGE2Mi4uMzM0YWQ3N2JmZTIwM2JiNTA3MWVlNWJhMGYwY2JjMGYwOTRlYjA3MyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheUJ1ZmZlclByb3Rv dHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheUJ1ZmZl clByb3RvdHlwZS5jcHAKQEAgLTY5LDg0ICs2OSw4MiBAQCBzdGF0aWMgQUxXQVlTX0lOTElORSBz dGQ6OnBhaXI8U3BlY2llc0NvbnN0cnVjdFJlc3VsdCwgSlNBcnJheUJ1ZmZlcio+IHNwZWNpZXND bwogICAgIC8vIGh0dHBzOi8vdGMzOS5lcy9lY21hMjYyLyNzZWMtc2hhcmVkYXJyYXlidWZmZXIu cHJvdG90eXBlLnNsaWNlCiAgICAgVk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOwogICAgIGF1 dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKLQotICAgIGF1dG8gZXhjZXB0aW9u UmVzdWx0ID0gW10gKCkgewotICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0Nv bnN0cnVjdFJlc3VsdDo6RXhjZXB0aW9uLCBudWxscHRyKTsKLSAgICB9OworICAgIGNvbnN0ZXhw ciBzdGQ6OnBhaXI8U3BlY2llc0NvbnN0cnVjdFJlc3VsdCwgSlNBcnJheUJ1ZmZlcio+IGVycm9y UmVzdWx0IHsgU3BlY2llc0NvbnN0cnVjdFJlc3VsdDo6RXhjZXB0aW9uLCBudWxscHRyIH07Cisg ICAgY29uc3RleHByIHN0ZDo6cGFpcjxTcGVjaWVzQ29uc3RydWN0UmVzdWx0LCBKU0FycmF5QnVm ZmVyKj4gZmFzdFBhdGhSZXN1bHQgeyBTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpGYXN0UGF0aCwg bnVsbHB0ciB9OwogCiAgICAgLy8gRmFzdCBwYXRoIGluIHRoZSBub3JtYWwgY2FzZSB3aGVyZSB0 aGUgdXNlciBoYXMgbm90IHNldCBhbiBvd24gY29uc3RydWN0b3IgYW5kIHRoZSBBcnJheUJ1ZmZl ci5wcm90b3R5cGUuY29uc3RydWN0b3IgaXMgbm9ybWFsLgogICAgIC8vIFdlIG5lZWQgcHJvdG90 eXBlIGNoZWNrIGZvciBzdWJjbGFzc2VzIG9mIEFycmF5QnVmZmVyLCB3aGljaCBhcmUgQXJyYXlC dWZmZXIgb2JqZWN0cyBidXQgaGF2ZSBhIGRpZmZlcmVudCBwcm90b3R5cGUgYnkgZGVmYXVsdC4K ICAgICBib29sIGlzVmFsaWQgPSBzcGVjaWVzV2F0Y2hwb2ludElzVmFsaWQodm0sIHRoaXNPYmpl Y3QsIG1vZGUpOwogICAgIHNjb3BlLmFzc2VydE5vRXhjZXB0aW9uKCk7CiAgICAgaWYgKExJS0VM WShpc1ZhbGlkKSkKLSAgICAgICAgcmV0dXJuIHN0ZDo6bWFrZV9wYWlyKFNwZWNpZXNDb25zdHJ1 Y3RSZXN1bHQ6OkZhc3RQYXRoLCBudWxscHRyKTsKKyAgICAgICAgcmV0dXJuIGZhc3RQYXRoUmVz dWx0OwogCiAgICAgSlNWYWx1ZSBjb25zdHJ1Y3RvciA9IHRoaXNPYmplY3QtPmdldChnbG9iYWxP YmplY3QsIHZtLnByb3BlcnR5TmFtZXMtPmNvbnN0cnVjdG9yKTsKLSAgICBSRVRVUk5fSUZfRVhD RVBUSU9OKHNjb3BlLCBleGNlcHRpb25SZXN1bHQoKSk7CisgICAgUkVUVVJOX0lGX0VYQ0VQVElP TihzY29wZSwgZXJyb3JSZXN1bHQpOwogICAgIGlmIChjb25zdHJ1Y3Rvci5pc0NvbnN0cnVjdG9y KHZtKSkgewogICAgICAgICBKU09iamVjdCogY29uc3RydWN0b3JPYmplY3QgPSBqc0Nhc3Q8SlNP YmplY3QqPihjb25zdHJ1Y3Rvcik7CiAgICAgICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmpl Y3RGcm9tQ29uc3RydWN0b3IgPSBjb25zdHJ1Y3Rvck9iamVjdC0+Z2xvYmFsT2JqZWN0KHZtKTsK ICAgICAgICAgYm9vbCBpc0FycmF5QnVmZmVyQ29uc3RydWN0b3JGcm9tQW5vdGhlclJlYWxtID0g Z2xvYmFsT2JqZWN0ICE9IGdsb2JhbE9iamVjdEZyb21Db25zdHJ1Y3RvcgogICAgICAgICAgICAg JiYgY29uc3RydWN0b3JPYmplY3QgPT0gZ2xvYmFsT2JqZWN0RnJvbUNvbnN0cnVjdG9yLT5hcnJh eUJ1ZmZlckNvbnN0cnVjdG9yKG1vZGUpOwogICAgICAgICBpZiAoaXNBcnJheUJ1ZmZlckNvbnN0 cnVjdG9yRnJvbUFub3RoZXJSZWFsbSkKLSAgICAgICAgICAgIHJldHVybiBzdGQ6Om1ha2VfcGFp cihTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpGYXN0UGF0aCwgbnVsbHB0cik7CisgICAgICAgICAg ICByZXR1cm4gZmFzdFBhdGhSZXN1bHQ7CiAgICAgfQogICAgIGlmIChjb25zdHJ1Y3Rvci5pc09i amVjdCgpKSB7CiAgICAgICAgIGNvbnN0cnVjdG9yID0gY29uc3RydWN0b3IuZ2V0KGdsb2JhbE9i amVjdCwgdm0ucHJvcGVydHlOYW1lcy0+c3BlY2llc1N5bWJvbCk7Ci0gICAgICAgIFJFVFVSTl9J Rl9FWENFUFRJT04oc2NvcGUsIGV4Y2VwdGlvblJlc3VsdCgpKTsKKyAgICAgICAgUkVUVVJOX0lG X0VYQ0VQVElPTihzY29wZSwgZXJyb3JSZXN1bHQpOwogICAgICAgICBpZiAoY29uc3RydWN0b3Iu aXNOdWxsKCkpCi0gICAgICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0NvbnN0 cnVjdFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOworICAgICAgICAgICAgcmV0dXJuIGZhc3RQ YXRoUmVzdWx0OwogICAgIH0KIAogICAgIGlmIChjb25zdHJ1Y3Rvci5pc1VuZGVmaW5lZCgpKQot ICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0NvbnN0cnVjdFJlc3VsdDo6RmFz dFBhdGgsIG51bGxwdHIpOworICAgICAgICByZXR1cm4gZmFzdFBhdGhSZXN1bHQ7CiAKICAgICAv LyAxNi4gTGV0IG5ldyBiZSA/IENvbnN0cnVjdChjdG9yLCDCqyDwnZS9KG5ld0xlbikgwrspLgog ICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyIGFyZ3M7CiAgICAgYXJncy5hcHBlbmQoanNOdW1iZXIo bGVuZ3RoKSk7CiAgICAgQVNTRVJUKCFhcmdzLmhhc092ZXJmbG93ZWQoKSk7CiAgICAgSlNPYmpl Y3QqIG5ld09iamVjdCA9IGNvbnN0cnVjdChnbG9iYWxPYmplY3QsIGNvbnN0cnVjdG9yLCBhcmdz LCAiU3BlY2llcyBjb25zdHJ1Y3Rpb24gZGlkIG5vdCBnZXQgYSB2YWxpZCBjb25zdHJ1Y3RvciIp OwotICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGV4Y2VwdGlvblJlc3VsdCgpKTsKKyAg ICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlcnJvclJlc3VsdCk7CiAKICAgICAvLyAxNy4g UGVyZm9ybSA/IFJlcXVpcmVJbnRlcm5hbFNsb3QobmV3LCBbW0FycmF5QnVmZmVyRGF0YV1dKS4K ICAgICBKU0FycmF5QnVmZmVyKiByZXN1bHQgPSBqc0R5bmFtaWNDYXN0PEpTQXJyYXlCdWZmZXIq Pih2bSwgbmV3T2JqZWN0KTsKICAgICBpZiAoVU5MSUtFTFkoIXJlc3VsdCkpIHsKICAgICAgICAg dGhyb3dUeXBlRXJyb3IoZ2xvYmFsT2JqZWN0LCBzY29wZSwgIlNwZWNpZXMgY29uc3RydWN0aW9u IGRvZXMgbm90IGNyZWF0ZSBBcnJheUJ1ZmZlciJfcyk7Ci0gICAgICAgIHJldHVybiBleGNlcHRp b25SZXN1bHQoKTsKKyAgICAgICAgcmV0dXJuIGVycm9yUmVzdWx0OwogICAgIH0KIAogICAgIGlm IChtb2RlID09IEFycmF5QnVmZmVyU2hhcmluZ01vZGU6OkRlZmF1bHQpIHsKICAgICAgICAgLy8g MTguIElmIElzU2hhcmVkQXJyYXlCdWZmZXIobmV3KSBpcyB0cnVlLCB0aHJvdyBhIFR5cGVFcnJv ciBleGNlcHRpb24uCiAgICAgICAgIGlmIChyZXN1bHQtPmlzU2hhcmVkKCkpIHsKICAgICAgICAg ICAgIHRocm93VHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2NvcGUsICJBcnJheUJ1ZmZlci5wcm90 b3R5cGUuc2xpY2UgY3JlYXRlcyBTaGFyZWRBcnJheUJ1ZmZlciJfcyk7Ci0gICAgICAgICAgICBy ZXR1cm4gZXhjZXB0aW9uUmVzdWx0KCk7CisgICAgICAgICAgICByZXR1cm4gZXJyb3JSZXN1bHQ7 CiAgICAgICAgIH0KICAgICAgICAgLy8gMTkuIElmIElzRGV0YWNoZWRCdWZmZXIobmV3KSBpcyB0 cnVlLCB0aHJvdyBhIFR5cGVFcnJvciBleGNlcHRpb24uCiAgICAgICAgIGlmIChyZXN1bHQtPmlt cGwoKS0+aXNEZXRhY2hlZCgpKSB7CiAgICAgICAgICAgICB0aHJvd1ZNVHlwZUVycm9yKGdsb2Jh bE9iamVjdCwgc2NvcGUsICJDcmVhdGVkIEFycmF5QnVmZmVyIGlzIGRldGFjaGVkIl9zKTsKLSAg ICAgICAgICAgIHJldHVybiBleGNlcHRpb25SZXN1bHQoKTsKKyAgICAgICAgICAgIHJldHVybiBl cnJvclJlc3VsdDsKICAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIDE3LiBJZiBJ c1NoYXJlZEFycmF5QnVmZmVyKG5ldykgaXMgZmFsc2UsIHRocm93IGEgVHlwZUVycm9yIGV4Y2Vw dGlvbi4KICAgICAgICAgaWYgKCFyZXN1bHQtPmlzU2hhcmVkKCkpIHsKICAgICAgICAgICAgIHRo cm93VHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2NvcGUsICJTaGFyZWRBcnJheUJ1ZmZlci5wcm90 b3R5cGUuc2xpY2UgY3JlYXRlcyBub24tc2hhcmVkIEFycmF5QnVmZmVyIl9zKTsKLSAgICAgICAg ICAgIHJldHVybiBleGNlcHRpb25SZXN1bHQoKTsKKyAgICAgICAgICAgIHJldHVybiBlcnJvclJl c3VsdDsKICAgICAgICAgfQogICAgIH0KIAogICAgIC8vIDIwLiBJZiBTYW1lVmFsdWUobmV3LCBP KSBpcyB0cnVlLCB0aHJvdyBhIFR5cGVFcnJvciBleGNlcHRpb24uCiAgICAgaWYgKHJlc3VsdCA9 PSB0aGlzT2JqZWN0KSB7CiAgICAgICAgIHRocm93Vk1UeXBlRXJyb3IoZ2xvYmFsT2JqZWN0LCBz Y29wZSwgIlNwZWNpZXMgY29uc3RydWN0aW9uIHJldHVybnMgc2FtZSBBcnJheUJ1ZmZlciB0byBh IHJlY2VpdmVyIl9zKTsKLSAgICAgICAgcmV0dXJuIGV4Y2VwdGlvblJlc3VsdCgpOworICAgICAg ICByZXR1cm4gZXJyb3JSZXN1bHQ7CiAgICAgfQogCiAgICAgLy8gMjEuIElmIG5ldy5bW0FycmF5 QnVmZmVyQnl0ZUxlbmd0aF1dIDwgbmV3TGVuLCB0aHJvdyBhIFR5cGVFcnJvciBleGNlcHRpb24u CiAgICAgaWYgKHJlc3VsdC0+aW1wbCgpLT5ieXRlTGVuZ3RoKCkgPCBsZW5ndGgpIHsKICAgICAg ICAgdGhyb3dWTVR5cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCAiU3BlY2llcyBjb25zdHJ1 Y3Rpb24gcmV0dXJucyBBcnJheUJ1ZmZlciB3aGljaCBieXRlTGVuZ3RoIGlzIGxlc3MgdGhhbiBy ZXF1ZXN0ZWQiX3MpOwotICAgICAgICByZXR1cm4gZXhjZXB0aW9uUmVzdWx0KCk7CisgICAgICAg IHJldHVybiBlcnJvclJlc3VsdDsKICAgICB9CiAKLSAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIo U3BlY2llc0NvbnN0cnVjdFJlc3VsdDo6Q3JlYXRlZE9iamVjdCwgcmVzdWx0KTsKKyAgICByZXR1 cm4geyBTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpDcmVhdGVkT2JqZWN0LCByZXN1bHQgfTsKIH0K IAogCg==