21949 2008-10-29 11:35:24 -0700 No need to clobber all ResourceRequest fields in FrameLoader::reload() 2008-11-04 11:41:18 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd webkit-unassigned oldest_to_newest 97009 0 fishd 2008-10-29 11:35:24 -0700 No need to clobber all ResourceRequest fields in FrameLoader::reload() Presently, FrameLoader::reload clobbers all fields of the initialRequest when there is an unreachableURL associated with the current DocumentLoader. This causes problems for the Chromium port since we store some extra data on the ResourceRequest object that we need to have preserved across a FrameLoader::reload call. FrameLoader::reloadAllowingStaleData is careful to only call setURL when there is an unreachableURL, and I think that FrameLoader::reload should do the same. I suspect that it was not intentional to make FrameLoader::reload behave differently in this respect. Please see the attached patch for further details. 97010 1 24751 fishd 2008-10-29 11:39:57 -0700 Created attachment 24751 v1 patch 97011 2 fishd 2008-10-29 11:42:06 -0700 To clarify, this causes problems for us because the HTTP method is forced to be GET. If the previous request was something else, then that information is lost. I guess this doesn't cause a problem for Safari, but it still seems like an error to me. 97153 3 24751 fishd 2008-10-30 13:00:59 -0700 Comment on attachment 24751 v1 patch Anders, can you please take a look at this patch? Thanks! 97573 4 24751 andersca 2008-11-04 09:25:15 -0800 Comment on attachment 24751 v1 patch Looks good, I can't think of a reason why it would break things (but I've been wrong before ;) r=me! 97600 5 fishd 2008-11-04 11:41:18 -0800 http://trac.webkit.org/changeset/38107 24751 2008-10-29 11:39:57 -0700 2008-11-04 09:25:15 -0800 v1 patch frame_loader_1.diff text/plain 1747 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3OTcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTAt MjkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZWVkIHRvIGNsb2JiZXIgYWxsIFJl c291cmNlUmVxdWVzdCBmaWVsZHMgaW4gRnJhbWVMb2FkZXI6OnJlbG9hZCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk0OQorCisgICAgICAgICog bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpy ZWxvYWQpOgorCiAyMDA4LTEwLTI5ICBCcmV0dCBXaWxzb24gIDxicmV0dHdAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyCkluZGV4OiBsb2FkZXIvRnJhbWVM b2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIGxvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9u IDM3OTczKQorKysgbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQz OCwxNyArMjQzOCwxNyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpyZWxvYWQoKQogICAgIGlmICghbV9k b2N1bWVudExvYWRlcikKICAgICAgICAgcmV0dXJuOwogCi0gICAgUmVzb3VyY2VSZXF1ZXN0JiBp bml0aWFsUmVxdWVzdCA9IG1fZG9jdW1lbnRMb2FkZXItPnJlcXVlc3QoKTsKLSAgICAKICAgICAv LyBJZiBhIHdpbmRvdyBpcyBjcmVhdGVkIGJ5IGphdmFzY3JpcHQsIGl0cyBtYWluIGZyYW1lIGNh biBoYXZlIGFuIGVtcHR5IGJ1dCBub24tbmlsIFVSTC4KICAgICAvLyBSZWxvYWRpbmcgaW4gdGhp cyBjYXNlIHdpbGwgbG9zZSB0aGUgY3VycmVudCBjb250ZW50cyAoc2VlIDQxNTEwMDEpLgotICAg IGlmIChpbml0aWFsUmVxdWVzdC51cmwoKS5pc0VtcHR5KCkpCisgICAgaWYgKG1fZG9jdW1lbnRM b2FkZXItPnJlcXVlc3QoKS51cmwoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAorICAg IFJlc291cmNlUmVxdWVzdCBpbml0aWFsUmVxdWVzdCA9IG1fZG9jdW1lbnRMb2FkZXItPnJlcXVl c3QoKTsKKwogICAgIC8vIFJlcGxhY2UgZXJyb3ItcGFnZSBVUkwgd2l0aCB0aGUgVVJMIHdlIHdl cmUgdHJ5aW5nIHRvIHJlYWNoLgogICAgIEtVUkwgdW5yZWFjaGFibGVVUkwgPSBtX2RvY3VtZW50 TG9hZGVyLT51bnJlYWNoYWJsZVVSTCgpOwogICAgIGlmICghdW5yZWFjaGFibGVVUkwuaXNFbXB0 eSgpKQotICAgICAgICBpbml0aWFsUmVxdWVzdCA9IFJlc291cmNlUmVxdWVzdCh1bnJlYWNoYWJs ZVVSTCk7CisgICAgICAgIGluaXRpYWxSZXF1ZXN0LnNldFVSTCh1bnJlYWNoYWJsZVVSTCk7CiAg ICAgCiAgICAgLy8gQ3JlYXRlIGEgbmV3IGRvY3VtZW50IGxvYWRlciBmb3IgdGhlIHJlbG9hZCwg dGhpcyB3aWxsIGJlY29tZSBtX2RvY3VtZW50TG9hZGVyIGV2ZW50dWFsbHksCiAgICAgLy8gYnV0 IGZpcnN0IGl0IGhhcyB0byBiZSB0aGUgInBvbGljeSIgZG9jdW1lbnQgbG9hZGVyLCBhbmQgdGhl biB0aGUgInByb3Zpc2lvbmFsIiBkb2N1bWVudCBsb2FkZXIuCg==