219483 2020-12-02 22:03:40 -0800 [WTF] Avoid JSONValue::create with raw string falling to bool overload 2020-12-03 02:31:41 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218686 InRadar P2 Normal --- 1 lmoura lmoura aperez bburg benjamin bugs-noreply cdumez cmarcelo ews-watchlist hi joepeck keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1711609 0 lmoura 2020-12-02 22:03:40 -0800 [WTF] Avoid JSONValue::create with raw string falling to bool overload 1711611 1 415278 lmoura 2020-12-02 22:05:11 -0800 Created attachment 415278 Patch 1711612 2 415278 lmoura 2020-12-02 22:22:26 -0800 Comment on attachment 415278 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415278&action=review > Source/WTF/wtf/JSONValues.h:81 > + static Ref<Value> create(T) = delete; If `create(T)` is too strict, it could use `create(T*)` instead, to avoid only the pointer conversions. 1711635 3 415278 aperez 2020-12-03 02:09:38 -0800 Comment on attachment 415278 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415278&action=review >> Source/WTF/wtf/JSONValues.h:81 >> + static Ref<Value> create(T) = delete; > > If `create(T)` is too strict, it could use `create(T*)` instead, to avoid only the pointer conversions. I think this is fine, and forbidding all possible implicit conversions is probably even a good thing, thus ensuring that only the provided create() factory functions are ever used. 1711639 4 ews-feeder 2020-12-03 02:30:42 -0800 Committed r270391: <https://trac.webkit.org/changeset/270391> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415278. 1711640 5 webkit-bug-importer 2020-12-03 02:31:41 -0800 <rdar://problem/71930497> 415278 2020-12-02 22:05:11 -0800 2020-12-03 02:30:43 -0800 Patch bug-219483-20201203030509.patch text/plain 6931 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NDU0MGRkNjhiMTVhMjVmNWUxOTEyMjIwNWY1NzQ3OTA4NTRmMTczLi43Y2JjODNjMWNlYmRhYjdk MmU2NWYyZGZmZWRjMzM1NjllZTU5NWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMC0xMi0wMiAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1RGXSBBdm9pZCBKU09OVmFsdWU6OmNyZWF0ZSB3aXRoIHJhdyBzdHJpbmcg ZmFsbGluZyB0byBib29sIG92ZXJsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTk0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwOgorICAg ICAgICAoSW5zcGVjdG9yOjpJbmplY3RlZFNjcmlwdEJhc2U6Om1ha2VBc3luY0NhbGwpOiBDb252 ZXJ0IHRvIFdURjo6U3RyaW5nIHdoZW4gY3JlYXRpbmcgdGhlIHZhbHVlLgorCiAyMDIwLTEyLTAy ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgogCiAgICAgICAgIGFh cmNoNjQgbGxpbnQgZG9lcyBub3QgYnVpbGQgd2l0aCBKSVQgZGlzYWJsZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggN2U5NGVi ZjVkY2Q3ZDM2NmI2ZmQ4YjdiMDBiYmYyNjc1OTA4NjgxYi4uZTgwOGZhZDY4ZTU0ZDJkMWU0ZGM2 MjkyOWNjYmE2MDVjMjI4ZWJjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMC0xMi0wMiAgTGF1 cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1RGXSBBdm9pZCBKU09O VmFsdWU6OmNyZWF0ZSB3aXRoIHJhdyBzdHJpbmcgZmFsbGluZyB0byBib29sIG92ZXJsb2FkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk0ODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjY5NzU3IHJl bW92ZWQgdGhlIGNvbnN0IGNoYXIqIG92ZXJsb2FkIGZvciBWYWx1ZTo6Y3JlYXRlKCkgYW5kIHJl cGxhY2VkCisgICAgICAgIHRoZW0gd2l0aCBtYWtlU3RyaW5nKCkgdmVyc2lvbnMuIFdoaWxlIHRo aXMgd29ya2VkIG1vc3Qgb2YgdGhlIHRpbWUsIG9uZQorICAgICAgICBjb3VsZCBzdGlsbCBjYWxs IFZhbHVlOjpjcmVhdGUocmF3X3N0cmluZykgYW5kIGl0IHdvdWxkIGVuZCB1cCBjYWxsaW5nIHRo ZQorICAgICAgICBib29sIG92ZXJsb2FkLiBUaGlzIGNvdWxkIGNhdXNlIHNpZGUgZWZmZWN0cyBs aWtlIG1ha2luZyBhIG51bWJlciBvZgorICAgICAgICBXZWJEcml2ZXIgdGVzdHMgdG8gZmFpbCB3 aXRoIHdyb25nIHR5cGVzIGluIHRoZSBleGVjdXRlZCBqYXZhc2NyaXB0IGNvZGUuCisKKyAgICAg ICAgVG8gYXZvaWQgdGhlc2UgYWNjaWRlbnRhbCBjb252ZXJzaW9ucywgdGhpcyBjb21taXQgYWRk ZWQgYW4gb3ZlcmxvYWQgdG8KKyAgICAgICAgZGVsZXRlIGFsbCBpbXBsaWNpdCBjb252ZXJzaW9u cyBvZiBWYWx1ZTo6Y3JlYXRlKCkuCisKKyAgICAgICAgKiB3dGYvSlNPTlZhbHVlcy5oOiBEZWxl dGUgaW1wbGljaXQgb3ZlcmxvYWRzIGZvciBWYWx1ZTo6Y3JlYXRlKFQpLgorCiAyMDIwLTEyLTAy ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgogCiAgICAgICAgIGFh cmNoNjQgbGxpbnQgZG9lcyBub3QgYnVpbGQgd2l0aCBKSVQgZGlzYWJsZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBjYjQ3NmMyNDJlMWI1MWIyMzBmZmYyNDFiNDU5ZTIwMzQ5MDQ4ODQ1Li4yMTM5ZmZlZTZmNTI5 ZjliOWZhMmEzMzc3OWQxNzgzMjRlMTVjMjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMjAtMTItMDIgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAg W1dURl0gQXZvaWQgSlNPTlZhbHVlOjpjcmVhdGUgd2l0aCByYXcgc3RyaW5nIGZhbGxpbmcgdG8g Ym9vbCBvdmVybG9hZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE5NDgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JGcm9udGVuZENsaWVudExvY2FsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3Bl Y3RvckZyb250ZW5kQ2xpZW50TG9jYWw6OnNldEF0dGFjaGVkV2luZG93KTogQ29udmVydCB0byBX VEY6OlN0cmluZyB3aGVuIGNyZWF0aW5nIHRoZSB2YWx1ZS4KKwogMjAyMC0xMi0wMiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIGlmcmFtZSB3aXRoIGBzYW5kYm94 PWFsbG93LXRvcC1uYXZpZ2F0aW9uLWJ5LXVzZXItYWN0aXZhdGlvbmAgY2FuIG5hdmlnYXRlIHRv cCBmcmFtZSB3aGVuIHRoZSB1c2VyIGludGVyYWN0cyB3aXRoIGFuIGlmcmFtZSBmcm9tIGFub3Ro ZXIgb3JpZ2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IDI2MjNjZTk1YmYyNjIyMjkxNDIxNTRjZDA1Mjlh MTA0YWU5ODU4YzEuLmI2YmI0NGQyNjUxYzNkZTI0YWUzZTYxZmFiYmE4ODkwZWU2NDRmNzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJEcml2 ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMTItMDIgIExhdXJvIE1vdXJhICA8 bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dURl0gQXZvaWQgSlNPTlZhbHVlOjpjcmVh dGUgd2l0aCByYXcgc3RyaW5nIGZhbGxpbmcgdG8gYm9vbCBvdmVybG9hZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NDgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgYWNjaWRlbnRhbCBjb252 ZXJzaW9uIG9mICJzZWxlY3RlZCIgdG8gYm9vbCB0aGF0IHdvdWxkIG1ha2UgdGhlCisgICAgICAg IGdldEVsZW1lbnRBdHRyaWJ1dGUgamF2YXNjcmlwdGNvZGUgdG8gZmFpbCB3aXRoICJhdHRyaWJ1 dGVOYW1lLnRvTG93ZXJDYXNlCisgICAgICAgIGlzIHVuZGVmaW5lZCIKKworICAgICAgICAqIFNl c3Npb24uY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpTZXNzaW9uOjppc0VsZW1lbnRTZWxlY3Rl ZCk6IENvbnZlcnQgdG8gV1RGOjpTdHJpbmcgd2hlbiBjcmVhdGluZyB0aGUgdmFsdWUuCisKIDIw MjAtMTEtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFdlYkRyaXZlcjogc2Vzc2lvbiBjYW4gaGF2ZSBtb3JlIHRoYW4gb25lIGFjdGl2ZSBp bnB1dCBzb3VyY2Ugb2YgdGhlIHNhbWUgdHlwZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwCmluZGV4IDA5MDE2NmE5MWZj NjZhZDFjZGU3MTgxOTUzY2Y0NzczZmY2NmYwOGYuLjE1YjAxNmZjZGI1MDJkZWQxMzNlNTA3ZjEz MDNjMzc0NGU2N2U4MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKQEAgLTEyMSw3ICsxMjEsNyBAQCB2b2lkIElu amVjdGVkU2NyaXB0QmFzZTo6bWFrZUFzeW5jQ2FsbChEZXByZWNhdGVkOjpTY3JpcHRGdW5jdGlv bkNhbGwmIGZ1bmN0aW9uLAogCiAgICAgICAgIGpzRnVuY3Rpb24gPSBKU0M6OkpTTmF0aXZlU3Rk RnVuY3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0LCAxLCBTdHJpbmcoKSwgWyYsIGNhbGxi YWNrID0gV1RGTW92ZShjYWxsYmFjayldIChKU0M6OkpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmpl Y3QsIEpTQzo6Q2FsbEZyYW1lKiBjYWxsRnJhbWUpIHsKICAgICAgICAgICAgIGlmICghY2FsbEZy YW1lKQotICAgICAgICAgICAgICAgIGNoZWNrQXN5bmNDYWxsUmVzdWx0KEpTT046OlZhbHVlOjpj cmVhdGUoIkV4Y2VwdGlvbiB3aGlsZSBtYWtpbmcgYSBjYWxsLiIpLCBjYWxsYmFjayk7CisgICAg ICAgICAgICAgICAgY2hlY2tBc3luY0NhbGxSZXN1bHQoSlNPTjo6VmFsdWU6OmNyZWF0ZShtYWtl U3RyaW5nKCJFeGNlcHRpb24gd2hpbGUgbWFraW5nIGEgY2FsbC4iX3MpKSwgY2FsbGJhY2spOwog ICAgICAgICAgICAgZWxzZSBpZiAoYXV0byByZXN1bHRKU09OVmFsdWUgPSB0b0luc3BlY3RvclZh bHVlKGdsb2JhbE9iamVjdCwgY2FsbEZyYW1lLT5hcmd1bWVudCgwKSkpCiAgICAgICAgICAgICAg ICAgY2hlY2tBc3luY0NhbGxSZXN1bHQocmVzdWx0SlNPTlZhbHVlLCBjYWxsYmFjayk7CiAgICAg ICAgICAgICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9KU09OVmFsdWVzLmggYi9T b3VyY2UvV1RGL3d0Zi9KU09OVmFsdWVzLmgKaW5kZXggNGE3ZjE1MmFkYjRmNDU0YTZkYmI0NTdm M2ZkZTRkY2M3MjE4ODVmMy4uYmUzM2JlODJiYThkZDA1ZGVlNTUwZWMxMDk2OTczN2Y5ZjQ4ZTdi ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvSlNPTlZhbHVlcy5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL0pTT05WYWx1ZXMuaApAQCAtNzcsNiArNzcsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGlj IFJlZjxWYWx1ZT4gY3JlYXRlKGludCk7CiAgICAgc3RhdGljIFJlZjxWYWx1ZT4gY3JlYXRlKGRv dWJsZSk7CiAgICAgc3RhdGljIFJlZjxWYWx1ZT4gY3JlYXRlKGNvbnN0IFN0cmluZyYpOworICAg IHRlbXBsYXRlPGNsYXNzIFQ+CisgICAgc3RhdGljIFJlZjxWYWx1ZT4gY3JlYXRlKFQpID0gZGVs ZXRlOwogCiAgICAgZW51bSBjbGFzcyBUeXBlIHsKICAgICAgICAgTnVsbCA9IDAsCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2Nh bC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRM b2NhbC5jcHAKaW5kZXggNDdiY2RmNzVkNWY1Nzg3Mzc2MzU0NWEzNzA5YTNmNzUwZDJiZjg2Yi4u NTA3MWVmZTg2MTdhMWI0ZDFlMDJiYjE0NzllOWZlNTY2OGVmNWNmNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kQ2xpZW50TG9jYWwuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZENsaWVudExvY2Fs LmNwcApAQCAtMzA4LDcgKzMwOCw3IEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2Nh bDo6c2V0QXR0YWNoZWRXaW5kb3coRG9ja1NpZGUgZG9ja1NpZGUpCiAKICAgICBtX2RvY2tTaWRl ID0gZG9ja1NpZGU7CiAKLSAgICBtX2Zyb250ZW5kQVBJRGlzcGF0Y2hlci0+ZGlzcGF0Y2hDb21t YW5kV2l0aFJlc3VsdEFzeW5jKCJzZXREb2NrU2lkZSJfcywgeyBKU09OOjpWYWx1ZTo6Y3JlYXRl KHNpZGUpIH0pOworICAgIG1fZnJvbnRlbmRBUElEaXNwYXRjaGVyLT5kaXNwYXRjaENvbW1hbmRX aXRoUmVzdWx0QXN5bmMoInNldERvY2tTaWRlIl9zLCB7IEpTT046OlZhbHVlOjpjcmVhdGUobWFr ZVN0cmluZyhzaWRlKSkgfSk7CiB9CiAKIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2Nh bDo6cmVzdG9yZUF0dGFjaGVkV2luZG93SGVpZ2h0KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJE cml2ZXIvU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Npb24uY3BwCmluZGV4IGE2 ZmI0OGQ3ZTQ4NGIwMGU4NDFjYjA5Y2ZhNmQxNzkxZjMyZWIyYzYuLjEzYWQzNjQwMTg3MzZkNmUw NTk0ZmE0NmQwY2RjYmIwNjUzNDg5M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vz c2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcApAQCAtMTIxNiw3ICsx MjE2LDcgQEAgdm9pZCBTZXNzaW9uOjppc0VsZW1lbnRTZWxlY3RlZChjb25zdCBTdHJpbmcmIGVs ZW1lbnRJRCwgRnVuY3Rpb248dm9pZCAoQ29tbWFuZFIKICAgICAgICAgfQogICAgICAgICBhdXRv IGFyZ3VtZW50cyA9IEpTT046OkFycmF5OjpjcmVhdGUoKTsKICAgICAgICAgYXJndW1lbnRzLT5w dXNoU3RyaW5nKGNyZWF0ZUVsZW1lbnQoZWxlbWVudElEKS0+dG9KU09OU3RyaW5nKCkpOwotICAg ICAgICBhcmd1bWVudHMtPnB1c2hTdHJpbmcoSlNPTjo6VmFsdWU6OmNyZWF0ZSgic2VsZWN0ZWQi KS0+dG9KU09OU3RyaW5nKCkpOworICAgICAgICBhcmd1bWVudHMtPnB1c2hTdHJpbmcoSlNPTjo6 VmFsdWU6OmNyZWF0ZShtYWtlU3RyaW5nKCJzZWxlY3RlZCJfcykpLT50b0pTT05TdHJpbmcoKSk7 CiAKICAgICAgICAgYXV0byBwYXJhbWV0ZXJzID0gSlNPTjo6T2JqZWN0OjpjcmVhdGUoKTsKICAg ICAgICAgcGFyYW1ldGVycy0+c2V0U3RyaW5nKCJicm93c2luZ0NvbnRleHRIYW5kbGUiX3MsIG1f dG9wbGV2ZWxCcm93c2luZ0NvbnRleHQudmFsdWUoKSk7Cg==