<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>219467</bug_id>
          
          <creation_ts>2020-12-02 17:45:59 -0800</creation_ts>
          <short_desc>Many different assertion failures on the GPU process bot after r270366</short_desc>
          <delta_ts>2020-12-02 21:08:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>rniwa</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1711544</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-12-02 17:45:59 -0800</bug_when>
    <thetext>Many different assertion failures on the GPU process bot after r270366</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711545</commentid>
    <comment_count>1</comment_count>
      <attachid>415268</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-12-02 17:46:10 -0800</bug_when>
    <thetext>Created attachment 415268
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711546</commentid>
    <comment_count>2</comment_count>
      <attachid>415268</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-12-02 17:47:48 -0800</bug_when>
    <thetext>Comment on attachment 415268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415268&amp;action=review

&gt; Source/WebKit/WebProcess/WebPage/WebPage.cpp:3799
&gt; +    WebProcess::singleton().setUseGPUProcessForDOMRendering(m_shouldRenderDOMInGPUProcess &amp;&amp; DrawingArea::drawingAreaTypeSupportsGPUProcessRendering(m_drawingAreaType));

This is static on DrawingArea, and based on DrawingAreaType instead of just being a virtual bool getter on DrawingArea, because we might not have an m_drawingArea at this point.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711571</commentid>
    <comment_count>3</comment_count>
      <attachid>415268</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2020-12-02 19:31:49 -0800</bug_when>
    <thetext>Comment on attachment 415268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415268&amp;action=review

&gt; Source/WebKit/WebProcess/WebPage/DrawingArea.h:78
&gt; +    static bool drawingAreaTypeSupportsGPUProcessRendering(DrawingAreaType);

Since this is called like DrawingArea::drawingAreaTypeSupportsGPUProcessRendering() I think you can all it supportsGPUProcessRenderingForType() or just supportsGPUProcessRendering()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711572</commentid>
    <comment_count>4</comment_count>
      <attachid>415268</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-12-02 19:32:31 -0800</bug_when>
    <thetext>Comment on attachment 415268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415268&amp;action=review

&gt;&gt; Source/WebKit/WebProcess/WebPage/DrawingArea.h:78
&gt;&gt; +    static bool drawingAreaTypeSupportsGPUProcessRendering(DrawingAreaType);
&gt; 
&gt; Since this is called like DrawingArea::drawingAreaTypeSupportsGPUProcessRendering() I think you can all it supportsGPUProcessRenderingForType() or just supportsGPUProcessRendering()

true</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711590</commentid>
    <comment_count>5</comment_count>
      <attachid>415272</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-12-02 20:10:18 -0800</bug_when>
    <thetext>Created attachment 415272
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711600</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-12-02 21:07:19 -0800</bug_when>
    <thetext>Committed r270387: &lt;https://trac.webkit.org/changeset/270387&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415272.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711602</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-12-02 21:08:21 -0800</bug_when>
    <thetext>&lt;rdar://problem/71923173&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>415268</attachid>
            <date>2020-12-02 17:46:10 -0800</date>
            <delta_ts>2020-12-02 20:10:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-219467-20201202174609.patch</filename>
            <type>text/plain</type>
            <size>6680</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4NjExODg1N2U2ZTI2M2Zj
YTNiZWExMDc5NjU1OTk4ZTYxNDZmNjcuLjNjNDQ0NmQzNDYwNDljMWVkYzBmZmMzZGU5OTE5NzYz
YTc4MTIyN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMTItMDIgIFRpbSBIb3J0
b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFueSBkaWZmZXJlbnQg
YXNzZXJ0aW9uIGZhaWx1cmVzIG9uIHRoZSBHUFUgcHJvY2VzcyBib3QgYWZ0ZXIgcjI3MDM2Ngor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NDY3CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9j
ZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJl
YTo6ZHJhd2luZ0FyZWFUeXBlU3VwcG9ydHNHUFVQcm9jZXNzUmVuZGVyaW5nKToKKyAgICAgICAg
KiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNz
L1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OldlYlBhZ2Up
OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisgICAgICAg
ICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAgICAgRGlzYWJsZSBET00gcmVu
ZGVyaW5nIGluIHRoZSBHUFUgcHJvY2VzcyBpZiB0aGUgRHJhd2luZ0FyZWEgZG9lc24ndCBzdXBw
b3J0IGl0LgorICAgICAgICBDdXJyZW50bHkgb25seSBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJl
YSBkb2VzLgorCiAyMDIwLTEyLTAyICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu
Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCB0aGUgaU9TIGJ1aWxkIGFmdGVyIHIyNzAz
NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB
cmVhLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmNw
cAppbmRleCA5NzQyOWU5NzY5ZDJhY2NmM2Q5OTk0OWUyZjZjYThhNGU4YWNlY2U5Li40ZDI5MmU1
ODNjNDkxN2VjOTViMDEyODcyMDE4MTU4ODMzZTYzMTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5jcHAKKysrIGIvU291cmNlL1dlYktp
dC9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3BwCkBAIC05Nyw0ICs5NywyMSBAQCB2
b2lkIERyYXdpbmdBcmVhOjpyZW1vdmVNZXNzYWdlUmVjZWl2ZXJJZk5lZWRlZCgpCiAgICAgV2Vi
UHJvY2Vzczo6c2luZ2xldG9uKCkucmVtb3ZlTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpEcmF3
aW5nQXJlYTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX2lkZW50aWZpZXIpOwogfQogCitib29s
IERyYXdpbmdBcmVhOjpkcmF3aW5nQXJlYVR5cGVTdXBwb3J0c0dQVVByb2Nlc3NSZW5kZXJpbmco
RHJhd2luZ0FyZWFUeXBlIHR5cGUpCit7CisgICAgc3dpdGNoICh0eXBlKSB7CisjaWYgUExBVEZP
Uk0oQ09DT0EpCisjaWYgIVBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgY2FzZSBEcmF3aW5nQXJl
YVR5cGVUaWxlZENvcmVBbmltYXRpb246CisgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgor
ICAgIGNhc2UgRHJhd2luZ0FyZWFUeXBlUmVtb3RlTGF5ZXJUcmVlOgorICAgICAgICByZXR1cm4g
dHJ1ZTsKKyNlbGlmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykgfHwgVVNFKFRFWFRVUkVfTUFQ
UEVSKQorICAgIGNhc2UgRHJhd2luZ0FyZWFUeXBlQ29vcmRpbmF0ZWRHcmFwaGljczoKKyAgICAg
ICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCisgICAgfQorfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJL
aXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB
cmVhLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5oCmlu
ZGV4IGUxYzIzMGFmMDAxYzA0ZTlhZDVjNTI1YTMxYjVjOTEyZTJlYWMzYmQuLmQ5ZTkxNDI4MGYx
NDYzODhhNjA5OGUxZGIwZDI5ZDlhNDgyZWI2MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv
V2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQ
cm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaApAQCAtNzUsNiArNzUsOCBAQCBwdWJsaWM6CiAg
ICAgRHJhd2luZ0FyZWFUeXBlIHR5cGUoKSBjb25zdCB7IHJldHVybiBtX3R5cGU7IH0KICAgICBE
cmF3aW5nQXJlYUlkZW50aWZpZXIgaWRlbnRpZmllcigpIGNvbnN0IHsgcmV0dXJuIG1faWRlbnRp
ZmllcjsgfQogCisgICAgc3RhdGljIGJvb2wgZHJhd2luZ0FyZWFUeXBlU3VwcG9ydHNHUFVQcm9j
ZXNzUmVuZGVyaW5nKERyYXdpbmdBcmVhVHlwZSk7CisKICAgICB2aXJ0dWFsIHZvaWQgc2V0TmVl
ZHNEaXNwbGF5KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc0Rpc3BsYXlJblJlY3Qo
Y29uc3QgV2ViQ29yZTo6SW50UmVjdCYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsKGNv
bnN0IFdlYkNvcmU6OkludFJlY3QmIHNjcm9sbFJlY3QsIGNvbnN0IFdlYkNvcmU6OkludFNpemUm
IHNjcm9sbERlbHRhKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv
V2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl
YlBhZ2UuY3BwCmluZGV4IDM3MmIyMzQxNTliMGRlNGFhMTQxMmIxZmU1MzNiZGRkNDJjMjg0MWMu
LjY4ZjFhYzBkMDdkYzdjZjBmMTQ3ZTFiZDcxOTgzYWYzZmFiMzE2ZmYgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X
ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC00MjEsNiArNDIxLDcgQEAg
V2ViUGFnZTo6V2ViUGFnZShQYWdlSWRlbnRpZmllciBwYWdlSUQsIFdlYlBhZ2VDcmVhdGlvblBh
cmFtZXRlcnMmJiBwYXJhbWV0ZXJzKQogICAgIDogbV9pZGVudGlmaWVyKHBhZ2VJRCkKICAgICAs
IG1fbWFpbkZyYW1lKFdlYkZyYW1lOjpjcmVhdGUoKSkKICAgICAsIG1fdmlld1NpemUocGFyYW1l
dGVycy52aWV3U2l6ZSkKKyAgICAsIG1fZHJhd2luZ0FyZWFUeXBlKHBhcmFtZXRlcnMuZHJhd2lu
Z0FyZWFUeXBlKQogICAgICwgbV9hbHdheXNTaG93c0hvcml6b250YWxTY3JvbGxlciB7IHBhcmFt
ZXRlcnMuYWx3YXlzU2hvd3NIb3Jpem9udGFsU2Nyb2xsZXIgfQogICAgICwgbV9hbHdheXNTaG93
c1ZlcnRpY2FsU2Nyb2xsZXIgeyBwYXJhbWV0ZXJzLmFsd2F5c1Nob3dzVmVydGljYWxTY3JvbGxl
ciB9CiAgICAgLCBtX3Nob3VsZFJlbmRlckNhbnZhc0luR1BVUHJvY2VzcyB7IHBhcmFtZXRlcnMu
c2hvdWxkUmVuZGVyQ2FudmFzSW5HUFVQcm9jZXNzIH0KQEAgLTM3OTUsNyArMzc5Niw3IEBAIHZv
aWQgV2ViUGFnZTo6dXBkYXRlUHJlZmVyZW5jZXMoY29uc3QgV2ViUHJlZmVyZW5jZXNTdG9yZSYg
c3RvcmUpCiAgICAgc3RhdGljX2Nhc3Q8V2ViTWVkaWFTdHJhdGVneSY+KHBsYXRmb3JtU3RyYXRl
Z2llcygpLT5tZWRpYVN0cmF0ZWd5KCkpLnNldFVzZUdQVVByb2Nlc3MobV9zaG91bGRQbGF5TWVk
aWFJbkdQVVByb2Nlc3MpOwogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnN1cHBsZW1lbnQ8
UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyPigpLT5zZXRVc2VHUFVQcm9jZXNzKG1fc2hvdWxkUGxh
eU1lZGlhSW5HUFVQcm9jZXNzKTsKICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5zZXRVc2VH
UFVQcm9jZXNzRm9yQ2FudmFzUmVuZGVyaW5nKG1fc2hvdWxkUmVuZGVyQ2FudmFzSW5HUFVQcm9j
ZXNzKTsKLSAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5zZXRVc2VHUFVQcm9jZXNzRm9yRE9N
UmVuZGVyaW5nKG1fc2hvdWxkUmVuZGVyRE9NSW5HUFVQcm9jZXNzKTsKKyAgICBXZWJQcm9jZXNz
OjpzaW5nbGV0b24oKS5zZXRVc2VHUFVQcm9jZXNzRm9yRE9NUmVuZGVyaW5nKG1fc2hvdWxkUmVu
ZGVyRE9NSW5HUFVQcm9jZXNzICYmIERyYXdpbmdBcmVhOjpkcmF3aW5nQXJlYVR5cGVTdXBwb3J0
c0dQVVByb2Nlc3NSZW5kZXJpbmcobV9kcmF3aW5nQXJlYVR5cGUpKTsKICAgICBXZWJQcm9jZXNz
OjpzaW5nbGV0b24oKS5zZXRVc2VHUFVQcm9jZXNzRm9yTWVkaWEobV9zaG91bGRQbGF5TWVkaWFJ
bkdQVVByb2Nlc3MpOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv
Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl
L1dlYlBhZ2UuaAppbmRleCA5ZGZiNjYxMzNlYjBjNGEwYjY5Yzc3NTBlNTM3NTg0NGYwMTJlMDIx
Li5lMDRlM2E4YjJkMTc4Y2M4NDk1ZDQ1YmFmODFmMzdkYWVmYmI3YjcwIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dl
YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCkBAIC0xODAyLDYgKzE4MDIsNyBAQCBw
cml2YXRlOgogCiAgICAgV2ViQ29yZTo6SW50U2l6ZSBtX3ZpZXdTaXplOwogICAgIHN0ZDo6dW5p
cXVlX3B0cjxEcmF3aW5nQXJlYT4gbV9kcmF3aW5nQXJlYTsKKyAgICBEcmF3aW5nQXJlYVR5cGUg
bV9kcmF3aW5nQXJlYVR5cGU7CiAKICAgICBIYXNoU2V0PFBsdWdpblZpZXcqPiBtX3BsdWdpblZp
ZXdzOwogICAgIGJvb2wgbV9oYXNTZWVuUGx1Z2luIHsgZmFsc2UgfTsKZGlmZiAtLWdpdCBhL1Rv
b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NmMwMmI5MzI0MGU0MTMxYjAx
ZDNmNTRhY2FmOWY1ODM3YWRhYjA5Li45Y2E5YTZjODJkYmRhOWEwYjY1Y2E5OTY3MDllYTUyNzhi
ZWIzNzQzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMTItMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRv
bkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFueSBkaWZmZXJlbnQgYXNzZXJ0aW9uIGZhaWx1cmVz
IG9uIHRoZSBHUFUgcHJvY2VzcyBib3QgYWZ0ZXIgcjI3MDM2NgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NDY3CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9y
Zy9jb25maWcuanNvbjoKKyAgICAgICAgUmV2ZXJ0IHIyNzAzNjY7IG1hY09TIFVJLXNpZGUgY29t
cG9zaXRpbmcgaXMgaW4gd2F5IHRvbyBzYWQKKyAgICAgICAgb2YgYSBzdGF0ZSwgdGhlIHdvcmxk
IGlzIG5vdCByZWFkeSBmb3IgdGhpcyB5ZXQuCisKIDIwMjAtMTItMDIgIFRpbSBIb3J0b24gIDx0
aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIFVJLXNpZGUgY29tcG9z
aXRpbmcgb24gdGhlIEdQVSBQcm9jZXNzIGxheW91dCB0ZXN0cyBib3QKZGlmZiAtLWdpdCBhL1Rv
b2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2NvbmZpZy5qc29uIGIvVG9vbHMvQ0lTdXBw
b3J0L2J1aWxkLXdlYmtpdC1vcmcvY29uZmlnLmpzb24KaW5kZXggYzg3N2NiYzRkMTY4YTUyZTcz
OWU2NzBhNzJjMzBkNTExOGU5YWY1OC4uZTEwMmM2NjI1NjNhNDM0NDcxZGU1ZjRiMzhiY2JlZmEx
YWVhMTFmMyAxMDA2NDQKLS0tIGEvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvY29u
ZmlnLmpzb24KKysrIGIvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvY29uZmlnLmpz
b24KQEAgLTE2OCw3ICsxNjgsNyBAQAogCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAi
QXBwbGUtQ2F0YWxpbmEtRGVidWctV0syLUdQVVByb2Nlc3MtVGVzdHMiLCAiZmFjdG9yeSI6ICJU
ZXN0QWxsQnV0SlNDRmFjdG9yeSIsICJidWlsZGRpciI6ICJjYXRhbGluYS1kZWJ1Zy10ZXN0cy13
azItZ3B1cHJvY2VzcyIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRmb3JtIjogIm1hYy1j
YXRhbGluYSIsICJjb25maWd1cmF0aW9uIjogImRlYnVnIiwgImFyY2hpdGVjdHVyZXMiOiBbIng4
Nl82NCJdLAotICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJndW1lbnRzIjogWyIt
LW5vLXJldHJ5LWZhaWx1cmVzIiwgIi0tdXNlLWdwdS1wcm9jZXNzIiwgIi0tcmVtb3RlLWxheWVy
LXRyZWUiXSwKKyAgICAgICAgICAgICAgICAgICAgICAiYWRkaXRpb25hbEFyZ3VtZW50cyI6IFsi
LS1uby1yZXRyeS1mYWlsdXJlcyIsICItLXVzZS1ncHUtcHJvY2VzcyJdLAogICAgICAgICAgICAg
ICAgICAgICAgICJ3b3JrZXJuYW1lcyI6IFsiYm90MjYwIl0KICAgICAgICAgICAgICAgICAgICAg
fSwKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJBcHBsZS1DYXRhbGluYS1SZWxlYXNl
LUJ1aWxkIiwgImZhY3RvcnkiOiAiQnVpbGRGYWN0b3J5IiwgImJ1aWxkZGlyIjogImNhdGFsaW5h
LXJlbGVhc2UiLAo=
</data>
<flag name="review"
          id="432435"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>415272</attachid>
            <date>2020-12-02 20:10:18 -0800</date>
            <delta_ts>2020-12-02 21:07:20 -0800</delta_ts>
            <desc>patch</desc>
            <filename>bug-219467-20201202174609.patch.txt</filename>
            <type>text/plain</type>
            <size>6616</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4NjExODg1N2U2ZTI2M2Zj
YTNiZWExMDc5NjU1OTk4ZTYxNDZmNjcuLjNjNDQ0NmQzNDYwNDljMWVkYzBmZmMzZGU5OTE5NzYz
YTc4MTIyN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMTItMDIgIFRpbSBIb3J0
b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFueSBkaWZmZXJlbnQg
YXNzZXJ0aW9uIGZhaWx1cmVzIG9uIHRoZSBHUFUgcHJvY2VzcyBib3QgYWZ0ZXIgcjI3MDM2Ngor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5NDY3CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgICogV2ViUHJvY2Vz
cy9XZWJQYWdlL0RyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWE6
OnN1cHBvcnRzR1BVUHJvY2Vzc1JlbmRlcmluZyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ
YWdlL0RyYXdpbmdBcmVhLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu
Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdlKToKKyAgICAgICAgKFdlYktp
dDo6V2ViUGFnZTo6dXBkYXRlUHJlZmVyZW5jZXMpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi
UGFnZS9XZWJQYWdlLmg6CisgICAgICAgIERpc2FibGUgRE9NIHJlbmRlcmluZyBpbiB0aGUgR1BV
IHByb2Nlc3MgaWYgdGhlIERyYXdpbmdBcmVhIGRvZXNuJ3Qgc3VwcG9ydCBpdC4KKyAgICAgICAg
Q3VycmVudGx5IG9ubHkgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEgZG9lcy4KKwogMjAyMC0x
Mi0wMiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBV
bnJldmlld2VkLCBmaXggdGhlIGlPUyBidWlsZCBhZnRlciByMjcwMzYyCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5jcHAgYi9Tb3VyY2Uv
V2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5jcHAKaW5kZXggOTc0MjllOTc2
OWQyYWNjZjNkOTk5NDllMmY2Y2E4YTRlOGFjZWNlOS4uNGQyOTJlNTgzYzQ5MTdlYzk1YjAxMjg3
MjAxODE1ODgzM2U2MzE1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl
YlBhZ2UvRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ
YWdlL0RyYXdpbmdBcmVhLmNwcApAQCAtOTcsNCArOTcsMjEgQEAgdm9pZCBEcmF3aW5nQXJlYTo6
cmVtb3ZlTWVzc2FnZVJlY2VpdmVySWZOZWVkZWQoKQogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRv
bigpLnJlbW92ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6RHJhd2luZ0FyZWE6Om1lc3NhZ2VS
ZWNlaXZlck5hbWUoKSwgbV9pZGVudGlmaWVyKTsKIH0KIAorYm9vbCBEcmF3aW5nQXJlYTo6c3Vw
cG9ydHNHUFVQcm9jZXNzUmVuZGVyaW5nKERyYXdpbmdBcmVhVHlwZSB0eXBlKQoreworICAgIHN3
aXRjaCAodHlwZSkgeworI2lmIFBMQVRGT1JNKENPQ09BKQorI2lmICFQTEFURk9STShJT1NfRkFN
SUxZKQorICAgIGNhc2UgRHJhd2luZ0FyZWFUeXBlVGlsZWRDb3JlQW5pbWF0aW9uOgorICAgICAg
ICByZXR1cm4gZmFsc2U7CisjZW5kaWYKKyAgICBjYXNlIERyYXdpbmdBcmVhVHlwZVJlbW90ZUxh
eWVyVHJlZToKKyAgICAgICAgcmV0dXJuIHRydWU7CisjZWxpZiBVU0UoQ09PUkRJTkFURURfR1JB
UEhJQ1MpIHx8IFVTRShURVhUVVJFX01BUFBFUikKKyAgICBjYXNlIERyYXdpbmdBcmVhVHlwZUNv
b3JkaW5hdGVkR3JhcGhpY3M6CisgICAgICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorICAgIH0K
K30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dl
YlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz
L1dlYlBhZ2UvRHJhd2luZ0FyZWEuaAppbmRleCBlMWMyMzBhZjAwMWMwNGU5YWQ1YzUyNWEzMWI1
YzkxMmUyZWFjM2JkLi5kOWU5MTQyODBmMTQ2Mzg4YTYwOThlMWRiMGQyOWQ5YTQ4MmViNjEyIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5o
CisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmgKQEAg
LTc1LDYgKzc1LDggQEAgcHVibGljOgogICAgIERyYXdpbmdBcmVhVHlwZSB0eXBlKCkgY29uc3Qg
eyByZXR1cm4gbV90eXBlOyB9CiAgICAgRHJhd2luZ0FyZWFJZGVudGlmaWVyIGlkZW50aWZpZXIo
KSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXI7IH0KIAorICAgIHN0YXRpYyBib29sIHN1cHBv
cnRzR1BVUHJvY2Vzc1JlbmRlcmluZyhEcmF3aW5nQXJlYVR5cGUpOworCiAgICAgdmlydHVhbCB2
b2lkIHNldE5lZWRzRGlzcGxheSgpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TmVlZHNEaXNw
bGF5SW5SZWN0KGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKSA9IDA7CiAgICAgdmlydHVhbCB2b2lk
IHNjcm9sbChjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBzY3JvbGxSZWN0LCBjb25zdCBXZWJDb3Jl
OjpJbnRTaXplJiBzY3JvbGxEZWx0YSkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9X
ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv
V2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCAzNzJiMjM0MTU5YjBkZTRhYTE0MTJiMWZlNTMzYmRk
ZDQyYzI4NDFjLi42OGYxYWMwZDA3ZGM3Y2YwZjE0N2UxYmQ3MTk4M2FmM2ZhYjMxNmZmIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysg
Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtNDIxLDYg
KzQyMSw3IEBAIFdlYlBhZ2U6OldlYlBhZ2UoUGFnZUlkZW50aWZpZXIgcGFnZUlELCBXZWJQYWdl
Q3JlYXRpb25QYXJhbWV0ZXJzJiYgcGFyYW1ldGVycykKICAgICA6IG1faWRlbnRpZmllcihwYWdl
SUQpCiAgICAgLCBtX21haW5GcmFtZShXZWJGcmFtZTo6Y3JlYXRlKCkpCiAgICAgLCBtX3ZpZXdT
aXplKHBhcmFtZXRlcnMudmlld1NpemUpCisgICAgLCBtX2RyYXdpbmdBcmVhVHlwZShwYXJhbWV0
ZXJzLmRyYXdpbmdBcmVhVHlwZSkKICAgICAsIG1fYWx3YXlzU2hvd3NIb3Jpem9udGFsU2Nyb2xs
ZXIgeyBwYXJhbWV0ZXJzLmFsd2F5c1Nob3dzSG9yaXpvbnRhbFNjcm9sbGVyIH0KICAgICAsIG1f
YWx3YXlzU2hvd3NWZXJ0aWNhbFNjcm9sbGVyIHsgcGFyYW1ldGVycy5hbHdheXNTaG93c1ZlcnRp
Y2FsU2Nyb2xsZXIgfQogICAgICwgbV9zaG91bGRSZW5kZXJDYW52YXNJbkdQVVByb2Nlc3MgeyBw
YXJhbWV0ZXJzLnNob3VsZFJlbmRlckNhbnZhc0luR1BVUHJvY2VzcyB9CkBAIC0zNzk1LDcgKzM3
OTYsNyBAQCB2b2lkIFdlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVu
Y2VzU3RvcmUmIHN0b3JlKQogICAgIHN0YXRpY19jYXN0PFdlYk1lZGlhU3RyYXRlZ3kmPihwbGF0
Zm9ybVN0cmF0ZWdpZXMoKS0+bWVkaWFTdHJhdGVneSgpKS5zZXRVc2VHUFVQcm9jZXNzKG1fc2hv
dWxkUGxheU1lZGlhSW5HUFVQcm9jZXNzKTsKICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5z
dXBwbGVtZW50PFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlcj4oKS0+c2V0VXNlR1BVUHJvY2Vzcyht
X3Nob3VsZFBsYXlNZWRpYUluR1BVUHJvY2Vzcyk7CiAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9u
KCkuc2V0VXNlR1BVUHJvY2Vzc0ZvckNhbnZhc1JlbmRlcmluZyhtX3Nob3VsZFJlbmRlckNhbnZh
c0luR1BVUHJvY2Vzcyk7Ci0gICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkuc2V0VXNlR1BVUHJv
Y2Vzc0ZvckRPTVJlbmRlcmluZyhtX3Nob3VsZFJlbmRlckRPTUluR1BVUHJvY2Vzcyk7CisgICAg
V2ViUHJvY2Vzczo6c2luZ2xldG9uKCkuc2V0VXNlR1BVUHJvY2Vzc0ZvckRPTVJlbmRlcmluZyht
X3Nob3VsZFJlbmRlckRPTUluR1BVUHJvY2VzcyAmJiBEcmF3aW5nQXJlYTo6c3VwcG9ydHNHUFVQ
cm9jZXNzUmVuZGVyaW5nKG1fZHJhd2luZ0FyZWFUeXBlKSk7CiAgICAgV2ViUHJvY2Vzczo6c2lu
Z2xldG9uKCkuc2V0VXNlR1BVUHJvY2Vzc0Zvck1lZGlhKG1fc2hvdWxkUGxheU1lZGlhSW5HUFVQ
cm9jZXNzKTsKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv
V2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ
YWdlLmgKaW5kZXggOWRmYjY2MTMzZWIwYzRhMGI2OWM3NzUwZTUzNzU4NDRmMDEyZTAyMS4uZTA0
ZTNhOGIyZDE3OGNjODQ5NWQ0NWJhZjgxZjM3ZGFlZmJiN2I3MCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv
V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAtMTgwMiw2ICsxODAyLDcgQEAgcHJpdmF0
ZToKIAogICAgIFdlYkNvcmU6OkludFNpemUgbV92aWV3U2l6ZTsKICAgICBzdGQ6OnVuaXF1ZV9w
dHI8RHJhd2luZ0FyZWE+IG1fZHJhd2luZ0FyZWE7CisgICAgRHJhd2luZ0FyZWFUeXBlIG1fZHJh
d2luZ0FyZWFUeXBlOwogCiAgICAgSGFzaFNldDxQbHVnaW5WaWV3Kj4gbV9wbHVnaW5WaWV3czsK
ICAgICBib29sIG1faGFzU2VlblBsdWdpbiB7IGZhbHNlIH07CmRpZmYgLS1naXQgYS9Ub29scy9D
aGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTZjMDJiOTMyNDBlNDEzMWIwMWQzZjU0
YWNhZjlmNTgzN2FkYWIwOS4uOWNhOWE2YzgyZGJkYTlhMGI2NWNhOTk2NzA5ZWE1Mjc4YmViMzc0
MyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE0IEBACisyMDIwLTEyLTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw
bGUuY29tPgorCisgICAgICAgIE1hbnkgZGlmZmVyZW50IGFzc2VydGlvbiBmYWlsdXJlcyBvbiB0
aGUgR1BVIHByb2Nlc3MgYm90IGFmdGVyIHIyNzAzNjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTQ2NworCisgICAgICAgIFJldmlld2VkIGJ5IFNp
bW9uIEZyYXNlci4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2NvbmZp
Zy5qc29uOgorICAgICAgICBSZXZlcnQgcjI3MDM2NjsgbWFjT1MgVUktc2lkZSBjb21wb3NpdGlu
ZyBpcyBpbiB3YXkgdG9vIHNhZAorICAgICAgICBvZiBhIHN0YXRlLCB0aGUgd29ybGQgaXMgbm90
IHJlYWR5IGZvciB0aGlzIHlldC4KKwogMjAyMC0xMi0wMiAgVGltIEhvcnRvbiAgPHRpbW90aHlf
aG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgVUktc2lkZSBjb21wb3NpdGluZyBv
biB0aGUgR1BVIFByb2Nlc3MgbGF5b3V0IHRlc3RzIGJvdApkaWZmIC0tZ2l0IGEvVG9vbHMvQ0lT
dXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvY29uZmlnLmpzb24gYi9Ub29scy9DSVN1cHBvcnQvYnVp
bGQtd2Via2l0LW9yZy9jb25maWcuanNvbgppbmRleCBjODc3Y2JjNGQxNjhhNTJlNzM5ZTY3MGE3
MmMzMGQ1MTE4ZTlhZjU4Li5lMTAyYzY2MjU2M2E0MzQ0NzFkZTVmNGIzOGJjYmVmYTFhZWExMWYz
IDEwMDY0NAotLS0gYS9Ub29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9jb25maWcuanNv
bgorKysgYi9Ub29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9jb25maWcuanNvbgpAQCAt
MTY4LDcgKzE2OCw3IEBACiAKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJBcHBsZS1D
YXRhbGluYS1EZWJ1Zy1XSzItR1BVUHJvY2Vzcy1UZXN0cyIsICJmYWN0b3J5IjogIlRlc3RBbGxC
dXRKU0NGYWN0b3J5IiwgImJ1aWxkZGlyIjogImNhdGFsaW5hLWRlYnVnLXRlc3RzLXdrMi1ncHVw
cm9jZXNzIiwKICAgICAgICAgICAgICAgICAgICAgICAicGxhdGZvcm0iOiAibWFjLWNhdGFsaW5h
IiwgImNvbmZpZ3VyYXRpb24iOiAiZGVidWciLCAiYXJjaGl0ZWN0dXJlcyI6IFsieDg2XzY0Il0s
Ci0gICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1bWVudHMiOiBbIi0tbm8tcmV0
cnktZmFpbHVyZXMiLCAiLS11c2UtZ3B1LXByb2Nlc3MiLCAiLS1yZW1vdGUtbGF5ZXItdHJlZSJd
LAorICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJndW1lbnRzIjogWyItLW5vLXJl
dHJ5LWZhaWx1cmVzIiwgIi0tdXNlLWdwdS1wcm9jZXNzIl0sCiAgICAgICAgICAgICAgICAgICAg
ICAgIndvcmtlcm5hbWVzIjogWyJib3QyNjAiXQogICAgICAgICAgICAgICAgICAgICB9LAogICAg
ICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlLUNhdGFsaW5hLVJlbGVhc2UtQnVpbGQi
LCAiZmFjdG9yeSI6ICJCdWlsZEZhY3RvcnkiLCAiYnVpbGRkaXIiOiAiY2F0YWxpbmEtcmVsZWFz
ZSIsCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>