<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>219431</bug_id>
          
          <creation_ts>2020-12-02 07:17:54 -0800</creation_ts>
          <short_desc>GPU Process WindowServer blocking prevents CGL</short_desc>
          <delta_ts>2020-12-04 07:44:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>217211</blocked>
    
    <blocked>217216</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kimmo Kinnunen">kkinnunen</reporter>
          <assigned_to name="Kimmo Kinnunen">kkinnunen</assigned_to>
          <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>pvollan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1711328</commentid>
    <comment_count>0</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2020-12-02 07:17:54 -0800</bug_when>
    <thetext>GPU Process WindowServer blocking prevents CGL

Currently block is done with setApplicationIsDaemon

I managed to use the Web Process method of blocking WindowServer on iMac Pro
I failed to use the method on MacBook with Intel/AMD</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711329</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-12-02 07:18:03 -0800</bug_when>
    <thetext>&lt;rdar://problem/71893390&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711662</commentid>
    <comment_count>2</comment_count>
      <attachid>415299</attachid>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2020-12-03 06:00:44 -0800</bug_when>
    <thetext>Created attachment 415299
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711728</commentid>
    <comment_count>3</comment_count>
      <attachid>415299</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-12-03 10:59:00 -0800</bug_when>
    <thetext>Comment on attachment 415299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415299&amp;action=review

&gt; Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:48
&gt; +    auto retval = CGSSetDenyWindowServerConnections(true);

Not really WebKit style to use the name &quot;retval&quot; and I would prefer &quot;result&quot;, &quot;returnValue&quot;, or &quot;errorCode&quot;, or even &quot;error&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711990</commentid>
    <comment_count>4</comment_count>
      <attachid>415406</attachid>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2020-12-04 04:17:59 -0800</bug_when>
    <thetext>Created attachment 415406
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711992</commentid>
    <comment_count>5</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2020-12-04 04:20:47 -0800</bug_when>
    <thetext>Thanks for the review. Per Arne found a proper fix.

The GPU Process property list was missing allowing the automatic graphics switching. It&apos;s unknown if this is intended limitation or accidental error in CGL.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711993</commentid>
    <comment_count>6</comment_count>
      <attachid>415407</attachid>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2020-12-04 04:22:11 -0800</bug_when>
    <thetext>Created attachment 415407
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1711999</commentid>
    <comment_count>7</comment_count>
      <attachid>415407</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-12-04 05:02:12 -0800</bug_when>
    <thetext>Comment on attachment 415407
Patch

R=me. I think the build failures are unrelated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1712021</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-12-04 07:44:06 -0800</bug_when>
    <thetext>Committed r270430: &lt;https://trac.webkit.org/changeset/270430&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415407.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>415299</attachid>
            <date>2020-12-03 06:00:44 -0800</date>
            <delta_ts>2020-12-04 04:17:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-219431-20201203160042.patch</filename>
            <type>text/plain</type>
            <size>2002</size>
            <attacher name="Kimmo Kinnunen">kkinnunen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJmZTU2NmE0YjE1YmQ0YmVl
Yjk3ZDBiNzAxOWU0M2NlZjFlYWEyMGUuLmY5MjIzMWMwZTY5YzliZGJjNmMyZDhiMjEzOTJhZGNk
M2VhODU1ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMTItMDMgIEtpbW1vIEtp
bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBHUFUgUHJvY2VzcyBXaW5k
b3dTZXJ2ZXIgYmxvY2tpbmcgcHJldmVudHMgQ0dMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk0MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcx
ODkzMzkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBC
bG9jayBHUFUgcHJvY2VzcyBXaW5kb3dTZXJ2ZXIgY29ubmVjdGlvbnMgdGhlIHNhbWUgd2F5IGFz
CisgICAgICAgIFdlYiBwcm9jZXNzLiBPdGhlcndpc2UgQ0dMIGRvZXMgbm90IHdvcmsuCisKKyAg
ICAgICAgKiBHUFVQcm9jZXNzL21hYy9HUFVQcm9jZXNzTWFjLm1tOgorICAgICAgICAoV2ViS2l0
OjpHUFVQcm9jZXNzOjppbml0aWFsaXplUHJvY2Vzcyk6CisKIDIwMjAtMTItMDEgIEtpbW1vIEtp
bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgUmVtb3Rl
V2ViR0xCYWNrZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL0dQ
VVByb2Nlc3NNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL0dQVVByb2Nlc3NN
YWMubW0KaW5kZXggYjdiYjYzYjI5YWQ4MDIxNzJkZjI3YTEyODk1YmIxOTk4ZmE0YjZiMC4uNjQz
NTc3Zjk0ZTBiMGQzZWUwYzdmZmIxMWMyMjIyNmY5MTE1MjE5NiAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdC9HUFVQcm9jZXNzL21hYy9HUFVQcm9jZXNzTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJL
aXQvR1BVUHJvY2Vzcy9tYWMvR1BVUHJvY2Vzc01hYy5tbQpAQCAtMzIsOCArMzIsOCBAQAogI2lt
cG9ydCAiU2FuZGJveEluaXRpYWxpemF0aW9uUGFyYW1ldGVycy5oIgogI2ltcG9ydCAiV0tGb3Vu
ZGF0aW9uLmgiCiAjaW1wb3J0IDxXZWJDb3JlL0xvY2FsaXplZFN0cmluZ3MuaD4KKyNpbXBvcnQg
PHBhbC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NvY29hL0xh
dW5jaFNlcnZpY2VzU1BJLmg+Ci0jaW1wb3J0IDxwYWwvc3BpL21hYy9ISVNlcnZpY2VzU1BJLmg+
CiAjaW1wb3J0IDxzeXNleGl0cy5oPgogI2ltcG9ydCA8d3RmL01lbW9yeVByZXNzdXJlSGFuZGxl
ci5oPgogI2ltcG9ydCA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CkBAIC00NSw4ICs0NSw5IEBAIHZv
aWQgR1BVUHJvY2Vzczo6aW5pdGlhbGl6ZVByb2Nlc3MoY29uc3QgQXV4aWxpYXJ5UHJvY2Vzc0lu
aXRpYWxpemF0aW9uUGFyYW1ldGVyCiB7CiAjaWYgUExBVEZPUk0oTUFDKSAmJiAhUExBVEZPUk0o
TUFDQ0FUQUxZU1QpCiAgICAgLy8gSGF2aW5nIGEgd2luZG93IHNlcnZlciBjb25uZWN0aW9uIGlu
IHRoaXMgcHJvY2VzcyB3b3VsZCByZXN1bHQgaW4gc3BpbiBsb2dzICg8cmRhcjovL3Byb2JsZW0v
MTMyMzkxMTk+KS4KLSAgICBPU1N0YXR1cyBlcnJvciA9IFNldEFwcGxpY2F0aW9uSXNEYWVtb24o
dHJ1ZSk7Ci0gICAgQVNTRVJUX1VOVVNFRChlcnJvciwgZXJyb3IgPT0gbm9FcnIpOworICAgIGF1
dG8gcmV0dmFsID0gQ0dTU2V0RGVueVdpbmRvd1NlcnZlckNvbm5lY3Rpb25zKHRydWUpOworICAg
IFJFTEVBU0VfQVNTRVJUKHJldHZhbCA9PSBrQ0dFcnJvclN1Y2Nlc3MpOworICAgIENHU1NodXRk
b3duU2VydmVyQ29ubmVjdGlvbnMoKTsKICNlbmRpZgogCiAgICAgbGF1bmNoU2VydmljZXNDaGVj
a0luKCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>415406</attachid>
            <date>2020-12-04 04:17:59 -0800</date>
            <delta_ts>2020-12-04 04:22:07 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-219431-20201204141757.patch</filename>
            <type>text/plain</type>
            <size>1502</size>
            <attacher name="Kimmo Kinnunen">kkinnunen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJmZTU2NmE0YjE1YmQ0YmVl
Yjk3ZDBiNzAxOWU0M2NlZjFlYWEyMGUuLjI2ZGQ5YmI4MzI0NjA0ZjU5YjllMjQwMTE1NTQ0Nzc2
NTMzN2RjZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTItMDQgIEtpbW1vIEtp
bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBHUFUgUHJvY2VzcyBXaW5k
b3dTZXJ2ZXIgYmxvY2tpbmcgcHJldmVudHMgQ0dMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk0MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcx
ODkzMzkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE1hcmsgdGhlIEdQVSBwcm9jZXNzIGFzIE5TU3VwcG9ydHNBdXRvbWF0aWNHcmFwaGljc1N3aXRj
aGluZy4KKyAgICAgICAgVGhpcyBhbGxvd3MgQ0dMIHRvIHdvcmsgaW4gY2FzZXMgd2hlbiBXaW5k
b3dTZXJ2ZXIgY29ubmVjdGlvbgorICAgICAgICBpcyBibG9ja2VkLgorCisgICAgICAgIE5vIG5l
dyB0ZXN0cywgbWFrZXMgdGhlIGZ1dHVyZSBXZWJHTCBpbiBHUFUgcHJvY2VzcyB3b3JrLgorCisg
ICAgICAgICogR1BVUHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvR1BVU2Vydmlj
ZS9JbmZvLU9TWC5wbGlzdDoKKwogMjAyMC0xMi0wMSAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVu
ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBSZW1vdGVXZWJHTEJhY2tlbmQKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1Nl
cnZpY2UvR1BVU2VydmljZS9JbmZvLU9TWC5wbGlzdCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vz
cy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvR1BVU2VydmljZS9JbmZvLU9TWC5wbGlzdApp
bmRleCBjYTljNjRmMWMzNmRiZWNiMDQzYTM5MjNiZTgzMGFiOTA1Nzg0ZTI0Li41YzZiNDRiZjVi
YWRkNmU1ODA0MzdiZWYyZDhmMmNhMTU1NTIwYzExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L0dQVVByb2Nlc3MvRW50cnlQb2ludC9Db2NvYS9YUENTZXJ2aWNlL0dQVVNlcnZpY2UvSW5mby1P
U1gucGxpc3QKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0VudHJ5UG9pbnQvQ29jb2Ev
WFBDU2VydmljZS9HUFVTZXJ2aWNlL0luZm8tT1NYLnBsaXN0CkBAIC00MSw1ICs0MSw3IEBACiAJ
CTxrZXk+X011bHRpcGxlSW5zdGFuY2VzPC9rZXk+CiAJCTx0cnVlLz4KIAk8L2RpY3Q+CisgICAg
PGtleT5OU1N1cHBvcnRzQXV0b21hdGljR3JhcGhpY3NTd2l0Y2hpbmc8L2tleT4KKwk8dHJ1ZS8+
CiA8L2RpY3Q+CiA8L3BsaXN0Pgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>415407</attachid>
            <date>2020-12-04 04:22:11 -0800</date>
            <delta_ts>2020-12-04 07:44:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-219431-20201204142210.patch</filename>
            <type>text/plain</type>
            <size>1505</size>
            <attacher name="Kimmo Kinnunen">kkinnunen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJmZTU2NmE0YjE1YmQ0YmVl
Yjk3ZDBiNzAxOWU0M2NlZjFlYWEyMGUuLjI2ZGQ5YmI4MzI0NjA0ZjU5YjllMjQwMTE1NTQ0Nzc2
NTMzN2RjZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTItMDQgIEtpbW1vIEtp
bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBHUFUgUHJvY2VzcyBXaW5k
b3dTZXJ2ZXIgYmxvY2tpbmcgcHJldmVudHMgQ0dMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk0MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcx
ODkzMzkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE1hcmsgdGhlIEdQVSBwcm9jZXNzIGFzIE5TU3VwcG9ydHNBdXRvbWF0aWNHcmFwaGljc1N3aXRj
aGluZy4KKyAgICAgICAgVGhpcyBhbGxvd3MgQ0dMIHRvIHdvcmsgaW4gY2FzZXMgd2hlbiBXaW5k
b3dTZXJ2ZXIgY29ubmVjdGlvbgorICAgICAgICBpcyBibG9ja2VkLgorCisgICAgICAgIE5vIG5l
dyB0ZXN0cywgbWFrZXMgdGhlIGZ1dHVyZSBXZWJHTCBpbiBHUFUgcHJvY2VzcyB3b3JrLgorCisg
ICAgICAgICogR1BVUHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvR1BVU2Vydmlj
ZS9JbmZvLU9TWC5wbGlzdDoKKwogMjAyMC0xMi0wMSAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVu
ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBSZW1vdGVXZWJHTEJhY2tlbmQKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1Nl
cnZpY2UvR1BVU2VydmljZS9JbmZvLU9TWC5wbGlzdCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vz
cy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvR1BVU2VydmljZS9JbmZvLU9TWC5wbGlzdApp
bmRleCBjYTljNjRmMWMzNmRiZWNiMDQzYTM5MjNiZTgzMGFiOTA1Nzg0ZTI0Li5jMDRiNzFiYTYy
NmEzYmYwNmM0MTNmNDJjYTgzYjQ4MmJmNjY0YTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L0dQVVByb2Nlc3MvRW50cnlQb2ludC9Db2NvYS9YUENTZXJ2aWNlL0dQVVNlcnZpY2UvSW5mby1P
U1gucGxpc3QKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0VudHJ5UG9pbnQvQ29jb2Ev
WFBDU2VydmljZS9HUFVTZXJ2aWNlL0luZm8tT1NYLnBsaXN0CkBAIC00MSw1ICs0MSw3IEBACiAJ
CTxrZXk+X011bHRpcGxlSW5zdGFuY2VzPC9rZXk+CiAJCTx0cnVlLz4KIAk8L2RpY3Q+CisgICAg
PGtleT5OU1N1cHBvcnRzQXV0b21hdGljR3JhcGhpY3NTd2l0Y2hpbmc8L2tleT4KKyAgICA8dHJ1
ZS8+CiA8L2RpY3Q+CiA8L3BsaXN0Pgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>