219382 2020-11-30 17:56:54 -0800 check-webkit-style should allow WebKitAdditions headers to appear after soft linking headers 2020-11-30 20:00:45 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh darin ews-watchlist glenn hi jbedard thorton webkit-bug-importer oldest_to_newest 1710888 0 wenson_hsieh 2020-11-30 17:56:54 -0800 SSIA 1710891 1 415087 wenson_hsieh 2020-11-30 18:07:58 -0800 Created attachment 415087 Patch 1710907 2 415087 wenson_hsieh 2020-11-30 19:49:07 -0800 Comment on attachment 415087 Patch Thanks for the review! 1710908 3 ews-feeder 2020-11-30 19:59:50 -0800 Committed r270282: <https://trac.webkit.org/changeset/270282> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415087. 1710909 4 webkit-bug-importer 2020-11-30 20:00:45 -0800 <rdar://problem/71835018> 415087 2020-11-30 18:07:58 -0800 2020-11-30 19:59:50 -0800 Patch bug-219382-20201130180757.patch text/plain 5044 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2U0ZjdlMDQzMjY0NGRlZTdjMjA5NGE0ZTI4NTViNWY2 OWMwY2FlNy4uYThjZTYwMmRjNWU0NWQzYWIzZWIwMjYwZWViZGJmY2I2MjFlYzQ4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTExLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQgYWxsb3cgV2ViS2l0QWRkaXRpb25z IGhlYWRlcnMgdG8gYXBwZWFyIGFmdGVyIHNvZnQgbGlua2luZyBoZWFkZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkzODIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgaGVhZGVyIGluY2x1ZGUg b3JkZXJpbmcgcnVsZSB0aGF0IGZvcmNlcyBzb2Z0IGxpbmtpbmcgaGVhZGVycyB0byBiZSBpbmNs dWRlZCBsYXN0IGluIGltcGxlbWVudGF0aW9uIChjcHAgYW5kCisgICAgICAgIG1tKSBmaWxlcyBz aG91bGRuJ3QgcmVhbGx5IGFwcGx5IHRvIFdlYktpdEFkZGl0aW9ucyBoZWFkZXJzLCBzaW5jZSB0 aG9zZSBhZGRpdGlvbnMgaGVhZGVycyBhcmUgb25seSBtZWFudCB0bworICAgICAgICBjb250YWlu IG1ldGhvZCBhbmQgZnVuY3Rpb24gaW1wbGVtZW50YXRpb25zIGFueXdheXMuCisKKyAgICAgICAg Rml4IHRoaXMgYnkgYWRkaW5nIGNvZGUgdG8gcmVjb2duaXplIFdlYktpdEFkZGl0aW9ucyBoZWFk ZXJzIGFzIGEgc3BlY2lhbCB0eXBlIG9mIGhlYWRlciwgYW5kIGV4ZW1wdCB0aGVzZQorICAgICAg ICBoZWFkZXJzIGZyb20gdGhlIGAnKlNvZnRMaW5rLmggaGVhZGVyIHNob3VsZCBiZSBpbmNsdWRl ZCBhZnRlciBhbGwgb3RoZXIgaGVhZGVycy4nYCBydWxlLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChfSW5jbHVkZVN0YXRlKToK KyAgICAgICAgKF9JbmNsdWRlU3RhdGUuY2hlY2tfbmV4dF9pbmNsdWRlX29yZGVyKToKKyAgICAg ICAgKF9jbGFzc2lmeV9pbmNsdWRlKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weTogQWRkIGEgdGVzdCBjYXNlIHRvIGV4ZXJjaXNlIHRo aXMgc2NlbmFyaW8uCisKIDIwMjAtMTEtMjQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBh cHBsZS5jb20+CiAKICAgICAgICAgW0NvbmN1cnJlbnQgZGlzcGxheSBsaXN0c10gUmVtb3ZlIGRp c3BsYXkgbGlzdCBpdGVtIGJhdGNoaW5nCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5CmluZGV4IDljYmY0OTkyNjQ2YzViZTNkYTBiZDI0Y2ViODVlZGU3NmMw ZmM2MmEuLmYzODY2Y2NlNGEyZTNmNDY3MDdkOWIyZjY4YWJhZWMzNmRjMTY5YTEgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xMjIsNiArMTIy LDcgQEAgX1BSSU1BUllfSEVBREVSID0gMQogX09USEVSX0hFQURFUiA9IDIKIF9TT0ZUX0xJTktf SEVBREVSID0gMwogX01PQ19IRUFERVIgPSA0CitfV0VCS0lUX0FERElUSU9OU19IRUFERVIgPSA1 CiAKIAogIyBGaWxlcyB3aGljaCBpcyBnZW5lcmF0ZWQgYnkgc29tZSBzb3J0IG9mIGNvZGUgZ2Vu ZXJhdG9yLgpAQCAtMjkyLDYgKzI5Myw3IEBAIGNsYXNzIF9JbmNsdWRlU3RhdGUoZGljdCk6CiAg ICAgICAgIF9PVEhFUl9IRUFERVI6ICdvdGhlciBoZWFkZXInLAogICAgICAgICBfU09GVF9MSU5L X0hFQURFUjogJypTb2Z0TGluay5oIGhlYWRlcicsCiAgICAgICAgIF9NT0NfSEVBREVSOiAnbW9j IGZpbGUnLAorICAgICAgICBfV0VCS0lUX0FERElUSU9OU19IRUFERVI6ICdXZWJLaXRBZGRpdGlv bnMgaGVhZGVyJywKICAgICAgICAgfQogICAgIF9TRUNUSU9OX05BTUVTID0gewogICAgICAgICBf SU5JVElBTF9TRUNUSU9OOiAiLi4uIG5vdGhpbmcuIiwKQEAgLTM2NCwxNSArMzY2LDE0IEBAIGNs YXNzIF9JbmNsdWRlU3RhdGUoZGljdCk6CiAgICAgICAgICAgICAgICAgaWYgcHJpbWFyeV9oZWFk ZXJfZXhpc3RzIGFuZCBub3QgZmlsZW5hbWUuZW5kc3dpdGgoJ1NvZnRMaW5rLmNwcCcpOgogICAg ICAgICAgICAgICAgICAgICBlcnJvcl9tZXNzYWdlID0gYmVmb3JlX2Vycm9yX21lc3NhZ2UKICAg ICAgICAgICAgIHNlbGYuX3NlY3Rpb24gPSBzZWxmLl9PVEhFUl9TRUNUSU9OCi0gICAgICAgIGVs c2U6Ci0gICAgICAgICAgICBhc3NlcnQgaGVhZGVyX3R5cGUgPT0gX1NPRlRfTElOS19IRUFERVIK KyAgICAgICAgZWxpZiBoZWFkZXJfdHlwZSA9PSBfU09GVF9MSU5LX0hFQURFUjoKICAgICAgICAg ICAgIGlmIGZpbGVfaXNfaGVhZGVyOgogICAgICAgICAgICAgICAgIGVycm9yX21lc3NhZ2UgPSAn e30gc2hvdWxkIG5ldmVyIGJlIGluY2x1ZGVkIGluIGEgaGVhZGVyLicuZm9ybWF0KAogICAgICAg ICAgICAgICAgICAgICBzZWxmLl9UWVBFX05BTUVTW2hlYWRlcl90eXBlXSkKICAgICAgICAgICAg IHNlbGYuX3NlY3Rpb24gPSBzZWxmLl9TT0ZUX0xJTktfU0VDVElPTgogICAgICAgICAgICAgc2Vs Zi5fdmlzaXRlZF9zb2Z0X2xpbmtfc2VjdGlvbiA9IFRydWUKIAotICAgICAgICBpZiBub3QgZXJy b3JfbWVzc2FnZSBhbmQgc2VsZi52aXNpdGVkX3NvZnRfbGlua19zZWN0aW9uKCkgYW5kIGhlYWRl cl90eXBlICE9IF9TT0ZUX0xJTktfSEVBREVSOgorICAgICAgICBpZiBub3QgZXJyb3JfbWVzc2Fn ZSBhbmQgc2VsZi52aXNpdGVkX3NvZnRfbGlua19zZWN0aW9uKCkgYW5kIGhlYWRlcl90eXBlICE9 IF9TT0ZUX0xJTktfSEVBREVSIGFuZCBoZWFkZXJfdHlwZSAhPSBfV0VCS0lUX0FERElUSU9OU19I RUFERVI6CiAgICAgICAgICAgICBlcnJvcl9tZXNzYWdlID0gJypTb2Z0TGluay5oIGhlYWRlciBz aG91bGQgYmUgaW5jbHVkZWQgYWZ0ZXIgYWxsIG90aGVyIGhlYWRlcnMuJwogCiAgICAgICAgIHJl dHVybiBlcnJvcl9tZXNzYWdlCkBAIC0zNDI4LDYgKzM0MjksOSBAQCBkZWYgX2NsYXNzaWZ5X2lu Y2x1ZGUoZmlsZW5hbWUsIGluY2x1ZGUsIGlzX3N5c3RlbSwgaW5jbHVkZV9zdGF0ZSk6CiAgICAg ICBfT1RIRVJfSEVBREVSCiAgICAgIiIiCiAKKyAgICBpZiAnV2ViS2l0QWRkaXRpb25zLycgaW4g aW5jbHVkZToKKyAgICAgICAgcmV0dXJuIF9XRUJLSVRfQURESVRJT05TX0hFQURFUgorCiAgICAg IyBJZiBpdCBpcyBhIHN5c3RlbSBoZWFkZXIgd2Uga25vdyBpdCBpcyBjbGFzc2lmaWVkIGFzIF9P VEhFUl9IRUFERVIuCiAgICAgaWYgaXNfc3lzdGVtIGFuZCBub3QgaW5jbHVkZS5zdGFydHN3aXRo KCdwdWJsaWMvJykgYW5kIG5vdCBpbmNsdWRlLnN0YXJ0c3dpdGgoJ3d0Zi8nKSBhbmQgbm90IGlu Y2x1ZGUuZW5kc3dpdGgoJ1NvZnRMaW5rLmgnKToKICAgICAgICAgcmV0dXJuIF9PVEhFUl9IRUFE RVIKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkKaW5kZXggNjc2YTFjNDdkZjgyYTRkOThhYzg3YmVlOTkxMWE1MTQ1YzU3NzBi Mi4uOWRmOGFmZmQ4NjlmYmU0ZWIxMTk1NDQ4NGQ5YmE2YTdkNTc0ZGZlZCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK QEAgLTM0MjcsNiArMzQyNywxNiBAQCBjbGFzcyBPcmRlck9mSW5jbHVkZXNUZXN0KENwcFN0eWxl VGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2lu Y2x1ZGUgPEZyYW1ld29yay9CYXIuaD5cbicsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICcqU29mdExpbmsuaCBoZWFkZXIgc2hvdWxkIGJlIGluY2x1ZGVkIGFmdGVy IGFsbCBvdGhlciBoZWFkZXJzLiAgW2J1aWxkL2luY2x1ZGVfb3JkZXJdIFs0XScpCiAKKyAgICAg ICAgIyBBbGxvdyBXZWJLaXRBZGRpdGlvbnMgaGVhZGVycyB0byBhcHBlYXIgYWZ0ZXIgKlNvZnRM aW5rLmggaGVhZGVycy4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hlY2so J0Zvby5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnI2lu Y2x1ZGUgImNvbmZpZy5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnI2luY2x1ZGUgIkZvby5oIlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICcjaW5jbHVkZSAiQUxvY2FsSGVhZGVyLmgiXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiRnJhbWV3b3JrU29mdExpbmsuaCJcbicKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlIDxXZWJLaXRBZGRp dGlvbnMvRm9vQWRkaXRpb25zLmg+XG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnJykKKwogICAgICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9ydWxlc19jaGVj aygnRm9vLmNwcCcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcj aW5jbHVkZSAiY29uZmlnLmgiXG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICcjaW5jbHVkZSAiRm9vLmgiXG4nCg==