<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>21937</bug_id>
          
          <creation_ts>2008-10-28 15:03:21 -0700</creation_ts>
          <short_desc>h1:first-letter is incorrectly inherited by run-in box</short_desc>
          <delta_ts>2022-07-11 16:33:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>525.x (Safari 3.1)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anantha Keesara">anantha</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>hamaji</cc>
    
    <cc>webkit</cc>
    
    <cc>yhayashi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>96928</commentid>
    <comment_count>0</comment_count>
    <who name="Anantha Keesara">anantha</who>
    <bug_when>2008-10-28 15:03:21 -0700</bug_when>
    <thetext>What steps will reproduce the problem?
1. Open the attached page.

What is the expected result?
A link named &quot;top&quot; 

What happens instead?
A link named &quot;Top&quot; - first letter in &quot;top&quot; should not be in uppercase

FF3: ok
Safari4(526), Chrome154.5: not ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>96929</commentid>
    <comment_count>1</comment_count>
      <attachid>24734</attachid>
    <who name="Anantha Keesara">anantha</who>
    <bug_when>2008-10-28 15:03:54 -0700</bug_when>
    <thetext>Created attachment 24734
Testcase</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>103705</commentid>
    <comment_count>2</comment_count>
      <attachid>26290</attachid>
    <who name="Robert Blaut">webkit</who>
    <bug_when>2008-12-29 04:58:43 -0800</bug_when>
    <thetext>Created attachment 26290
same test case as text/html

I found interesting behavior when you compare rendering of test case bug sending as text/html and application/xhtml+xml</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>103706</commentid>
    <comment_count>3</comment_count>
    <who name="Robert Blaut">webkit</who>
    <bug_when>2008-12-29 05:05:01 -0800</bug_when>
    <thetext>Confirmed as bug in both cases since &quot;Despite appearing visually part of the following block box, a run-in element still inherits properties from its parent in the source tree.&quot; [http://www.w3.org/TR/CSS21/visuren.html#run-in]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231630</commentid>
    <comment_count>4</comment_count>
    <who name="Yoshiki Hayashi">yhayashi</who>
    <bug_when>2010-05-28 03:36:21 -0700</bug_when>
    <thetext>It looks like you just have to skip run-ins when you try to find the block for :first-letter.

The test in the patch I&apos;m going to attach depends on the following bug because otherwise :first-letter applied letter doesn&apos;t show up in dumpAsText.

https://bugs.webkit.org/show_bug.cgi?id=39863</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>231632</commentid>
    <comment_count>5</comment_count>
      <attachid>57313</attachid>
    <who name="Yoshiki Hayashi">yhayashi</who>
    <bug_when>2010-05-28 03:38:48 -0700</bug_when>
    <thetext>Created attachment 57313
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>233193</commentid>
    <comment_count>6</comment_count>
      <attachid>57313</attachid>
    <who name="Shinichiro Hamaji">hamaji</who>
    <bug_when>2010-06-02 03:45:56 -0700</bug_when>
    <thetext>Comment on attachment 57313
Proposed Patch

Looks good, but putting r- for minor issues.

I&apos;ve noticed that with the following HTML

&lt;style type=&quot;text/css&quot;&gt;
  h1:first-letter {text-transform: uppercase;}
&lt;/style&gt;
&lt;h1 style=&quot;display:run-in;&quot;&gt;capitalized&lt;/h1&gt;&lt;div&gt;downcase&lt;/div&gt;

the text &quot;capitalized&quot; isn&apos;t capitalized even with this patch. Is this issue related to this bug? Or, should we file another bug to resolve this issue?


I think this patch depends on the patch in Bug 39863 so we should not land this patch without fixing Bug 39863. For such cases, please set commit-queue- to tell reviewers/committers that this patch should not be landed.


LayoutTests/ChangeLog:8
 +          Need a short description and bug URL (OOPS!)
This line should be gone.

WebCore/ChangeLog:8
 +          Need a short description and bug URL (OOPS!)
Unnecessary. Or, you might want to describe something.

LayoutTests/fast/css/first-letter-after-run-in.html:18
 +  &lt;div class=&quot;run-in&quot;&gt;run-in&lt;/div&gt;&lt;div class=&quot;upper&quot;&gt;test&lt;/div&gt;
I would say

&lt;div class=&quot;run-in&quot;&gt;not-capitalized&lt;/div&gt;&lt;div class=&quot;upper&quot;&gt;capitalized&lt;/div&gt;

or something like this so we can remove the description about the expectation (&quot;If you see...&quot;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>233687</commentid>
    <comment_count>7</comment_count>
    <who name="Yoshiki Hayashi">yhayashi</who>
    <bug_when>2010-06-03 03:25:25 -0700</bug_when>
    <thetext>Thank you for review!

(In reply to comment #6)
&gt; (From update of attachment 57313 [details])
&gt; Looks good, but putting r- for minor issues.
&gt; 
&gt; I&apos;ve noticed that with the following HTML
&gt; 
&gt; &lt;style type=&quot;text/css&quot;&gt;
&gt;   h1:first-letter {text-transform: uppercase;}
&gt; &lt;/style&gt;
&gt; &lt;h1 style=&quot;display:run-in;&quot;&gt;capitalized&lt;/h1&gt;&lt;div&gt;downcase&lt;/div&gt;
&gt; 
&gt; the text &quot;capitalized&quot; isn&apos;t capitalized even with this patch. Is this issue related to this bug? Or, should we file another bug to resolve this issue?

That&apos;s a different bug.  Right now, WebKit doesn&apos;t apply first-letter to inline elements.  In this case, the h1 with run-in is converted to an inline element and inserted as the first element of the div so it won&apos;t get :first-letter.  The following link shows that div gets :first-letter while span does not.

http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cstyle%3E%0Adiv%3A%3Afirst-letter%20%7B%0A%20%20text-transform%3A%20uppercase%3B%0A%7D%0Aspan%3A%3Afirst-letter%20%7B%0A%20%20text-transform%3A%20uppercase%3B%0A%7D%0A%3C%2Fstyle%3E%0A%0A%3Cdiv%3E%0Atest%0A%3C%2Fdiv%3E%0A%0A%3Cspan%3E%0Atest%0A%3C%2Fspan%3E%0A&amp;ohh=1&amp;ohj=1&amp;jt=&amp;ojh=1&amp;ojj=1&amp;ms=100&amp;oth=0&amp;otj=0&amp;cex=1

&gt; 
&gt; I think this patch depends on the patch in Bug 39863 so we should not land this patch without fixing Bug 39863. For such cases, please set commit-queue- to tell reviewers/committers that this patch should not be landed.
&gt; 
&gt; 
&gt; LayoutTests/ChangeLog:8
&gt;  +          Need a short description and bug URL (OOPS!)
&gt; This line should be gone.
&gt; 
&gt; WebCore/ChangeLog:8
&gt;  +          Need a short description and bug URL (OOPS!)
&gt; Unnecessary. Or, you might want to describe something.

Oops.  Removed.

&gt; LayoutTests/fast/css/first-letter-after-run-in.html:18
&gt;  +  &lt;div class=&quot;run-in&quot;&gt;run-in&lt;/div&gt;&lt;div class=&quot;upper&quot;&gt;test&lt;/div&gt;
&gt; I would say
&gt; 
&gt; &lt;div class=&quot;run-in&quot;&gt;not-capitalized&lt;/div&gt;&lt;div class=&quot;upper&quot;&gt;capitalized&lt;/div&gt;
&gt; 
&gt; or something like this so we can remove the description about the expectation (&quot;If you see...&quot;)

Done.

I also added a test case where run-in stays as a block level element and if :first-letter gets applied to that element.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>233688</commentid>
    <comment_count>8</comment_count>
      <attachid>57749</attachid>
    <who name="Yoshiki Hayashi">yhayashi</who>
    <bug_when>2010-06-03 03:29:10 -0700</bug_when>
    <thetext>Created attachment 57749
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>233692</commentid>
    <comment_count>9</comment_count>
      <attachid>57749</attachid>
    <who name="Shinichiro Hamaji">hamaji</who>
    <bug_when>2010-06-03 03:44:45 -0700</bug_when>
    <thetext>Comment on attachment 57749
Proposed Patch

Looks good. Thanks for your description and updating the patch!

&gt; That&apos;s a different bug.  Right now, WebKit doesn&apos;t apply first-letter to inline elements.  In this case, the h1 with run-in is converted to an inline element and inserted as the first element of the div so it won&apos;t get :first-letter.  The following link shows that div gets :first-letter while span does not.

Ah, I didn&apos;t notice run-in box becomes an inline element. It seems the current spec says we don&apos;t need to apply ::first-letter for inline elements, so this would be a non-issue.

http://dev.w3.org/csswg/selectors3/#application-in-css</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>258557</commentid>
    <comment_count>10</comment_count>
      <attachid>57749</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2010-07-30 23:23:18 -0700</bug_when>
    <thetext>Comment on attachment 57749
Proposed Patch

LayoutTests/fast/css/first-letter-after-run-in-expected.txt:1
 +  not-capitalized
Can you use the script-tests framework, to create a better testcase, that actually tells what you&apos;re checkink. Of course it&apos;s clear from the testcase, but I think you could do better and explicitely explain what&apos;s happening, in the expected-txt output.

Can&apos;t review the actual RenderBlock change, you&apos;ll need to ask rendering gurus for that (Dave Hyatt / Dan Bernstein..)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1882210</commentid>
    <comment_count>11</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2022-07-11 16:33:51 -0700</bug_when>
    <thetext>Safari, Chrome, and Firefox show the same rendering behavior for this test case. I do not believe any further compatibility issue remains.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>24734</attachid>
            <date>2008-10-28 15:03:54 -0700</date>
            <delta_ts>2008-10-28 15:03:54 -0700</delta_ts>
            <desc>Testcase</desc>
            <filename>mytest.xhtml</filename>
            <type>application/xhtml+xml</type>
            <size>361</size>
            <attacher name="Anantha Keesara">anantha</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAiaHR0cDov
L3d3dy53My5vcmcvVFIveGh0bWwxMS9EVEQveGh0bWwxMS5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0
dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJwdC1iciI+DQo8aGVhZD4NCjxz
dHlsZSB0eXBlPSJ0ZXh0L2NzcyI+DQoJaDE6Zmlyc3QtbGV0dGVyIHt0ZXh0LXRyYW5zZm9ybTog
dXBwZXJjYXNlO30NCglkaXYge2Rpc3BsYXk6IHJ1bi1pbjt9DQo8L3N0eWxlPg0KPC9oZWFkPg0K
PGJvZHk+DQo8ZGl2PjxhIGhyZWY9IiMiPnRvcDwvYT48L2Rpdj4NCjxoMT51cHBlcmNhc2U8L2gx
Pg0KPC9ib2R5Pg0KPC9odG1sPg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>26290</attachid>
            <date>2008-12-29 04:58:43 -0800</date>
            <delta_ts>2008-12-29 04:58:43 -0800</delta_ts>
            <desc>same test case as text/html</desc>
            <filename>mytest.html</filename>
            <type>text/html</type>
            <size>361</size>
            <attacher name="Robert Blaut">webkit</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAiaHR0cDov
L3d3dy53My5vcmcvVFIveGh0bWwxMS9EVEQveGh0bWwxMS5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0
dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJwdC1iciI+DQo8aGVhZD4NCjxz
dHlsZSB0eXBlPSJ0ZXh0L2NzcyI+DQoJaDE6Zmlyc3QtbGV0dGVyIHt0ZXh0LXRyYW5zZm9ybTog
dXBwZXJjYXNlO30NCglkaXYge2Rpc3BsYXk6IHJ1bi1pbjt9DQo8L3N0eWxlPg0KPC9oZWFkPg0K
PGJvZHk+DQo8ZGl2PjxhIGhyZWY9IiMiPnRvcDwvYT48L2Rpdj4NCjxoMT51cHBlcmNhc2U8L2gx
Pg0KPC9ib2R5Pg0KPC9odG1sPg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57313</attachid>
            <date>2010-05-28 03:38:48 -0700</date>
            <delta_ts>2010-06-03 03:29:04 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>bug-21937-20100528193846.patch</filename>
            <type>text/plain</type>
            <size>3824</size>
            <attacher name="Yoshiki Hayashi">yhayashi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA3MDYwYjI2NDQ5NGIwYzdiZDAwZmUzMTdiZTBhNjIyOWYyNDAzNDZkLi5lZGI5ZWUx
OTUxZGJlZTkxYjc0ZGNhMDYwMGRjY2U4YTI2Mzg4NTk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTAtMDUtMjggIFlvc2hpa2kgSGF5YXNoaSAgPHloYXlhc2hpQGdvb2dsZS5jb20+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgOmZpcnN0LWxldHRl
ciBzaG91bGQgbm90IGJlIGFwcGxpZWQgdG8gcnVuLWluIGJ1dCByYXRoZXIgdG8gdGhlIHNwZWNp
ZmllZCBib3guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMTkzNworCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQgYnVnIFVSTCAo
T09QUyEpCisKKyAgICAgICAgKiBmYXN0L2Nzcy9maXJzdC1sZXR0ZXItYWZ0ZXItcnVuLWluLWV4
cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvZmlyc3QtbGV0dGVyLWFmdGVy
LXJ1bi1pbi5odG1sOiBBZGRlZC4KKwogMjAxMC0wNS0yNyAgUm9sYW5kIFN0ZWluZXIgIDxyb2xh
bmRzdGVpbmVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUYW11cmEgS2Vu
dC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2ZpcnN0LWxldHRlci1hZnRlci1y
dW4taW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZmlyc3QtbGV0dGVyLWFm
dGVyLXJ1bi1pbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjQwZDVhNTM0ZGUzMDU1MGRlZDI4
MTliMjFlZjBhNDNjODI0MGQ5YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv
Y3NzL2ZpcnN0LWxldHRlci1hZnRlci1ydW4taW4tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBA
QAorVGhpcyB0ZXN0cyA6Zmlyc3QtbGV0dGVyIGlzIGFwcGxpZWQgdG8gc3BlY2lmaWVkIGJveCBy
YXRoZXIgdGhhbiB0aGUgcnVuLWluLiBJZiB5b3Ugc2VlICJydW4taW5UZXN0IiwgdGhlbiB0aGUg
dGVzdCBoYXMgcGFzc2VkLiBJZiB5b3Ugc2VlICJSdW4taW50ZXN0IiwgdGhlbiB0aGUgdGVzdCBo
YXMgZmFpbGVkLgorCitydW4taW4KK1Rlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv
Y3NzL2ZpcnN0LWxldHRlci1hZnRlci1ydW4taW4uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3Nz
L2ZpcnN0LWxldHRlci1hZnRlci1ydW4taW4uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl
eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zY2U0NzdjZDc0Nzg1
YzM5NWEyZWE3YmZkOTk3MTFhY2Y1MDc0OGQ0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz
dHMvZmFzdC9jc3MvZmlyc3QtbGV0dGVyLWFmdGVyLXJ1bi1pbi5odG1sCkBAIC0wLDAgKzEsMjEg
QEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CitkaXYucnVuLWluIHsKKyAgZGlzcGxheTogcnVu
LWluOworfQorZGl2LnVwcGVyOmZpcnN0LWxldHRlciB7CisgIHRleHQtdHJhbnNmb3JtOiB1cHBl
cmNhc2U7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy
b2xsZXIpCisgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0Pgor
PC9oZWFkPgorPGJvZHk+Cis8cD5UaGlzIHRlc3RzIDpmaXJzdC1sZXR0ZXIgaXMgYXBwbGllZCB0
byBzcGVjaWZpZWQgYm94IHJhdGhlciB0aGFuIHRoZSBydW4taW4uIElmIHlvdSBzZWUgInJ1bi1p
blRlc3QiLCB0aGVuIHRoZSB0ZXN0IGhhcyBwYXNzZWQuICBJZiB5b3Ugc2VlICJSdW4taW50ZXN0
IiwgdGhlbiB0aGUgdGVzdCBoYXMgZmFpbGVkLjwvcD4KKzxkaXYgY2xhc3M9InJ1bi1pbiI+cnVu
LWluPC9kaXY+PGRpdiBjbGFzcz0idXBwZXIiPnRlc3Q8L2Rpdj4KKzwvc2NyaXB0PgorPC9ib2R5
PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n
ZUxvZwppbmRleCBhOTEzZDYyZjhjYmU2ZWJkYjcxMTY1NGI1NWEzOTM5NTNiNmFkN2U1Li43NWI1
Zjg0ZDRiODM5MTlkNDg0ZTMyZTljZTlmYTM3YTgyNjI3MzlkIDEwMDY0NAotLS0gYS9XZWJDb3Jl
L0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEw
LTA1LTI4ICBZb3NoaWtpIEhheWFzaGkgIDx5aGF5YXNoaUBnb29nbGUuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDpmaXJzdC1sZXR0ZXIgc2hv
dWxkIG5vdCBiZSBhcHBsaWVkIHRvIHJ1bi1pbiBidXQgcmF0aGVyIHRvIHRoZSBzcGVjaWZpZWQg
Ym94LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5
MzcKKworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMh
KQorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL2ZpcnN0LWxldHRlci1hZnRlci1ydW4taW4uaHRt
bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OlJlbmRlckJsb2NrOjp1cGRhdGVGaXJzdExldHRlcik6CisKIDIwMTAtMDUtMjcgIE1PUklU
QSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLiBG
aXhlZCB0eXBvCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAg
Yi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggYjkyMWQ1MmIyMmY4OTE2
ZDBiMTJkYzQwOTI5YmIyZDQyNGYwMzJkYy4uYmRlZmZhYzdjZDdlYjhjZmNkMzM4NjM5YmU2OGRi
YWJmODU5ZTM2NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw
CisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtNDg2OCw3ICs0ODY4
LDkgQEAgdm9pZCBSZW5kZXJCbG9jazo6dXBkYXRlRmlyc3RMZXR0ZXIoKQogICAgIC8vIERyaWxs
IGludG8gaW5saW5lcyBsb29raW5nIGZvciBvdXIgZmlyc3QgdGV4dCBjaGlsZC4KICAgICBSZW5k
ZXJPYmplY3QqIGN1cnJDaGlsZCA9IGZpcnN0TGV0dGVyQmxvY2stPmZpcnN0Q2hpbGQoKTsKICAg
ICB3aGlsZSAoY3VyckNoaWxkICYmICgoIWN1cnJDaGlsZC0+aXNSZXBsYWNlZCgpICYmICFjdXJy
Q2hpbGQtPmlzUmVuZGVyQnV0dG9uKCkgJiYgIWN1cnJDaGlsZC0+aXNNZW51TGlzdCgpKSB8fCBj
dXJyQ2hpbGQtPmlzRmxvYXRpbmdPclBvc2l0aW9uZWQoKSkgJiYgIWN1cnJDaGlsZC0+aXNUZXh0
KCkpIHsKLSAgICAgICAgaWYgKGN1cnJDaGlsZC0+aXNGbG9hdGluZ09yUG9zaXRpb25lZCgpKSB7
CisgICAgICAgIGlmIChjdXJyQ2hpbGQtPmlzUnVuSW4oKSkKKyAgICAgICAgICAgIGN1cnJDaGls
ZCA9IGN1cnJDaGlsZC0+bmV4dFNpYmxpbmcoKTsKKyAgICAgICAgZWxzZSBpZiAoY3VyckNoaWxk
LT5pc0Zsb2F0aW5nT3JQb3NpdGlvbmVkKCkpIHsKICAgICAgICAgICAgIGlmIChjdXJyQ2hpbGQt
PnN0eWxlKCktPnN0eWxlVHlwZSgpID09IEZJUlNUX0xFVFRFUikgewogICAgICAgICAgICAgICAg
IGN1cnJDaGlsZCA9IGN1cnJDaGlsZC0+Zmlyc3RDaGlsZCgpOwogICAgICAgICAgICAgICAgIGJy
ZWFrOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>57749</attachid>
            <date>2010-06-03 03:29:10 -0700</date>
            <delta_ts>2010-07-30 23:23:18 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>bug-21937-20100603192908.patch</filename>
            <type>text/plain</type>
            <size>3487</size>
            <attacher name="Yoshiki Hayashi">yhayashi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA0ZDQ2N2Q0YTIwOTc5ZDk4M2E1ZmQwYjUyNTQwNThmNThjOTgzMDA0Li41ZGZjM2Qx
ZGY5ODljNmQwNmFiY2JkZWYwZTk2MDI5OTZmOTNiYWI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMTAtMDYtMDMgIFlvc2hpa2kgSGF5YXNoaSAgPHloYXlhc2hpQGdvb2dsZS5jb20+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgOmZpcnN0LWxldHRl
ciBzaG91bGQgbm90IGJlIGFwcGxpZWQgdG8gcnVuLWluIGJ1dCByYXRoZXIgdG8gdGhlIHNwZWNp
ZmllZCBib3guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMTkzNworCisgICAgICAgICogZmFzdC9jc3MvZmlyc3QtbGV0dGVyLWFmdGVyLXJ1bi1pbi1l
eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2ZpcnN0LWxldHRlci1hZnRl
ci1ydW4taW4uaHRtbDogQWRkZWQuCisKIDIwMTAtMDYtMDMgIEtlbnQgVGFtdXJhICA8dGtlbnRA
Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFRlc3QgZXhwZWN0YXRpb24gdXBk
YXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZmlyc3QtbGV0dGVyLWFmdGVy
LXJ1bi1pbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXIt
YWZ0ZXItcnVuLWluLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNDg5OWUxODQ5Y2U0NTAyMmQ5
MzFlYTNkNGUwNWEzNjNhMjIwMjc2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz
dC9jc3MvZmlyc3QtbGV0dGVyLWFmdGVyLXJ1bi1pbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0
IEBACitub3QtY2FwaXRhbGl6ZWQKK0NhcGl0YWxpemVkCitDYXBpdGFsaXplZAorbm90LWNhcGl0
YWxpemVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYWZ0
ZXItcnVuLWluLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9maXJzdC1sZXR0ZXItYWZ0ZXIt
cnVuLWluLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMGIzNTUyZmFjYjBhOWZhMWYxZGMyOGQ0NTI1MTRlMDM1
OTg3MmU5NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2ZpcnN0LWxl
dHRlci1hZnRlci1ydW4taW4uaHRtbApAQCAtMCwwICsxLDIxIEBACis8aHRtbD4KKzxoZWFkPgor
PHN0eWxlPgorZGl2LnJ1bi1pbiB7CisgIGRpc3BsYXk6IHJ1bi1pbjsKK30KK2Rpdi51cHBlcjpm
aXJzdC1sZXR0ZXIgeworICB0ZXh0LXRyYW5zZm9ybTogdXBwZXJjYXNlOworfQorPC9zdHlsZT4K
KzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICBsYXlvdXRUZXN0
Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGRp
diBjbGFzcz0icnVuLWluIj5ub3QtY2FwaXRhbGl6ZWQ8L2Rpdj48ZGl2IGNsYXNzPSJ1cHBlciI+
Y2FwaXRhbGl6ZWQ8L2Rpdj4KKzxkaXYgY2xhc3M9InJ1bi1pbiB1cHBlciI+Y2FwaXRhbGl6ZWQ8
L2Rpdj48c3Bhbj5ub3QtY2FwaXRhbGl6ZWQ8L3NwYW4+Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwv
aHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cK
aW5kZXggOTU1MTg3YzY0Yjg3N2JiNWMzZmQ5YzVjMWNkNzRhYmM0ZjkxZWU1Yy4uZGM5NGExMTdm
Mzc1YmVjMTFiNmU3ZjU0MWFlYTM2YzMxNzVhMmQ0MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu
Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0w
MyAgWW9zaGlraSBIYXlhc2hpICA8eWhheWFzaGlAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA6Zmlyc3QtbGV0dGVyIHNob3VsZCBu
b3QgYmUgYXBwbGllZCB0byBydW4taW4gYnV0IHJhdGhlciB0byB0aGUgc3BlY2lmaWVkIGJveC4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTM3CisK
KyAgICAgICAgVGVzdDogZmFzdC9jc3MvZmlyc3QtbGV0dGVyLWFmdGVyLXJ1bi1pbi5odG1sCisK
KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6
UmVuZGVyQmxvY2s6OnVwZGF0ZUZpcnN0TGV0dGVyKToKKwogMjAxMC0wNi0wMyAgS2ltIEdyw7Zu
aG9sbSAgPGtpbS4xLmdyb25ob2xtQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT
aW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr
LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA5YTZiYjJlY2Rm
ZWI3NTUxNzhkYmIxZjlhMjljZjFkM2UyZDk0YTVlLi44ZjdjNDc5ZDM4YzQ2NDg1YTZiYzc2NDEw
MmFjNGM0ZTJjMzI5NjczIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j
ay5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC01MDg0LDcg
KzUwODQsOSBAQCB2b2lkIFJlbmRlckJsb2NrOjp1cGRhdGVGaXJzdExldHRlcigpCiAgICAgLy8g
RHJpbGwgaW50byBpbmxpbmVzIGxvb2tpbmcgZm9yIG91ciBmaXJzdCB0ZXh0IGNoaWxkLgogICAg
IFJlbmRlck9iamVjdCogY3VyckNoaWxkID0gZmlyc3RMZXR0ZXJCbG9jay0+Zmlyc3RDaGlsZCgp
OwogICAgIHdoaWxlIChjdXJyQ2hpbGQgJiYgKCghY3VyckNoaWxkLT5pc1JlcGxhY2VkKCkgJiYg
IWN1cnJDaGlsZC0+aXNSZW5kZXJCdXR0b24oKSAmJiAhY3VyckNoaWxkLT5pc01lbnVMaXN0KCkp
IHx8IGN1cnJDaGlsZC0+aXNGbG9hdGluZ09yUG9zaXRpb25lZCgpKSAmJiAhY3VyckNoaWxkLT5p
c1RleHQoKSkgewotICAgICAgICBpZiAoY3VyckNoaWxkLT5pc0Zsb2F0aW5nT3JQb3NpdGlvbmVk
KCkpIHsKKyAgICAgICAgaWYgKGN1cnJDaGlsZC0+aXNSdW5JbigpKQorICAgICAgICAgICAgY3Vy
ckNoaWxkID0gY3VyckNoaWxkLT5uZXh0U2libGluZygpOworICAgICAgICBlbHNlIGlmIChjdXJy
Q2hpbGQtPmlzRmxvYXRpbmdPclBvc2l0aW9uZWQoKSkgewogICAgICAgICAgICAgaWYgKGN1cnJD
aGlsZC0+c3R5bGUoKS0+c3R5bGVUeXBlKCkgPT0gRklSU1RfTEVUVEVSKSB7CiAgICAgICAgICAg
ICAgICAgY3VyckNoaWxkID0gY3VyckNoaWxkLT5maXJzdENoaWxkKCk7CiAgICAgICAgICAgICAg
ICAgYnJlYWs7Cg==
</data>
<flag name="review"
          id="42391"
          type_id="1"
          status="-"
          setter="zimmermann"
    />
          </attachment>
      

    </bug>

</bugzilla>