219348 2020-11-30 05:05:53 -0800 [GStreamer] Common module should use a dedicated logging category 2020-12-01 09:24:16 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia ews-watchlist gustavo menard vjaquez webkit-bug-importer oldest_to_newest 1710571 0 pnormand 2020-11-30 05:05:53 -0800 We can't assume the player debug category has been initialized when logging in the common module, because that module can be used from WebAudio backend components, for instance: STDERR: 0:00:02.188465738 132 0x248a640 DEBUG webkitaudioprovider AudioSourceProviderGStreamer.cpp:306:handleNewDeinterleavePad: New pad <deinterleave:src_0> STDERR: 0:00:02.188840904 132 0x248a640 DEBUG webkitaudioprovider AudioSourceProviderGStreamer.cpp:376:deinterleavePadsConfigured: Deinterleave configured, notifying client STDERR: STDERR: (WebKitWebProcess:132): GStreamer-CRITICAL **: 04:55:44.079: gst_debug_log_valist: assertion 'category != NULL' failed Thread 1 (Thread 0x7f0517bfa180 (LWP 132)): #0 g_logv (log_domain=0x7f051a9bd240 <g_log_domain_gstreamer> "GStreamer", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../glib/gmessages.c:1377 #1 0x00007f0519fdfad3 in g_log (log_domain=<optimized out>, log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7f051a0358df "%s: assertion '%s' failed") at ../glib/gmessages.c:1415 #2 0x00007f0519fe02cd in g_return_if_fail_warning (log_domain=<optimized out>, pretty_function=pretty_function@entry=0x7f051a9cc070 <__func__.12> "gst_debug_log_valist", expression=<optimized out>) at ../glib/g messages.c:2771 #3 0x00007f051a948bfc in gst_debug_log_valist (category=<optimized out>, level=<optimized out>, file=<optimized out>, function=<optimized out>, line=388, object=<optimized out>, format=0x7f0534f3806c "State cha nged (old: %s, new: %s, pending: %s)", args=0x7ffde8ddf8b0) at ../gst/gstinfo.c:568 #4 0x00007f051a948cff in gst_debug_log (category=<optimized out>, level=<optimized out>, file=<optimized out>, function=<optimized out>, line=<optimized out>, object=<optimized out>, format=0x7f0534f3806c "Stat e changed (old: %s, new: %s, pending: %s)") at ../gst/gstinfo.c:512 #5 0x00007f052f49c5ac in WebCore::simpleBusMessageCallback(_GstBus*, _GstMessage*, _GstBin*) (message=0x25b4800 [GstMessage], pipeline=0x258a0e0 [GstPipeline|WebAudioProvider_MediaStreamTrack_f4cb5d3f-a1c7-487c -9fa5-7b5b723b84a3]) at ../../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:385 #6 0x00007f051a0ced04 in g_cclosure_marshal_VOID__BOXEDv (closure=0x250f220, return_value=<optimized out>, instance=<optimized out>, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x214da10) at ../gobject/gmarshal.c:1686 #7 0x00007f051a0cbb46 in _g_closure_invoke_va (closure=closure@entry=0x250f220, return_value=return_value@entry=0x0, instance=instance@entry=0x2148720, args=args@entry=0x7ffde8ddfcd0, n_params=1, param_types=0x 214da10) at ../gobject/gclosure.c:873 #8 0x00007f051a0e4b5f in g_signal_emit_valist (instance=0x2148720, signal_id=<optimized out>, detail=236, var_args=var_args@entry=0x7ffde8ddfcd0) at ../gobject/gsignal.c:3403 #9 0x00007f051a0e4d43 in g_signal_emit (instance=instance@entry=0x2148720, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3550 #10 0x00007f051a92142c in gst_bus_async_signal_func (bus=0x2148720 [GstBus|bus3], message=0x25b4800 [GstMessage], data=<optimized out>) at ../gst/gstbus.c:1295 #11 0x00007f051a92232c in gst_bus_source_dispatch (source=0x250f100, callback=0x7f051a9213d0 <gst_bus_async_signal_func>, user_data=0x0) at ../gst/gstbus.c:851 #12 0x00007f0519fd804f in g_main_dispatch (context=0x2107970) at ../glib/gmain.c:3325 #13 g_main_context_dispatch (context=0x2107970) at ../glib/gmain.c:4016 #14 0x00007f0519fd83f8 in g_main_context_iterate (context=0x2107970, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4092 #15 0x00007f0519fd8713 in g_main_loop_run (loop=0x2081a00) at ../glib/gmain.c:4290 #16 0x00007f0521074fb8 in WTF::RunLoop::run() () at ../../Source/WTF/wtf/glib/RunLoopGLib.cpp:108 #17 0x00007f052f2a6028 in WebKit::AuxiliaryProcessMain<WebKit::WebProcess, WebKit::WebProcessMainGtk>(int, char**) (argc=4, argv=0x7ffde8de0118) at ../../Source/WebKit/Shared/AuxiliaryProcessMain.h:68 #18 0x00007f052f2a5d3b in WebKit::WebProcessMain(int, char**) (argc=4, argv=0x7ffde8de0118) at ../../Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:66 #19 0x0000000000400c56 in main(int, char**) (argc=4, argv=0x7ffde8de0118) at ../../Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp:45 1711043 1 415136 pnormand 2020-12-01 08:25:36 -0800 Created attachment 415136 Patch 1711055 2 ews-feeder 2020-12-01 09:23:28 -0800 Committed r270301: <https://trac.webkit.org/changeset/270301> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415136. 1711056 3 webkit-bug-importer 2020-12-01 09:24:16 -0800 <rdar://problem/71853400> 415136 2020-12-01 08:25:36 -0800 2020-12-01 09:23:28 -0800 Patch bug-219348-20201201082534.patch text/plain 2292 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGNmODVjYzI5NjQzZDBl YTU2Yzg0MWU3ZWQ5Yjc2ZWE4M2EzMTdlZS4uNDhkZGFlMDYzYzIwNGRmZDdlYmZjOTZmYjkxNGQx NDU4MzdiMjRjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEyLTAxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBDb21tb24gbW9kdWxlIHNob3VsZCB1c2UgYSBkZWRpY2F0ZWQgbG9nZ2luZyBjYXRlZ29yeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MzQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSB0 aGlzIG1vZHVsZSBjYW4gYmUgdXNlZCBvdXRzaWRlIG9mIHRoZSBNZWRpYVBsYXllciBzY29wZSwg d2UgY2Fubm90IGFzc3VtZSB0aGUKKyAgICAgICAgTWVkaWFQbGF5ZXIgZGVidWcgY2F0ZWdvcnkg d2lsbCBiZSBpbml0aWFsaXplZCBpbiB0aW1lIHdoZW4gR1NUX0RFQlVHIGxvZ3MgbmVlZCB0byBi ZQorICAgICAgICBlbWl0dGVkIGZyb20gR1N0cmVhbWVyQ29tbW9uLiBTbyBpdCBpcyBzYWZlciB0 byBpbnRyb2R1Y2UgYSBuZXcsIHN0YW5kYWxvbmUsIGxvZ2dpbmcKKyAgICAgICAgY2F0ZWdvcnkg Zm9yIHRoaXMgbW9kdWxlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dTdHJlYW1lckNvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbml0aWFsaXplR1N0cmVh bWVyKToKKwogMjAyMC0xMi0wMSAgVGV0c3VoYXJ1IE9oemVraSAgPHRldHN1aGFydS5vaHpla2lA Z21haWwuY29tPgogCiAgICAgICAgIFtXZWJJRExdIE1vdmUgU2hhZG93Um9vdEluaXQgdG8gZGVk aWNhdGVkIGlkbCBmaWxlIGZyb20gRWxlbWVudC5pZGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5j cHAKaW5kZXggN2NiODE5YzA1ZTAxYTkzMTBmYmYxZTEyY2RmOTY1OGQ2ZWFkMzE4YS4uNTIwOWVm MjExODEyYmJhMTgxZDNhZjJhMThjNGU2MTdmMGRlZDFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNv bW1vbi5jcHAKQEAgLTY1LDggKzY1LDggQEAKICNpbmNsdWRlICJXZWJLaXRXZWJTb3VyY2VHU3Ry ZWFtZXIuaCIKICNlbmRpZgogCi1HU1RfREVCVUdfQ0FURUdPUllfRVhURVJOKHdlYmtpdF9tZWRp YV9wbGF5ZXJfZGVidWcpOwotI2RlZmluZSBHU1RfQ0FUX0RFRkFVTFQgd2Via2l0X21lZGlhX3Bs YXllcl9kZWJ1ZworR1NUX0RFQlVHX0NBVEVHT1JZKHdlYmtpdF9nc3RfY29tbW9uX2RlYnVnKTsK KyNkZWZpbmUgR1NUX0NBVF9ERUZBVUxUIHdlYmtpdF9nc3RfY29tbW9uX2RlYnVnCiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIApAQCAtMjU1LDYgKzI1NSw3IEBAIGJvb2wgaW5pdGlhbGl6ZUdTdHJl YW1lcihPcHRpb25hbDxWZWN0b3I8U3RyaW5nPj4mJiBvcHRpb25zKQogICAgICAgICBpc0dTdHJl YW1lckluaXRpYWxpemVkID0gZ3N0X2luaXRfY2hlY2soJmFyZ2MsICZhcmd2LCAmZXJyb3Iub3V0 UHRyKCkpOwogICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKGlzR1N0cmVhbWVySW5pdGlhbGl6 ZWQsICJHU3RyZWFtZXIgaW5pdGlhbGl6YXRpb24gZmFpbGVkOiAlcyIsIGVycm9yID8gZXJyb3It Pm1lc3NhZ2UgOiAidW5rbm93biBlcnJvciBvY2N1cnJlZCIpOwogICAgICAgICBnX3N0cmZyZWV2 KGFyZ3YpOworICAgICAgICBHU1RfREVCVUdfQ0FURUdPUllfSU5JVCh3ZWJraXRfZ3N0X2NvbW1v bl9kZWJ1ZywgIndlYmtpdGNvbW1vbiIsIDAsICJXZWJLaXQgQ29tbW9uIHV0aWxpdGllcyIpOwog CiAgICAgICAgIGlmIChpc0Zhc3RNYWxsb2NFbmFibGVkKCkpIHsKICAgICAgICAgICAgIGNvbnN0 IGNoYXIqIGRpc2FibGVGYXN0TWFsbG9jID0gZ2V0ZW52KCJXRUJLSVRfR1NUX0RJU0FCTEVfRkFT VF9NQUxMT0MiKTsK