219340 2020-11-29 20:17:36 -0800 REGRESSION(r270185) [GTK] Some webgl failures after multivalue setter refactor 2021-03-15 04:16:15 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219256 InRadar P2 Normal --- 1 lmoura kkinnunen cdumez changseok dino esprehn+autocc ews-watchlist graouts gyuyoung.kim kkinnunen kondapallykalyan simon.fraser webkit-bug-importer oldest_to_newest 1710526 0 lmoura 2020-11-29 20:17:36 -0800 fast/canvas/webgl/gl-bind-attrib-location-test.html fast/canvas/webgl/gl-bind-attrib-mapped-names.html webgl/1.0.3/conformance/attribs/gl-disabled-vertex-attrib.html webgl/1.0.3/conformance/extensions/angle-instanced-arrays-out-of-bounds.html webgl/1.0.3/conformance/programs/gl-bind-attrib-location-long-names-test.html webgl/1.0.3/conformance/programs/gl-bind-attrib-location-test.html webgl/1.0.3/conformance/rendering/draw-elements-out-of-bounds.html All with messages like this in stderr (varying the sizes): Mesa: User error: GL_INVALID_VALUE in glBufferSubData(offset 0 + size 192 > buffer size 48) Most recent build with errors: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r270231%20(17200)/results.html Sample diff from webgl/1.0.3/conformance/programs/gl-bind-attrib-location-test.html --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webgl/1.0.3/conformance/programs/gl-bind-attrib-location-test-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/webgl/1.0.3/conformance/programs/gl-bind-attrib-location-test-actual.txt @@ -1,5 +1,22 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-test.html -[ PASS ] All tests passed +[ 1: PASS ] gl is non-null. +[ 2: PASS ] getError was expected value: INVALID_OPERATION : bindAttribLocation should return INVALID_OPERATION if name starts with 'gl_' +[ 3: PASS ] getError was expected value: INVALID_OPERATION : bindAttribLocation should return INVALID_OPERATION if name starts with 'gl_' +[ 4: PASS ] program linked successfully +[ 5: PASS ] location of vPosition should be 3 +[ 6: PASS ] location of vColor should be 2 +[ 7: PASS ] First line should be all black +[ 8: PASS ] Line 15 should be red for at least 10 rgba pixels starting 20 pixels in +[ 9: PASS ] Last line should be all black +[ 10: PASS ] program linked successfully +[ 11: PASS ] location of vPosition should be 3 +[ 12: PASS ] location of vColor should be 0 +[ 13: PASS ] First line should be all black +[ 14: FAIL ] at (20, 15) expected: 255,0,0,255 was 0,0,0,0 +[ 15: PASS ] Last line should be all black +[ 16: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : +[ 17: PASS ] successfullyParsed is true +[ FAIL ] 2 failures reported 1710536 1 415006 kkinnunen 2020-11-30 00:06:58 -0800 Created attachment 415006 Patch 1710537 2 kkinnunen 2020-11-30 00:09:38 -0800 Thanks for the investigation. The GTK EWS bots were green when I submitted the patch that regressed. Do you (or anyone) know why is this? My mental model is that "Bots green == All tests passed and will most likely pass in future too for this patch." 1710575 3 lmoura 2020-11-30 05:29:06 -0800 (In reply to Kimmo Kinnunen from comment #2) > Thanks for the investigation. > Thanks for the quick patch > The GTK EWS bots were green when I submitted the patch that regressed. Do > you (or anyone) know why is this? > > My mental model is that "Bots green == All tests passed and will most likely > pass in future too for this patch." Currently the main EWS queue only runs GTK API tests. We have a GTK Layout tests bot in the UAT queue and we are working to make it stable enough to be moved to the main queue. I've tested the patch locally and indeed it makes all the tests pass. Just need to update the expectations but I can do it unreviewed once this lands. 1739363 4 ews-feeder 2021-03-15 04:15:44 -0700 Committed r274410: <https://commits.webkit.org/r274410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415006. 1739364 5 webkit-bug-importer 2021-03-15 04:16:15 -0700 <rdar://problem/75424863> 415006 2020-11-30 00:06:58 -0800 2021-03-15 04:15:45 -0700 Patch bug-219340-20201130100656.patch text/plain 2471 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM0ZjI5ZTVmOTY3Yjlk NGU4ODU5ZGYwODJlMWEwMjcwNjYxOGFhMi4uMjhmZWU1ZDU3NzFiNjE1MzZjYTA2NGRkMGNjZDI3 OGM1ZGRlNWY4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTExLTMwICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjcwMTg1KSBbR1RLXSBTb21lIHdlYmdsIGZhaWx1cmVzIGFmdGVyIG11bHRpdmFsdWUgc2V0dGVy IHJlZmFjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTkzNDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb25zdHJ1Y3QgdGhlIHNpbXVsYXRlZCB2ZXJ0ZXggYXR0cmliIDAgYnVmZmVyIEdDR0xTcGFu IHdpdGggY29ycmVjdCBzaXplIC0tIHRoZQorICAgICAgICBwb2ludGVyIGlzIEdDR0xmbG9hdCwg c28gdGhlIGxlbmd0aCBzaG91bGQgYmUgdGhlIGNvdW50IG9mIGZsb2F0cy4KKworICAgICAgICBO byBuZXcgdGVzdHMsIHRlc3RlZCBieSB0aGUgcmVncmVzc2VkIHRlc3RzOgorICAgICAgICBmYXN0 L2NhbnZhcy93ZWJnbC9nbC1iaW5kLWF0dHJpYi1sb2NhdGlvbi10ZXN0Lmh0bWwKKyAgICAgICAg ZmFzdC9jYW52YXMvd2ViZ2wvZ2wtYmluZC1hdHRyaWItbWFwcGVkLW5hbWVzLmh0bWwKKyAgICAg ICAgd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvYXR0cmlicy9nbC1kaXNhYmxlZC12ZXJ0ZXgtYXR0 cmliLmh0bWwKKyAgICAgICAgd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvZXh0ZW5zaW9ucy9hbmds ZS1pbnN0YW5jZWQtYXJyYXlzLW91dC1vZi1ib3VuZHMuaHRtbAorICAgICAgICB3ZWJnbC8xLjAu My9jb25mb3JtYW5jZS9wcm9ncmFtcy9nbC1iaW5kLWF0dHJpYi1sb2NhdGlvbi1sb25nLW5hbWVz LXRlc3QuaHRtbAorICAgICAgICB3ZWJnbC8xLjAuMy9jb25mb3JtYW5jZS9wcm9ncmFtcy9nbC1i aW5kLWF0dHJpYi1sb2NhdGlvbi10ZXN0Lmh0bWwKKyAgICAgICAgd2ViZ2wvMS4wLjMvY29uZm9y bWFuY2UvcmVuZGVyaW5nL2RyYXctZWxlbWVudHMtb3V0LW9mLWJvdW5kcy5odG1sCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OnNpbXVsYXRlVmVydGV4QXR0cmli MCk6CisKIDIwMjAtMTEtMjkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtCRkNdIERvIG5vdCBhc3N1bWUgZmxvYXQgYXZvaWRlcnMgaGF2ZSBwcmUtY29t cHV0ZWQgdmVydGljYWwgcG9zaXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCmluZGV4IGE1NjJhNGQ0Yzkw NjdhOThjYTdiNzUyZmZmM2E3MjZjN2RiMmRhYzIuLjMyYTcxNTAzMDgxNjQwZmUwODE3ZDg5ODUw Yzc3MmRhMjA4NmUzOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCkBAIC03Mzc2LDcgKzczNzYsNyBAQCBP cHRpb25hbDxib29sPiBXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjpzaW11bGF0ZVZlcnRleEF0 dHJpYjAoR0NHTHVpbnQgbnVtVmVydAogICAgICAgICBtX3ZlcnRleEF0dHJpYjBCdWZmZXJWYWx1 ZVsyXSA9IGF0dHJpYlZhbHVlLmZWYWx1ZVsyXTsKICAgICAgICAgbV92ZXJ0ZXhBdHRyaWIwQnVm ZmVyVmFsdWVbM10gPSBhdHRyaWJWYWx1ZS5mVmFsdWVbM107CiAgICAgICAgIG1fZm9yY2VBdHRy aWIwQnVmZmVyUmVmaWxsID0gZmFsc2U7Ci0gICAgICAgIG1fY29udGV4dC0+YnVmZmVyU3ViRGF0 YShHcmFwaGljc0NvbnRleHRHTDo6QVJSQVlfQlVGRkVSLCAwLCBtYWtlR0NHTFNwYW4oYnVmZmVy RGF0YS5nZXQoKSwgYnVmZmVyRGF0YVNpemUpKTsKKyAgICAgICAgbV9jb250ZXh0LT5idWZmZXJT dWJEYXRhKEdyYXBoaWNzQ29udGV4dEdMOjpBUlJBWV9CVUZGRVIsIDAsIG1ha2VHQ0dMU3Bhbihi dWZmZXJEYXRhLmdldCgpLCBidWZmZXJTaXplKSk7CiAgICAgfQogICAgIG1fY29udGV4dC0+dmVy dGV4QXR0cmliUG9pbnRlcigwLCA0LCBHcmFwaGljc0NvbnRleHRHTDo6RkxPQVQsIDAsIDAsIDAp OwogICAgIHJldHVybiB0cnVlOwo=