219339 2020-11-29 16:28:58 -0800 [LFC][IFC] Remove redundant const ContainerBox& formattingContextRoot from LineBuilder c'tor 2020-11-30 07:40:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1710511 0 zalan 2020-11-29 16:28:58 -0800 use InlineFormattingContext::root() instead 1710512 1 414998 zalan 2020-11-29 16:30:07 -0800 Created attachment 414998 Patch 1710609 2 ews-feeder 2020-11-30 07:39:59 -0800 Committed r270244: <https://trac.webkit.org/changeset/270244> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414998. 1710610 3 webkit-bug-importer 2020-11-30 07:40:17 -0800 <rdar://problem/71805185> 414998 2020-11-29 16:30:07 -0800 2020-11-30 07:40:00 -0800 Patch bug-219339-20201129163007.patch text/plain 5737 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZmNTM2ZGIxZWRlMmQw NTk1Yjc3OTE4YmI0N2M0NWU5ZWQ5MDdkNy4uNmZlZjYwZDBkNDY4Y2NkNWM3NjgyZDRiNDM3MDMx MTc0M2IzNTg1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg cmVkdW5kYW50IGNvbnN0IENvbnRhaW5lckJveCYgZm9ybWF0dGluZ0NvbnRleHRSb290IGZyb20g TGluZUJ1aWxkZXIgYyd0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxOTMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRl eHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4 dDo6bGluZUxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRp bmdDb250ZXh0Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29uc3RyYWludCBjb25zdCk6Cisg ICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6TGluZUJ1aWxkZXIpOgorICAg ICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6cm9vdCBjb25zdCk6CisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuaDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6TGluZUJ1aWxkZXI6OnJvb3QgY29uc3QpOiBEZWxldGVkLgorCiAy MDIwLTExLTI5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bSUZDXSBQcmVmZXJyZWQgd2lkdGggY29tcHV0YXRpb24gaXMgbm90IGNvbnN0cmFpbmVkIGJ5 IGV4aXN0aW5nIGZsb2F0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4 IGI5Nzk4NGNjNjhhODQ4ZWYyMWEwYjViZjI4ZTk2YWMwNmIyZTMxYTMuLjhhMjI3ZGI1NTQzZGJi MTg2Y2JjN2RiNjgxZjRjNjA5OWU4OTkxMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dC5jcHAKQEAgLTE1Miw3ICsxNTIsNyBAQCB2b2lkIElubGluZUZvcm1hdHRpbmdDb250ZXh0 OjpsaW5lTGF5b3V0KElubGluZUl0ZW1zJiBpbmxpbmVJdGVtcywgTGluZUJ1aWxkZXI6OgogICAg IGF1dG8gZmxvYXRpbmdDb250ZXh0ID0gRmxvYXRpbmdDb250ZXh0IHsgKnRoaXMsIGZvcm1hdHRp bmdTdGF0ZSgpLmZsb2F0aW5nU3RhdGUoKSB9OwogICAgIGF1dG8gaXNGaXJzdExpbmUgPSBmb3Jt YXR0aW5nU3RhdGUoKS5saW5lcygpLmlzRW1wdHkoKTsKIAotICAgIGF1dG8gbGluZUJ1aWxkZXIg PSBMaW5lQnVpbGRlciB7ICp0aGlzLCBmbG9hdGluZ0NvbnRleHQsIHJvb3QoKSwgaW5saW5lSXRl bXMgfTsKKyAgICBhdXRvIGxpbmVCdWlsZGVyID0gTGluZUJ1aWxkZXIgeyAqdGhpcywgZmxvYXRp bmdDb250ZXh0LCBpbmxpbmVJdGVtcyB9OwogICAgIHdoaWxlICghbmVlZHNMYXlvdXRSYW5nZS5p c0VtcHR5KCkpIHsKICAgICAgICAgLy8gVHVybiBwcmV2aW91cyBsaW5lJ3Mgb3ZlcmZsb3cgY29u dGVudCBsZW5ndGggaW50byB0aGUgbmV4dCBsaW5lJ3MgbGVhZGluZyBjb250ZW50IHBhcnRpYWwg bGVuZ3RoLgogICAgICAgICAvLyAic3BbPC1saW5lIGJyZWFrLT5dbGl0X2NvbnRlbnQiIC0+IG92 ZXJmbG93IGxlbmd0aDogMTEgLT4gbGVhZGluZyBwYXJ0aWFsIGNvbnRlbnQgbGVuZ3RoOiAxMS4K QEAgLTI2NCw3ICsyNjQsNyBAQCBJbmxpbmVMYXlvdXRVbml0IElubGluZUZvcm1hdHRpbmdDb250 ZXh0Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29uc3RyYWludChJbgogICAgIC8vIFByZWZl cnJlZCB3aWR0aCBjb21wdXRhdGlvbiBpcyBub3QgY29uc3RyYWluZWQgYnkgZmxvYXRzLiAKICAg ICBhdXRvIGZsb2F0aW5nU3RhdGUgPSBGbG9hdGluZ1N0YXRlOjpjcmVhdGUobGF5b3V0U3RhdGUo KSwgcm9vdCgpKTsKICAgICBhdXRvIGZsb2F0aW5nQ29udGV4dCA9IEZsb2F0aW5nQ29udGV4dCB7 ICp0aGlzLCBmbG9hdGluZ1N0YXRlIH07Ci0gICAgYXV0byBsaW5lQnVpbGRlciA9IExpbmVCdWls ZGVyIHsgKnRoaXMsIGZsb2F0aW5nQ29udGV4dCwgcm9vdCgpLCBpbmxpbmVJdGVtcyB9OworICAg IGF1dG8gbGluZUJ1aWxkZXIgPSBMaW5lQnVpbGRlciB7ICp0aGlzLCBmbG9hdGluZ0NvbnRleHQs IGlubGluZUl0ZW1zIH07CiAgICAgYXV0byBsYXlvdXRSYW5nZSA9IExpbmVCdWlsZGVyOjpJbmxp bmVJdGVtUmFuZ2UgeyAwICwgaW5saW5lSXRlbXMuc2l6ZSgpIH07CiAgICAgYXV0byBtYXhpbXVt TGluZVdpZHRoID0gSW5saW5lTGF5b3V0VW5pdCB7IH07CiAgICAgd2hpbGUgKCFsYXlvdXRSYW5n ZS5pc0VtcHR5KCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRleCAzMDBjOWY5ZmVkOWZh MzdlOTJiNzBmZGI4MjQxMzg1MmY2MWRlNDMwLi5kMTJiZTdkYTA0N2Y1ZmEyNDAwZDQ3NGRjMTJl MDIxNzQ3MDI0NGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC0yMjksMTAgKzIyOSw5 IEBAIElubGluZUxheW91dFVuaXQgTGluZUJ1aWxkZXI6OmlubGluZUl0ZW1XaWR0aChjb25zdCBJ bmxpbmVJdGVtJiBpbmxpbmVJdGVtLCBJbmxpCiAgICAgcmV0dXJuIGJveEdlb21ldHJ5Lm1hcmdp bkJveFdpZHRoKCk7CiB9CiAKLUxpbmVCdWlsZGVyOjpMaW5lQnVpbGRlcihjb25zdCBJbmxpbmVG b3JtYXR0aW5nQ29udGV4dCYgaW5saW5lRm9ybWF0dGluZ0NvbnRleHQsIGNvbnN0IEZsb2F0aW5n Q29udGV4dCYgZmxvYXRpbmdDb250ZXh0LCBjb25zdCBDb250YWluZXJCb3gmIGZvcm1hdHRpbmdD b250ZXh0Um9vdCwgY29uc3QgSW5saW5lSXRlbXMmIGlubGluZUl0ZW1zKQorTGluZUJ1aWxkZXI6 OkxpbmVCdWlsZGVyKGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0JiBpbmxpbmVGb3JtYXR0 aW5nQ29udGV4dCwgY29uc3QgRmxvYXRpbmdDb250ZXh0JiBmbG9hdGluZ0NvbnRleHQsIGNvbnN0 IElubGluZUl0ZW1zJiBpbmxpbmVJdGVtcykKICAgICA6IG1faW5saW5lRm9ybWF0dGluZ0NvbnRl eHQoaW5saW5lRm9ybWF0dGluZ0NvbnRleHQpCiAgICAgLCBtX2Zsb2F0aW5nQ29udGV4dChmbG9h dGluZ0NvbnRleHQpCi0gICAgLCBtX2Zvcm1hdHRpbmdDb250ZXh0Um9vdChmb3JtYXR0aW5nQ29u dGV4dFJvb3QpCiAgICAgLCBtX2xpbmUoaW5saW5lRm9ybWF0dGluZ0NvbnRleHQpCiAgICAgLCBt X2lubGluZUl0ZW1zKGlubGluZUl0ZW1zKQogewpAQCAtNzAwLDYgKzY5OSwxMSBAQCBib29sIExp bmVCdWlsZGVyOjppc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQoY29uc3QgSW5saW5lSXRlbVJh bmdlJiBsaW5lUmFuZ2UsCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitjb25zdCBDb250YWluZXJC b3gmIExpbmVCdWlsZGVyOjpyb290KCkgY29uc3QKK3sKKyAgICByZXR1cm4gZm9ybWF0dGluZ0Nv bnRleHQoKS5yb290KCk7Cit9CisKIGNvbnN0IExheW91dFN0YXRlJiBMaW5lQnVpbGRlcjo6bGF5 b3V0U3RhdGUoKSBjb25zdAogewogICAgIHJldHVybiBmb3JtYXR0aW5nQ29udGV4dCgpLmxheW91 dFN0YXRlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9JbmxpbmVMaW5lQnVpbGRlci5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuaAppbmRleCBlODgxODNlMzNkZWFkYzYxMDRiOTAw MjMyNDdlYWMwY2RjMjQwMjEyLi5mYzJlODIwZGM3Y2MyNzc3Y2NlNGM2OTMxOTBkNjI5MDRmOGVh YjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9J bmxpbmVMaW5lQnVpbGRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmgKQEAgLTM5LDcgKzM5LDcgQEAgc3RydWN0IExpbmVD YW5kaWRhdGU7CiAKIGNsYXNzIExpbmVCdWlsZGVyIHsKIHB1YmxpYzoKLSAgICBMaW5lQnVpbGRl cihjb25zdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dCYsIGNvbnN0IEZsb2F0aW5nQ29udGV4dCYs IGNvbnN0IENvbnRhaW5lckJveCYgZm9ybWF0dGluZ0NvbnRleHRSb290LCBjb25zdCBJbmxpbmVJ dGVtcyYpOworICAgIExpbmVCdWlsZGVyKGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0Jiwg Y29uc3QgRmxvYXRpbmdDb250ZXh0JiwgY29uc3QgSW5saW5lSXRlbXMmKTsKIAogICAgIHN0cnVj dCBJbmxpbmVJdGVtUmFuZ2UgewogICAgICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVy biBzdGFydCA9PSBlbmQ7IH0KQEAgLTEwMywxMiArMTAzLDExIEBAIHByaXZhdGU6CiAgICAgYm9v bCBpc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQoY29uc3QgSW5saW5lSXRlbVJhbmdlJiBsaW5l UmFuZ2UsIHNpemVfdCBsYXN0SW5saW5lSXRlbUluZGV4LCBib29sIGhhc1BhcnRpYWxUcmFpbGlu Z0NvbnRlbnQpIGNvbnN0OwogCiAgICAgY29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQmIGZv cm1hdHRpbmdDb250ZXh0KCkgY29uc3QgeyByZXR1cm4gbV9pbmxpbmVGb3JtYXR0aW5nQ29udGV4 dDsgfQotICAgIGNvbnN0IENvbnRhaW5lckJveCYgcm9vdCgpIGNvbnN0IHsgcmV0dXJuIG1fZm9y bWF0dGluZ0NvbnRleHRSb290OyB9CisgICAgY29uc3QgQ29udGFpbmVyQm94JiByb290KCkgY29u c3Q7CiAgICAgY29uc3QgTGF5b3V0U3RhdGUmIGxheW91dFN0YXRlKCkgY29uc3Q7CiAKICAgICBj b25zdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dCYgbV9pbmxpbmVGb3JtYXR0aW5nQ29udGV4dDsK ICAgICBjb25zdCBGbG9hdGluZ0NvbnRleHQmIG1fZmxvYXRpbmdDb250ZXh0OwotICAgIGNvbnN0 IENvbnRhaW5lckJveCYgbV9mb3JtYXR0aW5nQ29udGV4dFJvb3Q7CiAgICAgTGluZSBtX2xpbmU7 CiAgICAgSW5saW5lTGF5b3V0VW5pdCBtX2hvcml6b250YWxTcGFjZUZvckxpbmUgeyAwIH07CiAg ICAgY29uc3QgSW5saW5lSXRlbXMmIG1faW5saW5lSXRlbXM7Cg==