219321 2020-11-27 13:09:33 -0800 GPU process remains alive even after UI process exited 2020-11-30 19:23:15 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii cdumez darin don.olmstead thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1710378 0 fujii 2020-11-27 13:09:33 -0800 [WinCairo?] GPU process remains alive even after web process exited GPUProcess overrides AuxiliaryProcess::didClose but it does nothing. Is this a WinCairo specific issue? 1710379 1 414969 fujii 2020-11-27 13:17:06 -0800 Created attachment 414969 Patch 1710397 2 fujii 2020-11-27 20:29:43 -0800 Committed r270213: <https://trac.webkit.org/changeset/270213> 1710398 3 webkit-bug-importer 2020-11-27 20:30:17 -0800 <rdar://problem/71770347> 1710400 4 fujii 2020-11-27 20:30:40 -0800 Landed in r270210, and reverted in r270213. It broke TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo on iOS. 1710401 5 fujii 2020-11-27 20:31:17 -0800 Reopened. 1710404 6 wenson_hsieh 2020-11-27 20:34:49 -0800 Hmm...would this mean that if there are two web content processes (and therefore two connections) and one of the web processes die, then the GPU process will also terminate? If so, I think we'd still need the GPU process to stay alive in this scenario, since it's still required to service the other web content process that is still alive. 1710452 7 thorton 2020-11-28 17:24:45 -0800 (In reply to Wenson Hsieh from comment #6) > Hmm...would this mean that if there are two web content processes (and > therefore two connections) and one of the web processes die, then the GPU > process will also terminate? If so, I think we'd still need the GPU process > to stay alive in this scenario, since it's still required to service the > other web content process that is still alive. No, the connection this is referring to /should/ be the UI->GPU connection, right? 1710485 8 wenson_hsieh 2020-11-29 11:17:28 -0800 (In reply to Tim Horton from comment #7) > (In reply to Wenson Hsieh from comment #6) > > Hmm...would this mean that if there are two web content processes (and > > therefore two connections) and one of the web processes die, then the GPU > > process will also terminate? If so, I think we'd still need the GPU process > > to stay alive in this scenario, since it's still required to service the > > other web content process that is still alive. > > No, the connection this is referring to /should/ be the UI->GPU connection, > right? Ah, if that's the case then this makes a lot more sense. I was unclear on which process the `IPC::Connection` was referring to. I suppose this doesn't affect Cocoa platforms because the GPU process is a child process of the UI (application) process, so if the app dies then the GPU process goes along with it. 1710743 9 fujii 2020-11-30 13:35:36 -0800 Thank you for clarifying. I didn't understand GPU process model. I confirmed GPUConnectionToWebProcess::didClose is called when Web process exits, and GPUProcess::didClose is called when UI process exits on WinCairo. Why does TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo fail on iOS with my patch? 1710758 10 thorton 2020-11-30 13:57:19 -0800 (In reply to Fujii Hironori from comment #9) > Thank you for clarifying. I didn't understand GPU process model. > > I confirmed GPUConnectionToWebProcess::didClose is called when Web process > exits, and GPUProcess::didClose is called when UI process exits on WinCairo. > > Why does TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo fail on iOS with my > patch? Do you have a link to the test output? Also, +cdumez 1710764 11 fujii 2020-11-30 14:09:56 -0800 (In reply to Tim Horton from comment #10) > Do you have a link to the test output? Also, +cdumez I'm sorry. It did misunderstand. TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is flaky without my patch. https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo&platform=ios I'm going to land it again. 1710781 12 cdumez 2020-11-30 14:23:53 -0800 (In reply to Fujii Hironori from comment #11) > (In reply to Tim Horton from comment #10) > > Do you have a link to the test output? Also, +cdumez > > I'm sorry. It did misunderstand. > TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is flaky without my patch. > > https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess. > CrashWhilePlayingVideo&platform=ios > > I'm going to land it again. Yes, I noticed GPUProcess.CrashWhilePlayingVideo is flaky on the iOS bots too. I have not been able to reproduce this flakiness though. 1710892 13 fujii 2020-11-30 18:10:15 -0800 Committed r270279: <https://trac.webkit.org/changeset/270279> 1710896 14 darin 2020-11-30 18:28:04 -0800 For future reference: A bug like this should *not* have the [WinCairo?] prefix. Platform-independent fix to cross-platform issue! 1710904 15 fujii 2020-11-30 19:23:15 -0800 I got it. 414969 2020-11-27 13:17:06 -0800 2020-11-30 13:36:23 -0800 Patch bug-219321-20201128061705.patch text/plain 2054 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNlMzA2YTBiNDQzMDdlYzU2 OWU0OGUzN2FjMzE3N2RmYWQ0YjJkZGIuLjIwYjQ0NjlhMDgzODE3ODMxYTA3ZGUyODcxY2M4NDk4 Nzk2MDk4NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMTEtMjcgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvP10g R1BVIHByb2Nlc3MgcmVtYWlucyBhbGl2ZSBldmVuIGFmdGVyIHdlYiBwcm9jZXNzIGV4aXRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MzIxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXV4aWxpYXJ5 UHJvY2Vzczo6ZGlkQ2xvc2UgaXMgY2FsbGluZyBfZXhpdC4gSG93ZXZlciwgR1BVUHJvY2Vzcwor ICAgICAgICBvdmVycm9kZSBBdXhpbGlhcnlQcm9jZXNzOjpkaWRDbG9zZSBidXQgaXQgZGlkIG5v dGhpbmcuIEdQVVByb2Nlc3MKKyAgICAgICAgZG9lc24ndCBuZWVkIHRvIG92ZXJyaWRlIGl0Lgor CisgICAgICAgICogR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 R1BVUHJvY2Vzczo6ZGlkQ2xvc2UpOiBEZWxldGVkLgorICAgICAgICAqIEdQVVByb2Nlc3MvR1BV UHJvY2Vzcy5oOgorCiAyMDIwLTExLTI3ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CiAKICAgICAgICAgTm9uLXVuaWZpZWQgYnVpbGQgZml4ZXMsIGxhdGUgTm92ZW1iZXIg MjAyMCBlZGl0aW9uLCB0YWtlIHR3bwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9j ZXNzL0dQVVByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3Mu Y3BwCmluZGV4IDAyNTFiNzVhMjlmYjk1NzY0NTI4MzQ2MTI0MjIwNWFmMmNlNDdhNGUuLmUzZDU2 YTg3YzdkZGVhZWYwMGE2ZDE3MjA4ZGI4YWUxZTIyOTEwZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L0dQVVBy b2Nlc3MvR1BVUHJvY2Vzcy5jcHAKQEAgLTExNCwxMSArMTE0LDYgQEAgYm9vbCBHUFVQcm9jZXNz OjpzaG91bGRUZXJtaW5hdGUoKQogICAgIHJldHVybiBtX3dlYlByb2Nlc3NDb25uZWN0aW9ucy5p c0VtcHR5KCk7CiB9CiAKLXZvaWQgR1BVUHJvY2Vzczo6ZGlkQ2xvc2UoSVBDOjpDb25uZWN0aW9u JikKLXsKLSAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwotfQotCiB2b2lkIEdQVVByb2Nl c3M6Omxvd01lbW9yeUhhbmRsZXIoQ3JpdGljYWwgY3JpdGljYWwpCiB7CiAgICAgV1RGOjpyZWxl YXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BV UHJvY2Vzcy9HUFVQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vz cy5oCmluZGV4IGI1NDBmZmQyYzQ1Y2M2ODA3OGFlOTljZDFlZjI2ZmUxYzkwMzRiMGIuLmI2ZWE4 MTgzY2U2NTFlNDhkMTE3ZTI0N2I1N2ZiMDU4NzkxYzI2OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9j ZXNzL0dQVVByb2Nlc3MuaApAQCAtOTgsNyArOTgsNiBAQCBwcml2YXRlOgogCiAgICAgLy8gSVBD OjpDb25uZWN0aW9uOjpDbGllbnQKICAgICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29u bmVjdGlvbiYsIElQQzo6RGVjb2RlciYpIG92ZXJyaWRlOwotICAgIHZvaWQgZGlkQ2xvc2UoSVBD OjpDb25uZWN0aW9uJikgb3ZlcnJpZGU7CiAKICAgICAvLyBNZXNzYWdlIEhhbmRsZXJzCiAgICAg dm9pZCBpbml0aWFsaXplR1BVUHJvY2VzcyhHUFVQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiYp Owo=