21932 2008-10-28 13:47:47 -0700 Add non-pointer symbol lookups to SoftLinking.h 2008-10-28 14:43:23 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bolsinga webkit-unassigned ddkilzer oldest_to_newest 96908 0 bolsinga 2008-10-28 13:47:47 -0700 It can currently look up pointers, but not symbols that aren't pointers. 96909 1 24728 bolsinga 2008-10-28 13:49:35 -0700 Created attachment 24728 looks up non pointer symbols This is needed for some other platform work. 96910 2 24728 darin 2008-10-28 13:54:28 -0700 Comment on attachment 24728 looks up non pointer symbols The change seems fine. But I'm not sure "SYMBOL" is a good name for this. They're all symbols. Maybe "OBJECT"? r=me as-is, but please consider other names 96914 3 bolsinga 2008-10-28 14:28:31 -0700 How about DATA, as I'm using this to get data constants? 96918 4 24730 bolsinga 2008-10-28 14:33:11 -0700 Created attachment 24730 changed SYMBOL to DATA Same as before, but SYMBOL is not DATA 96920 5 ddkilzer 2008-10-28 14:37:22 -0700 (In reply to comment #3) > How about DATA, as I'm using this to get data constants? CONSTANT might work better. 96923 6 ddkilzer 2008-10-28 14:43:23 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/mac/SoftLinking.h Committed r37941 Changed SYMBOL/DATA to CONSTANT when landing. http://trac.webkit.org/changeset/37941 24728 2008-10-28 13:49:35 -0700 2008-10-28 13:54:28 -0700 looks up non pointer symbols SoftLink.patch.txt text/plain 1418 bolsinga SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3OTM0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAt MjggIEdyZWcgQm9sc2luZ2EgIDxib2xzaW5nYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBB RERFRCBPUiBDSEFOR0VECisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MzIKKyAgICAgICAgQWRkIG5vbi1wb2ludGVyIHN5bWJvbCBs b29rdXBzIHRvIFNvZnRMaW5raW5nLmgKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9Tb2Z0TGlu a2luZy5oOgorCiAyMDA4LTEwLTI4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNv bT4KIAogICAgICAgICBNYWtlIHRoZSBQcm9maWxlcyBwYW5lbCBpbiB0aGUgV2ViIEluc3BlY3Rv ciBoYXZlIGFuIGVuYWJsZSBzY3JlZW4uCkluZGV4OiBwbGF0Zm9ybS9tYWMvU29mdExpbmtpbmcu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9tYWMvU29mdExpbmtpbmcuaAkocmV2aXNpb24gMzc5 MzApCisrKyBwbGF0Zm9ybS9tYWMvU29mdExpbmtpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtOTgs MyArOTgsMjIgQEAKICAgICAgICAgZ2V0IyNuYW1lID0gbmFtZSMjRnVuY3Rpb247IFwKICAgICAg ICAgcmV0dXJuIHBvaW50ZXIjI25hbWU7IFwKICAgICB9CisKKyNkZWZpbmUgU09GVF9MSU5LX1NZ TUJPTChmcmFtZXdvcmssIG5hbWUsIHR5cGUpIFwKKyAgICBzdGF0aWMgdHlwZSBpbml0IyNuYW1l KCk7IFwKKyAgICBzdGF0aWMgdHlwZSAoKmdldCMjbmFtZSkoKSA9IGluaXQjI25hbWU7IFwKKyAg ICBzdGF0aWMgdHlwZSBzeW1ib2wjI25hbWU7IFwKKyAgICBcCisgICAgc3RhdGljIHR5cGUgbmFt ZSMjRnVuY3Rpb24oKSBcCisgICAgeyBcCisgICAgICAgIHJldHVybiBzeW1ib2wjI25hbWU7IFwK KyAgICB9XAorICAgIFwKKyAgICBzdGF0aWMgdHlwZSBpbml0IyNuYW1lKCkgXAorICAgIHsgXAor ICAgICAgICB2b2lkKiBzeW1ib2wgPSBkbHN5bShmcmFtZXdvcmsjI0xpYnJhcnkoKSwgI25hbWUp OyBcCisgICAgICAgIEFTU0VSVChzeW1ib2wpOyBcCisgICAgICAgIHN5bWJvbCMjbmFtZSA9ICpz dGF0aWNfY2FzdDx0eXBlKj4oc3ltYm9sKTsgXAorICAgICAgICBnZXQjI25hbWUgPSBuYW1lIyNG dW5jdGlvbjsgXAorICAgICAgICByZXR1cm4gc3ltYm9sIyNuYW1lOyBcCisgICAgfQo= 24730 2008-10-28 14:33:11 -0700 2008-10-28 14:33:11 -0700 changed SYMBOL to DATA SoftLink.patch.txt text/plain 1407 bolsinga SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzkzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMjggIEdyZWcgQm9sc2luZ2EgIDxib2xzaW5nYUBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisgICAgICAgIAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MzIKKyAgICAgICAg QWRkIG5vbi1wb2ludGVyIHN5bWJvbCBsb29rdXBzIHRvIFNvZnRMaW5raW5nLmgKKworICAgICAg ICAqIHBsYXRmb3JtL21hYy9Tb2Z0TGlua2luZy5oOgorCiAyMDA4LTEwLTI4ICBHcmVnIEJvbHNp bmdhICA8Ym9sc2luZ2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEtp bHplci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL1NvZnRMaW5raW5nLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU29mdExpbmtpbmcuaAkocmV2aXNpb24gMzc5Mzcp CisrKyBXZWJDb3JlL3BsYXRmb3JtL21hYy9Tb2Z0TGlua2luZy5oCSh3b3JraW5nIGNvcHkpCkBA IC05OCwzICs5OCwyMiBAQAogICAgICAgICBnZXQjI25hbWUgPSBuYW1lIyNGdW5jdGlvbjsgXAog ICAgICAgICByZXR1cm4gcG9pbnRlciMjbmFtZTsgXAogICAgIH0KKworI2RlZmluZSBTT0ZUX0xJ TktfREFUQShmcmFtZXdvcmssIG5hbWUsIHR5cGUpIFwKKyAgICBzdGF0aWMgdHlwZSBpbml0IyNu YW1lKCk7IFwKKyAgICBzdGF0aWMgdHlwZSAoKmdldCMjbmFtZSkoKSA9IGluaXQjI25hbWU7IFwK KyAgICBzdGF0aWMgdHlwZSBkYXRhIyNuYW1lOyBcCisgICAgXAorICAgIHN0YXRpYyB0eXBlIG5h bWUjI0Z1bmN0aW9uKCkgXAorICAgIHsgXAorICAgICAgICByZXR1cm4gZGF0YSMjbmFtZTsgXAor ICAgIH1cCisgICAgXAorICAgIHN0YXRpYyB0eXBlIGluaXQjI25hbWUoKSBcCisgICAgeyBcCisg ICAgICAgIHZvaWQqIGRhdGEgPSBkbHN5bShmcmFtZXdvcmsjI0xpYnJhcnkoKSwgI25hbWUpOyBc CisgICAgICAgIEFTU0VSVChkYXRhKTsgXAorICAgICAgICBkYXRhIyNuYW1lID0gKnN0YXRpY19j YXN0PHR5cGUqPihkYXRhKTsgXAorICAgICAgICBnZXQjI25hbWUgPSBuYW1lIyNGdW5jdGlvbjsg XAorICAgICAgICByZXR1cm4gZGF0YSMjbmFtZTsgXAorICAgIH0K