<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>219302</bug_id>
          
          <creation_ts>2020-11-27 02:40:15 -0800</creation_ts>
          <short_desc>[Flatpak SDK] Add clangd</short_desc>
          <delta_ts>2020-11-27 06:49:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Philippe Normand">pnormand</assigned_to>
          <cc>aperez</cc>
    
    <cc>vjaquez</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1710252</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2020-11-27 02:40:15 -0800</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710254</commentid>
    <comment_count>1</comment_count>
      <attachid>414930</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2020-11-27 02:43:48 -0800</bug_when>
    <thetext>Created attachment 414930
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710272</commentid>
    <comment_count>2</comment_count>
      <attachid>414930</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2020-11-27 04:02:46 -0800</bug_when>
    <thetext>Comment on attachment 414930
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414930&amp;action=review

&gt; Tools/buildstream/project.conf:47
&gt; +  github_files: https://github.com/

Yet here both are using “https://github.com/” 🤔️

Does this mean that something is missing to make “github_files” point to
a different host?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710274</commentid>
    <comment_count>3</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2020-11-27 04:13:48 -0800</bug_when>
    <thetext>(In reply to Adrian Perez from comment #2)
&gt; Comment on attachment 414930 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=414930&amp;action=review
&gt; 
&gt; &gt; Tools/buildstream/project.conf:47
&gt; &gt; +  github_files: https://github.com/
&gt; 
&gt; Yet here both are using “https://github.com/” 🤔️
&gt; 
&gt; Does this mean that something is missing to make “github_files” point to
&gt; a different host?

I did just like in the FDO SDK. Their cache server requires a different alias for &quot;static&quot; files vs git repositories, IIUC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710275</commentid>
    <comment_count>4</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2020-11-27 04:16:46 -0800</bug_when>
    <thetext>https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/master/include/_private/aliases.yml#L36</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710281</commentid>
    <comment_count>5</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2020-11-27 04:24:31 -0800</bug_when>
    <thetext>(In reply to Philippe Normand from comment #4)
&gt; https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/master/include/
&gt; _private/aliases.yml#L36

I did some digging, too…  I&apos;ve read from the Buildstream documentation
that this would allow users to set a different mirror server in their
local configuration for static files which are not repository fetches:

  https://docs.buildstream.build/1.6.1/format_project.html#project-essentials-mirrors

All right, then!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710282</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-11-27 04:41:52 -0800</bug_when>
    <thetext>Tools/Scripts/svn-apply failed to apply attachment 414930 to trunk.
Please resolve the conflicts and upload a new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710292</commentid>
    <comment_count>7</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2020-11-27 06:49:02 -0800</bug_when>
    <thetext>Committed r270193: &lt;https://trac.webkit.org/changeset/270193&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710293</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-11-27 06:49:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/71764528&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>414930</attachid>
            <date>2020-11-27 02:43:48 -0800</date>
            <delta_ts>2020-11-27 04:41:52 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-219302-20201127024346.patch</filename>
            <type>text/plain</type>
            <size>2670</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTg2CmRpZmYgLS1naXQgYS9Ub29scy9idWlsZHN0cmVh
bS9DaGFuZ2VMb2cgYi9Ub29scy9idWlsZHN0cmVhbS9DaGFuZ2VMb2cKaW5kZXggYmIyOGUwOWMw
MDM1NGIyZWQxMzg4OTc1ZTUxY2E5MTdjZThiMmQ5YS4uMjVkNjU0Y2FkOWQyZjQ1YzA5M2M5ZTNm
MmY1ZjU4YTg1MTU0OTE5MiAxMDA2NDQKLS0tIGEvVG9vbHMvYnVpbGRzdHJlYW0vQ2hhbmdlTG9n
CisrKyBiL1Rvb2xzL2J1aWxkc3RyZWFtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIw
LTExLTI3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg
ICBbRmxhdHBhayBTREtdIEFkZCBjbGFuZ2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTIxOTMwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIGNsYW5nZCBjYW4gYmUgdXNlZCBhcyBhbiBhbHRlcm5hdGl2ZSB0
byBjY2xzIGluIElERXMgc3VwcG9ydGluZyB0aGUgTFNQIHByb3RvY29sLgorCisgICAgICAgICog
ZWxlbWVudHMvc2RrLXBsYXRmb3JtLmJzdDoKKyAgICAgICAgKiBlbGVtZW50cy9zZGsvY2xhbmdk
LmJzdDogQWRkZWQuCisgICAgICAgICogcHJvamVjdC5jb25mOgorCiAyMDIwLTExLTE2ICBQaGls
aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBhayBT
REtdIFVwZGF0ZSBycgpkaWZmIC0tZ2l0IGEvVG9vbHMvYnVpbGRzdHJlYW0vZWxlbWVudHMvc2Rr
LXBsYXRmb3JtLmJzdCBiL1Rvb2xzL2J1aWxkc3RyZWFtL2VsZW1lbnRzL3Nkay1wbGF0Zm9ybS5i
c3QKaW5kZXggYWZmOTQ5MzE1MzEyY2M0N2FkZTg5N2Q0MDRiOGRmMzVhOTJiNjNhZi4uYWM0MmMz
M2FjOGU1ZjQ3OWY2YTFmMmM2ZDhjZjY1NzQzYWY1NDdiNSAxMDA2NDQKLS0tIGEvVG9vbHMvYnVp
bGRzdHJlYW0vZWxlbWVudHMvc2RrLXBsYXRmb3JtLmJzdAorKysgYi9Ub29scy9idWlsZHN0cmVh
bS9lbGVtZW50cy9zZGstcGxhdGZvcm0uYnN0CkBAIC0xMSw2ICsxMSw3IEBAIGRlcGVuZHM6CiAt
IHNkay9hZHdhaXRhLWljb24tdGhlbWUuYnN0CiAtIHNkay9jYXBucC5ic3QKIC0gc2RrL2NjbHMu
YnN0CistIHNkay9jbGFuZ2QuYnN0CiAtIHNkay9lbmNoYW50LTIuYnN0CiAtIHNkay9mZm1wZWcu
YnN0CiAtIHNkay9nbGliLW5ldHdvcmtpbmcuYnN0CmRpZmYgLS1naXQgYS9Ub29scy9idWlsZHN0
cmVhbS9lbGVtZW50cy9zZGsvY2xhbmdkLmJzdCBiL1Rvb2xzL2J1aWxkc3RyZWFtL2VsZW1lbnRz
L3Nkay9jbGFuZ2QuYnN0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY4NDQ3ZmJhOTRhMzMyMjgzYzIyNzU0NWNhNjZj
NTYwMjFiNzllYzkKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9idWlsZHN0cmVhbS9lbGVtZW50
cy9zZGsvY2xhbmdkLmJzdApAQCAtMCwwICsxLDIyIEBACitraW5kOiBtYW51YWwKK3NvdXJjZXM6
CistIGtpbmQ6IHppcAorICB1cmw6IGdpdGh1Yl9maWxlczpjbGFuZ2QvY2xhbmdkL3JlbGVhc2Vz
L2Rvd25sb2FkLzExLjAuMC9jbGFuZ2QtbGludXgtMTEuMC4wLnppcAorICByZWY6IDEwMDQ3ZTJm
OTc0Y2QzNWExNDVlNjcyZWI1NzQ3YjZjYjI3OTAyMTgxYWU3OGMxNDhkNmU2OTdhOWRhNTYyZDgK
KworZGVwZW5kczoKKy0gZnJlZWRlc2t0b3Atc2RrLmJzdDpib290c3RyYXAtaW1wb3J0LmJzdAor
Citjb25maWc6CisgIGluc3RhbGwtY29tbWFuZHM6CisgIC0gfAorICAgIGluc3RhbGwgLUQgLW0g
YStyeCAtdCAiJXtpbnN0YWxsLXJvb3R9LyV7YmluZGlyfSIgLi9iaW4vY2xhbmdkCisKK3Zhcmlh
YmxlczoKKyAgc3RyaXAtYmluYXJpZXM6ICJ0cnVlIgorCitwdWJsaWM6CisgIGJzdDoKKyAgICBp
bnRlZ3JhdGlvbi1jb21tYW5kczoKKyAgICAtIHwKKyAgICAgIGNsYW5nZCAtLXZlcnNpb24KZGlm
ZiAtLWdpdCBhL1Rvb2xzL2J1aWxkc3RyZWFtL3Byb2plY3QuY29uZiBiL1Rvb2xzL2J1aWxkc3Ry
ZWFtL3Byb2plY3QuY29uZgppbmRleCA5MWE2YThlMDA3MjFiM2FjZDk4MzdiMDc2Yjc4YmM1ZmMz
NTExNGRiLi5lOTY5OTJkODM0YjdjNjhiNjFmMWIzYTRmZWQwZGJkNmRhOWQ3YWZkIDEwMDY0NAot
LS0gYS9Ub29scy9idWlsZHN0cmVhbS9wcm9qZWN0LmNvbmYKKysrIGIvVG9vbHMvYnVpbGRzdHJl
YW0vcHJvamVjdC5jb25mCkBAIC00Myw2ICs0Myw4IEBAIGFsaWFzZXM6CiAgIGZmbXBlZzogaHR0
cHM6Ly9naXQuZmZtcGVnLm9yZy8KICAgZ2l0bGFiX2ZyZWVkZXNrdG9wX29yZzogaHR0cHM6Ly9n
aXRsYWIuZnJlZWRlc2t0b3Aub3JnLwogICBnaXRodWJfY29tOiBodHRwczovL2dpdGh1Yi5jb20v
CisgICMoZ2l0aHViX2ZpbGVzIGlzIGFuIGFsaWFzIGZvciB0aGUgc2FtZSB1cmwgYXMgZ2l0aHVi
LCBidXQgZG9lc24ndCB1c2UgdGhlIHNhbWUgbWlycm9yKQorICBnaXRodWJfZmlsZXM6IGh0dHBz
Oi8vZ2l0aHViLmNvbS8KICAgZ2l0bGFiX2NvbTogaHR0cHM6Ly9naXRsYWIuY29tLwogICBnaXRs
YWJfZ25vbWVfb3JnOiBodHRwczovL2dpdGxhYi5nbm9tZS5vcmcvCiAgIHJhd19naXRodWJ1c2Vy
Y29udGVudF9jb206IGh0dHBzOi8vcmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbS8K
</data>
<flag name="review"
          id="431936"
          type_id="1"
          status="+"
          setter="aperez"
    />
    <flag name="commit-queue"
          id="431950"
          type_id="3"
          status="-"
          setter="ews-feeder"
    />
          </attachment>
      

    </bug>

</bugzilla>