21930 2008-10-28 11:48:14 -0700 Add MediaPlayerPrivateChromium to MediaPlayer 2008-10-29 14:45:28 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 scherkus webkit-unassigned oldest_to_newest 96892 0 scherkus 2008-10-28 11:48:14 -0700 Adds in a MediaPlayerPrivate implementation for Chromium using PLATFORM(CHROMIUM) guard. 96894 1 24723 scherkus 2008-10-28 11:52:18 -0700 Created attachment 24723 patch 96956 2 24723 sam 2008-10-28 23:34:16 -0700 Comment on attachment 24723 patch This needs a ChangeLog and should really also include the new MediaPlayerPrivateChromium.h file as well. I no we have let quite a few of these header #include changes, but I am beginning to think we should not. 96999 3 fishd 2008-10-29 11:00:08 -0700 Sam, please see Brett's post to webkit-dev on the subject: https://lists.webkit.org/pipermail/webkit-dev/2008-October/005526.html 97000 4 sam 2008-10-29 11:02:13 -0700 Ok, but it still needs a changelog, which was my main complaint :) 97001 5 scherkus 2008-10-29 11:04:29 -0700 Yes that was my mistake :) Uploading a new patch as we speak! 97007 6 24750 scherkus 2008-10-29 11:19:01 -0700 Created attachment 24750 Includes ChangeLog entry and I fixed the order (we no longer define WIN/MAC/etc. so it doesn't have to be first) 97021 7 24750 darin 2008-10-29 13:01:54 -0700 Comment on attachment 24750 Includes ChangeLog entry and I fixed the order (we no longer define WIN/MAC/etc. so it doesn't have to be first) > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 37973) > +++ ChangeLog (working copy) > @@ -1,3 +1,12 @@ > +2008-10-29 Andrew Scherkus <scherkus@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Add MediaPlayerPrivate header include for Chromium platform. > + > + * WebCore\platform\graphics\MediaPlayer.cpp > +: > + I'm not sure how you're generating ChangeLog files but there are three problems with this one: 1) The path uses \ rather than / -- we use / in our ChangeLog even though Windows is one of the platforms we support. 2) The colon is on a separate line after the filename. 3) Doesn't contain a link to this bug on bugs.webkit.org; we prefer to do that. The person who lands this patch will need to fix these problems. r=me 97026 8 scherkus 2008-10-29 13:17:12 -0700 Thanks for pointing out the ChangeLog mistakes. I used prepare-ChangeLog under cygwin, but I believe the non-cygwin svn was used by mistake. I'll fix it up for future submissions. 97043 9 fishd 2008-10-29 14:45:28 -0700 http://trac.webkit.org/changeset/37980 24723 2008-10-28 11:52:18 -0700 2008-10-29 11:19:01 -0700 patch media_player_chromium.diff text/plain 439 scherkus SW5kZXg6IE1lZGlhUGxheWVyLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIE1lZGlhUGxheWVyLmNwcAko cmV2aXNpb24gMzk3NCkNCisrKyBNZWRpYVBsYXllci5jcHAJKHdvcmtpbmcgY29weSkNCkBAIC0z NCw3ICszNCw5IEBADQogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIK IAotI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyNpbmNsdWRlICJN ZWRpYVBsYXllclByaXZhdGVDaHJvbWl1bS5oIgorI2VsaWYgUExBVEZPUk0oTUFDKQogI2luY2x1 ZGUgIk1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0LmgiCiAjZWxpZiBQTEFURk9STShXSU4pCiAjaW5j bHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlUXVpY2tUaW1lV2luLmgiCg== 24750 2008-10-29 11:19:01 -0700 2008-10-29 13:01:54 -0700 Includes ChangeLog entry and I fixed the order (we no longer define WIN/MAC/etc. so it doesn't have to be first) media_player_chromium.patch text/plain 931 scherkus SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMzc5 NzMpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0x MC0yOSAgQW5kcmV3IFNjaGVya3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBNZWRpYVBsYXllclBy aXZhdGUgaGVhZGVyIGluY2x1ZGUgZm9yIENocm9taXVtIHBsYXRmb3JtLgorCisgICAgICAgICog V2ViQ29yZVxwbGF0Zm9ybVxncmFwaGljc1xNZWRpYVBsYXllci5jcHAKKzoKKwogMjAwOC0xMC0y OCAgTWlrZSBIb21tZXkgIDxnbGFuZGl1bUBkZWJpYW4ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFscCBUb2tlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5 ZXIuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBs YXllci5jcHAJKHJldmlzaW9uIDM3OTczKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9N ZWRpYVBsYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDggQEAKICNpbmNsdWRl ICJNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCIKICNlbGlmIFBMQVRGT1JNKFFUKQogI2lu Y2x1ZGUgIk1lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5oIgorI2VsaWYgUExBVEZPUk0oQ0hST01J VU0pCisjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcml2YXRlQ2hyb21pdW0uaCIKICNlbmRpZgogCiBu YW1lc3BhY2UgV2ViQ29yZSB7Cg==