219290 2020-11-25 17:35:06 -0800 AXObjectCache::focusedObjectForPage() is not defined when ENABLE(ACCESSIBILITY) is off 2020-11-26 17:22:21 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219238 InRadar P2 Normal --- 1 yoshiaki.jitsukawa yoshiaki.jitsukawa aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1710086 0 yoshiaki.jitsukawa 2020-11-25 17:35:06 -0800 AXObjectCache::focusedObjectForPage() is not defined when ENABLE(ACCESSIBILITY) is tuned off and build fails. 1710087 1 414871 yoshiaki.jitsukawa 2020-11-25 17:45:26 -0800 Created attachment 414871 Patch1 1710088 2 414872 yoshiaki.jitsukawa 2020-11-25 17:46:06 -0800 Created attachment 414872 Patch2 1710090 3 yoshiaki.jitsukawa 2020-11-25 17:54:04 -0800 Hello, Chris, Andres. I came across this with PlayStation build and prepared two versions of patches (Patch1 and Patch2)but I'm not sure which one is better. Would you please review? 1710145 4 webkit-bug-importer 2020-11-26 03:28:00 -0800 <rdar://problem/71747849> 1710185 5 ews-feeder 2020-11-26 16:05:19 -0800 commit-queue failed to commit attachment 414872 to WebKit repository. 1710186 6 414910 yoshiaki.jitsukawa 2020-11-26 16:10:36 -0800 Created attachment 414910 Patch (fix tabs in the change log) 1710192 7 ews-feeder 2020-11-26 17:22:20 -0800 Committed r270172: <https://trac.webkit.org/changeset/270172> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414910. 414871 2020-11-25 17:45:26 -0800 2020-11-26 16:10:36 -0800 Patch1 patch1.patch text/plain 1452 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjNhYjZiNGU2YzQuLmUzZjU3ZWFlNjA5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIwLTExLTI2ICBZb3NoaWFraSBKaXRzdWthd2EgIDx5b3NoaWFraS5q aXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAgQVhPYmplY3RDYWNoZTo6Zm9jdXNlZE9iamVj dEZvclBhZ2UoKSBpcyBub3QgZGVmaW5lZCB3aGVuIEVOQUJMRShBQ0NFU1NJQklMSVRZKSBpcyBv ZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTI5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlZmlu ZSBBWE9iamVjdENhY2hlOjpmb2N1c2VkT2JqZWN0Rm9yUGFnZSgpIGFzIGEgZnVuY3Rpb24gd2hp Y2gKKwlyZXR1cm5zIGEgbnVsbHB0ci4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Zm9jdXNlZE9iamVj dEZvclBhZ2UpOiBEZWZpbmVkLgorCiAyMDIwLTExLTIyICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gQ29udmVydCBzb21lIHJl bWFpbmluZyBJbmxpbmVCb3ggYWNjZXNzIHRvIHVzZSBpbmxpbmUgaXRlcmF0b3IKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmgKaW5kZXggNzZhMzE2MjgxYzAx Li44YTkyYmQ5YjY1NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QVhPYmplY3RDYWNoZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5oCkBAIC0xNDUsNyArMTQ1LDExIEBAIHB1YmxpYzoKICAgICB+QVhPYmplY3RDYWNo ZSgpOwogCiAgICAgV0VCQ09SRV9FWFBPUlQgQVhDb3JlT2JqZWN0KiBmb2N1c2VkVUlFbGVtZW50 Rm9yUGFnZShjb25zdCBQYWdlKik7CisjaWYgRU5BQkxFKEFDQ0VTU0lCSUxJVFkpCiAgICAgc3Rh dGljIEFYQ29yZU9iamVjdCogZm9jdXNlZE9iamVjdEZvclBhZ2UoY29uc3QgUGFnZSopOworI2Vs c2UKKyAgICBzdGF0aWMgQVhDb3JlT2JqZWN0KiBmb2N1c2VkT2JqZWN0Rm9yUGFnZShjb25zdCBQ YWdlKikgeyByZXR1cm4gbnVsbHB0cjsgfQorI2VuZGlmCiAKICAgICAvLyBSZXR1cm5zIHRoZSBy b290IG9iamVjdCBmb3IgdGhlIGVudGlyZSBkb2N1bWVudC4KICAgICBXRUJDT1JFX0VYUE9SVCBB WENvcmVPYmplY3QqIHJvb3RPYmplY3QoKTsK 414872 2020-11-25 17:46:06 -0800 2020-11-26 16:10:36 -0800 Patch2 patch2.patch text/plain 2168 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjNhYjZiNGU2YzQuLmUzZjU3ZWFlNjA5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIwLTExLTI2ICBZb3NoaWFraSBKaXRzdWthd2EgIDx5b3NoaWFraS5q aXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAgQVhPYmplY3RDYWNoZTo6Zm9jdXNlZE9iamVj dEZvclBhZ2UoKSBpcyBub3QgZGVmaW5lZCB3aGVuIEVOQUJMRShBQ0NFU1NJQklMSVRZKSBpcyBv ZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTI5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlZmlu ZSBBWE9iamVjdENhY2hlOjpmb2N1c2VkT2JqZWN0Rm9yUGFnZSgpIGFzIGEgZnVuY3Rpb24gd2hp Y2gKKwlyZXR1cm5zIGEgbnVsbHB0ci4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6Zm9jdXNlZE9iamVj dEZvclBhZ2UpOiBEZWZpbmVkLgorCiAyMDIwLTExLTIyICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gQ29udmVydCBzb21lIHJl bWFpbmluZyBJbmxpbmVCb3ggYWNjZXNzIHRvIHVzZSBpbmxpbmUgaXRlcmF0b3IKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmgKaW5kZXggNzZhMzE2MjgxYzAx Li4yOTM4ZDc2Njc3NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QVhPYmplY3RDYWNoZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5oCkBAIC0xNDUsNyArMTQ1LDYgQEAgcHVibGljOgogICAgIH5BWE9iamVjdENhY2hl KCk7CiAKICAgICBXRUJDT1JFX0VYUE9SVCBBWENvcmVPYmplY3QqIGZvY3VzZWRVSUVsZW1lbnRG b3JQYWdlKGNvbnN0IFBhZ2UqKTsKLSAgICBzdGF0aWMgQVhDb3JlT2JqZWN0KiBmb2N1c2VkT2Jq ZWN0Rm9yUGFnZShjb25zdCBQYWdlKik7CiAKICAgICAvLyBSZXR1cm5zIHRoZSByb290IG9iamVj dCBmb3IgdGhlIGVudGlyZSBkb2N1bWVudC4KICAgICBXRUJDT1JFX0VYUE9SVCBBWENvcmVPYmpl Y3QqIHJvb3RPYmplY3QoKTsKQEAgLTIwMiw2ICsyMDEsOCBAQCBwdWJsaWM6CiAgICAgV0VCQ09S RV9FWFBPUlQgc3RhdGljIHZvaWQgZW5hYmxlQWNjZXNzaWJpbGl0eSgpOwogICAgIFdFQkNPUkVf RVhQT1JUIHN0YXRpYyB2b2lkIGRpc2FibGVBY2Nlc3NpYmlsaXR5KCk7CiAKKyAgICBzdGF0aWMg QVhDb3JlT2JqZWN0KiBmb2N1c2VkT2JqZWN0Rm9yUGFnZShjb25zdCBQYWdlKik7CisKICAgICAv LyBFbmhhbmNlZCB1c2VyIGludGVyZmFjZSBhY2Nlc3NpYmlsaXR5IGNhbiBiZSB0b2dnbGVkIGJ5 IHRoZSBhc3Npc3RpdmUgdGVjaG5vbG9neS4KICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgdm9p ZCBzZXRFbmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nlc3NpYmlsaXR5KGJvb2wgZmxhZyk7CiAgICAg CkBAIC0yMDksNiArMjEwLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIGFjY2Vzc2liaWxp dHlFbmFibGVkKCkgeyByZXR1cm4gZ0FjY2Vzc2liaWxpdHlFbmFibGVkOyB9CiAgICAgc3RhdGlj IGJvb2wgYWNjZXNzaWJpbGl0eUVuaGFuY2VkVXNlckludGVyZmFjZUVuYWJsZWQoKSB7IHJldHVy biBnQWNjZXNzaWJpbGl0eUVuaGFuY2VkVXNlckludGVyZmFjZUVuYWJsZWQ7IH0KICNlbHNlCisg ICAgc3RhdGljIEFYQ29yZU9iamVjdCogZm9jdXNlZE9iamVjdEZvclBhZ2UoY29uc3QgUGFnZSop IHsgcmV0dXJuIG51bGxwdHI7IH0KICAgICBzdGF0aWMgdm9pZCBlbmFibGVBY2Nlc3NpYmlsaXR5 KCkgeyB9CiAgICAgc3RhdGljIHZvaWQgZGlzYWJsZUFjY2Vzc2liaWxpdHkoKSB7IH0KICAgICBz dGF0aWMgdm9pZCBzZXRFbmhhbmNlZFVzZXJJbnRlcmZhY2VBY2Nlc3NpYmlsaXR5KGJvb2wpIHsg fQo= 414910 2020-11-26 16:10:36 -0800 2020-11-26 17:22:20 -0800 Patch (fix tabs in the change log) patch3.patch text/plain 2175 yoshiaki.jitsukawa ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjNhYjZiNGU2YzQuLmUzZjU3ZWFlNjA5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIwLTExLTI2ICBZb3NoaWFraSBKaXRzdWthd2EgIDx5b3NoaWFraS5q aXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAgQVhPYmplY3RDYWNoZTo6Zm9jdXNlZE9iamVj dEZvclBhZ2UoKSBpcyBub3QgZGVmaW5lZCB3aGVuIEVOQUJMRShBQ0NFU1NJQklMSVRZKSBpcyBv ZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTI5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IENocmlzIEZsZWl6YWNoLgorCisgICAgICAgIERlZmlu ZSBBWE9iamVjdENhY2hlOjpmb2N1c2VkT2JqZWN0Rm9yUGFnZSgpIGFzIGEgZnVuY3Rpb24gd2hp Y2gKKyAgICAgICAgcmV0dXJucyBhIG51bGxwdHIuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5 L0FYT2JqZWN0Q2FjaGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmZvY3Vz ZWRPYmplY3RGb3JQYWdlKTogRGVmaW5lZC4KKwogMjAyMC0xMS0yMiAgQW50dGkgS29pdmlzdG8g IDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIENvbnZlcnQg c29tZSByZW1haW5pbmcgSW5saW5lQm94IGFjY2VzcyB0byB1c2UgaW5saW5lIGl0ZXJhdG9yCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaCBi L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCmluZGV4IDc2YTMx NjI4MWMwMS4uMjkzOGQ3NjY3NzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FYT2JqZWN0Q2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FYT2JqZWN0Q2FjaGUuaApAQCAtMTQ1LDcgKzE0NSw2IEBAIHB1YmxpYzoKICAgICB+QVhPYmpl Y3RDYWNoZSgpOwogCiAgICAgV0VCQ09SRV9FWFBPUlQgQVhDb3JlT2JqZWN0KiBmb2N1c2VkVUlF bGVtZW50Rm9yUGFnZShjb25zdCBQYWdlKik7Ci0gICAgc3RhdGljIEFYQ29yZU9iamVjdCogZm9j dXNlZE9iamVjdEZvclBhZ2UoY29uc3QgUGFnZSopOwogCiAgICAgLy8gUmV0dXJucyB0aGUgcm9v dCBvYmplY3QgZm9yIHRoZSBlbnRpcmUgZG9jdW1lbnQuCiAgICAgV0VCQ09SRV9FWFBPUlQgQVhD b3JlT2JqZWN0KiByb290T2JqZWN0KCk7CkBAIC0yMDIsNiArMjAxLDggQEAgcHVibGljOgogICAg IFdFQkNPUkVfRVhQT1JUIHN0YXRpYyB2b2lkIGVuYWJsZUFjY2Vzc2liaWxpdHkoKTsKICAgICBX RUJDT1JFX0VYUE9SVCBzdGF0aWMgdm9pZCBkaXNhYmxlQWNjZXNzaWJpbGl0eSgpOwogCisgICAg c3RhdGljIEFYQ29yZU9iamVjdCogZm9jdXNlZE9iamVjdEZvclBhZ2UoY29uc3QgUGFnZSopOwor CiAgICAgLy8gRW5oYW5jZWQgdXNlciBpbnRlcmZhY2UgYWNjZXNzaWJpbGl0eSBjYW4gYmUgdG9n Z2xlZCBieSB0aGUgYXNzaXN0aXZlIHRlY2hub2xvZ3kuCiAgICAgV0VCQ09SRV9FWFBPUlQgc3Rh dGljIHZvaWQgc2V0RW5oYW5jZWRVc2VySW50ZXJmYWNlQWNjZXNzaWJpbGl0eShib29sIGZsYWcp OwogICAgIApAQCAtMjA5LDYgKzIxMCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBhY2Nl c3NpYmlsaXR5RW5hYmxlZCgpIHsgcmV0dXJuIGdBY2Nlc3NpYmlsaXR5RW5hYmxlZDsgfQogICAg IHN0YXRpYyBib29sIGFjY2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VFbmFibGVkKCkg eyByZXR1cm4gZ0FjY2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VFbmFibGVkOyB9CiAj ZWxzZQorICAgIHN0YXRpYyBBWENvcmVPYmplY3QqIGZvY3VzZWRPYmplY3RGb3JQYWdlKGNvbnN0 IFBhZ2UqKSB7IHJldHVybiBudWxscHRyOyB9CiAgICAgc3RhdGljIHZvaWQgZW5hYmxlQWNjZXNz aWJpbGl0eSgpIHsgfQogICAgIHN0YXRpYyB2b2lkIGRpc2FibGVBY2Nlc3NpYmlsaXR5KCkgeyB9 CiAgICAgc3RhdGljIHZvaWQgc2V0RW5oYW5jZWRVc2VySW50ZXJmYWNlQWNjZXNzaWJpbGl0eShi b29sKSB7IH0K