219268 2020-11-23 19:14:28 -0800 [GTK4] Declare lambda return type to avoid build error deducing it 2020-11-26 18:57:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210100 1 lmoura lmoura aperez bugs-noreply cgarcia webkit-bug-importer oldest_to_newest 1709958 0 lmoura 2020-11-23 19:14:28 -0800 [GTK4] Declare lambda return type to avoid build error deducing it 1709959 1 414820 lmoura 2020-11-23 19:15:25 -0800 Created attachment 414820 Patch 1709968 2 414820 cgarcia 2020-11-23 23:11:53 -0800 Comment on attachment 414820 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414820&action=review > Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:258 > - g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) { > + g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) -> bool { it should be gboolean, not bool 1710107 3 414878 lmoura 2020-11-25 21:45:40 -0800 Created attachment 414878 Patch with gboolean 1710202 4 ews-feeder 2020-11-26 18:56:04 -0800 Committed r270177: <https://trac.webkit.org/changeset/270177> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414878. 1710203 5 webkit-bug-importer 2020-11-26 18:57:16 -0800 <rdar://problem/71756197> 414820 2020-11-23 19:15:25 -0800 2020-11-25 21:45:36 -0800 Patch bug-219268-20201124001524.patch text/plain 1809 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5Nzc2OWJlYjQwYWZjNWY4 ZGNjNDdjYjE0MWY4YzU4MDUwMzMxNGMuLjcxYjZmOGJmMWRhZDE5NmVmY2I3ZTcxNjZjNTc0Yzg4 NWIwN2RiZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMTEtMjMgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUSzRdIERlY2xhcmUgbGFtYmRh IHJldHVybiB0eXBlIHRvIGF2b2lkIGJ1aWxkIGVycm9yIGRlZHVjaW5nIGl0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkyNjgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2Vi UG9wdXBNZW51UHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVQcm94 eUd0azo6Y3JlYXRlUG9wdXBNZW51KToKKwogMjAyMC0xMS0yMSAgU2lodWkgTGl1ICA8c2lodWlf bGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgYXVkaW8gY2FwdHVyZSBmb3IgU3Bl ZWNoUmVjb2duaXRpb24gb24gbWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9ndGsvV2ViUG9wdXBNZW51UHJveHlHdGsuY3BwCmluZGV4IDIzODdmY2RiMjI5ODE5MWJlN2E3 M2VlZGRjYTJkMjI5ZmRkZTM5NDEuLmE1MjM4MTQwZjdjYWZmOWU0NWE3M2Y2Njk1NTFlMWQ4OTFm ZTE5NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XZWJQb3B1cE1l bnVQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dlYlBvcHVw TWVudVByb3h5R3RrLmNwcApAQCAtMjU1LDcgKzI1NSw3IEBAIHZvaWQgV2ViUG9wdXBNZW51UHJv eHlHdGs6OmNyZWF0ZVBvcHVwTWVudShjb25zdCBWZWN0b3I8V2ViUG9wdXBJdGVtPiYgaXRlbXMs IGluCiAgICAgZ3RrX3dpZGdldF9zZXRfcGFyZW50KG1fcG9wdXAsIG1fd2ViVmlldyk7CiAKICAg ICBhdXRvKiBjb250cm9sbGVyID0gZ3RrX2V2ZW50X2NvbnRyb2xsZXJfa2V5X25ldygpOwotICAg IGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChjb250cm9sbGVyLCAia2V5LXByZXNzZWQiLCBHX0NB TExCQUNLKCtbXShXZWJQb3B1cE1lbnVQcm94eUd0ayogcG9wdXBNZW51LCB1bnNpZ25lZCBrZXl2 YWwsIHVuc2lnbmVkLCBHZGtNb2RpZmllclR5cGUsIEd0a0V2ZW50Q29udHJvbGxlciogY29udHJv bGxlcikgeworICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChjb250cm9sbGVyLCAia2V5LXBy ZXNzZWQiLCBHX0NBTExCQUNLKCtbXShXZWJQb3B1cE1lbnVQcm94eUd0ayogcG9wdXBNZW51LCB1 bnNpZ25lZCBrZXl2YWwsIHVuc2lnbmVkLCBHZGtNb2RpZmllclR5cGUsIEd0a0V2ZW50Q29udHJv bGxlciogY29udHJvbGxlcikgLT4gYm9vbCB7CiAgICAgICAgIGF1dG8qIGV2ZW50ID0gZ3RrX2V2 ZW50X2NvbnRyb2xsZXJfZ2V0X2N1cnJlbnRfZXZlbnQoY29udHJvbGxlcik7CiAgICAgICAgIGlm IChwb3B1cE1lbnUtPnR5cGVBaGVhZEZpbmQoa2V5dmFsLCBnZGtfZXZlbnRfZ2V0X3RpbWUoZXZl bnQpKSkKICAgICAgICAgICAgIHJldHVybiBHREtfRVZFTlRfU1RPUDsK 414878 2020-11-25 21:45:40 -0800 2020-11-26 18:56:04 -0800 Patch with gboolean bug-219268-20201126024539.patch text/plain 1813 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5Nzc2OWJlYjQwYWZjNWY4 ZGNjNDdjYjE0MWY4YzU4MDUwMzMxNGMuLjcxYjZmOGJmMWRhZDE5NmVmY2I3ZTcxNjZjNTc0Yzg4 NWIwN2RiZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMTEtMjMgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUSzRdIERlY2xhcmUgbGFtYmRh IHJldHVybiB0eXBlIHRvIGF2b2lkIGJ1aWxkIGVycm9yIGRlZHVjaW5nIGl0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkyNjgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2Vi UG9wdXBNZW51UHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVQcm94 eUd0azo6Y3JlYXRlUG9wdXBNZW51KToKKwogMjAyMC0xMS0yMSAgU2lodWkgTGl1ICA8c2lodWlf bGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgYXVkaW8gY2FwdHVyZSBmb3IgU3Bl ZWNoUmVjb2duaXRpb24gb24gbWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9ndGsvV2ViUG9wdXBNZW51UHJveHlHdGsuY3BwCmluZGV4IDIzODdmY2RiMjI5ODE5MWJlN2E3 M2VlZGRjYTJkMjI5ZmRkZTM5NDEuLjViNDYwOTk3OTJiNjk5ZTBhZTA0NzljMjhhYTAzYzNhNzkz NGIxMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9XZWJQb3B1cE1l bnVQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1dlYlBvcHVw TWVudVByb3h5R3RrLmNwcApAQCAtMjU1LDcgKzI1NSw3IEBAIHZvaWQgV2ViUG9wdXBNZW51UHJv eHlHdGs6OmNyZWF0ZVBvcHVwTWVudShjb25zdCBWZWN0b3I8V2ViUG9wdXBJdGVtPiYgaXRlbXMs IGluCiAgICAgZ3RrX3dpZGdldF9zZXRfcGFyZW50KG1fcG9wdXAsIG1fd2ViVmlldyk7CiAKICAg ICBhdXRvKiBjb250cm9sbGVyID0gZ3RrX2V2ZW50X2NvbnRyb2xsZXJfa2V5X25ldygpOwotICAg IGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChjb250cm9sbGVyLCAia2V5LXByZXNzZWQiLCBHX0NB TExCQUNLKCtbXShXZWJQb3B1cE1lbnVQcm94eUd0ayogcG9wdXBNZW51LCB1bnNpZ25lZCBrZXl2 YWwsIHVuc2lnbmVkLCBHZGtNb2RpZmllclR5cGUsIEd0a0V2ZW50Q29udHJvbGxlciogY29udHJv bGxlcikgeworICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChjb250cm9sbGVyLCAia2V5LXBy ZXNzZWQiLCBHX0NBTExCQUNLKCtbXShXZWJQb3B1cE1lbnVQcm94eUd0ayogcG9wdXBNZW51LCB1 bnNpZ25lZCBrZXl2YWwsIHVuc2lnbmVkLCBHZGtNb2RpZmllclR5cGUsIEd0a0V2ZW50Q29udHJv bGxlciogY29udHJvbGxlcikgLT4gZ2Jvb2xlYW4gewogICAgICAgICBhdXRvKiBldmVudCA9IGd0 a19ldmVudF9jb250cm9sbGVyX2dldF9jdXJyZW50X2V2ZW50KGNvbnRyb2xsZXIpOwogICAgICAg ICBpZiAocG9wdXBNZW51LT50eXBlQWhlYWRGaW5kKGtleXZhbCwgZ2RrX2V2ZW50X2dldF90aW1l KGV2ZW50KSkpCiAgICAgICAgICAgICByZXR1cm4gR0RLX0VWRU5UX1NUT1A7Cg==