219264 2020-11-23 15:12:20 -0800 [WPE][GTK] Fix build with GCC 11 2020-11-26 15:56:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro benjamin bugs-noreply cdumez cgarcia cmarcelo ews-watchlist mcatanzaro oldest_to_newest 1709942 0 mcatanzaro 2020-11-23 15:12:20 -0800 WTFGType is using volatile improperly when defining the get_type() macro, because the code is copied from GLib, which had the same bug. See: https://gitlab.gnome.org/GNOME/glib/-/issues/600#note_877282 1709944 1 414813 mcatanzaro 2020-11-23 15:14:45 -0800 Created attachment 414813 Patch 1709945 2 mcatanzaro 2020-11-23 15:19:01 -0800 Honestly I'm not sure why this is a hard build failure. It causes a -Wincompatible-pointer-types warning. Maybe the compiler people decided to test a build with -Werror=incompatible-pointer-types enabled? Regardless, it's nice to see such problems pop up early, rather than waiting until after GCC 11 hits Fedora next year.... 1710182 3 ews-feeder 2020-11-26 15:56:47 -0800 Committed r270166: <https://trac.webkit.org/changeset/270166> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414813. 414813 2020-11-23 15:14:45 -0800 2020-11-26 15:56:48 -0800 Patch bug-219264-20201123171458.patch text/plain 2028 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY5NDRmNzYzMTc4NTQ5MzNhNGRjZmU4 N2QxNTY1N2E5OWJjMmI4ZmMuLjBjYTNjYzBhM2ZkNDljYTgwNjlkMGI1MGQyODg1NDllOGNiYjgw ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTEtMjMgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBGaXggYnVpbGQgd2l0 aCBHQ0MgMTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxOTI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEl0J3Mgbm90IHVuY29tbW9uIGZvciByZWFsbHkgb2xkIGNvZGUgbGlrZSB0aGlzIHRvIGFidXNl IHZvbGF0aWxlIGFzIGlmIGl0IHdlcmUgYQorICAgICAgICBzeW5jaHJvbml6YXRpb24gcHJpbWl0 aXZlLiBJdCdzIG5vdC4gVGhpcyBjb2RlIGlzIGFscmVhZHkgc3luY2hyb25pemVkIGJ5IHVzZSBv ZiBHT25jZSwgc28KKyAgICAgICAgaXQgY2FuIGJlIHNhZmVseSByZW1vdmVkLiBSZWZlcmVuY2Vz OgorCisgICAgICAgIGh0dHBzOi8vZ2l0bGFiLmdub21lLm9yZy9HTk9NRS9nbGliLy0vaXNzdWVz LzYwMCNub3RlXzg3NzI4MgorICAgICAgICBodHRwOi8vaXN2b2xhdGlsZXVzZWZ1bHdpdGh0aHJl YWRzLmluL0MrKy8KKworICAgICAgICAqIHd0Zi9nbGliL1dURkdUeXBlLmg6CisKIDIwMjAtMTEt MTcgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQg ZmFpbHMgb24gaW50ZXJuYWwgc2ltdWxhdG9yIGJ1aWxkcyBkdWUgdG8gbWlzc2luZyBlbnVtIGtD VlBpeGVsRm9ybWF0VHlwZV9BR1hfNDIwWXBDYkNyOEJpUGxhbmFyVmlkZW9SYW5nZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvZ2xpYi9XVEZHVHlwZS5oIGIvU291cmNlL1dURi93dGYvZ2xp Yi9XVEZHVHlwZS5oCmluZGV4IDIwMzUyMmU2NTI2YzBjZTdlZjUyNDA4Y2RiYTBiOTc2YTE3NTVl YjMuLmRlZDMzZTUzNmUzNTRlYjlkMTM2NDBhYjgzYTA4Mzk0M2QwYmY5MWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL2dsaWIvV1RGR1R5cGUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9nbGli L1dURkdUeXBlLmgKQEAgLTc0LDEyICs3NCwxMiBAQCBzdGF0aWMgdm9pZCB0eXBlX25hbWUjI19p bml0KFR5cGVOYW1lKiBzZWxmLCBncG9pbnRlcikgXAogXAogR1R5cGUgdHlwZV9uYW1lIyNfZ2V0 X3R5cGUodm9pZCkgXAogeyBcCi0gICAgc3RhdGljIHZvbGF0aWxlIGdzaXplIGdfZGVmaW5lX3R5 cGVfaWRfX3ZvbGF0aWxlID0gMDsgXAotICAgIGlmIChnX29uY2VfaW5pdF9lbnRlcigmZ19kZWZp bmVfdHlwZV9pZF9fdm9sYXRpbGUpKSB7IFwKKyAgICBzdGF0aWMgZ3NpemUgc3RhdGljX2dfZGVm aW5lX3R5cGVfaWQgPSAwOyBcCisgICAgaWYgKGdfb25jZV9pbml0X2VudGVyKCZzdGF0aWNfZ19k ZWZpbmVfdHlwZV9pZCkpIHsgXAogICAgICAgICBHVHlwZSBnX2RlZmluZV90eXBlX2lkID0gdHlw ZV9uYW1lIyNfZ2V0X3R5cGVfb25jZSgpOyBcCi0gICAgICAgIGdfb25jZV9pbml0X2xlYXZlKCZn X2RlZmluZV90eXBlX2lkX192b2xhdGlsZSwgZ19kZWZpbmVfdHlwZV9pZCk7IFwKKyAgICAgICAg Z19vbmNlX2luaXRfbGVhdmUoJnN0YXRpY19nX2RlZmluZV90eXBlX2lkLCBnX2RlZmluZV90eXBl X2lkKTsgXAogICAgIH0gXAotICAgIHJldHVybiBnX2RlZmluZV90eXBlX2lkX192b2xhdGlsZTsg XAorICAgIHJldHVybiBzdGF0aWNfZ19kZWZpbmVfdHlwZV9pZDsgXAogfSAvKiBDbG9zZXMgdHlw ZV9uYW1lIyNfZ2V0X3R5cGUoKS4gKi8gXAogXAogTkVWRVJfSU5MSU5FIHN0YXRpYyBHVHlwZSB0 eXBlX25hbWUjI19nZXRfdHlwZV9vbmNlKHZvaWQpIFwK