<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>219260</bug_id>
          
          <creation_ts>2020-11-23 09:20:49 -0800</creation_ts>
          <short_desc>Fix ANGLE CMakeLists.txt warnings</short_desc>
          <delta_ts>2022-08-16 14:08:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>ANGLE</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WORKSFORME</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>244008</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rbuis</reporter>
          <assigned_to name="Rob Buis">rbuis</assigned_to>
          <cc>annulen</cc>
    
    <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>graouts</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>pnormand</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1709907</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-11-23 09:20:49 -0800</bug_when>
    <thetext>Make Warning (dev) at Source/ThirdParty/ANGLE/CMakeLists.txt:103:
  Syntax Warning in cmake code at column 37

  Argument not separated from preceding token by whitespace.
This warning is for project developers.  Use -Wno-dev to suppress it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1709908</commentid>
    <comment_count>1</comment_count>
      <attachid>414806</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-11-23 09:23:03 -0800</bug_when>
    <thetext>Created attachment 414806
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710094</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2020-11-25 19:16:44 -0800</bug_when>
    <thetext>Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710300</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-11-27 08:32:18 -0800</bug_when>
    <thetext>Committed r270194: &lt;https://trac.webkit.org/changeset/270194&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414806.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710302</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-11-27 08:33:22 -0800</bug_when>
    <thetext>&lt;rdar://problem/71765587&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710830</commentid>
    <comment_count>5</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-11-30 15:43:48 -0800</bug_when>
    <thetext>Reverted r270129, r270194, and r270258 for reason:

r270129 broke macCatalyst build

Committed r270272: &lt;https://trac.webkit.org/changeset/270272&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1710997</commentid>
    <comment_count>6</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-12-01 03:27:41 -0800</bug_when>
    <thetext>Since the revert of r270129 this is no longer needed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>414806</attachid>
            <date>2020-11-23 09:23:03 -0800</date>
            <delta_ts>2020-11-27 08:32:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-219260-20201123182301.patch</filename>
            <type>text/plain</type>
            <size>1498</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k
ZXggOWFiNDc1ZGU4ZGY1ZTQxNDgxNmQ1NDA4YmE3OGM4ODg3YzMxY2IwYi4uNWY4NDJhYTljN2Nm
ZTAxNzY0NGRkYTE1OTFkYTQ2ZTE5Mzc4YWEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTExLTIzICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5j
b20+CisKKyAgICAgICAgRml4IEFOR0xFIENNYWtlTGlzdHMudHh0IHdhcm5pbmdzCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkyNjAKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggd2FybmluZyB3aGVu
IGJ1aWxkaW5nIG9uIEdUSzoKKyAgICAgICAgTWFrZSBXYXJuaW5nIChkZXYpIGF0IFNvdXJjZS9U
aGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0OjEwMzoKKyAgICAgICAgU3ludGF4IFdhcm5p
bmcgaW4gY21ha2UgY29kZSBhdCBjb2x1bW4gMzcKKworICAgICAgICBBcmd1bWVudCBub3Qgc2Vw
YXJhdGVkIGZyb20gcHJlY2VkaW5nIHRva2VuIGJ5IHdoaXRlc3BhY2UuCisgICAgICAgIFRoaXMg
d2FybmluZyBpcyBmb3IgcHJvamVjdCBkZXZlbG9wZXJzLiAgVXNlIC1Xbm8tZGV2IHRvIHN1cHBy
ZXNzIGl0LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjAtMTEtMjAgIEphbWVz
IERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBB
TkdMRSAyMDIwLTExLTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFr
ZUxpc3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0CmluZGV4
IDJmYjM3ZTk2NzY1NTE3ZTM1NzdjOWFiYjZjNWUwNzcxYmYwYjM1OTMuLmUwZjViZjI1NThkMDZh
NzRjMTZiMjU4NTEyYmRjM2FlYjMxOTk1ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5
L0FOR0xFL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtl
TGlzdHMudHh0CkBAIC0xMDAsOCArMTAwLDggQEAgc2V0KHpsaWJfd3JhcHBlcl9zb3VyY2VzCiAp
CiAKIHNldChhbmdsZV9nbF9lbnVtX3V0aWxzCi0gICAgInNyYy9saWJBTkdMRS9nbF9lbnVtX3V0
aWxzLmNwcCIsCi0gICAgInNyYy9saWJBTkdMRS9nbF9lbnVtX3V0aWxzX2F1dG9nZW4uY3BwIiwK
KyAgICAic3JjL2xpYkFOR0xFL2dsX2VudW1fdXRpbHMuY3BwIgorICAgICJzcmMvbGliQU5HTEUv
Z2xfZW51bV91dGlsc19hdXRvZ2VuLmNwcCIKICkKIAogV0VCS0lUX0lOQ0xVREVfQ09ORklHX0ZJ
TEVTX0lGX0VYSVNUUygpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>