219244 2020-11-22 05:38:12 -0800 [LFC][Integration] Convert some remaining InlineBox access to use inline iterator 2020-11-22 06:54:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham cdumez changseok esprehn+autocc ews-watchlist glenn kangil.han kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1709833 0 koivisto 2020-11-22 05:38:12 -0800 Less direct InlineBox access 1709834 1 414788 koivisto 2020-11-22 05:40:46 -0800 Created attachment 414788 patch 1709837 2 ews-feeder 2020-11-22 06:53:06 -0800 Committed r270164: <https://trac.webkit.org/changeset/270164> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414788. 1709838 3 webkit-bug-importer 2020-11-22 06:54:16 -0800 <rdar://problem/71665475> 414788 2020-11-22 05:40:46 -0800 2020-11-22 06:53:06 -0800 patch lfc-iterator-random.patch text/plain 5605 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMDhiNWNkYjZiOGEuLmEwYzA3MzNiY2NmMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIxIEBACisyMDIwLTExLTIyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gQ29udmVydCBzb21lIHJlbWFpbmluZyBJ bmxpbmVCb3ggYWNjZXNzIHRvIHVzZSBpbmxpbmUgaXRlcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTI0NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL1Bvc2l0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Omhhc0lubGluZVJ1bik6CisgICAgICAgIChXZWJDb3JlOjpuZXh0UmVuZGVy ZWRFZGl0YWJsZSk6CisgICAgICAgIChXZWJDb3JlOjpwcmV2aW91c1JlbmRlcmVkRWRpdGFibGUp OgorICAgICAgICAoV2ViQ29yZTo6aGFzSW5saW5lQm94V3JhcHBlcik6IERlbGV0ZWQuCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyRWxlbWVudDo6Z2V0TGVhZGluZ0Nvcm5lciBjb25zdCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlclRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dDo6dG9wT2ZGaXJz dFRleHQgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Lmg6 CisKIDIwMjAtMTEtMjIgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBG aXggZ2V0SW5kZXhlZFBhcmFtZXRlciBpbmRleGluZyBjcmFzaApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5j cHAKaW5kZXggNTcwZWZmMDNmNWNmLi5iOTdhYTE0MjYzMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Bvc2l0aW9u LmNwcApAQCAtNjgsMTMgKzY4LDEzIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFt ZXNwYWNlIEhUTUxOYW1lczsKIAotc3RhdGljIGJvb2wgaGFzSW5saW5lQm94V3JhcHBlcihSZW5k ZXJPYmplY3QmIHJlbmRlcmVyKQorc3RhdGljIGJvb2wgaGFzSW5saW5lUnVuKFJlbmRlck9iamVj dCYgcmVuZGVyZXIpCiB7Ci0gICAgaWYgKGlzPFJlbmRlckJveD4ocmVuZGVyZXIpICYmIGRvd25j YXN0PFJlbmRlckJveD4ocmVuZGVyZXIpLmlubGluZUJveFdyYXBwZXIoKSkKKyAgICBpZiAoaXM8 UmVuZGVyQm94PihyZW5kZXJlcikgJiYgTGF5b3V0SW50ZWdyYXRpb246OnJ1bkZvcihkb3duY2Fz dDxSZW5kZXJCb3g+KHJlbmRlcmVyKSkpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAgIGlmIChp czxSZW5kZXJUZXh0PihyZW5kZXJlcikgJiYgZG93bmNhc3Q8UmVuZGVyVGV4dD4ocmVuZGVyZXIp LmZpcnN0VGV4dEJveCgpKQorICAgIGlmIChpczxSZW5kZXJUZXh0PihyZW5kZXJlcikgJiYgTGF5 b3V0SW50ZWdyYXRpb246OmZpcnN0VGV4dFJ1bkZvcihkb3duY2FzdDxSZW5kZXJUZXh0PihyZW5k ZXJlcikpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAoaXM8UmVuZGVyTGluZUJyZWFr PihyZW5kZXJlcikgJiYgZG93bmNhc3Q8UmVuZGVyTGluZUJyZWFrPihyZW5kZXJlcikuaW5saW5l Qm94V3JhcHBlcigpKQorICAgIGlmIChpczxSZW5kZXJMaW5lQnJlYWs+KHJlbmRlcmVyKSAmJiBM YXlvdXRJbnRlZ3JhdGlvbjo6cnVuRm9yKGRvd25jYXN0PFJlbmRlckxpbmVCcmVhaz4ocmVuZGVy ZXIpKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgcmV0dXJuIGZhbHNlOwogfQpAQCAtODUs NyArODUsNyBAQCBzdGF0aWMgTm9kZSogbmV4dFJlbmRlcmVkRWRpdGFibGUoTm9kZSogbm9kZSkK ICAgICAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IG5vZGUtPnJlbmRlcmVyKCk7CiAgICAg ICAgIGlmICghcmVuZGVyZXIgfHwgIW5vZGUtPmhhc0VkaXRhYmxlU3R5bGUoKSkKICAgICAgICAg ICAgIGNvbnRpbnVlOwotICAgICAgICBpZiAoaGFzSW5saW5lQm94V3JhcHBlcigqcmVuZGVyZXIp KQorICAgICAgICBpZiAoaGFzSW5saW5lUnVuKCpyZW5kZXJlcikpCiAgICAgICAgICAgICByZXR1 cm4gbm9kZTsKICAgICB9CiAgICAgcmV0dXJuIG51bGxwdHI7CkBAIC05Nyw3ICs5Nyw3IEBAIHN0 YXRpYyBOb2RlKiBwcmV2aW91c1JlbmRlcmVkRWRpdGFibGUoTm9kZSogbm9kZSkKICAgICAgICAg UmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IG5vZGUtPnJlbmRlcmVyKCk7CiAgICAgICAgIGlmICgh cmVuZGVyZXIgfHwgIW5vZGUtPmhhc0VkaXRhYmxlU3R5bGUoKSkKICAgICAgICAgICAgIGNvbnRp bnVlOwotICAgICAgICBpZiAoaGFzSW5saW5lQm94V3JhcHBlcigqcmVuZGVyZXIpKQorICAgICAg ICBpZiAoaGFzSW5saW5lUnVuKCpyZW5kZXJlcikpCiAgICAgICAgICAgICByZXR1cm4gbm9kZTsK ICAgICB9CiAgICAgcmV0dXJuIG51bGxwdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRWxlbWVudC5jcHAKaW5kZXggNTQ0N2Q2OThiYmQ1Li4wZjhmYjM5MzgxMzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKQEAgLTQzLDYgKzQzLDggQEAK ICNpbmNsdWRlICJIVE1MSHRtbEVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MSW1hZ2VFbGVtZW50 LmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCisjaW5jbHVkZSAiTGF5b3V0SW50ZWdyYXRpb25M aW5lSXRlcmF0b3IuaCIKKyNpbmNsdWRlICJMYXlvdXRJbnRlZ3JhdGlvblJ1bkl0ZXJhdG9yLmgi CiAjaW5jbHVkZSAiTGVuZ3RoRnVuY3Rpb25zLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2lu Y2x1ZGUgIlBhZ2UuaCIKQEAgLTE1NjksMTMgKzE1NzEsMTUgQEAgYm9vbCBSZW5kZXJFbGVtZW50 OjpnZXRMZWFkaW5nQ29ybmVyKEZsb2F0UG9pbnQmIHBvaW50LCBib29sJiBpbnNpZGVGaXhlZCkg Y29uc3QKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CiAKLSAgICAgICAgaWYg KHAtPm5vZGUoKSAmJiBwLT5ub2RlKCkgPT0gZWxlbWVudCgpICYmIGlzPFJlbmRlclRleHQ+KCpv KSAmJiAhZG93bmNhc3Q8UmVuZGVyVGV4dD4oKm8pLmZpcnN0VGV4dEJveCgpKSB7CisgICAgICAg IGlmIChwLT5ub2RlKCkgJiYgcC0+bm9kZSgpID09IGVsZW1lbnQoKSAmJiBpczxSZW5kZXJUZXh0 PigqbykgJiYgIUxheW91dEludGVncmF0aW9uOjpmaXJzdFRleHRSdW5Gb3IoZG93bmNhc3Q8UmVu ZGVyVGV4dD4oKm8pKSkgewogICAgICAgICAgICAgLy8gZG8gbm90aGluZyAtIHNraXAgdW5yZW5k ZXJlZCB3aGl0ZXNwYWNlIHRoYXQgaXMgYSBjaGlsZCBvciBuZXh0IHNpYmxpbmcgb2YgdGhlIGFu Y2hvcgogICAgICAgICB9IGVsc2UgaWYgKGlzPFJlbmRlclRleHQ+KCpvKSB8fCBvLT5pc1JlcGxh Y2VkKCkpIHsKICAgICAgICAgICAgIHBvaW50ID0gRmxvYXRQb2ludCgpOwotICAgICAgICAgICAg aWYgKGlzPFJlbmRlclRleHQ+KCpvKSAmJiBkb3duY2FzdDxSZW5kZXJUZXh0PigqbykuZmlyc3RU ZXh0Qm94KCkpCi0gICAgICAgICAgICAgICAgcG9pbnQubW92ZShkb3duY2FzdDxSZW5kZXJUZXh0 PigqbykubGluZXNCb3VuZGluZ0JveCgpLngoKSwgZG93bmNhc3Q8UmVuZGVyVGV4dD4oKm8pLnRv cE9mRmlyc3RUZXh0KCkpOwotICAgICAgICAgICAgZWxzZSBpZiAoaXM8UmVuZGVyQm94Pigqbykp CisgICAgICAgICAgICBpZiAoaXM8UmVuZGVyVGV4dD4oKm8pKSB7CisgICAgICAgICAgICAgICAg YXV0byYgdGV4dFJlbmRlcmVyID0gZG93bmNhc3Q8UmVuZGVyVGV4dD4oKm8pOworICAgICAgICAg ICAgICAgIGlmIChhdXRvIHJ1biA9IExheW91dEludGVncmF0aW9uOjpmaXJzdFRleHRSdW5Gb3Io dGV4dFJlbmRlcmVyKSkKKyAgICAgICAgICAgICAgICAgICAgcG9pbnQubW92ZSh0ZXh0UmVuZGVy ZXIubGluZXNCb3VuZGluZ0JveCgpLngoKSwgcnVuLmxpbmUoKS0+dG9wKCkpOworICAgICAgICAg ICAgfSBlbHNlIGlmIChpczxSZW5kZXJCb3g+KCpvKSkKICAgICAgICAgICAgICAgICBwb2ludC5t b3ZlQnkoZG93bmNhc3Q8UmVuZGVyQm94PigqbykubG9jYXRpb24oKSk7CiAgICAgICAgICAgICBw b2ludCA9IG8tPmNvbnRhaW5lcigpLT5sb2NhbFRvQWJzb2x1dGUocG9pbnQsIFVzZVRyYW5zZm9y bXMsICZpbnNpZGVGaXhlZCk7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAppbmRleCA0YTRlNzIzYzZiYWMuLjg1ZTA4MmEwZGFm NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcApAQCAtMTMzMiwxMSAr MTMzMiw2IEBAIFVDaGFyIFJlbmRlclRleHQ6OnByZXZpb3VzQ2hhcmFjdGVyKCkgY29uc3QKICAg ICByZXR1cm4gcHJldmlvdXNTdHJpbmdbcHJldmlvdXNTdHJpbmcubGVuZ3RoKCkgLSAxXTsKIH0K IAotTGF5b3V0VW5pdCBSZW5kZXJUZXh0Ojp0b3BPZkZpcnN0VGV4dCgpIGNvbnN0Ci17Ci0gICAg cmV0dXJuIGZpcnN0VGV4dEJveCgpLT5yb290KCkubGluZVRvcCgpOwotfQotCiBTdHJpbmcgYXBw bHlUZXh0VHJhbnNmb3JtKGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSwgY29uc3QgU3RyaW5nJiB0 ZXh0LCBVQ2hhciBwcmV2aW91c0NoYXJhY3RlcikKIHsKICAgICBzd2l0Y2ggKHN0eWxlLnRleHRU cmFuc2Zvcm0oKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmgKaW5kZXggYWFk NzkzZjNjZjI4Li5iNWQyODU4OWNlYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRl eHQuaApAQCAtMTcxLDggKzE3MSw2IEBAIHB1YmxpYzoKICAgICBib29sIHVzZXNDb21wbGV4TGlu ZUxheW91dFBhdGgoKSBjb25zdDsKIAogICAgIFN0cmluZ1ZpZXcgc3RyaW5nVmlldyh1bnNpZ25l ZCBzdGFydCA9IDAsIE9wdGlvbmFsPHVuc2lnbmVkPiBzdG9wID0gV1RGOjpudWxsb3B0KSBjb25z dDsKLQotICAgIExheW91dFVuaXQgdG9wT2ZGaXJzdFRleHQoKSBjb25zdDsKICAgICAKICAgICBi b29sIGNvbnRhaW5zT25seUhUTUxXaGl0ZXNwYWNlKHVuc2lnbmVkIGZyb20sIHVuc2lnbmVkIGxl bmd0aCkgY29uc3Q7CiAgICAgCg==