219221 2020-11-20 13:39:40 -0800 [GTK][GTK4] Building with GObject-Introspection support does not work 2020-11-26 20:22:19 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 aperez lmoura annulen bugs-noreply cgarcia ews-watchlist gyuyoung.kim lmoura ryuan.choi sergio oldest_to_newest 1709626 0 aperez 2020-11-20 13:39:40 -0800 Currently we are unconditionally disabling introspection support if USE_GTK4 is enabled. Removing that restriction from CMake and configuring with USE_GTK4=ON and ENABLE_INTROSPECTION=ON results in the following build error: (process:18103): GLib-GObject-WARNING **: 19:42:24.462: specified class size for type 'WebKitWebViewBase' is smaller than the parent type's 'GtkWidget' class size (process:18103): GLib-CRITICAL **: 19:42:24.463: g_once_init_leave: assertion 'result != 0' failed Invalid GType function: 'webkit_web_view_base_get_type' Function 'webkit_web_view_base_get_type' returned G_TYPE_INVALID UIProcess/API/glib/WebKitWebView.cpp:2193: Warning: WebKit2: multiple comment blocks documenting 'WebKitWebView::show-option-menu:' identifier (already seen at WebKitWebView.cpp:2157). Command '['/run/build/webkit-gtk4/Source/WebKit/tmp-introspectvo_b70is/WebKit2-5.0', '--introspect-dump=/run/build/webkit-gtk4/Source/WebKit/tmp-introspectvo_b70is/functions.txt,/run/build/webkit-gtk4/Source/WebKit/tmp-introspectvo_b70is/dump.xml']' returned non-zero exit status 1. 1710017 1 414847 lmoura 2020-11-24 12:30:30 -0800 Created attachment 414847 Patch 1710206 2 ews-feeder 2020-11-26 20:22:17 -0800 Committed r270178: <https://trac.webkit.org/changeset/270178> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414847. 414847 2020-11-24 12:30:30 -0800 2020-11-26 20:22:18 -0800 Patch bug-219221-20201124173029.patch text/plain 3939 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxYjZmOGJmMWRhZDE5NmVm Y2I3ZTcxNjZjNTc0Yzg4NWIwN2RiZjEuLjM5Y2M2NzhkYTlhODA0MDFlYjZkN2NmOWI3MjEwZDU1 MzA0NDZmZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTEtMjQgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bR1RLNF0gQnVpbGRpbmcg d2l0aCBHT2JqZWN0LUludHJvc3BlY3Rpb24gc3VwcG9ydCBkb2VzIG5vdCB3b3JrCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkyMjEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNt YWtlOiBGb3J3YXJkIEdUSyB2ZXJzaW9uIHRvIGdpciBzY2FubmVyIGFuZCB1c2UgY29ycmVjdCBw a2ctY29uZmlnIHBhY2thZ2UuCisKIDIwMjAtMTEtMjMgIExhdXJvIE1vdXJhICA8bG1vdXJhQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUSzRdIERlY2xhcmUgbGFtYmRhIHJldHVybiB0eXBlIHRv IGF2b2lkIGJ1aWxkIGVycm9yIGRlZHVjaW5nIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQppbmRl eCA3MTVkMzhkNzZiODkxNDg5ZWY5NWE3NGUzMTM4OWI4ODQ0ZWJmMTAyLi5iYTM0YzdhOTlmZDg0 OGJiNGU4MjNmZDdmNGMwZDU2M2JkZGIyNDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKQEAg LTY2LDggKzY2LDEwIEBAIGVuZGlmICgpCiAKIGlmIChVU0VfR1RLNCkKICAgICBzZXQoR1RLX0FQ SV9WRVJTSU9OIDQpCisgICAgc2V0KEdUS19QS0dDT05GSUdfUEFDS0FHRSBndGs0KQogZWxzZSAo KQogICAgIHNldChHVEtfQVBJX1ZFUlNJT04gMykKKyAgICBzZXQoR1RLX1BLR0NPTkZJR19QQUNL QUdFIGd0aystMy4wKQogZW5kaWYgKCkKIAogc2V0KFdlYktpdDJHVEtfSU5TVEFMTEVEX0hFQURF UlMKQEAgLTY1MCw3ICs2NTIsNyBAQCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgICAg ICAgICAtLW5hbWVzcGFjZT1XZWJLaXQyCiAgICAgICAgICAgICAtLW5zdmVyc2lvbj0ke1dFQktJ VEdUS19BUElfVkVSU0lPTn0KICAgICAgICAgICAgIC0taW5jbHVkZT1HT2JqZWN0LTIuMAotICAg ICAgICAgICAgLS1pbmNsdWRlPUd0ay0zLjAKKyAgICAgICAgICAgIC0taW5jbHVkZT1HdGstJHtH VEtfQVBJX1ZFUlNJT059LjAKICAgICAgICAgICAgIC0taW5jbHVkZT1Tb3VwLTIuNAogICAgICAg ICAgICAgLS1pbmNsdWRlLXVuaW5zdGFsbGVkPSR7Q01BS0VfQklOQVJZX0RJUn0vSmF2YVNjcmlw dENvcmUtJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAgICAgICAgICAgLS1saWJyYXJ5 PXdlYmtpdDJndGstJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059CkBAIC02NTksNyArNjYxLDcgQEAg aWYgKEVOQUJMRV9JTlRST1NQRUNUSU9OKQogICAgICAgICAgICAgJHtJTlRST1NQRUNUSU9OX0FE RElUSU9OQUxfTElOS0VSX0ZMQUdTfQogICAgICAgICAgICAgLS1uby1saWJ0b29sCiAgICAgICAg ICAgICAtLXBrZz1nb2JqZWN0LTIuMAotICAgICAgICAgICAgLS1wa2c9Z3RrKy0zLjAKKyAgICAg ICAgICAgIC0tcGtnPSR7R1RLX1BLR0NPTkZJR19QQUNLQUdFfQogICAgICAgICAgICAgLS1wa2c9 bGlic291cC0yLjQKICAgICAgICAgICAgIC0tcGtnLWV4cG9ydD13ZWJraXQyZ3RrLSR7V0VCS0lU R1RLX0FQSV9WRVJTSU9OfQogICAgICAgICAgICAgLS1vdXRwdXQ9JHtDTUFLRV9CSU5BUllfRElS fS9XZWJLaXQyLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfS5naXIKQEAgLTY5Niw3ICs2OTgsNyBA QCBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAgICAgICAgICAgICAtLW5hbWVzcGFjZT1XZWJL aXQyV2ViRXh0ZW5zaW9uCiAgICAgICAgICAgICAtLW5zdmVyc2lvbj0ke1dFQktJVEdUS19BUElf VkVSU0lPTn0KICAgICAgICAgICAgIC0taW5jbHVkZT1HT2JqZWN0LTIuMAotICAgICAgICAgICAg LS1pbmNsdWRlPUd0ay0zLjAKKyAgICAgICAgICAgIC0taW5jbHVkZT1HdGstJHtHVEtfQVBJX1ZF UlNJT059LjAKICAgICAgICAgICAgIC0taW5jbHVkZT1Tb3VwLTIuNAogICAgICAgICAgICAgLS1p bmNsdWRlLXVuaW5zdGFsbGVkPSR7Q01BS0VfQklOQVJZX0RJUn0vSmF2YVNjcmlwdENvcmUtJHtX RUJLSVRHVEtfQVBJX1ZFUlNJT059LmdpcgogICAgICAgICAgICAgLS1saWJyYXJ5PXdlYmtpdDJn dGstJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059CkBAIC03MDYsNyArNzA4LDcgQEAgaWYgKEVOQUJM RV9JTlRST1NQRUNUSU9OKQogICAgICAgICAgICAgJHtJTlRST1NQRUNUSU9OX0FERElUSU9OQUxf TElOS0VSX0ZMQUdTfQogICAgICAgICAgICAgLS1uby1saWJ0b29sCiAgICAgICAgICAgICAtLXBr Zz1nb2JqZWN0LTIuMAotICAgICAgICAgICAgLS1wa2c9Z3RrKy0zLjAKKyAgICAgICAgICAgIC0t cGtnPSR7R1RLX1BLR0NPTkZJR19QQUNLQUdFfQogICAgICAgICAgICAgLS1wa2c9bGlic291cC0y LjQKICAgICAgICAgICAgIC0tcGtnLWV4cG9ydD13ZWJraXQyZ3RrLXdlYi1leHRlbnNpb24tJHtX RUJLSVRHVEtfQVBJX1ZFUlNJT059CiAgICAgICAgICAgICAtLW91dHB1dD0ke0NNQUtFX0JJTkFS WV9ESVJ9L1dlYktpdDJXZWJFeHRlbnNpb24tJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059Lmdpcgpk aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2Uv T3B0aW9uc0dUSy5jbWFrZQppbmRleCAyODAwYmU3YjgzOTI1OTBmNDJiMDZiN2Q5Yjk2MzM5Nzdh YTM1MGRmLi4wMjdlZDk4OTY5ODlkNzU5N2ViZjgzOGExMTE4MzdhYTg0YzYxZDMwIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZQpAQCAtMjQ2LDEwICsyNDYsNiBAQCBpZiAoVVNFX0xJQlNFQ1JFVCkKICAg ICBlbmRpZiAoKQogZW5kaWYgKCkKIAotaWYgKFVTRV9HVEs0KQotICAgIHNldChFTkFCTEVfSU5U Uk9TUEVDVElPTiBPRkYpCi1lbmRpZiAoKQotCiBpZiAoRU5BQkxFX0lOVFJPU1BFQ1RJT04pCiAg ICAgZmluZF9wYWNrYWdlKEdPYmplY3RJbnRyb3NwZWN0aW9uKQogICAgIGlmIChOT1QgSU5UUk9T UEVDVElPTl9GT1VORCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAx Y2RmZWE1MTc4YTlmODU0ZmE0NDJhMGVkMTM0ZGRhYmZlNGExZDA2Li44YjExODM1Mzg4NzVhMWQx MTFkMDdkNjdhOGVlZmM2Y2RlYjEzMzY0IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTEtMjQgIExhdXJvIE1vdXJhICA8bG1vdXJh QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bR1RLNF0gQnVpbGRpbmcgd2l0aCBHT2JqZWN0 LUludHJvc3BlY3Rpb24gc3VwcG9ydCBkb2VzIG5vdCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkyMjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNt YWtlOiBBbGxvdyBpbnRyb3NwZWN0aW9uIHdpdGggR1RLNC4KKwogMjAyMC0xMS0yMCAgRG9uIE9s bXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFJlbW92ZSBxdW90YSBt b2R1bGUK