21921 2008-10-28 07:18:26 -0700 MessagePort messages are dispatched to documents that are not fully active 2008-10-29 03:45:39 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ap ap darin oldest_to_newest 96854 0 ap 2008-10-28 07:18:26 -0700 We have a test that is supposed to verify that this doesn't happen, but it is incorrect, as it lets the document be destroyed. 96856 1 24711 ap 2008-10-28 07:25:22 -0700 Created attachment 24711 proposed fix 96884 2 24711 darin 2008-10-28 11:35:27 -0700 Comment on attachment 24711 proposed fix I'm a little worried that this kind of check might be needed in more cases other than just this event listener function. Is there a way to make this change a more natural part of how you get the frame from the window in the first place? What's a good way to audit the rest of the code to se if we need other changes like this? Is there a way to change the design to fill this "crack in the foundation"? r=me 96897 3 ap 2008-10-28 12:24:11 -0700 I think that DOMWindow's frame pointer should be cleared out when it stops being active, just like it is the case for Document. And going from DOMWindow to Document and back probably shouldn't involve Frame at all. In this case, this check wouldn't be necessary. But I don't know the reasons for the current design, maybe I'm way off. 96899 4 darin 2008-10-28 12:26:36 -0700 (In reply to comment #3) > I think that DOMWindow's frame pointer should be cleared out when it stops > being active, just like it is the case for Document. And going from DOMWindow > to Document and back probably shouldn't involve Frame at all. In this case, > this check wouldn't be necessary. Maybe we could add a FIXME mentioning this alternate possible design. It seems fine to clear the DOMWindow's frame pointer; we just need to test to see if there are any code paths that require on it not being cleared. 96966 5 ap 2008-10-29 03:45:39 -0700 Committed revision 37971. Added a FIXME. 24711 2008-10-28 07:25:22 -0700 2008-10-28 11:35:27 -0700 proposed fix DispatchToInactiveDocument.txt text/plain 2793 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzkyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAtMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkyMQorICAgICAgICBN ZXNzYWdlUG9ydCBtZXNzYWdlcyBhcmUgZGlzcGF0Y2hlZCB0byBkb2N1bWVudHMgdGhhdCBhcmUg bm90IGZ1bGx5IGFjdGl2ZQorCisgICAgICAgIENvdmVyZWQgYnkgY29ycmVjdGVkIGZhc3QvZXZl bnRzL21lc3NhZ2UtcG9ydC1pbmFjdGl2ZS1kb2N1bWVudC5odG1sCisKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNBYnN0cmFj dEV2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KTogRG9uJ3QgZGlzcGF0Y2ggbWVzc2FnZXMgdG8g Y29udGV4dHMKKyAgICAgICAgdGhhdCBhcmUgbm90IGZ1bGx5IGFjdGl2ZS4KKwogMjAwOC0xMC0y OCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRXZlbnRMaXN0 ZW5lci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVu ZXIuY3BwCShyZXZpc2lvbiAzNzg5NikKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvSlNFdmVudExp c3RlbmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsOSBAQCB2b2lkIEpTQWJzdHJh Y3RFdmVudExpc3RlbmVyOjpoYW5kbGVFdmVuCiAgICAgRnJhbWUqIGZyYW1lID0gd2luZG93LT5p bXBsKCktPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuOworICAgIC8v IFRoZSB3aW5kb3cgbXVzdCBzdGlsbCBiZSBhY3RpdmUgaW4gaXRzIGZyYW1lLgorICAgIGlmIChm cmFtZS0+ZG9tV2luZG93KCkgIT0gd2luZG93LT5pbXBsKCkpCisgICAgICAgIHJldHVybjsKICAg ICBTY3JpcHRDb250cm9sbGVyKiBzY3JpcHQgPSBmcmFtZS0+c2NyaXB0KCk7CiAgICAgaWYgKCFz Y3JpcHQtPmlzRW5hYmxlZCgpIHx8IHNjcmlwdC0+aXNQYXVzZWQoKSkKICAgICAgICAgcmV0dXJu OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gMzc5MjQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOC0xMC0yOCAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx OTIxCisgICAgICAgIE1lc3NhZ2VQb3J0IG1lc3NhZ2VzIGFyZSBkaXNwYXRjaGVkIHRvIGRvY3Vt ZW50cyB0aGF0IGFyZSBub3QgZnVsbHkgYWN0aXZlCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9t ZXNzYWdlLXBvcnQtaW5hY3RpdmUtZG9jdW1lbnQuaHRtbDogUHJvdGVjdCB0aGUgZG9jdW1lbnQg ZnJvbSBiZWluZworICAgICAgICBkZXN0cnVjdGVkIGluIGEgd29ya2luZyB3YXkgKGEgZ2xvYmFs IHZhcmlhYmxlIG5hbWVkICJkb2N1bWVudCIgZGlkbid0IGRvIHRoZSB0cmljayBkdWUKKyAgICAg ICAgdG8gaXRzIG5hbWUpLgorCiAyMDA4LTEwLTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL21lc3NhZ2UtcG9ydC1pbmFjdGl2ZS1kb2N1bWVudC5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL21lc3NhZ2UtcG9ydC1pbmFj dGl2ZS1kb2N1bWVudC5odG1sCShyZXZpc2lvbiAzNzg5NikKKysrIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL21lc3NhZ2UtcG9ydC1pbmFjdGl2ZS1kb2N1bWVudC5odG1sCSh3b3JraW5nIGNvcHkp CkBAIC0yMiwxMiArMjIsMTIgQEAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewog ICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKIH0KIAotdmFyIGRvY3Vt ZW50OwordmFyIG90aGVyRG9jdW1lbnQ7CiB2YXIgbWFpblBvcnQ7CiAKIGZ1bmN0aW9uIHRlc3Qo KQogewotICAgIGRvY3VtZW50ID0gd2luZG93LmZyYW1lc1swXS5kb2N1bWVudDsKKyAgICBvdGhl ckRvY3VtZW50ID0gd2luZG93LmZyYW1lc1swXS5kb2N1bWVudDsKICAgICB2YXIgY2hhbm5lbCA9 IG5ldyBNZXNzYWdlQ2hhbm5lbDsKICAgICB3aW5kb3cuZnJhbWVzWzBdLnBvc3RNZXNzYWdlKCJt c2ciLCBjaGFubmVsLnBvcnQyLCAiKiIpOwogICAgIG1haW5Qb3J0ID0gY2hhbm5lbC5wb3J0MTsK