<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>219198</bug_id>
          
          <creation_ts>2020-11-20 03:20:54 -0800</creation_ts>
          <short_desc>[GTK] [WPE] Add entries on the bots&apos; /etc/hosts file for testing purpose</short_desc>
          <delta_ts>2022-09-09 09:48:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>219257</dependson>
          <blocked>127676</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Frédéric Wang (:fredw)">fred.wang</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>jfernandez</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pgriffis</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1709436</commentid>
    <comment_count>0</comment_count>
    <who name="Frédéric Wang (:fredw)">fred.wang</who>
    <bug_when>2020-11-20 03:20:54 -0800</bug_when>
    <thetext>This can be a preliminary step for bug 127676.

It would also allow to rewrite our GTK API test for WebKitInsecureContentEvent without relying on &quot;localhost&quot; and &quot;127.0.0.1&quot; (which are supposed not to be treated as mixed content, see bug 171934).

Unfortunately Philippe mentioned that /etc/hosts in the flatpak sandbox is readonly.

Opening this to track the issue and discuss ideas on how to address it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1709459</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-11-20 05:55:21 -0800</bug_when>
    <thetext>Suggestion: you can write a GResolver that wraps the default GResolver and just specially resolves some extra host. Compile it into a shared object and have the run-[gtk,wpe]-tests scripts set GIO_EXTRA_MODULES to point to it. Then you won&apos;t wind up with a test that breaks when not run on a specially-configured bot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721582</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-01-22 07:15:04 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #1)
&gt; Suggestion: you can write a GResolver that wraps the default GResolver and
&gt; just specially resolves some extra host. Compile it into a shared object and
&gt; have the run-[gtk,wpe]-tests scripts set GIO_EXTRA_MODULES to point to it.
&gt; Then you won&apos;t wind up with a test that breaks when not run on a
&gt; specially-configured bot.

Yeah this seems like a much better approach. It&apos;s not *too* complicated, and otherwise the affected tests will never pass when not run on bots. Surely we don&apos;t want to tell devs to edit their /etc/hosts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1897272</commentid>
    <comment_count>3</comment_count>
    <who name="Patrick Griffis">pgriffis</who>
    <bug_when>2022-09-09 09:48:47 -0700</bug_when>
    <thetext>Fixed by bug 243428. It now exposes a generic way to add domains for testing.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>