219158 2020-11-19 07:04:57 -0800 [JSC] Build failed due to unknown values in LLIntDesiredOffsets.h 2020-11-19 10:33:52 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez annulen don.olmstead ews-watchlist gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff ryuan.choi saam sergio tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1709085 0 aperez 2020-11-19 07:04:57 -0800 After updating from the repository the following happens: In file included from ../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:103: DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h:610:56: error: use of undeclared identifier 'WasmI32Extend16S_m_dst_index'; did you mean 'WasmI32Load16S_m_dst_index'? constexpr int64_t constValue607 = static_cast<int64_t>(WasmI32Extend16S_m_dst_index); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ WasmI32Load16S_m_dst_index DerivedSources/JavaScriptCore/BytecodeIndices.h:1053:16: note: 'WasmI32Load16S_m_dst_index' declared here const unsigned WasmI32Load16S_m_dst_index = 0; ^ In file included from ../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:103: DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h:611:56: error: use of undeclared identifier 'WasmI32Extend16S_m_operand_index' constexpr int64_t constValue608 = static_cast<int64_t>(WasmI32Extend16S_m_operand_index); ^ DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h:612:56: error: use of undeclared identifier 'WasmI32Extend8S_m_dst_index'; did you mean 'WasmI32Load8S_m_dst_index'? constexpr int64_t constValue609 = static_cast<int64_t>(WasmI32Extend8S_m_dst_index); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ WasmI32Load8S_m_dst_index DerivedSources/JavaScriptCore/BytecodeIndices.h:1047:16: note: 'WasmI32Load8S_m_dst_index' declared here const unsigned WasmI32Load8S_m_dst_index = 0; ^ In file included from ../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:103: DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h:613:56: error: use of undeclared identifier 'WasmI32Extend8S_m_operand_index' constexpr int64_t constValue610 = static_cast<int64_t>(WasmI32Extend8S_m_operand_index); ^ DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h:1103:57: error: use of undeclared identifier 'wasm_i32_extend16_s_length'; did you mean 'wasm_i32_load16_s_length'? constexpr int64_t constValue1100 = static_cast<int64_t>(wasm_i32_extend16_s_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~ wasm_i32_load16_s_length ../Source/JavaScriptCore/bytecode/Opcode.h:88:22: note: 'wasm_i32_load16_s_length' declared here FOR_EACH_WASM_ID(OPCODE_ID_LENGTHS); ^ In file included from ../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:103: DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h:1104:57: error: use of undeclared identifier 'wasm_i32_extend8_s_length'; did you mean 'wasm_i32_load8_s_length'? constexpr int64_t constValue1101 = static_cast<int64_t>(wasm_i32_extend8_s_length); ^~~~~~~~~~~~~~~~~~~~~~~~~ wasm_i32_load8_s_length ../Source/JavaScriptCore/bytecode/Opcode.h:88:22: note: 'wasm_i32_load8_s_length' declared here FOR_EACH_WASM_ID(OPCODE_ID_LENGTHS); ^ 6 errors generated. 1709086 1 aperez 2020-11-19 07:06:11 -0800 Doing a clean build works, so I suspect this is caused by some dependency that should trigger the rebuild of LLIntDesiredOffsets.h not being listed in the corresponding CMake custom_command(). 1709102 2 414579 aperez 2020-11-19 07:52:22 -0800 Created attachment 414579 Patch 1709113 3 414579 mcatanzaro 2020-11-19 08:11:47 -0800 Comment on attachment 414579 Patch Grrr, now this is good proof that I am not smart. I found one file missing in bug #219043 but managed to miss four others. Nice. :P 1709150 4 ews-feeder 2020-11-19 09:37:53 -0800 Committed r270036: <https://trac.webkit.org/changeset/270036> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414579. 1709152 5 webkit-bug-importer 2020-11-19 09:38:17 -0800 <rdar://problem/71589994> 414579 2020-11-19 07:52:22 -0800 2020-11-19 10:33:52 -0800 Patch bug-219158-20201119175220.patch text/plain 1826 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz Njg1NTFlYWFkNWU1ZGEyNGQ1Mzc5MzAyY2U4ZmU5M2M4NGRiN2E1Li4wYWQzNTAzN2E2ZDM0OTkw MjJhN2M4YjZlMWI3ZDcxYzRjMjNiNzY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0xMS0xOSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIFtKU0NdIEJ1aWxkIGZhaWxlZCBkdWUgdG8gdW5rbm93biB2 YWx1ZXMgaW4gTExJbnREZXNpcmVkT2Zmc2V0cy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDTWFrZSB1c2VzIHRoZSBjb250ZW50cyBvZiB0aGUgdmFy aWFibGVzIE9GRkxJTkVfQVNNIGFuZCBHRU5FUkFUT1IgYXMgcGFydCBvZiB0aGUKKyAgICAgICAg ZGVwZW5kZW5jaWVzIHRoYXQgY2F1c2UgTExJbnREZXNpcmVkT2Zmc2V0cy5oIHRvIGJlIHJlZ2Vu ZXJhdGVkLCBzbyBhZGQgdG8gdGhlbQorICAgICAgICB0aG9zZSBmaWxlcyBtaXNzaW5nIGZyb20g dGhlIGxpc3RzLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IFVwZGF0ZSBPRkZMSU5FX0FT TSBhbmQgR0VORVJBVE9SIGxpc3RzLgorCiAyMDIwLTExLTE4ICBEbWl0cnkgQmV6aGV0c2tvdiAg PGRiZXpoZXRza292QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dBU00tUmVmZXJlbmNlc10gUmVt b3ZlIHN1YnR5cGluZyBydWxlIGZvciBleHRlcm5yZWYgYW5kIGZ1bmNyZWYKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBlMDcwM2Y3ODQzODdiNTg0MDkzODkzYWM0MDZkMDE4 MThiNDU1ZGM1Li4wMWMxNmYwNGM4NjU4ZDQ0NzVjYjMxMDM0NmU3ODI3ZWFlNDE4YWY0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xOTgsNiArMTk4LDggQEAgc2V0KExM SU5UX0FTTQogc2V0KE9GRkxJTkVfQVNNCiAgICAgb2ZmbGluZWFzbS9hcm0ucmIKICAgICBvZmZs aW5lYXNtL2FybTY0LnJiCisgICAgb2ZmbGluZWFzbS9hcm02NGUucmIKKyAgICBvZmZsaW5lYXNt L2FzbS5yYgogICAgIG9mZmxpbmVhc20vYXN0LnJiCiAgICAgb2ZmbGluZWFzbS9iYWNrZW5kcy5y YgogICAgIG9mZmxpbmVhc20vY2xvb3AucmIKQEAgLTIxOCw2ICsyMjAsNyBAQCBzZXQoT0ZGTElO RV9BU00KIHNldChHRU5FUkFUT1IKICAgICBnZW5lcmF0b3IvQXJndW1lbnQucmIKICAgICBnZW5l cmF0b3IvQXNzZXJ0aW9uLnJiCisgICAgZ2VuZXJhdG9yL0NoZWNrcG9pbnRzLnJiCiAgICAgZ2Vu ZXJhdG9yL0RTTC5yYgogICAgIGdlbmVyYXRvci9GaXRzLnJiCiAgICAgZ2VuZXJhdG9yL0dlbmVy YXRlZEZpbGUucmIKQEAgLTIyOCw2ICsyMzEsNyBAQCBzZXQoR0VORVJBVE9SCiAgICAgZ2VuZXJh dG9yL1NlY3Rpb24ucmIKICAgICBnZW5lcmF0b3IvVGVtcGxhdGUucmIKICAgICBnZW5lcmF0b3Iv VHlwZS5yYgorICAgIGdlbmVyYXRvci9XYXNtLnJiCiAgICAgZ2VuZXJhdG9yL21haW4ucmIKICkK IAo=