219155 2020-11-19 05:32:08 -0800 [LFC][Integration] Use inline iterator in CompositeEditCommand::deleteInsignificantText 2020-11-19 07:35:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham ews-watchlist mifenton simon.fraser webkit-bug-importer zalan oldest_to_newest 1709056 0 koivisto 2020-11-19 05:32:08 -0800 Reduce direct InlineBox access. 1709058 1 414569 koivisto 2020-11-19 05:38:18 -0800 Created attachment 414569 patch 1709098 2 ews-feeder 2020-11-19 07:34:34 -0800 Committed r270029: <https://trac.webkit.org/changeset/270029> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414569. 1709100 3 webkit-bug-importer 2020-11-19 07:35:16 -0800 <rdar://problem/71586451> 414569 2020-11-19 05:38:18 -0800 2020-11-19 07:34:35 -0800 patch lfc-deleteInsignificantText-iterator.patch text/plain 3752 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMzhkNmNmMWNlMTguLjA2ZmFjNDE4YmRkOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIwLTExLTE5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gVXNlIGlubGluZSBpdGVyYXRvciBpbiBD b21wb3NpdGVFZGl0Q29tbWFuZDo6ZGVsZXRlSW5zaWduaWZpY2FudFRleHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTE1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZHVjZSBkaXJlY3QgSW5saW5l Qm94IGFjY2Vzcy4KKworICAgICAgICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlRWRpdENvbW1hbmQ6OmRlbGV0ZUluc2lnbmlm aWNhbnRUZXh0KToKKwogMjAyMC0xMS0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IHRoZSBidWlsZCB3aXRoIEdD QyAxMApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29t bWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNw cAppbmRleCBmMDQ2ZTMwZjQxNDIuLmJjNjhkMTk5M2EyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAgLTUzLDYgKzUzLDcgQEAKICNp bmNsdWRlICJJbnNlcnROb2RlQmVmb3JlQ29tbWFuZC5oIgogI2luY2x1ZGUgIkluc2VydFBhcmFn cmFwaFNlcGFyYXRvckNvbW1hbmQuaCIKICNpbmNsdWRlICJJbnNlcnRUZXh0Q29tbWFuZC5oIgor I2luY2x1ZGUgIkxheW91dEludGVncmF0aW9uUnVuSXRlcmF0b3IuaCIKICNpbmNsdWRlICJNZXJn ZUlkZW50aWNhbEVsZW1lbnRzQ29tbWFuZC5oIgogI2luY2x1ZGUgIk5vZGVUcmF2ZXJzYWwuaCIK ICNpbmNsdWRlICJSZW1vdmVOb2RlQ29tbWFuZC5oIgpAQCAtOTgxLDIwICs5ODIsOCBAQCB2b2lk IENvbXBvc2l0ZUVkaXRDb21tYW5kOjpkZWxldGVJbnNpZ25pZmljYW50VGV4dChUZXh0JiB0ZXh0 Tm9kZSwgdW5zaWduZWQgc3RhcgogICAgIGlmICghdGV4dFJlbmRlcmVyKQogICAgICAgICByZXR1 cm47CiAKLSAgICBWZWN0b3I8SW5saW5lVGV4dEJveCo+IHNvcnRlZFRleHRCb3hlczsKLSAgICBz aXplX3Qgc29ydGVkVGV4dEJveGVzUG9zaXRpb24gPSAwOwotICAgCi0gICAgdGV4dFJlbmRlcmVy LT5lbnN1cmVMaW5lQm94ZXMoKTsKLSAgICBmb3IgKElubGluZVRleHRCb3gqIHRleHRCb3ggPSB0 ZXh0UmVuZGVyZXItPmZpcnN0VGV4dEJveCgpOyB0ZXh0Qm94OyB0ZXh0Qm94ID0gdGV4dEJveC0+ bmV4dFRleHRCb3goKSkKLSAgICAgICAgc29ydGVkVGV4dEJveGVzLmFwcGVuZCh0ZXh0Qm94KTsK LSAgICAKLSAgICAvLyBJZiB0aGVyZSBpcyBtaXhlZCBkaXJlY3Rpb25hbGl0eSB0ZXh0LCB0aGUg Ym94ZXMgY2FuIGJlIG91dCBvZiBvcmRlciwKLSAgICAvLyAobGlrZSBBcmFiaWMgd2l0aCBlbWJl ZGRlZCBMVFIpLCBzbyBzb3J0IHRoZW0gZmlyc3QuIAotICAgIGlmICh0ZXh0UmVuZGVyZXItPmNv bnRhaW5zUmV2ZXJzZWRUZXh0KCkpICAgIAotICAgICAgICBzdGQ6OnNvcnQoc29ydGVkVGV4dEJv eGVzLmJlZ2luKCksIHNvcnRlZFRleHRCb3hlcy5lbmQoKSwgSW5saW5lVGV4dEJveDo6Y29tcGFy ZUJ5U3RhcnQpOwotICAgIElubGluZVRleHRCb3gqIGJveCA9IHNvcnRlZFRleHRCb3hlcy5pc0Vt cHR5KCkgPyAwIDogc29ydGVkVGV4dEJveGVzW3NvcnRlZFRleHRCb3hlc1Bvc2l0aW9uXTsKLQot ICAgIGlmICghYm94KSB7CisgICAgYXV0byBydW4gPSBMYXlvdXRJbnRlZ3JhdGlvbjo6Zmlyc3RU ZXh0UnVuSW5UZXh0T3JkZXJGb3IoKnRleHRSZW5kZXJlcik7CisgICAgaWYgKCFydW4pIHsKICAg ICAgICAgLy8gd2hvbGUgdGV4dCBub2RlIGlzIGVtcHR5CiAgICAgICAgIHJlbW92ZU5vZGUodGV4 dE5vZGUpOwogICAgICAgICByZXR1cm47ICAgIApAQCAtMTAwNSwxOCArOTk0LDE4IEBAIHZvaWQg Q29tcG9zaXRlRWRpdENvbW1hbmQ6OmRlbGV0ZUluc2lnbmlmaWNhbnRUZXh0KFRleHQmIHRleHRO b2RlLCB1bnNpZ25lZCBzdGFyCiAgICAgICAgIHJldHVybjsKIAogICAgIHVuc2lnbmVkIHJlbW92 ZWQgPSAwOwotICAgIElubGluZVRleHRCb3gqIHByZXZCb3ggPSBudWxscHRyOworICAgIExheW91 dEludGVncmF0aW9uOjpUZXh0UnVuSXRlcmF0b3IgcHJldmlvdXNSdW47CiAgICAgU3RyaW5nIHN0 cjsKIAogICAgIC8vIFRoaXMgbG9vcCBzdHJ1Y3R1cmUgd29ya3MgdG8gcHJvY2VzcyBhbGwgZ2Fw cyBwcmVjZWRpbmcgYSBib3gsCiAgICAgLy8gYW5kIGFsc28gd2lsbCBsb29rIGF0IHRoZSBnYXAg YWZ0ZXIgdGhlIGxhc3QgYm94LgotICAgIHdoaWxlIChwcmV2Qm94IHx8IGJveCkgewotICAgICAg ICB1bnNpZ25lZCBnYXBTdGFydCA9IHByZXZCb3ggPyBwcmV2Qm94LT5zdGFydCgpICsgcHJldkJv eC0+bGVuKCkgOiAwOworICAgIHdoaWxlIChwcmV2aW91c1J1biB8fCBydW4pIHsKKyAgICAgICAg dW5zaWduZWQgZ2FwU3RhcnQgPSBwcmV2aW91c1J1biA/IHByZXZpb3VzUnVuLT5lbmQoKSA6IDA7 CiAgICAgICAgIGlmIChlbmQgPCBnYXBTdGFydCkKICAgICAgICAgICAgIC8vIE5vIG1vcmUgY2hh bmNlIGZvciBhbnkgaW50ZXJzZWN0aW9ucwogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAg dW5zaWduZWQgZ2FwRW5kID0gYm94ID8gYm94LT5zdGFydCgpIDogbGVuZ3RoOworICAgICAgICB1 bnNpZ25lZCBnYXBFbmQgPSBydW4gPyBydW4tPnN0YXJ0KCkgOiBsZW5ndGg7CiAgICAgICAgIGJv b2wgaW5kaWNlc0ludGVyc2VjdCA9IHN0YXJ0IDw9IGdhcEVuZCAmJiBlbmQgPj0gZ2FwU3RhcnQ7 CiAgICAgICAgIGludCBnYXBMZW4gPSBnYXBFbmQgLSBnYXBTdGFydDsKICAgICAgICAgaWYgKGlu ZGljZXNJbnRlcnNlY3QgJiYgZ2FwTGVuID4gMCkgewpAQCAtMTAyOSwxMyArMTAxOCw5IEBAIHZv aWQgQ29tcG9zaXRlRWRpdENvbW1hbmQ6OmRlbGV0ZUluc2lnbmlmaWNhbnRUZXh0KFRleHQmIHRl eHROb2RlLCB1bnNpZ25lZCBzdGFyCiAgICAgICAgICAgICByZW1vdmVkICs9IGdhcExlbjsKICAg ICAgICAgfQogICAgICAgICAKLSAgICAgICAgcHJldkJveCA9IGJveDsKLSAgICAgICAgaWYgKGJv eCkgewotICAgICAgICAgICAgaWYgKCsrc29ydGVkVGV4dEJveGVzUG9zaXRpb24gPCBzb3J0ZWRU ZXh0Qm94ZXMuc2l6ZSgpKQotICAgICAgICAgICAgICAgIGJveCA9IHNvcnRlZFRleHRCb3hlc1tz b3J0ZWRUZXh0Qm94ZXNQb3NpdGlvbl07Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAg ICAgYm94ID0gbnVsbHB0cjsKLSAgICAgICAgfQorICAgICAgICBwcmV2aW91c1J1biA9IHJ1bjsK KyAgICAgICAgaWYgKHJ1bikKKyAgICAgICAgICAgIHJ1bi50cmF2ZXJzZU5leHRUZXh0UnVuSW5U ZXh0T3JkZXIoKTsKICAgICB9CiAKICAgICBpZiAoIXN0ci5pc051bGwoKSkgewo=