219138 2020-11-18 18:04:57 -0800 [WTF] Fix a condition to check if statvfs() succeeds in getVolumeFreeSpace() 2020-11-18 20:01:46 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Yousuke.Kimoto Yousuke.Kimoto benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1708927 0 Yousuke.Kimoto 2020-11-18 18:04:57 -0800 statvfs() returns Zero on success, and -1 is returned on error. But getVolumeFreeSpace() of FileSystemPOSIX.cpp treats a non Zero value as success case. The condition is wrong. 1708929 1 414524 Yousuke.Kimoto 2020-11-18 18:11:47 -0800 Created attachment 414524 Patch to fix the condition. 1708958 2 ews-feeder 2020-11-18 20:00:41 -0800 Committed r270013: <https://trac.webkit.org/changeset/270013> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414524. 1708959 3 webkit-bug-importer 2020-11-18 20:01:46 -0800 <rdar://problem/71569072> 414524 2020-11-18 18:11:47 -0800 2020-11-18 20:00:42 -0800 Patch to fix the condition. patch text/plain 1467 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZjk0NGY3NjMxNzg1Li45YTZlMjBkNzM5MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjAtMTEtMTkgIFlvdXN1a2UgS2ltb3RvICA8WW91c3VrZS5LaW1vdG9Ac29ueS5jb20+CisKKyAg ICAgICAgW1dURl0gRml4IGEgY29uZGl0aW9uIHRvIGNoZWNrIGlmIHN0YXR2ZnMoKSBzdWNjZWVk cyBpbiBnZXRWb2x1bWVGcmVlU3BhY2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgc3RhdHZmcygpIHJldHVybnMgWmVybyBvbiBzdWNjZXNzIGJ1dCBn ZXRWb2x1bWVGcmVlU3BhY2UoKSB0cmVhdHMgYSBub24gWmVybyB2YWx1ZQorICAgICAgICBhcyBh IHN1Y2NlcyBjYXNlLiBUaGUgY29uZGl0aW9uIGlzIG9wcHNpdGUgdG8gdGhlIHNwZWMgb2Ygc3Rh dHZmcygpLgorCisgICAgICAgICogd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHA6CisKIDIw MjAtMTEtMTcgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAg QnVpbGQgZmFpbHMgb24gaW50ZXJuYWwgc2ltdWxhdG9yIGJ1aWxkcyBkdWUgdG8gbWlzc2luZyBl bnVtIGtDVlBpeGVsRm9ybWF0VHlwZV9BR1hfNDIwWXBDYkNyOEJpUGxhbmFyVmlkZW9SYW5nZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNwcCBiL1Nv dXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAKaW5kZXggYTliZGIyYzBlYWYy Li45OWRjYmYyM2U5MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3Bvc2l4L0ZpbGVTeXN0 ZW1QT1NJWC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvcG9zaXgvRmlsZVN5c3RlbVBPU0lYLmNw cApAQCAtNDM1LDcgKzQzNSw3IEBAIGJvb2wgbW92ZUZpbGUoY29uc3QgU3RyaW5nJiBvbGRQYXRo LCBjb25zdCBTdHJpbmcmIG5ld1BhdGgpCiBib29sIGdldFZvbHVtZUZyZWVTcGFjZShjb25zdCBT dHJpbmcmIHBhdGgsIHVpbnQ2NF90JiBmcmVlU3BhY2UpCiB7CiAgICAgc3RydWN0IHN0YXR2ZnMg ZmlsZVN5c3RlbVN0YXQ7Ci0gICAgaWYgKHN0YXR2ZnMoZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9u KHBhdGgpLmRhdGEoKSwgJmZpbGVTeXN0ZW1TdGF0KSkgeworICAgIGlmICghc3RhdHZmcyhmaWxl U3lzdGVtUmVwcmVzZW50YXRpb24ocGF0aCkuZGF0YSgpLCAmZmlsZVN5c3RlbVN0YXQpKSB7CiAg ICAgICAgIGZyZWVTcGFjZSA9IGZpbGVTeXN0ZW1TdGF0LmZfYmF2YWlsICogZmlsZVN5c3RlbVN0 YXQuZl9mcnNpemU7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K