219132 2020-11-18 16:28:40 -0800 [webitscmpy] Branch point incorrect for Git checkouts 2020-11-18 17:43:09 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu webkit-bug-importer oldest_to_newest 1708868 0 jbedard 2020-11-18 16:28:40 -0800 Discovered earlier today that the current code computes branch-point incorrectly in git checkouts, partially because our Mocking code also computed it incorrectly. 1708869 1 webkit-bug-importer 2020-11-18 16:28:54 -0800 <rdar://problem/71561569> 1708875 2 414512 jbedard 2020-11-18 16:36:24 -0800 Created attachment 414512 Patch 1708918 3 ews-feeder 2020-11-18 17:43:08 -0800 Committed r270004: <https://trac.webkit.org/changeset/270004> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414512. 414512 2020-11-18 16:36:24 -0800 2020-11-18 17:43:08 -0800 Patch bug-219132-20201118163623.patch text/plain 2929 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2OTk5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTExLTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2ViaXRzY21weV0gQnJhbmNoIHBvaW50IGluY29ycmVjdCBmb3IgR2l0 IGNoZWNrb3V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE5MTMyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MTU2MTU2OT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVz L3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L2xvY2FsL2dpdC5weToKKyAgICAgICAgKEdpdC5jb21t aXQpOiBCYW5jYS1wb2ludCBpcyB0aGUgZGlzdGFuY2UgZnJvbSB0aGUgcHJpbW9yZGlhbCBjb21t aXQgbWludXMgdGhlIGRpc3RhbmNlIGZyb20KKyAgICAgICAgdGhlIGRlZmF1bHQgYnJhbmNoLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L21vY2tz L2xvY2FsL2dpdC5weToKKwogMjAyMC0xMS0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBw bGUuY29tPgogCiAgICAgICAgIFtKU0NdIEltcHJvdmUgV2FzbSBiaW5hcnkgdGVzdCBjb3ZlcmFn ZQpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv X19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI2OTk5OCkKKysrIFRvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoKICAgICAg ICAgIlBsZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVweSB3aXRoIGBwaXAgaW5zdGFsbCB3ZWJraXRj b3JlcHkgLS1leHRyYS1pbmRleC11cmwgPHBhY2thZ2UgaW5kZXggVVJMPmAiCiAgICAgKQogCi12 ZXJzaW9uID0gVmVyc2lvbigwLCAzLCAxKQordmVyc2lvbiA9IFZlcnNpb24oMCwgMywgMikKIAog QXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZGF0ZXV0aWwnLCBWZXJzaW9uKDIsIDgsIDEp LCBweXBpX25hbWU9J3B5dGhvbi1kYXRldXRpbCcpKQogCkluZGV4OiBUb29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9sb2NhbC9naXQucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbG9jYWwv Z2l0LnB5CShyZXZpc2lvbiAyNjk5OTgpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS93ZWJraXRzY21weS9sb2NhbC9naXQucHkJKHdvcmtpbmcgY29weSkKQEAgLTI0Myw3 ICsyNDMsNyBAQCBjbGFzcyBHaXQoU2NtKToKIAogICAgICAgICBpZiBub3QgaWRlbnRpZmllcjoK ICAgICAgICAgICAgIGlkZW50aWZpZXIgPSBzZWxmLl9jb21taXRfY291bnQoaGFzaCBpZiBicmFu Y2ggPT0gZGVmYXVsdF9icmFuY2ggZWxzZSAne30uLnt9Jy5mb3JtYXQoZGVmYXVsdF9icmFuY2gs IGhhc2gpKQotICAgICAgICBicmFuY2hfcG9pbnQgPSBOb25lIGlmIGJyYW5jaCA9PSBkZWZhdWx0 X2JyYW5jaCBlbHNlIHNlbGYuX2NvbW1pdF9jb3VudChoYXNoKQorICAgICAgICBicmFuY2hfcG9p bnQgPSBOb25lIGlmIGJyYW5jaCA9PSBkZWZhdWx0X2JyYW5jaCBlbHNlIHNlbGYuX2NvbW1pdF9j b3VudChoYXNoKSAtIGlkZW50aWZpZXIKICAgICAgICAgaWYgYnJhbmNoX3BvaW50IGFuZCBwYXJz ZWRfYnJhbmNoX3BvaW50IGFuZCBicmFuY2hfcG9pbnQgIT0gcGFyc2VkX2JyYW5jaF9wb2ludDoK ICAgICAgICAgICAgIHJhaXNlIFZhbHVlRXJyb3IoIlByb3ZpZGVkICdicmFuY2hfcG9pbnQnIGRv ZXMgbm90IG1hdGNoIGJyYW5jaCBwb2ludCBvZiBzcGVjaWZpZWQgYnJhbmNoIikKIApJbmRleDog VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3MvbG9j YWwvZ2l0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNj bXB5L3dlYmtpdHNjbXB5L21vY2tzL2xvY2FsL2dpdC5weQkocmV2aXNpb24gMjY5OTk4KQorKysg VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbW9ja3MvbG9j YWwvZ2l0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNTEsNyArMzUxLDcgQEAgbm90aGluZyB0byBj b21taXQsIHdvcmtpbmcgdHJlZSBjbGVhbgogICAgICAgICBtYXRjaCA9IHNlbGYuZmluZChzb21l dGhpbmcpCiAgICAgICAgIGlmICcuLicgaW4gc29tZXRoaW5nIG9yIG5vdCBtYXRjaC5icmFuY2hf cG9pbnQ6CiAgICAgICAgICAgICByZXR1cm4gbWF0Y2guaWRlbnRpZmllcgotICAgICAgICByZXR1 cm4gbWF0Y2guYnJhbmNoX3BvaW50CisgICAgICAgIHJldHVybiBtYXRjaC5icmFuY2hfcG9pbnQg KyBtYXRjaC5pZGVudGlmaWVyCiAKICAgICBkZWYgYnJhbmNoZXNfb24oc2VsZiwgaGFzaCk6CiAg ICAgICAgIHJlc3VsdCA9IHNldCgpCg==