219117 2020-11-18 14:53:50 -0800 Menu Bar support for app highlights in book. 2020-11-18 19:18:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1708794 0 megan_gardner 2020-11-18 14:53:50 -0800 Menu Bar support for app highlights in book. 1708797 1 414489 megan_gardner 2020-11-18 14:57:53 -0800 Created attachment 414489 Patch 1708899 2 414489 wenson_hsieh 2020-11-18 17:15:35 -0800 Comment on attachment 414489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414489&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8612 > + [[UIMenuController sharedMenuController] setMenuItems:@[ addHighlightCurrentGroupItem.get(), addHighlightNewGroupItem.get()]]; Nit - maybe an extra space after `addHighlightNewGroupItem.get()` to balance out the leading space after @[? 1708931 3 414525 megan_gardner 2020-11-18 18:17:56 -0800 Created attachment 414525 Patch for landing 1708942 4 ews-feeder 2020-11-18 19:17:16 -0800 Committed r270007: <https://trac.webkit.org/changeset/270007> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414525. 1708944 5 webkit-bug-importer 2020-11-18 19:18:17 -0800 <rdar://problem/71567873> 414489 2020-11-18 14:57:53 -0800 2020-11-18 18:17:54 -0800 Patch bug-219117-20201118145752.patch text/plain 3445 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhhZWEyNTVhOTI4YWFhZGUy MzlhZGMxMDBkZjUwMTMxOWU1Y2YxMDEuLjEwNTI1MzMxYzc3ZGE3MzFiZTAwYjkyM2YwMWY1NWZl YWM0ODIyNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTEtMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBNZW51IEJhciBzdXBw b3J0IGZvciBhcHAgaGlnaGxpZ2h0cyBpbiBib29rLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1lbnUgc3R1YnMgaW4gaU9TIHRvIHN1cHBvcnQg aGlnaGxpZ2h0cyBmb3IgYm9va3MgaW4gbW9kZXJuIHdlYmtpdC4gCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBzZXRVcEludGVyYWN0aW9uXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY2Fu UGVyZm9ybUFjdGlvbjp3aXRoU2VuZGVyOl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHNl dHVwQXBwSGlnaGxpZ2h0TWVudXNdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjcmVhdGVI aWdobGlnaHRJbkN1cnJlbnRHcm91cFdpdGhSYW5nZTpdKToKKyAgICAgICAgKC1bV0tDb250ZW50 VmlldyBjcmVhdGVIaWdobGlnaHRJbk5ld0dyb3VwV2l0aFJhbmdlOl0pOgorCiAyMDIwLTExLTE4 ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFu IHVwIHNvbWUgY29kZSBpbiBTaGFyZWREaXNwbGF5TGlzdEhhbmRsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5k ZXggNjhjNmI2ZWNlYzE2ZWU0NjM0MzYzYmMwZTg4NWQ2ZDlkMDk1NWY0Mi4uZDQxZDY0YjdhYWE1 ODNmYjQwNzQ2ZDNkMmY0NTI2NjY0Zjc3NWVjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04MzcsNiAr ODM3LDEwIEBAIC0gKHZvaWQpc2V0VXBJbnRlcmFjdGlvbgogICAgIFtzZWxmIHNldFVwU2NyaWJi bGVJbnRlcmFjdGlvbl07CiAjZW5kaWYKIAorI2lmIEVOQUJMRShBUFBfSElHSExJR0hUUykKKyAg ICBbc2VsZiBzZXR1cEFwcEhpZ2hsaWdodE1lbnVzXTsKKyNlbmRpZgorCiAgICAgX3R3b0Zpbmdl clNpbmdsZVRhcEdlc3R1cmVSZWNvZ25pemVyID0gYWRvcHROUyhbW1VJVGFwR2VzdHVyZVJlY29n bml6ZXIgYWxsb2NdIGluaXRXaXRoVGFyZ2V0OnNlbGYgYWN0aW9uOkBzZWxlY3RvcihfdHdvRmlu Z2VyU2luZ2xlVGFwR2VzdHVyZVJlY29nbml6ZWQ6KV0pOwogICAgIFtfdHdvRmluZ2VyU2luZ2xl VGFwR2VzdHVyZVJlY29nbml6ZXIgc2V0QWxsb3dhYmxlTW92ZW1lbnQ6NjBdOwogICAgIFtfdHdv RmluZ2VyU2luZ2xlVGFwR2VzdHVyZVJlY29nbml6ZXIgX3NldEFsbG93YWJsZVNlcGFyYXRpb246 MTUwXTsKQEAgLTMzMjYsNiArMzMzMCwxMSBAQCAtIChCT09MKWNhblBlcmZvcm1BY3Rpb246KFNF TClhY3Rpb24gd2l0aFNlbmRlcjooaWQpc2VuZGVyCiAgICAgICAgIHx8IGFjdGlvbiA9PSBAc2Vs ZWN0b3IoX3RyYW5zcG9zZSkpCiAgICAgICAgIHJldHVybiBlZGl0b3JTdGF0ZS5pc0NvbnRlbnRF ZGl0YWJsZTsKIAorI2lmIEVOQUJMRShBUFBfSElHSExJR0hUUykKKyAgICBpZiAoYWN0aW9uID09 IEBzZWxlY3RvcihjcmVhdGVIaWdobGlnaHRJbkN1cnJlbnRHcm91cFdpdGhSYW5nZTopIHx8IGFj dGlvbiA9PSBAc2VsZWN0b3IoY3JlYXRlSGlnaGxpZ2h0SW5OZXdHcm91cFdpdGhSYW5nZTopKQor ICAgICAgICByZXR1cm4gZWRpdG9yU3RhdGUuc2VsZWN0aW9uSXNSYW5nZSAmJiAhZWRpdG9yU3Rh dGUuaXNDb250ZW50RWRpdGFibGU7CisjZW5kaWYKKwogICAgIHJldHVybiBbX3dlYlZpZXcgY2Fu UGVyZm9ybUFjdGlvbjphY3Rpb24gd2l0aFNlbmRlcjpzZW5kZXJdOwogfQogCkBAIC04NTk0LDYg Kzg2MDMsMjggQEAgLSAodm9pZClfbG9va3VwR2VzdHVyZVJlY29nbml6ZWQ6KFVJR2VzdHVyZVJl Y29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgogfQogI2VuZGlmCiAKKyNpZiBFTkFCTEUoQVBQ X0hJR0hMSUdIVFMpCistICh2b2lkKXNldHVwQXBwSGlnaGxpZ2h0TWVudXMKK3sKKyAgICBpZiAo X3BhZ2UtPnByZWZlcmVuY2VzKCkuYXBwSGlnaGxpZ2h0c0VuYWJsZWQoKSkgeworICAgICAgICBh dXRvIGFkZEhpZ2hsaWdodEN1cnJlbnRHcm91cEl0ZW0gPSBhZG9wdE5TKFtbVUlNZW51SXRlbSBh bGxvY10gaW5pdFdpdGhUaXRsZTpXZWJDb3JlOjpjb250ZXh0TWVudUl0ZW1UYWdBZGRIaWdobGln aHRUb0N1cnJlbnRHcm91cCgpIGFjdGlvbjpAc2VsZWN0b3IoY3JlYXRlSGlnaGxpZ2h0SW5DdXJy ZW50R3JvdXBXaXRoUmFuZ2U6KV0pOworICAgICAgICBhdXRvIGFkZEhpZ2hsaWdodE5ld0dyb3Vw SXRlbSA9IGFkb3B0TlMoW1tVSU1lbnVJdGVtIGFsbG9jXSBpbml0V2l0aFRpdGxlOldlYkNvcmU6 OmNvbnRleHRNZW51SXRlbVRhZ0FkZEhpZ2hsaWdodFRvTmV3R3JvdXAoKSBhY3Rpb246QHNlbGVj dG9yKGNyZWF0ZUhpZ2hsaWdodEluTmV3R3JvdXBXaXRoUmFuZ2U6KV0pOworICAgICAgICBbW1VJ TWVudUNvbnRyb2xsZXIgc2hhcmVkTWVudUNvbnRyb2xsZXJdIHNldE1lbnVJdGVtczpAWyBhZGRI aWdobGlnaHRDdXJyZW50R3JvdXBJdGVtLmdldCgpLCBhZGRIaWdobGlnaHROZXdHcm91cEl0ZW0u Z2V0KCldXTsKKyAgICB9Cit9CisKKy0gKHZvaWQpY3JlYXRlSGlnaGxpZ2h0SW5DdXJyZW50R3Jv dXBXaXRoUmFuZ2U6KGlkKXNlbmRlcgoreworICAgIC8vIEZJWE1FOiBBZGQgSGlnaGxpZ2h0IGxv Z2ljLgorfQorCistICh2b2lkKWNyZWF0ZUhpZ2hsaWdodEluTmV3R3JvdXBXaXRoUmFuZ2U6KGlk KXNlbmRlcgoreworICAgIC8vIEZJWE1FOiBBZGQgSGlnaGxpZ2h0IGxvZ2ljLgorfQorCisjZW5k aWYKKwogLSAodm9pZClzZXRDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQ6KEJPT0wpZW5h YmxlZAogewogICAgIGlmIChXZWJLaXQ6OlRleHRDaGVja2VyOjpzZXRDb250aW51b3VzU3BlbGxD aGVja2luZ0VuYWJsZWQoZW5hYmxlZCkpCg== 414525 2020-11-18 18:17:56 -0800 2020-11-18 19:17:16 -0800 Patch for landing bug-219117-20201118181755.patch text/plain 3444 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhhZWEyNTVhOTI4YWFhZGUy MzlhZGMxMDBkZjUwMTMxOWU1Y2YxMDEuLjkzMzhmZjIwOTMwMzJjY2Q4M2I1NTgwYjZlOWU3ZjEx N2FlZjYyYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTEtMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBNZW51IEJhciBzdXBw b3J0IGZvciBhcHAgaGlnaGxpZ2h0cyBpbiBib29rLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgV2Vu c29uIEhzaWVoLgorCisgICAgICAgIEFkZCBtZW51IHN0dWJzIGluIGlPUyB0byBzdXBwb3J0IGhp Z2hsaWdodHMgZm9yIGJvb2tzIGluIG1vZGVybiB3ZWJraXQuIAorCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVu dFZpZXcgc2V0VXBJbnRlcmFjdGlvbl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNhblBl cmZvcm1BY3Rpb246d2l0aFNlbmRlcjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBzZXR1 cEFwcEhpZ2hsaWdodE1lbnVzXSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY3JlYXRlSGln aGxpZ2h0SW5DdXJyZW50R3JvdXBXaXRoUmFuZ2U6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgY3JlYXRlSGlnaGxpZ2h0SW5OZXdHcm91cFdpdGhSYW5nZTpdKToKKwogMjAyMC0xMS0xOCAg V2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1 cCBzb21lIGNvZGUgaW4gU2hhcmVkRGlzcGxheUxpc3RIYW5kbGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4 IDY4YzZiNmVjZWMxNmVlNDYzNDM2M2JjMGU4ODVkNmQ5ZDA5NTVmNDIuLmM1MTQ3ZjQzMDQ3OTFh Y2Y2NjNkMjE0NTlhMmU2MzFhNDMzNmQ3NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtODM3LDYgKzgz NywxMCBAQCAtICh2b2lkKXNldFVwSW50ZXJhY3Rpb24KICAgICBbc2VsZiBzZXRVcFNjcmliYmxl SW50ZXJhY3Rpb25dOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoQVBQX0hJR0hMSUdIVFMpCisgICAg W3NlbGYgc2V0dXBBcHBIaWdobGlnaHRNZW51c107CisjZW5kaWYKKwogICAgIF90d29GaW5nZXJT aW5nbGVUYXBHZXN0dXJlUmVjb2duaXplciA9IGFkb3B0TlMoW1tVSVRhcEdlc3R1cmVSZWNvZ25p emVyIGFsbG9jXSBpbml0V2l0aFRhcmdldDpzZWxmIGFjdGlvbjpAc2VsZWN0b3IoX3R3b0Zpbmdl clNpbmdsZVRhcEdlc3R1cmVSZWNvZ25pemVkOildKTsKICAgICBbX3R3b0ZpbmdlclNpbmdsZVRh cEdlc3R1cmVSZWNvZ25pemVyIHNldEFsbG93YWJsZU1vdmVtZW50OjYwXTsKICAgICBbX3R3b0Zp bmdlclNpbmdsZVRhcEdlc3R1cmVSZWNvZ25pemVyIF9zZXRBbGxvd2FibGVTZXBhcmF0aW9uOjE1 MF07CkBAIC0zMzI2LDYgKzMzMzAsMTEgQEAgLSAoQk9PTCljYW5QZXJmb3JtQWN0aW9uOihTRUwp YWN0aW9uIHdpdGhTZW5kZXI6KGlkKXNlbmRlcgogICAgICAgICB8fCBhY3Rpb24gPT0gQHNlbGVj dG9yKF90cmFuc3Bvc2UpKQogICAgICAgICByZXR1cm4gZWRpdG9yU3RhdGUuaXNDb250ZW50RWRp dGFibGU7CiAKKyNpZiBFTkFCTEUoQVBQX0hJR0hMSUdIVFMpCisgICAgaWYgKGFjdGlvbiA9PSBA c2VsZWN0b3IoY3JlYXRlSGlnaGxpZ2h0SW5DdXJyZW50R3JvdXBXaXRoUmFuZ2U6KSB8fCBhY3Rp b24gPT0gQHNlbGVjdG9yKGNyZWF0ZUhpZ2hsaWdodEluTmV3R3JvdXBXaXRoUmFuZ2U6KSkKKyAg ICAgICAgcmV0dXJuIGVkaXRvclN0YXRlLnNlbGVjdGlvbklzUmFuZ2UgJiYgIWVkaXRvclN0YXRl LmlzQ29udGVudEVkaXRhYmxlOworI2VuZGlmCisKICAgICByZXR1cm4gW193ZWJWaWV3IGNhblBl cmZvcm1BY3Rpb246YWN0aW9uIHdpdGhTZW5kZXI6c2VuZGVyXTsKIH0KIApAQCAtODU5NCw2ICs4 NjAzLDI4IEBAIC0gKHZvaWQpX2xvb2t1cEdlc3R1cmVSZWNvZ25pemVkOihVSUdlc3R1cmVSZWNv Z25pemVyICopZ2VzdHVyZVJlY29nbml6ZXIKIH0KICNlbmRpZgogCisjaWYgRU5BQkxFKEFQUF9I SUdITElHSFRTKQorLSAodm9pZClzZXR1cEFwcEhpZ2hsaWdodE1lbnVzCit7CisgICAgaWYgKF9w YWdlLT5wcmVmZXJlbmNlcygpLmFwcEhpZ2hsaWdodHNFbmFibGVkKCkpIHsKKyAgICAgICAgYXV0 byBhZGRIaWdobGlnaHRDdXJyZW50R3JvdXBJdGVtID0gYWRvcHROUyhbW1VJTWVudUl0ZW0gYWxs b2NdIGluaXRXaXRoVGl0bGU6V2ViQ29yZTo6Y29udGV4dE1lbnVJdGVtVGFnQWRkSGlnaGxpZ2h0 VG9DdXJyZW50R3JvdXAoKSBhY3Rpb246QHNlbGVjdG9yKGNyZWF0ZUhpZ2hsaWdodEluQ3VycmVu dEdyb3VwV2l0aFJhbmdlOildKTsKKyAgICAgICAgYXV0byBhZGRIaWdobGlnaHROZXdHcm91cEl0 ZW0gPSBhZG9wdE5TKFtbVUlNZW51SXRlbSBhbGxvY10gaW5pdFdpdGhUaXRsZTpXZWJDb3JlOjpj b250ZXh0TWVudUl0ZW1UYWdBZGRIaWdobGlnaHRUb05ld0dyb3VwKCkgYWN0aW9uOkBzZWxlY3Rv cihjcmVhdGVIaWdobGlnaHRJbk5ld0dyb3VwV2l0aFJhbmdlOildKTsKKyAgICAgICAgW1tVSU1l bnVDb250cm9sbGVyIHNoYXJlZE1lbnVDb250cm9sbGVyXSBzZXRNZW51SXRlbXM6QFsgYWRkSGln aGxpZ2h0Q3VycmVudEdyb3VwSXRlbS5nZXQoKSwgYWRkSGlnaGxpZ2h0TmV3R3JvdXBJdGVtLmdl dCgpIF1dOworICAgIH0KK30KKworLSAodm9pZCljcmVhdGVIaWdobGlnaHRJbkN1cnJlbnRHcm91 cFdpdGhSYW5nZTooaWQpc2VuZGVyCit7CisgICAgLy8gRklYTUU6IEFkZCBIaWdobGlnaHQgbG9n aWMuCit9CisKKy0gKHZvaWQpY3JlYXRlSGlnaGxpZ2h0SW5OZXdHcm91cFdpdGhSYW5nZTooaWQp c2VuZGVyCit7CisgICAgLy8gRklYTUU6IEFkZCBIaWdobGlnaHQgbG9naWMuCit9CisKKyNlbmRp ZgorCiAtICh2b2lkKXNldENvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDooQk9PTCllbmFi bGVkCiB7CiAgICAgaWYgKFdlYktpdDo6VGV4dENoZWNrZXI6OnNldENvbnRpbnVvdXNTcGVsbENo ZWNraW5nRW5hYmxlZChlbmFibGVkKSkK