219081 2020-11-18 06:16:30 -0800 [GTK] MiniBrowser: add an option to quit the browser after loading finishes 2020-12-10 05:19:47 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219737 Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply clopez svillar oldest_to_newest 1708576 0 cgarcia 2020-11-18 06:16:30 -0800 It's useful to run benchmarks or test case reduction tools 1708577 1 414444 cgarcia 2020-11-18 06:21:13 -0800 Created attachment 414444 Patch 1709057 2 414444 clopez 2020-11-19 05:35:04 -0800 Comment on attachment 414444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414444&action=review > Tools/MiniBrowser/gtk/main.c:594 > +static void exitAfterWebProcessCrashed(WebKitWebView *webView, WebKitWebProcessTerminationReason reason, GApplication *application) > +{ > + if (reason == WEBKIT_WEB_PROCESS_CRASHED) > + exitAfterWebViewLoadFinishesCallback(webView, WEBKIT_LOAD_FINISHED, application); In this case I think it will be useful to print an error message saying that the webprocess has crashed. Otherwise it can be confusing, and the user can't easily tell if the minibrowser is exiting because the load has finished correctly or because of a crash from the webprocess. Also setting a non-zero exit code in this case can be also useful for tests. 1709065 3 414444 cgarcia 2020-11-19 06:00:14 -0800 Comment on attachment 414444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414444&action=review >> Tools/MiniBrowser/gtk/main.c:594 >> + exitAfterWebViewLoadFinishesCallback(webView, WEBKIT_LOAD_FINISHED, application); > > In this case I think it will be useful to print an error message saying that the webprocess has crashed. > Otherwise it can be confusing, and the user can't easily tell if the minibrowser is exiting because the load has finished correctly or because of a crash from the webprocess. > Also setting a non-zero exit code in this case can be also useful for tests. The message is always printed by the webProcessTerminatedCallback() in BrowserTab.c. I think it's a good idea to exit(1) instead of g_application_quit(). 1710246 4 cgarcia 2020-11-27 02:02:33 -0800 Committed r270186: <https://trac.webkit.org/changeset/270186> 414444 2020-11-18 06:21:13 -0800 2020-11-19 05:35:04 -0800 Patch mb-lithium.diff text/plain 6363 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ZTU3 ZWRmMTU2MTMuLmU2ZDg5ZDk1YThjNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTExLTE4ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNaW5pQnJv ZXNlciBhZGQgYW4gb3B0aW9uIHRvIHF1aXQgdGhlIGJyb3dzZXIgYWZ0ZXIgbG9hZGluZyBmaW5p c2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5 MDgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQn cyB1c2VmdWwgdG8gcnVuIGJlbmNobWFya3Mgb3IgdGVzdCBjYXNlIHJlZHVjdGlvbiB0b29scy4K KworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyVGFiLmM6CisgICAgICAgICh3ZWJQ cm9jZXNzVGVybWluYXRlZENhbGxiYWNrKTogU2hvdyBhIHdhcm5pbmcgd2hlbiB0aGUgd2ViIHBy b2Nlc3MgY3Jhc2hlcy4KKyAgICAgICAgKGJyb3dzZXJUYWJDb25zdHJ1Y3RlZCk6IENvbm5lY3Qg dG8gd2ViLXByb2Nlc3MtdGVybWluYXRlZCBzaWduYWwuCisgICAgICAgICogTWluaUJyb3dzZXIv Z3RrL21haW4uYzoKKyAgICAgICAgKHF1aXRBcHBsaWNhdGlvbik6IFF1aXQgdGhlIE1pbmlCcm93 c2VyLgorICAgICAgICAoZXhpdEFmdGVyV2ViVmlld0xvYWRGaW5pc2hlc0NhbGxiYWNrKTogU2No ZWR1bGUgYSBicm93c2VyIHF1aXQgdG8gdGhlIG5leHQgcnVuIGxvb3AgaXRlcmF0aW9uLgorICAg ICAgICAoZXhpdEFmdGVyV2ViUHJvY2Vzc0NyYXNoZWQpOiBDYWxsIGV4aXRBZnRlcldlYlZpZXdM b2FkRmluaXNoZXNDYWxsYmFjayB3aXRoIFdFQktJVF9MT0FEX0ZJTklTSEVELgorICAgICAgICAo ZXhpdEFmdGVyV2ViVmlld0xvYWRGaW5pc2hlcyk6IENvbm5lY3QgdG8gbG9hZC1jaGFuZ2VkIGFu ZCB3ZWItcHJvY2Vzcy10ZXJtaW5hdGVkIHNpZ25hbHMKKyAgICAgICAgKGFjdGl2YXRlKTogRW5z dXJlIHRoZSBicm93c2VyIGlzIGV4aXRlZCBhZnRlciB0aGUgbG9hZCBmaW5pc2hlcyBvciB3ZWIg cHJvY2VzcyBjcmFzaGVzIHdoZW4gLS1leGl0LWFmdGVyLWxvYWQgaXMgcGFzc2VkLgorCiAyMDIw LTExLTE3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAg W2J1aWxkYm90XSBBZGQgYnVpbGRBbmRUZXN0IGJvdCBmb3IgV2ViS2l0R1RLIChHVEs0KQpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJUYWIuYyBiL1Rvb2xzL01pbmlC cm93c2VyL2d0ay9Ccm93c2VyVGFiLmMKaW5kZXggMzg0NWVhYmJhM2U5Li4zZTUzOGE5ZDhhNWYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyVGFiLmMKKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJUYWIuYwpAQCAtNDE3LDYgKzQxNywxMiBAQCBzdGF0 aWMgZ2Jvb2xlYW4gcnVuQ29sb3JDaG9vc2VyQ2FsbGJhY2soV2ViS2l0V2ViVmlldyAqd2ViVmll dywgV2ViS2l0Q29sb3JDaG9vcwogICAgIHJldHVybiBUUlVFOwogfQogCitzdGF0aWMgdm9pZCB3 ZWJQcm9jZXNzVGVybWluYXRlZENhbGxiYWNrKFdlYktpdFdlYlZpZXcgKndlYlZpZXcsIFdlYktp dFdlYlByb2Nlc3NUZXJtaW5hdGlvblJlYXNvbiByZWFzb24pCit7CisgICAgaWYgKHJlYXNvbiA9 PSBXRUJLSVRfV0VCX1BST0NFU1NfQ1JBU0hFRCkKKyAgICAgICAgZ193YXJuaW5nKCJXZWJQcm9j ZXNzIENSQVNIRUQiKTsKK30KKwogc3RhdGljIGdib29sZWFuIGluc3BlY3Rvck9wZW5lZEluV2lu ZG93KFdlYktpdFdlYkluc3BlY3RvciAqaW5zcGVjdG9yLCBCcm93c2VyVGFiICp0YWIpCiB7CiAg ICAgdGFiLT5pbnNwZWN0b3JJc1Zpc2libGUgPSBUUlVFOwpAQCAtNjI2LDYgKzYzMiw3IEBAIHN0 YXRpYyB2b2lkIGJyb3dzZXJUYWJDb25zdHJ1Y3RlZChHT2JqZWN0ICpnT2JqZWN0KQogICAgIGdf c2lnbmFsX2Nvbm5lY3QodGFiLT53ZWJWaWV3LCAibG9hZC1mYWlsZWQtd2l0aC10bHMtZXJyb3Jz IiwgR19DQUxMQkFDSyhsb2FkRmFpbGVkV2l0aFRMU2Vycm9ycyksIHRhYik7CiAgICAgZ19zaWdu YWxfY29ubmVjdCh0YWItPndlYlZpZXcsICJwZXJtaXNzaW9uLXJlcXVlc3QiLCBHX0NBTExCQUNL KGRlY2lkZVBlcm1pc3Npb25SZXF1ZXN0KSwgdGFiKTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHRh Yi0+d2ViVmlldywgInJ1bi1jb2xvci1jaG9vc2VyIiwgR19DQUxMQkFDSyhydW5Db2xvckNob29z ZXJDYWxsYmFjayksIHRhYik7CisgICAgZ19zaWduYWxfY29ubmVjdCh0YWItPndlYlZpZXcsICJ3 ZWItcHJvY2Vzcy10ZXJtaW5hdGVkIiwgR19DQUxMQkFDSyh3ZWJQcm9jZXNzVGVybWluYXRlZENh bGxiYWNrKSwgTlVMTCk7CiAKICAgICBnX29iamVjdF9iaW5kX3Byb3BlcnR5KHRhYi0+d2ViVmll dywgImlzLXBsYXlpbmctYXVkaW8iLCB0YWItPnRpdGxlQXVkaW9CdXR0b24sICJ2aXNpYmxlIiwg R19CSU5ESU5HX0RFRkFVTFQgfCBHX0JJTkRJTkdfU1lOQ19DUkVBVEUpOwogICAgIGdfc2lnbmFs X2Nvbm5lY3QodGFiLT53ZWJWaWV3LCAibm90aWZ5Ojppcy1tdXRlZCIsIEdfQ0FMTEJBQ0soYXVk aW9NdXRlZENoYW5nZWQpLCB0YWIpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKaW5kZXggZGM1M2RiMGMyNThi Li5kNTliNTk4NzFjYjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMK KysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYwpAQCAtNTIsNiArNTIsNyBAQCBzdGF0 aWMgY29uc3QgY2hhciAqY29va2llc1BvbGljeTsKIHN0YXRpYyBjb25zdCBjaGFyICpwcm94eTsK IHN0YXRpYyBnYm9vbGVhbiBkYXJrTW9kZTsKIHN0YXRpYyBnYm9vbGVhbiBlbmFibGVJVFA7Citz dGF0aWMgZ2Jvb2xlYW4gZXhpdEFmdGVyTG9hZDsKIHN0YXRpYyBnYm9vbGVhbiBwcmludFZlcnNp b247CiAKIHR5cGVkZWYgZW51bSB7CkBAIC0xNDMsNiArMTQ0LDcgQEAgc3RhdGljIGNvbnN0IEdP cHRpb25FbnRyeSBjb21tYW5kTGluZU9wdGlvbnNbXSA9CiAgICAgeyAiaWdub3JlLXRscy1lcnJv cnMiLCAwLCAwLCBHX09QVElPTl9BUkdfTk9ORSwgJmlnbm9yZVRMU0Vycm9ycywgIklnbm9yZSBU TFMgZXJyb3JzIiwgTlVMTCB9LAogICAgIHsgImNvbnRlbnQtZmlsdGVyIiwgMCwgMCwgR19PUFRJ T05fQVJHX0ZJTEVOQU1FLCAmY29udGVudEZpbHRlciwgIkpTT04gd2l0aCBjb250ZW50IGZpbHRl cmluZyBydWxlcyIsICJGSUxFIiB9LAogICAgIHsgImVuYWJsZS1pdHAiLCAwLCAwLCBHX09QVElP Tl9BUkdfTk9ORSwgJmVuYWJsZUlUUCwgIkVuYWJsZSBJbnRlbGxpZ2VudCBUcmFja2luZyBQcmV2 ZW50aW9uIChJVFApIiwgTlVMTCB9LAorICAgIHsgImV4aXQtYWZ0ZXItbG9hZCIsIDAsIDAsIEdf T1BUSU9OX0FSR19OT05FLCAmZXhpdEFmdGVyTG9hZCwgIlF1aXQgdGhlIGJyb3dzZXIgYWZ0ZXIg dGhlIGxvYWQgZmluaXNoZXMiLCBOVUxMIH0sCiAgICAgeyAidmVyc2lvbiIsICd2JywgMCwgR19P UFRJT05fQVJHX05PTkUsICZwcmludFZlcnNpb24sICJQcmludCB0aGUgV2ViS2l0R1RLIHZlcnNp b24iLCBOVUxMIH0sCiAgICAgeyBHX09QVElPTl9SRU1BSU5JTkcsIDAsIDAsIEdfT1BUSU9OX0FS R19GSUxFTkFNRV9BUlJBWSwgJnVyaUFyZ3VtZW50cywgMCwgIltVUkzigKZdIiB9LAogICAgIHsg MCwgMCwgMCwgMCwgMCwgMCwgMCB9CkBAIC01NzIsNiArNTc0LDMyIEBAIHN0YXRpYyB2b2lkIGF1 dG9tYXRpb25TdGFydGVkQ2FsbGJhY2soV2ViS2l0V2ViQ29udGV4dCAqd2ViQ29udGV4dCwgV2Vi S2l0QXV0b21hCiAgICAgZ19zaWduYWxfY29ubmVjdChzZXNzaW9uLCAiY3JlYXRlLXdlYi12aWV3 Ojp0YWIiLCBHX0NBTExCQUNLKGNyZWF0ZVdlYlZpZXdGb3JBdXRvbWF0aW9uSW5UYWJDYWxsYmFj ayksIGFwcGxpY2F0aW9uKTsKIH0KIAorc3RhdGljIGdib29sZWFuIHF1aXRBcHBsaWNhdGlvbihH QXBwbGljYXRpb24gKmFwcGxpY2F0aW9uKQoreworICAgIGdfYXBwbGljYXRpb25fcXVpdChhcHBs aWNhdGlvbik7CisgICAgcmV0dXJuIEZBTFNFOworfQorCitzdGF0aWMgdm9pZCBleGl0QWZ0ZXJX ZWJWaWV3TG9hZEZpbmlzaGVzQ2FsbGJhY2soV2ViS2l0V2ViVmlldyAqd2ViVmlldywgV2ViS2l0 TG9hZEV2ZW50IGxvYWRFdmVudCwgR0FwcGxpY2F0aW9uICphcHBsaWNhdGlvbikKK3sKKyAgICBp ZiAobG9hZEV2ZW50ICE9IFdFQktJVF9MT0FEX0ZJTklTSEVEKQorICAgICAgICByZXR1cm47CisK KyAgICBnX2lkbGVfYWRkX2Z1bGwoR19QUklPUklUWV9ERUZBVUxUX0lETEUsIChHU291cmNlRnVu YylxdWl0QXBwbGljYXRpb24sIGdfb2JqZWN0X3JlZihhcHBsaWNhdGlvbiksIGdfb2JqZWN0X3Vu cmVmKTsKK30KKworc3RhdGljIHZvaWQgZXhpdEFmdGVyV2ViUHJvY2Vzc0NyYXNoZWQoV2ViS2l0 V2ViVmlldyAqd2ViVmlldywgV2ViS2l0V2ViUHJvY2Vzc1Rlcm1pbmF0aW9uUmVhc29uIHJlYXNv biwgR0FwcGxpY2F0aW9uICphcHBsaWNhdGlvbikKK3sKKyAgICBpZiAocmVhc29uID09IFdFQktJ VF9XRUJfUFJPQ0VTU19DUkFTSEVEKQorICAgICAgICBleGl0QWZ0ZXJXZWJWaWV3TG9hZEZpbmlz aGVzQ2FsbGJhY2sod2ViVmlldywgV0VCS0lUX0xPQURfRklOSVNIRUQsIGFwcGxpY2F0aW9uKTsK K30KKworc3RhdGljIHZvaWQgZXhpdEFmdGVyV2ViVmlld0xvYWRGaW5pc2hlcyhXZWJLaXRXZWJW aWV3ICp3ZWJWaWV3LCBHQXBwbGljYXRpb24gKmFwcGxpY2F0aW9uKQoreworICAgIGdfc2lnbmFs X2Nvbm5lY3Rfb2JqZWN0KHdlYlZpZXcsICJsb2FkLWNoYW5nZWQiLCBHX0NBTExCQUNLKGV4aXRB ZnRlcldlYlZpZXdMb2FkRmluaXNoZXNDYWxsYmFjayksIGFwcGxpY2F0aW9uLCBHX0NPTk5FQ1Rf QUZURVIpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Rfb2JqZWN0KHdlYlZpZXcsICJ3ZWItcHJvY2Vz cy10ZXJtaW5hdGVkIiwgR19DQUxMQkFDSyhleGl0QWZ0ZXJXZWJQcm9jZXNzQ3Jhc2hlZCksIGFw cGxpY2F0aW9uLCBHX0NPTk5FQ1RfQUZURVIpOworfQorCiB0eXBlZGVmIHN0cnVjdCB7CiAgICAg R01haW5Mb29wICptYWluTG9vcDsKICAgICBXZWJLaXRVc2VyQ29udGVudEZpbHRlciAqZmlsdGVy OwpAQCAtNzE0LDggKzc0MiwxMSBAQCBzdGF0aWMgdm9pZCBhY3RpdmF0ZShHQXBwbGljYXRpb24g KmFwcGxpY2F0aW9uLCBXZWJLaXRTZXR0aW5ncyAqd2Via2l0U2V0dGluZ3MpCiAKICAgICAgICAg Zm9yIChpID0gMDsgdXJpQXJndW1lbnRzW2ldOyBpKyspIHsKICAgICAgICAgICAgIFdlYktpdFdl YlZpZXcgKndlYlZpZXcgPSBjcmVhdGVCcm93c2VyVGFiKG1haW5XaW5kb3csIHdlYmtpdFNldHRp bmdzLCB1c2VyQ29udGVudE1hbmFnZXIsIGRlZmF1bHRXZWJzaXRlUG9saWNpZXMpOwotICAgICAg ICAgICAgaWYgKCFpKQorICAgICAgICAgICAgaWYgKCFpKSB7CiAgICAgICAgICAgICAgICAgZmly c3RUYWIgPSBHVEtfV0lER0VUKHdlYlZpZXcpOworICAgICAgICAgICAgICAgIGlmIChleGl0QWZ0 ZXJMb2FkKQorICAgICAgICAgICAgICAgICAgICBleGl0QWZ0ZXJXZWJWaWV3TG9hZEZpbmlzaGVz KHdlYlZpZXcsIGFwcGxpY2F0aW9uKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGdjaGFy ICp1cmwgPSBhcmd1bWVudFRvVVJMKHVyaUFyZ3VtZW50c1tpXSk7CiAgICAgICAgICAgICB3ZWJr aXRfd2ViX3ZpZXdfbG9hZF91cmkod2ViVmlldywgdXJsKTsKICAgICAgICAgICAgIGdfZnJlZSh1 cmwpOwpAQCAtNzI3LDggKzc1OCwxMCBAQCBzdGF0aWMgdm9pZCBhY3RpdmF0ZShHQXBwbGljYXRp b24gKmFwcGxpY2F0aW9uLCBXZWJLaXRTZXR0aW5ncyAqd2Via2l0U2V0dGluZ3MpCiAgICAgICAg IGlmICghZWRpdG9yTW9kZSkgewogICAgICAgICAgICAgaWYgKHNlc3Npb25GaWxlKQogICAgICAg ICAgICAgICAgIGJyb3dzZXJfd2luZG93X2xvYWRfc2Vzc2lvbihtYWluV2luZG93LCBzZXNzaW9u RmlsZSk7Ci0gICAgICAgICAgICBlbHNlIGlmICghYXV0b21hdGlvbk1vZGUpCisgICAgICAgICAg ICBlbHNlIGlmICghYXV0b21hdGlvbk1vZGUpIHsKICAgICAgICAgICAgICAgICB3ZWJraXRfd2Vi X3ZpZXdfbG9hZF91cmkod2ViVmlldywgQlJPV1NFUl9ERUZBVUxUX1VSTCk7CisgICAgICAgICAg ICAgICAgZXhpdEFmdGVyV2ViVmlld0xvYWRGaW5pc2hlcyh3ZWJWaWV3LCBhcHBsaWNhdGlvbik7 CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAK