219079 2020-11-18 04:59:49 -0800 Web process assert when loading slack 2020-12-04 05:35:50 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia zalan bfulgham koivisto simon.fraser svillar webkit-bug-importer zalan oldest_to_newest 1708567 0 cgarcia 2020-11-18 04:59:49 -0800 Since a few days ago I'm unable to use slack because my web process crashes: 1 0x7f63279098d9 WTFCrash 2 0x7f632c0f9154 WebCore::LayoutIntegration::LineLayout::contentLogicalHeight() const 3 0x7f632c5af081 WebCore::RenderBlockFlow::layoutModernLines(bool, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 4 0x7f632c5f36f8 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 5 0x7f632c5c3c2a WebCore::RenderBlock::layout() 6 0x7f632c5e822f WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 7 0x7f632c5f32cd WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 8 0x7f632c5f3add WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 9 0x7f632c5c3c2a WebCore::RenderBlock::layout() 10 0x7f632c64046c WebCore::RenderFlexibleBox::layoutAndPlaceChildren(WebCore::LayoutUnit&, WTF::Vector<WebCore::FlexItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::LayoutUnit, bool, WTF::Vector<WebCore::RenderFlexibleBox::LineContext, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::LayoutUnit) 11 0x7f632c643ac3 WebCore::RenderFlexibleBox::layoutFlexItems(bool) 12 0x7f632c644286 WebCore::RenderFlexibleBox::layoutBlock(bool, WebCore::LayoutUnit) 13 0x7f632c5c3c2a WebCore::RenderBlock::layout() 14 0x7f632c5e822f WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 15 0x7f632c5f32cd WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 16 0x7f632c5f3add WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 17 0x7f632c5c3c2a WebCore::RenderBlock::layout() 18 0x7f632c5e822f WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 19 0x7f632c5f32cd WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 20 0x7f632c5f3add WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 21 0x7f632c5c3c2a WebCore::RenderBlock::layout() 22 0x7f632c5e822f WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 23 0x7f632c5f32cd WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 24 0x7f632c5f3add WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 25 0x7f632c5c3c2a WebCore::RenderBlock::layout() 26 0x7f632c5e822f WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 27 0x7f632c5f32cd WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 28 0x7f632c5f3add WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 29 0x7f632c5c3c2a WebCore::RenderBlock::layout() 30 0x7f632c64046c WebCore::RenderFlexibleBox::layoutAndPlaceChildren(WebCore::LayoutUnit&, WTF::Vector<WebCore::FlexItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::LayoutUnit, bool, WTF::Vector<WebCore::RenderFlexibleBox::LineContext, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::LayoutUnit) 31 0x7f632c643ac3 WebCore::RenderFlexibleBox::layoutFlexItems(bool) 1708594 1 svillar 2020-11-18 07:09:45 -0800 I'm getting a crash but due to ASSERTs failing ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread() DerivedSources/ForwardingHeaders/wtf/WeakPtr.h(94) : T* WTF::WeakPtr< <template-parameter-1-1>, <template-parameter-1-2> >::get() const [with T = WebCore::Frame; Counter = WTF::EmptyCounter] ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread() DerivedSources/ForwardingHeaders/wtf/WeakPtr.h(94) : T* WTF::WeakPtr< <template-parameter-1-1>, <template-parameter-1-2> >::get() const [with T = WebCore::Frame; Counter = WTF::EmptyCounter] ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread() DerivedSources/ForwardingHeaders/wtf/WeakPtr.h(94) : T* WTF::WeakPtr< <template-parameter-1-1>, <template-parameter-1-2> >::get() const [with T = WebCore::Frame; Counter = WTF::EmptyCounter] ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread() DerivedSources/ForwardingHeaders/wtf/WeakPtr.h(94) : T* WTF::WeakPtr< <template-parameter-1-1>, <template-parameter-1-2> >::get() const [with T = WebCore::Frame; Counter = WTF::EmptyCounter] 1 0x7f81b193878b WTFCrash 2 0x7f81abdebf0e WTF::CrashOnOverflow::overflowed() 1 0x7f81b193878b WTFCrash 3 0x7f81acc360de WTF::WeakPtr<WebCore::Frame, WTF::EmptyCounter>::get() const 1 0x7f81b193878b WTFCrash 2 0x7f81abdebf0e WTF::CrashOnOverflow::overflowed() 2 0x7f81abdebf0e WTF::CrashOnOverflow::overflowed() 3 0x7f81acc360de WTF::WeakPtr<WebCore::Frame, WTF::EmptyCounter>::get() const 4 0x7f81aef98daa WebCore::FrameDestructionObserver::frame() const 3 0x7f81acc360de WTF::WeakPtr<WebCore::Frame, WTF::EmptyCounter>::get() const 4 0x7f81aef98daa WebCore::FrameDestructionObserver::frame() const 1 0x7f81b193878b WTFCrash 5 0x7f81ae961233 WebCore::HTMLMediaElement::mediaPlayerReferrer() const 4 0x7f81aef98daa WebCore::FrameDestructionObserver::frame() const 5 0x7f81ae961233 WebCore::HTMLMediaElement::mediaPlayerReferrer() const 2 0x7f81abdebf0e WTF::CrashOnOverflow::overflowed() 6 0x7f81af2b0c5d WebCore::MediaPlayer::referrer() const 5 0x7f81ae961233 WebCore::HTMLMediaElement::mediaPlayerReferrer() const 6 0x7f81af2b0c5d WebCore::MediaPlayer::referrer() const 7 0x7f81acf5e02f ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2b102f) [0x7f81acf5e02f] 8 0x7f81acf5cc7e ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2afc7e) [0x7f81acf5cc7e] 6 0x7f81af2b0c5d WebCore::MediaPlayer::referrer() const 3 0x7f81acc360de WTF::WeakPtr<WebCore::Frame, WTF::EmptyCounter>::get() const 7 0x7f81acf5e02f ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2b102f) [0x7f81acf5e02f] 9 0x7f819d8fd13d ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3c13d) [0x7f819d8fd13d] 8 0x7f81acf5cc7e ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2afc7e) [0x7f81acf5cc7e] 4 0x7f81aef98daa WebCore::FrameDestructionObserver::frame() const 10 0x7f819d8ff346 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3e346) [0x7f819d8ff346] 7 0x7f81acf5e02f ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2b102f) [0x7f81acf5e02f] 9 0x7f819d8fd13d ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3c13d) [0x7f819d8fd13d] 8 0x7f81acf5cc7e ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2afc7e) [0x7f81acf5cc7e] 11 0x7f819e3d969f ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstreamer-1.0.so.0(+0xb669f) [0x7f819e3d969f] 12 0x7f819e601ee4 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libglib-2.0.so.0(+0x74ee4) [0x7f819e601ee4] 5 0x7f81ae961233 WebCore::HTMLMediaElement::mediaPlayerReferrer() const 9 0x7f819d8fd13d ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3c13d) [0x7f819d8fd13d] 6 0x7f81af2b0c5d WebCore::MediaPlayer::referrer() const 13 0x7f819e6017c5 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libglib-2.0.so.0(+0x747c5) [0x7f819e6017c5] 7 0x7f81acf5e02f ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2b102f) [0x7f81acf5e02f] 10 0x7f819d8ff346 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3e346) [0x7f819d8ff346] 8 0x7f81acf5cc7e ~/checkout/WebKit/WebKitBuild/Debug/lib/libWPEWebKit-1.0.so.3(+0xe2afc7e) [0x7f81acf5cc7e] 14 0x7f819daa6ea7 /lib/x86_64-linux-gnu/libpthread.so.0(+0x8ea7) [0x7f819daa6ea7] 10 0x7f819d8ff346 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3e346) [0x7f819d8ff346] 11 0x7f819e3d969f ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstreamer-1.0.so.0(+0xb669f) [0x7f819e3d969f] 9 0x7f819d8fd13d ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3c13d) [0x7f819d8fd13d] 15 0x7f819ea8eeaf clone 11 0x7f819e3d969f ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstreamer-1.0.so.0(+0xb669f) [0x7f819e3d969f] 12 0x7f819e601ee4 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libglib-2.0.so.0(+0x74ee4) [0x7f819e601ee4] 10 0x7f819d8ff346 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstbase-1.0.so.0(+0x3e346) [0x7f819d8ff346] 12 0x7f819e601ee4 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libglib-2.0.so.0(+0x74ee4) [0x7f819e601ee4] 13 0x7f819e6017c5 ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libglib-2.0.so.0(+0x747c5) [0x7f819e6017c5] 11 0x7f819e3d969f ~/checkout/WebKit/WebKitBuild/DependenciesWPE/Root/lib/libgstreamer-1.0.so.0(+0xb669f) [0x7f819e3d969f] 1708733 2 zalan 2020-11-18 13:14:34 -0800 Do you have repro steps or a test reduction? (my ToT WebKit debug build works fine with the slack channels I am in). 1708998 3 cgarcia 2020-11-19 00:41:05 -0800 It started to happen even with the same WebKit version, so I guess something changed in the current room or something like that, that revealed the bug. The only step to reproduce it for me is opening webkit slack in my browser. I don't have a test case, so I'll try to debug it. 1709973 4 cgarcia 2020-11-24 01:15:10 -0800 I found some time to debug the issue. The problem is that in LineLayout::contentLogicalHeight() we have a m_inlineContent, but lines is empty. I don't have time right now to figure out why, or whether that's expected or not, but checking also lines is not empty fixes the issue. 1709974 5 414825 cgarcia 2020-11-24 01:17:31 -0800 Created attachment 414825 Patch 1710001 6 414825 zalan 2020-11-24 07:19:55 -0800 Comment on attachment 414825 Patch Please upload a test reduction (or some kind of test content with repro steps). While the patch certainly fixes the crash, it'd be great to understand under what circumstances it happens (to check if it needs additional changes) and also it'd be nice to regression test it. 1710140 7 webkit-bug-importer 2020-11-26 03:24:02 -0800 <rdar://problem/71747792> 1711980 8 zalan 2020-12-04 03:41:52 -0800 <rdar://problem/71814675> 1711981 9 415401 zalan 2020-12-04 03:47:52 -0800 Created attachment 415401 Patch 1711982 10 zalan 2020-12-04 03:51:49 -0800 (In reply to zalan from comment #6) > Comment on attachment 414825 [details] > Patch > > Please upload a test reduction (or some kind of test content with repro > steps). While the patch certainly fixes the crash, it'd be great to > understand under what circumstances it happens (to check if it needs > additional changes) and also it'd be nice to regression test it. The patch was just papering over the actual issue of missing additional inline types. 1712001 11 ews-feeder 2020-12-04 05:35:49 -0800 Committed r270428: <https://trac.webkit.org/changeset/270428> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415401. 414825 2020-11-24 01:17:31 -0800 2020-12-04 03:47:48 -0800 Patch lines-empty.diff text/plain 1388 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMzhiY2MxM2IyNGYuLjNlNTUyN2ViY2RmMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIwLTExLTI0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBXZWIgcHJvY2VzcyBhc3NlcnQgd2hlbiBsb2FkaW5nIHNs YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkw NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXR1 cm4gZWFybHkgZnJvbSBMaW5lTGF5b3V0Ojpjb250ZW50TG9naWNhbEhlaWdodCgpIGlmIHdlIGhh dmUgaW5saW5lIGNvbnRlbnQgYnV0IHRoZSBsaW5lcyBsaXN0IGlzIGVtcHR5LgorCisgICAgICAg ICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6TGluZUxheW91dDo6Y29udGVudExv Z2ljYWxIZWlnaHQgY29uc3QpOgorCiAyMDIwLTExLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IGFkZCBzdXBwb3J0IGZv ciBwZW4gcG9pbnRlciBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5k ZXggMmY2YjMwMTdiYzNmLi5hNmY5ZWY2OTFjZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVM YXlvdXQuY3BwCkBAIC0yMjgsNyArMjI4LDcgQEAgTGF5b3V0VW5pdCBMaW5lTGF5b3V0Ojpjb250 ZW50TG9naWNhbEhlaWdodCgpIGNvbnN0CiB7CiAgICAgaWYgKG1fcGFnaW5hdGVkSGVpZ2h0KQog ICAgICAgICByZXR1cm4gKm1fcGFnaW5hdGVkSGVpZ2h0OwotICAgIGlmICghbV9pbmxpbmVDb250 ZW50KQorICAgIGlmICghbV9pbmxpbmVDb250ZW50IHx8IG1faW5saW5lQ29udGVudC0+bGluZXMu aXNFbXB0eSgpKQogICAgICAgICByZXR1cm4geyB9OwogCiAgICAgYXV0byYgbGluZXMgPSBtX2lu bGluZUNvbnRlbnQtPmxpbmVzOwo= 415401 2020-12-04 03:47:52 -0800 2020-12-04 05:35:49 -0800 Patch bug-219079-20201204034751.patch text/plain 3488 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzMzhmNjg2YmYyNjJl Mjc1YjM5ZjliOWEzYWE0YWEyN2ZiZDdjMy4uMmUwMWFlZTVhYmQ4OGQwZjJjNmE2Zjg1OWY0OTRl ZjI3OTJhNTI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTEyLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIHByb2Nlc3MgYXNzZXJ0 IHdoZW4gbG9hZGluZyBzbGFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE5MDc5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MTgxNDY3NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGlsZSBzb21l IGRpc3BsYXkgdHlwZXMgZG8gbm90IG1ha2UgdG9vIG11Y2ggc2Vuc2Ugb24gcmVwbGFjZWQgZWxl bWVudHMsIEJveDo6aXNJbmxpbmVMZXZlbEJveCBzaG91bGQKKyAgICAgICAgcmV0dXJuIHRydWUg Zm9yIGFsbCBvZiB0aGVtLgorCisgICAgICAgIFRlc3Q6IGZhc3QvaW5saW5lL2lubGluZS1mbGV4 LW9uLXJlcGxhY2VkLWNyYXNoLmh0bWwKKworICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xh eW91dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJveDo6aXNJbmxpbmVMZXZl bEJveCBjb25zdCk6CisKIDIwMjAtMTItMDMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXVtGbG9hdHNdIEZsb2F0QXZvaWRlciBkb2VzIG5vdCBuZWVkIHRv IGtlZXAgYSBwb2ludGVyIHRvIExheW91dDo6Qm94IGFyb3VuZC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwCmluZGV4IDU1NTc2NWUyYjc1NGVkYzZj ZDYwZDU1MDNkYzRhNDlkYzZlY2U2ZDEuLjVkM2QxYTMyMTY4MDFjNTQyNzUzNzEzOTAzNzgxNjdk MzdlZWNlNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xh eW91dEJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0 Qm94LmNwcApAQCAtMzA4LDcgKzMwOCwxMiBAQCBib29sIEJveDo6aXNJbmxpbmVMZXZlbEJveCgp IGNvbnN0CiB7CiAgICAgLy8gSW5saW5lIGxldmVsIGVsZW1lbnRzIGdlbmVyYXRlIGlubGluZSBs ZXZlbCBib3hlcy4KICAgICBhdXRvIGRpc3BsYXkgPSBtX3N0eWxlLmRpc3BsYXkoKTsKLSAgICBy ZXR1cm4gZGlzcGxheSA9PSBEaXNwbGF5VHlwZTo6SW5saW5lIHx8IGlzSW5saW5lQmxvY2tCb3go KSB8fCBpc0lubGluZVRhYmxlQm94KCk7CisgICAgcmV0dXJuIGRpc3BsYXkgPT0gRGlzcGxheVR5 cGU6OklubGluZQorICAgICAgICB8fCBkaXNwbGF5ID09IERpc3BsYXlUeXBlOjpJbmxpbmVGbGV4 CisgICAgICAgIHx8IGRpc3BsYXkgPT0gRGlzcGxheVR5cGU6OldlYktpdElubGluZUZsZXgKKyAg ICAgICAgfHwgZGlzcGxheSA9PSBEaXNwbGF5VHlwZTo6SW5saW5lR3JpZAorICAgICAgICB8fCBp c0lubGluZUJsb2NrQm94KCkKKyAgICAgICAgfHwgaXNJbmxpbmVUYWJsZUJveCgpOwogfQogCiBi b29sIEJveDo6aXNJbmxpbmVCb3goKSBjb25zdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDBhOGE5NjRhMDIxNDQzZTE4Mjlm Zjg4YWRlNjMwNzA3NTBjZDI2ZjYuLjdiODA1Y2IxNWQwMWM0OGQ5N2RhYmMwZjVjNTk5OWI2ODg3 NDZlYWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0xMi0wNCAgWmFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBwcm9jZXNzIGFzc2VydCB3aGVuIGxvYWRp bmcgc2xhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxOTA3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzE4MTQ2NzU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2lubGluZS9pbmxpbmUt ZmxleC1vbi1yZXBsYWNlZC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvaW5saW5lL2lubGluZS1mbGV4LW9uLXJlcGxhY2VkLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAy MDIwLTEyLTAzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bSUZDXSBBZGQgc3VwcG9ydCBmb3IgaW50cnVzaXZlIGZsb2F0cyB3aGVuIGxpbmUgZ2V0cyBz dHJldGNoZWQgdmVydGljYWxseQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUv aW5saW5lLWZsZXgtb24tcmVwbGFjZWQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9pbmxpbmUvaW5saW5lLWZsZXgtb24tcmVwbGFjZWQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmEwY2U0NDdjNDg3ODI0MTA0ZjU2Yjk4YzFkOWMzMzczZmM1OWQzNGUKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtZmxleC1vbi1yZXBs YWNlZC1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitQQVNTIGlmIG5vIGNyYXNo IG9yIEFTU0VSVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUt ZmxleC1vbi1yZXBsYWNlZC1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5s aW5lLWZsZXgtb24tcmVwbGFjZWQtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZGVhZGE3YzM3MjE5 YWQ2ZjdjZTQzMzA5M2ExOTk3MTU1ODIxOWI1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9pbmxpbmUvaW5saW5lLWZsZXgtb24tcmVwbGFjZWQtY3Jhc2guaHRtbApAQCAtMCww ICsxLDYgQEAKK1BBU1MgaWYgbm8gY3Jhc2ggb3IgQVNTRVJUCis8ZGl2PjxpbWcgc3R5bGU9Indp ZHRoOiAxMDBweDsgaGVpZ2h0OiAxMDBweDsgZGlzcGxheTogaW5saW5lLWZsZXg7IGJhY2tncm91 bmQtY29sb3I6IGdyZWVuIj48L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIp CisgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQo=