219065 2020-11-17 20:19:08 -0800 REGRESSION(r269614): [iOS] WebContent crashes when entering Full Screen video with text captions 2020-11-17 22:27:54 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa thorton webkit-bug-importer oldest_to_newest 1708478 0 sabouhallawa 2020-11-17 20:19:08 -0800 Web process crashes with the following backtrace: #0 0x00000001a105fc90 in objc_retain () #1 0x000000018f8392c8 in -[CALayer setContents:] () #2 0x0000000109771598 in WebCore::TextTrackRepresentationCocoa::update() at /Volumes/Data/webkit/OpenSource/Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:133 #3 0x000000010a049aac in WebCore::HTMLMediaElement::updateTextTrackRepresentationImageIfNeeded() at /Volumes/Data/webkit/OpenSource/Source/WebCore/html/HTMLMediaElement.cpp:6260 #4 0x000000010a40c96c in WTF::Function<void (WebCore::Document&)>::operator()(WebCore::Document&) const [inlined] at /Volumes/Data/webkit/OpenSource/WebKitBuild/Release-iphoneos/usr/local/include/wtf/Function.h:83 #5 0x000000010a40c958 in WebCore::Page::forEachDocument(WTF::Function<void (WebCore::Document&)> const&) const at /Volumes/Data/webkit/OpenSource/Source/WebCore/page/Page.cpp:3171 #6 0x000000010a411fb4 in WebCore::Page::doAfterUpdateRendering() at /Volumes/Data/webkit/OpenSource/Source/WebCore/page/Page.cpp:1599 #7 0x000000010a411cb8 in WebCore::Page::updateRendering() at /Volumes/Data/webkit/OpenSource/Source/WebCore/page/Page.cpp:1553 #8 0x00000001045eaaf8 in WebKit::RemoteLayerTreeDrawingArea::updateRendering() at /Volumes/Data/webkit/OpenSource/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:327 #9 0x000000010a4c1f4c in WebCore::ThreadTimers::sharedTimerFiredInternal() at /Volumes/Data/webkit/OpenSource/Source/WebCore/platform/ThreadTimers.cpp:127 #10 0x000000010a4e8a84 in WebCore::timerFired(__CFRunLoopTimer*, void*) at /Volumes/Data/webkit/OpenSource/Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp:74 When introducing the NativeImage class, the following function was left as is: void TextTrackRepresentationCocoa::update() { if (auto representation = m_client.createTextTrackRepresentationImage()) [m_layer.get() setContents:(__bridge id)representation->nativeImage().get()]; } [CALayer setContents] used to take an id of a CGImageRef. With r269614, we are now passing to it a NativeImage casted to an id. 1708479 1 414403 sabouhallawa 2020-11-17 20:23:15 -0800 Created attachment 414403 Patch 1708480 2 sabouhallawa 2020-11-17 20:23:51 -0800 <rdar://problem/71494591> 1708499 3 ews-feeder 2020-11-17 22:27:53 -0800 Committed r269944: <https://trac.webkit.org/changeset/269944> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414403. 414403 2020-11-17 20:23:15 -0800 2020-11-17 22:27:54 -0800 Patch bug-219065-20201117202315.patch text/plain 1772 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMyNDEwNjBjMDY4ZDEz MjY5YTYwMDg1M2U3MGZmZGY1MzRmZDk3Zi4uZjE3NGYyZDkxZGI2ZmMzODY5MThlYTc2MWE0ZTBi ODZhNDZiYjliYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTExLTE3ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI2 OTYxNCk6IFtpT1NdIFdlYkNvbnRlbnQgY3Jhc2hlcyB3aGVuIGVudGVyaW5nIEZ1bGwgU2NyZWVu IHZpZGVvIHdpdGggdGV4dCBjYXB0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUGFzcyBhIENHSW1hZ2VSZWYgb2YgdGhlIHZpZGVvIGNhcHRpb24g dG8gQ0FMYXllciBpbnN0ZWFkIG9mIHBhc3NpbmcgYQorICAgICAgICBOYXRpdmVJbWFnZSB3aGlj aCBpcyBub3cgYSBXZWJDb3JlIGNsYXNzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y29jb2EvVGV4dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2E6OnVwZGF0ZSk6CisKIDIwMjAtMTEtMTcgIEFk cmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkIGJ1aWxkIGZpeCBmb3Igbm9uLXVuaWZpZWQgYnVpbGRzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvVGV4dFRyYWNrUmVwcmVzZW50YXRp b25Db2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1RleHRU cmFja1JlcHJlc2VudGF0aW9uQ29jb2EubW0KaW5kZXggZjJlOWRmMTQ3YzAyYTZkYmUwZjZlOWIy ZDI4NjQ4ZDk3MTQzMDY3YS4uYjk4NzE5MDllYzNlN2E5MjRiNzc3YTRjYTQxYWI0NzhmN2E3Y2Qx NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvVGV4 dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jb2NvYS9UZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hLm1tCkBAIC0xMzAs NyArMTMwLDcgQEAgVGV4dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYTo6flRleHRUcmFja1JlcHJl c2VudGF0aW9uQ29jb2EoKQogdm9pZCBUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hOjp1cGRh dGUoKQogewogICAgIGlmIChhdXRvIHJlcHJlc2VudGF0aW9uID0gbV9jbGllbnQuY3JlYXRlVGV4 dFRyYWNrUmVwcmVzZW50YXRpb25JbWFnZSgpKQotICAgICAgICBbbV9sYXllci5nZXQoKSBzZXRD b250ZW50czooX19icmlkZ2UgaWQpcmVwcmVzZW50YXRpb24tPm5hdGl2ZUltYWdlKCkuZ2V0KCld OworICAgICAgICBbbV9sYXllci5nZXQoKSBzZXRDb250ZW50czooX19icmlkZ2UgaWQpcmVwcmVz ZW50YXRpb24tPm5hdGl2ZUltYWdlKCktPnBsYXRmb3JtSW1hZ2UoKS5nZXQoKV07CiB9CiAKIHZv aWQgVGV4dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYTo6c2V0Q29udGVudFNjYWxlKGZsb2F0IHNj YWxlKQo=