219055 2020-11-17 15:26:44 -0800 [iOS] ASSERTION FAILED: Completion handler should always be called under WebKit::GPUProcess::didReceiveMessage 2020-11-17 17:07:31 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad cdumez achristensen cdumez ggaren simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1708407 0 ryanhaddad 2020-11-17 15:26:44 -0800 I'm seeing > 10 GPUProcess crashes on iOS simulator debug bots with the assertion failure below. Some crashes are attributed to tests, others are showing up in the "Other crashes" section. ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/ios-simulator-14-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/CompletionHandler.h(58) : WTF::CompletionHandler<void ()>::~CompletionHandler() 1 0x123bdfb09 WTFCrash 2 0x111afac97 WTF::CompletionHandler<void ()>::~CompletionHandler() 3 0x111af8235 WTF::CompletionHandler<void ()>::~CompletionHandler() 4 0x112096bde void IPC::handleMessageAsync<Messages::GPUProcess::PrepareToSuspend, WebKit::GPUProcess, void (WebKit::GPUProcess::*)(bool, WTF::CompletionHandler<void ()>&&)>(IPC::Connection&, IPC::Decoder&, WebKit::GPUProcess*, void (WebKit::GPUProcess::*)(bool, WTF::CompletionHandler<void ()>&&)) 5 0x1120963c6 WebKit::GPUProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 6 0x111a2fe6a IPC::Connection::dispatchMessage(IPC::Decoder&) 7 0x111a30fb0 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 8 0x111a31640 IPC::Connection::dispatchOneIncomingMessage() 9 0x111a524e8 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_8::operator()() 10 0x111a523fe WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_8, void>::call() 11 0x123c0b532 WTF::Function<void ()>::operator()() const 12 0x123c89bd5 WTF::RunLoop::performWork() 13 0x123c8e311 WTF::RunLoop::performWork(void*) 14 0x10a55037a __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 15 0x10a550272 __CFRunLoopDoSource0 16 0x10a54f754 __CFRunLoopDoSources0 17 0x10a549f1f __CFRunLoopRun 18 0x10a5496c6 CFRunLoopRunSpecific 19 0x109f377b9 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 20 0x109f379cd -[NSRunLoop(NSRunLoop) run] 21 0x10be64176 _xpc_objc_main 22 0x10be66115 xpc_main 23 0x1123e58b2 WebKit::XPCServiceMain(int, char const**) 24 0x11390872b WKXPCServiceMain 25 0x109d68d52 main 26 0x10bb11409 start 27 0x1 https://build.webkit.org/results/Apple-iOS-14-Simulator-Debug-WK2-Tests/r269914%20(725)/results.html 1708408 1 webkit-bug-importer 2020-11-17 15:28:20 -0800 <rdar://problem/71508223> 1708409 2 ryanhaddad 2020-11-17 15:29:08 -0800 This might be related to https://trac.webkit.org/changeset/269879/webkit 1708410 3 cdumez 2020-11-17 15:29:34 -0800 r269690 did not fix this? 1708411 4 cdumez 2020-11-17 15:30:26 -0800 I will investigate shortly. Just surprised because we had those crashes before and I had landed r269690 for it. 1708413 5 cdumez 2020-11-17 15:32:06 -0800 Oh, it is an easy fix. GPUProcess::prepareToSuspend() fails to call its completion handler. 1708425 6 414393 cdumez 2020-11-17 16:05:39 -0800 Created attachment 414393 Patch 1708433 7 414393 cdumez 2020-11-17 16:42:35 -0800 Comment on attachment 414393 Patch Clearing flags on attachment: 414393 Committed r269935: <https://trac.webkit.org/changeset/269935> 1708434 8 cdumez 2020-11-17 16:42:37 -0800 All reviewed patches have been landed. Closing bug. 414393 2020-11-17 16:05:39 -0800 2020-11-17 17:07:31 -0800 Patch bug-219055-20201117160538.patch text/plain 1581 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA0MDYwODVmYTllNDIwMmMx ZmE1ODJjYjE0ZTNiNjU0OTI1ZDk2OTcuLjA4NDlmMTYwMWVjNDcwMzI0ZjYxNzI4MDNmZTY4MzY4 ZGZhMTYwNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMTEtMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBU1NFUlRJT04gRkFJTEVE OiBDb21wbGV0aW9uIGhhbmRsZXIgc2hvdWxkIGFsd2F5cyBiZSBjYWxsZWQgdW5kZXIgV2ViS2l0 OjpHUFVQcm9jZXNzOjpkaWRSZWNlaXZlTWVzc2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MDU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 MTUwODIyMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNYWtlIHN1cmUgR1BVUHJvY2Vzczo6cHJlcGFyZVRvU3VzcGVuZCgpIGNhbGxzIGl0cyBjb21w bGV0aW9uIGhhbmRsZXIgdG8gYXZvaWQgZGVsYXlpbmcgc3VzcGVuc2lvbgorICAgICAgICBhbmQg YXZvaWQgYXNzZXJ0aW9uIGhpdHMgaW4gZGVidWcuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL0dQ VVByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpHUFVQcm9jZXNzOjpwcmVwYXJlVG9TdXNw ZW5kKToKKwogMjAyMC0xMS0xNyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW21hY09TXSBJc3N1ZSBzYW5kYm94IGV4dGVuc2lvbiB0byB0cnVzdCBzZXJ2 aWNlIGlmIE1lZGlhIGluIHRoZSBHUFUgcHJvY2VzcyBpcyBub3QgZW5hYmxlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktp dC9HUFVQcm9jZXNzL0dQVVByb2Nlc3MuY3BwCmluZGV4IGZkNTU0Yjg0OGM5NmUyN2QzZWMwY2I1 YWNmNmVmNzJhMTg5NTQ5MjkuLjQzN2Q5ODM2ZDE1NGM4ZTA4NzIwZDYxNGQ2ZjZhN2ZmMDQyZTFi YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5jcHAKQEAgLTE2Myw2ICsx NjMsNyBAQCB2b2lkIEdQVVByb2Nlc3M6OnByZXBhcmVUb1N1c3BlbmQoYm9vbCBpc1N1c3BlbnNp b25JbW1pbmVudCwgQ29tcGxldGlvbkhhbmRsZXI8dgogICAgIFJFTEVBU0VfTE9HKFByb2Nlc3NT dXNwZW5zaW9uLCAiJXAgLSBHUFVQcm9jZXNzOjpwcmVwYXJlVG9TdXNwZW5kKCksIGlzU3VzcGVu c2lvbkltbWluZW50OiAlZCIsIHRoaXMsIGlzU3VzcGVuc2lvbkltbWluZW50KTsKIAogICAgIGxv d01lbW9yeUhhbmRsZXIoQ3JpdGljYWw6Olllcyk7CisgICAgY29tcGxldGlvbkhhbmRsZXIoKTsK IH0KIAogdm9pZCBHUFVQcm9jZXNzOjpwcm9jZXNzRGlkUmVzdW1lKCkK