219053 2020-11-17 14:37:50 -0800 Make sure ProcessThrottler is always holding a ProcessAssertion for its child process 2020-11-17 16:37:20 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ggaren webkit-bug-importer oldest_to_newest 1708393 0 cdumez 2020-11-17 14:37:50 -0800 Make sure ProcessThrottler is always holding a ProcessAssertion for its child process. Previously, when changing the assertion type (e.g. when going from background to foreground) we would release the previous assertion and then take the new one. RunningBoard developers recommend that we wait until the new ProcessAssertion is taken before we release the previous one to avoid churn. It is also important we always hold a ProcessAssertion at all times for the child process because the child process may exit otherwise. 1708394 1 414386 cdumez 2020-11-17 14:39:18 -0800 Created attachment 414386 Patch 1708399 2 414386 ggaren 2020-11-17 14:58:25 -0800 Comment on attachment 414386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414386&action=review r=me > Source/WebKit/UIProcess/ProcessThrottler.cpp:132 > + // Keep the previous assertion around until after the new one has been created so that we always have > + // hold a process assertion for the process. have hold => hold 1708400 3 414388 cdumez 2020-11-17 15:00:53 -0800 Created attachment 414388 Patch 1708430 4 ews-feeder 2020-11-17 16:36:33 -0800 Committed r269934: <https://trac.webkit.org/changeset/269934> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414388. 1708431 5 webkit-bug-importer 2020-11-17 16:37:20 -0800 <rdar://problem/71512123> 414386 2020-11-17 14:39:18 -0800 2020-11-17 15:00:52 -0800 Patch bug-219053-20201117143918.patch text/plain 2405 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA0MDYwODVmYTllNDIwMmMx ZmE1ODJjYjE0ZTNiNjU0OTI1ZDk2OTcuLmE0ZWU5MGM1Y2UzMjZiMjhkNDRkNGRlODk3MGQ3OWNj MDU3MGIzZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMTEtMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHN1cmUgUHJvY2Vzc1Rocm90 dGxlciBpcyBhbHdheXMgaG9sZGluZyBhIFByb2Nlc3NBc3NlcnRpb24gZm9yIGl0cyBjaGlsZCBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTkwNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YWtlIHN1cmUgUHJvY2Vzc1Rocm90dGxlciBpcyBhbHdheXMgaG9sZGluZyBhIFByb2Nlc3NBc3Nl cnRpb24gZm9yIGl0cyBjaGlsZCBwcm9jZXNzLiBQcmV2aW91c2x5LCB3aGVuIGNoYW5naW5nIHRo ZSBhc3NlcnRpb24KKyAgICAgICAgdHlwZSAoZS5nLiB3aGVuIGdvaW5nIGZyb20gYmFja2dyb3Vu ZCB0byBmb3JlZ3JvdW5kKSB3ZSB3b3VsZCByZWxlYXNlIHRoZSBwcmV2aW91cyBhc3NlcnRpb24g YW5kIHRoZW4gdGFrZSB0aGUgbmV3IG9uZS4KKworICAgICAgICBSdW5uaW5nQm9hcmQgZGV2ZWxv cGVycyByZWNvbW1lbmQgdGhhdCB3ZSB3YWl0IHVudGlsIHRoZSBuZXcgUHJvY2Vzc0Fzc2VydGlv biBpcyB0YWtlbiBiZWZvcmUgd2UgcmVsZWFzZSB0aGUgcHJldmlvdXMgb25lIHRvCisgICAgICAg IGF2b2lkIGNodXJuLiBJdCBpcyBhbHNvIGltcG9ydGFudCB3ZSBhbHdheXMgaG9sZCBhIFByb2Nl c3NBc3NlcnRpb24gYXQgYWxsIHRpbWVzIGZvciB0aGUgY2hpbGQgcHJvY2VzcyBiZWNhdXNlIHRo ZSBjaGlsZCBwcm9jZXNzCisgICAgICAgIG1heSBleGl0IG90aGVyd2lzZS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9Qcm9jZXNzVGhyb3R0bGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vz c1Rocm90dGxlcjo6c2V0QXNzZXJ0aW9uVHlwZSk6CisKIDIwMjAtMTEtMTcgIFBlciBBcm5lIFZv bGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gSXNzdWUgc2FuZGJv eCBleHRlbnNpb24gdG8gdHJ1c3Qgc2VydmljZSBpZiBNZWRpYSBpbiB0aGUgR1BVIHByb2Nlc3Mg aXMgbm90IGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Byb2Nl c3NUaHJvdHRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc1Rocm90dGxl ci5jcHAKaW5kZXggYjM5Njk3NGVjMmVmZDQ1YWJmZTc2MzliNWY1ZmIzZTkyYzM1YzkyNS4uZTBj MTBkODRmZGNiM2IwMDU3YmU2YmRhM2VmNTVlMTlmZTYwZmIyZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc1Rocm90dGxlci5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvUHJvY2Vzc1Rocm90dGxlci5jcHAKQEAgLTEyNyw2ICsxMjcsMTAgQEAgdm9p ZCBQcm9jZXNzVGhyb3R0bGVyOjpzZXRBc3NlcnRpb25UeXBlKFByb2Nlc3NBc3NlcnRpb25UeXBl IG5ld1R5cGUpCiAgICAgICAgIHJldHVybjsKIAogICAgIFBST0NFU1NUSFJPVFRMRVJfUkVMRUFT RV9MT0coInNldEFzc2VydGlvblR5cGU6IFVwZGF0aW5nIHByb2Nlc3MgYXNzZXJ0aW9uIHR5cGUg dG8gJXUgKGZvcmVncm91bmRBY3Rpdml0aWVzOiAldSwgYmFja2dyb3VuZEFjdGl2aXRpZXM6ICV1 KSIsIG5ld1R5cGUsIG1fZm9yZWdyb3VuZEFjdGl2aXRpZXMuc2l6ZSgpLCBtX2JhY2tncm91bmRB Y3Rpdml0aWVzLnNpemUoKSk7CisKKyAgICAvLyBLZWVwIHRoZSBwcmV2aW91cyBhc3NlcnRpb24g YXJvdW5kIHVudGlsIGFmdGVyIHRoZSBuZXcgb25lIGhhcyBiZWVuIGNyZWF0ZWQgc28gdGhhdCB3 ZSBhbHdheXMgaGF2ZQorICAgIC8vIGhvbGQgYSBwcm9jZXNzIGFzc2VydGlvbiBmb3IgdGhlIHBy b2Nlc3MuCisgICAgYXV0byBwcmV2aW91c0Fzc2VydGlvbiA9IHN0ZDo6ZXhjaGFuZ2UobV9hc3Nl cnRpb24sIG51bGxwdHIpOwogICAgIGlmIChtX3Nob3VsZFRha2VVSUJhY2tncm91bmRBc3NlcnRp b24pIHsKICAgICAgICAgYXV0byBhc3NlcnRpb24gPSBtYWtlVW5pcXVlPFByb2Nlc3NBbmRVSUFz c2VydGlvbj4obV9wcm9jZXNzSWRlbnRpZmllciwgYXNzZXJ0aW9uTmFtZShuZXdUeXBlKSwgbmV3 VHlwZSk7CiAgICAgICAgIGFzc2VydGlvbi0+c2V0VUlBc3NlcnRpb25FeHBpcmF0aW9uSGFuZGxl cihbdGhpc10gewo= 414388 2020-11-17 15:00:53 -0800 2020-11-17 16:36:34 -0800 Patch bug-219053-20201117150052.patch text/plain 2397 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA0MDYwODVmYTllNDIwMmMx ZmE1ODJjYjE0ZTNiNjU0OTI1ZDk2OTcuLjZiMGE5NjE5OWNkYTI2MjA2NWI3YzhlZDYwOWI3MWI2 OWFkYmU4NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMTEtMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHN1cmUgUHJvY2Vzc1Rocm90 dGxlciBpcyBhbHdheXMgaG9sZGluZyBhIFByb2Nlc3NBc3NlcnRpb24gZm9yIGl0cyBjaGlsZCBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTkwNTMKKworICAgICAgICBSZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4KKworICAgICAgICBNYWtl IHN1cmUgUHJvY2Vzc1Rocm90dGxlciBpcyBhbHdheXMgaG9sZGluZyBhIFByb2Nlc3NBc3NlcnRp b24gZm9yIGl0cyBjaGlsZCBwcm9jZXNzLiBQcmV2aW91c2x5LCB3aGVuIGNoYW5naW5nIHRoZSBh c3NlcnRpb24KKyAgICAgICAgdHlwZSAoZS5nLiB3aGVuIGdvaW5nIGZyb20gYmFja2dyb3VuZCB0 byBmb3JlZ3JvdW5kKSB3ZSB3b3VsZCByZWxlYXNlIHRoZSBwcmV2aW91cyBhc3NlcnRpb24gYW5k IHRoZW4gdGFrZSB0aGUgbmV3IG9uZS4KKworICAgICAgICBSdW5uaW5nQm9hcmQgZGV2ZWxvcGVy cyByZWNvbW1lbmQgdGhhdCB3ZSB3YWl0IHVudGlsIHRoZSBuZXcgUHJvY2Vzc0Fzc2VydGlvbiBp cyB0YWtlbiBiZWZvcmUgd2UgcmVsZWFzZSB0aGUgcHJldmlvdXMgb25lIHRvCisgICAgICAgIGF2 b2lkIGNodXJuLiBJdCBpcyBhbHNvIGltcG9ydGFudCB3ZSBhbHdheXMgaG9sZCBhIFByb2Nlc3NB c3NlcnRpb24gYXQgYWxsIHRpbWVzIGZvciB0aGUgY2hpbGQgcHJvY2VzcyBiZWNhdXNlIHRoZSBj aGlsZCBwcm9jZXNzCisgICAgICAgIG1heSBleGl0IG90aGVyd2lzZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9Qcm9jZXNzVGhyb3R0bGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc1Ro cm90dGxlcjo6c2V0QXNzZXJ0aW9uVHlwZSk6CisKIDIwMjAtMTEtMTcgIFBlciBBcm5lIFZvbGxh biAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gSXNzdWUgc2FuZGJveCBl eHRlbnNpb24gdG8gdHJ1c3Qgc2VydmljZSBpZiBNZWRpYSBpbiB0aGUgR1BVIHByb2Nlc3MgaXMg bm90IGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Byb2Nlc3NU aHJvdHRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc1Rocm90dGxlci5j cHAKaW5kZXggYjM5Njk3NGVjMmVmZDQ1YWJmZTc2MzliNWY1ZmIzZTkyYzM1YzkyNS4uMjBjZjc1 ZjlhYjlhZDBjMDlkOTVmOWFkMGFkYTcyYTcxODhjMmIzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvUHJvY2Vzc1Rocm90dGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvUHJvY2Vzc1Rocm90dGxlci5jcHAKQEAgLTEyNyw2ICsxMjcsMTAgQEAgdm9pZCBQ cm9jZXNzVGhyb3R0bGVyOjpzZXRBc3NlcnRpb25UeXBlKFByb2Nlc3NBc3NlcnRpb25UeXBlIG5l d1R5cGUpCiAgICAgICAgIHJldHVybjsKIAogICAgIFBST0NFU1NUSFJPVFRMRVJfUkVMRUFTRV9M T0coInNldEFzc2VydGlvblR5cGU6IFVwZGF0aW5nIHByb2Nlc3MgYXNzZXJ0aW9uIHR5cGUgdG8g JXUgKGZvcmVncm91bmRBY3Rpdml0aWVzOiAldSwgYmFja2dyb3VuZEFjdGl2aXRpZXM6ICV1KSIs IG5ld1R5cGUsIG1fZm9yZWdyb3VuZEFjdGl2aXRpZXMuc2l6ZSgpLCBtX2JhY2tncm91bmRBY3Rp dml0aWVzLnNpemUoKSk7CisKKyAgICAvLyBLZWVwIHRoZSBwcmV2aW91cyBhc3NlcnRpb24gYXJv dW5kIHVudGlsIGFmdGVyIHRoZSBuZXcgb25lIGhhcyBiZWVuIGNyZWF0ZWQgc28gdGhhdCB3ZSBh bHdheXMgaG9sZAorICAgIC8vIGEgcHJvY2VzcyBhc3NlcnRpb24gZm9yIHRoZSBwcm9jZXNzLgor ICAgIGF1dG8gcHJldmlvdXNBc3NlcnRpb24gPSBzdGQ6OmV4Y2hhbmdlKG1fYXNzZXJ0aW9uLCBu dWxscHRyKTsKICAgICBpZiAobV9zaG91bGRUYWtlVUlCYWNrZ3JvdW5kQXNzZXJ0aW9uKSB7CiAg ICAgICAgIGF1dG8gYXNzZXJ0aW9uID0gbWFrZVVuaXF1ZTxQcm9jZXNzQW5kVUlBc3NlcnRpb24+ KG1fcHJvY2Vzc0lkZW50aWZpZXIsIGFzc2VydGlvbk5hbWUobmV3VHlwZSksIG5ld1R5cGUpOwog ICAgICAgICBhc3NlcnRpb24tPnNldFVJQXNzZXJ0aW9uRXhwaXJhdGlvbkhhbmRsZXIoW3RoaXNd IHsK