219052 2020-11-17 13:56:33 -0800 [macOS] Stop using RunLoopType=_WebKit starting in Big Sur 2020-11-17 15:56:57 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ggaren pvollan thorton webkit-bug-importer oldest_to_newest 1708373 0 cdumez 2020-11-17 13:56:33 -0800 Stop using RunLoopType=_WebKit starting in Big Sur. This was a temporary hack so that our WebProcesses would get the right scheduling priority. Starting with Big Sur, the right way to do this is to use _ProcessType=App and restore the RunLoopType to be NSRunLoop. 1708374 1 cdumez 2020-11-17 13:56:44 -0800 <rdar://problem/61742969> 1708375 2 414383 cdumez 2020-11-17 13:58:30 -0800 Created attachment 414383 Patch 1708380 3 ggaren 2020-11-17 14:10:21 -0800 It looks like r233932 was about app nap / tab nap. With this change, do tabs still nap / suspend properly? 1708383 4 ggaren 2020-11-17 14:20:38 -0800 I have a vague memory that we made a sandboxing change that was incompatible with the App process type or the NSRunLoop runloop type. Maybe Per Arne remembers? 1708384 5 cdumez 2020-11-17 14:22:02 -0800 (In reply to Geoffrey Garen from comment #4) > I have a vague memory that we made a sandboxing change that was incompatible > with the App process type or the NSRunLoop runloop type. Maybe Per Arne > remembers? I will verify AppNap shortly. I don't foresee any issue. 1708385 6 cdumez 2020-11-17 14:24:10 -0800 (In reply to Geoffrey Garen from comment #4) > I have a vague memory that we made a sandboxing change that was incompatible > with the App process type or the NSRunLoop runloop type. Maybe Per Arne > remembers? The sandboxing change made it so that we could not use _NSApplicationMain RunLoopType anymore. We initially tried to use NSRunLoop RunLoopType instead but it broke AppNap. This is when the _WebKit RunLoopType was introduced to unbreak AppNap. I am being told that we can now revert to NSRunLoop RunLoopType as long as we use "App" as _ProcessType (See radar). 1708388 7 414385 cdumez 2020-11-17 14:30:22 -0800 Created attachment 414385 Patch 1708389 8 414385 cdumez 2020-11-17 14:30:46 -0800 Comment on attachment 414385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414385&action=review > Source/WebKit/ChangeLog:13 > + After this change, I have verified that the WebContent's main thread still runs at UserInteractive QoS. App Nap is also I have verified that AppNap is still working fine with this patch. 1708391 9 414385 ggaren 2020-11-17 14:31:32 -0800 Comment on attachment 414385 Patch r=me OK, I think that addresses all my vague memories :P 1708412 10 ews-feeder 2020-11-17 15:30:31 -0800 Committed r269928: <https://trac.webkit.org/changeset/269928> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414385. 1708420 11 pvollan 2020-11-17 15:56:57 -0800 (In reply to Geoffrey Garen from comment #4) > I have a vague memory that we made a sandboxing change that was incompatible > with the App process type or the NSRunLoop runloop type. Maybe Per Arne > remembers? If I recall correctly, we stopped using the NSApplication runloop when blocking the WindowServer. As Chris noted, this introduced a process priority regression, which was fixed by using this custom runloop type. It was possibly also needed to fix the AppNap regression, but Chris seems to have that covered :) 414383 2020-11-17 13:58:30 -0800 2020-11-17 14:30:20 -0800 Patch bug-219052-20201117135829.patch text/plain 2994 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdiNzc2MzU5NDExNTc2Nzhi YTIxNjhjNTI0NzBlY2I4ZGQ1OGUwMDkuLmRhMDBhZmQ0ZTA3ZTg5OGQ2NjZkMGZjYzliZTU5NmIw ZmYyNWExYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMTEtMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFN0b3AgdXNpbmcgUnVu TG9vcFR5cGU9X1dlYktpdCBzdGFydGluZyBpbiBCaWcgU3VyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkwNTIKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzYxNzQyOTY5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFN0b3AgdXNpbmcgUnVuTG9vcFR5cGU9X1dlYktpdCBzdGFydGluZyBpbiBCaWcgU3Vy LiBUaGlzIHdhcyBhIHRlbXBvcmFyeSBoYWNrIHNvIHRoYXQgb3VyIFdlYlByb2Nlc3NlcyB3b3Vs ZCBnZXQgdGhlIHJpZ2h0CisgICAgICAgIHNjaGVkdWxpbmcgcHJpb3JpdHkuIFN0YXJ0aW5nIHdp dGggQmlnIFN1ciwgdGhlIHJpZ2h0IHdheSB0byBkbyB0aGlzIGlzIHRvIHVzZSBfUHJvY2Vzc1R5 cGU9QXBwIGFuZCByZXN0b3JlIHRoZSBSdW5Mb29wVHlwZQorICAgICAgICB0byBiZSBOU1J1bkxv b3AuCisKKyAgICAgICAgQWZ0ZXIgdGhpcyBjaGFuZ2UsIEkgaGF2ZSB2ZXJpZmllZCB0aGF0IHRo ZSBXZWJDb250ZW50J3MgbWFpbiB0aHJlYWQgc3RpbGwgcnVucyBhdCBVc2VySW50ZXJhY3RpdmUg UW9TLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNlcnZpY2UueGNjb25m aWc6CisgICAgICAgICogV2ViUHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvV2Vi Q29udGVudFNlcnZpY2UvSW5mby1PU1gucGxpc3Q6CisKIDIwMjAtMTEtMTcgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBTdG9wIGxlYWtpbmcgYW4gWFBD IHRyYW5zYWN0aW9uIGluIG91ciBYUEMgc2VydmljZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvQ29uZmlndXJhdGlvbnMvV2ViQ29udGVudFNlcnZpY2UueGNjb25maWcgYi9Tb3VyY2UvV2Vi S2l0L0NvbmZpZ3VyYXRpb25zL1dlYkNvbnRlbnRTZXJ2aWNlLnhjY29uZmlnCmluZGV4IGY4ZjNl ZTFkNTJjMmFiMWY3OGY0YmMyYWQ5MTY0NTVhYmEwZWJmODUuLjc0ZmU2NDQ5NTkwNTAzN2U4MWM2 OTRiNzViZjU0MTk0MWI4NjlhMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJh dGlvbnMvV2ViQ29udGVudFNlcnZpY2UueGNjb25maWcKKysrIGIvU291cmNlL1dlYktpdC9Db25m aWd1cmF0aW9ucy9XZWJDb250ZW50U2VydmljZS54Y2NvbmZpZwpAQCAtNDcsOSArNDcsOSBAQCBX S19XRUJDT05URU5UX1NFUlZJQ0VfTkVFRFNfVkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIX0xERkxB R18gPSAkKFdLX1dFQkNPTlRFTlRfUwogV0tfV0VCQ09OVEVOVF9TRVJWSUNFX05FRURTX1ZFUlNJ T05FRF9GUkFNRVdPUktfUEFUSF9MREZMQUdfTk8gPSAkKFdLX1dFQkNPTlRFTlRfU0VSVklDRV9O RUVEU19WRVJTSU9ORURfRlJBTUVXT1JLX1BBVEhfTERGTEFHKTsKIFdLX1dFQkNPTlRFTlRfU0VS VklDRV9ORUVEU19WRVJTSU9ORURfRlJBTUVXT1JLX1BBVEhfTERGTEFHX1lFUyA9ICQoVVNFX1NU QUdJTkdfSU5TVEFMTF9QQVRIKTsKIAotUlVOTE9PUF9UWVBFID0gJChSVU5MT09QX1RZUEUkKFdL X01BQ09TXzEwMTQpKTsKLVJVTkxPT1BfVFlQRV9NQUNPU19CRUZPUkVfMTAxNCA9IF9OU0FwcGxp Y2F0aW9uTWFpbjsKLVJVTkxPT1BfVFlQRV9NQUNPU19TSU5DRV8xMDE0ID0gX1dlYktpdDsKK1JV TkxPT1BfVFlQRSA9ICQoUlVOTE9PUF9UWVBFJChXS19NQUNPU18xMDE2KSk7CitSVU5MT09QX1RZ UEVfTUFDT1NfQkVGT1JFXzEwMTYgPSBfV2ViS2l0OworUlVOTE9PUF9UWVBFX01BQ09TX1NJTkNF XzEwMTYgPSBOU1J1bkxvb3A7CiAKIEVOVElUTEVNRU5UU19SRVFVSVJFRCA9ICQoRU5USVRMRU1F TlRTX1JFUVVJUkVEX1VTRV9JTlRFUk5BTF9TREtfJChVU0VfSU5URVJOQUxfU0RLKSkKIEVOVElU TEVNRU5UU19SRVFVSVJFRF9VU0VfSU5URVJOQUxfU0RLXyA9IE5POwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvQ29jb2EvWFBDU2VydmljZS9XZWJDb250 ZW50U2VydmljZS9JbmZvLU9TWC5wbGlzdCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9FbnRy eVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvV2ViQ29udGVudFNlcnZpY2UvSW5mby1PU1gucGxpc3QK aW5kZXggM2FkZjA5ODYwNDY0NmFhNzE4ZmM5MWNmNzJlMmE5Njk5YjcyOTQ3My4uYzlmMTc3MWJj NzUxMTJhMTZiMDljMzViYTQ3NjUyY2Y4Y2Y4YWU0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvQ29jb2EvWFBDU2VydmljZS9XZWJDb250ZW50U2Vydmlj ZS9JbmZvLU9TWC5wbGlzdAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvRW50cnlQb2lu dC9Db2NvYS9YUENTZXJ2aWNlL1dlYkNvbnRlbnRTZXJ2aWNlL0luZm8tT1NYLnBsaXN0CkBAIC00 Niw2ICs0Niw4IEBACiAJCTxzdHJpbmc+QXBwbGljYXRpb248L3N0cmluZz4KIAkJPGtleT5SdW5M b29wVHlwZTwva2V5PgogCQk8c3RyaW5nPiR7UlVOTE9PUF9UWVBFfTwvc3RyaW5nPgorICAgICAg ICAgICAgICAgIDxrZXk+X1Byb2Nlc3NUeXBlPC9rZXk+CisgICAgICAgICAgICAgICAgPHN0cmlu Zz5BcHA8L3N0cmluZz4KIAkJPGtleT5fTXVsdGlwbGVJbnN0YW5jZXM8L2tleT4KIAkJPHRydWUv PgogCQk8a2V5Pl9IaWdoQml0c0FTTFI8L2tleT4K 414385 2020-11-17 14:30:22 -0800 2020-11-17 15:30:31 -0800 Patch bug-219052-20201117143021.patch text/plain 3046 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdiNzc2MzU5NDExNTc2Nzhi YTIxNjhjNTI0NzBlY2I4ZGQ1OGUwMDkuLjEyYWNmY2NiOTc1Y2MxNDM5NDhjZDk4MzAwYTUzNzcz MDQ0ZmEwNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMTEtMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFN0b3AgdXNpbmcgUnVu TG9vcFR5cGU9X1dlYktpdCBzdGFydGluZyBpbiBCaWcgU3VyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTkwNTIKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzYxNzQyOTY5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFN0b3AgdXNpbmcgUnVuTG9vcFR5cGU9X1dlYktpdCBzdGFydGluZyBpbiBCaWcgU3Vy LiBUaGlzIHdhcyBhIHRlbXBvcmFyeSBoYWNrIHNvIHRoYXQgb3VyIFdlYlByb2Nlc3NlcyB3b3Vs ZCBnZXQgdGhlIHJpZ2h0CisgICAgICAgIHNjaGVkdWxpbmcgcHJpb3JpdHkuIFN0YXJ0aW5nIHdp dGggQmlnIFN1ciwgdGhlIHJpZ2h0IHdheSB0byBkbyB0aGlzIGlzIHRvIHVzZSBfUHJvY2Vzc1R5 cGU9QXBwIGFuZCByZXN0b3JlIHRoZSBSdW5Mb29wVHlwZQorICAgICAgICB0byBiZSBOU1J1bkxv b3AuCisKKyAgICAgICAgQWZ0ZXIgdGhpcyBjaGFuZ2UsIEkgaGF2ZSB2ZXJpZmllZCB0aGF0IHRo ZSBXZWJDb250ZW50J3MgbWFpbiB0aHJlYWQgc3RpbGwgcnVucyBhdCBVc2VySW50ZXJhY3RpdmUg UW9TLiBBcHAgTmFwIGlzIGFsc28KKyAgICAgICAgc3RpbGwgd29ya2luZyBhcyBleHBlY3RlZC4K KworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1dlYkNvbnRlbnRTZXJ2aWNlLnhjY29uZmlnOgor ICAgICAgICAqIFdlYlByb2Nlc3MvRW50cnlQb2ludC9Db2NvYS9YUENTZXJ2aWNlL1dlYkNvbnRl bnRTZXJ2aWNlL0luZm8tT1NYLnBsaXN0OgorCiAyMDIwLTExLTE3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gU3RvcCBsZWFraW5nIGFuIFhQQyB0cmFu c2FjdGlvbiBpbiBvdXIgWFBDIHNlcnZpY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0Nv bmZpZ3VyYXRpb25zL1dlYkNvbnRlbnRTZXJ2aWNlLnhjY29uZmlnIGIvU291cmNlL1dlYktpdC9D b25maWd1cmF0aW9ucy9XZWJDb250ZW50U2VydmljZS54Y2NvbmZpZwppbmRleCBmOGYzZWUxZDUy YzJhYjFmNzhmNGJjMmFkOTE2NDU1YWJhMGViZjg1Li43NGZlNjQ0OTU5MDUwMzdlODFjNjk0Yjc1 YmY1NDE5NDFiODY5YTE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25z L1dlYkNvbnRlbnRTZXJ2aWNlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJh dGlvbnMvV2ViQ29udGVudFNlcnZpY2UueGNjb25maWcKQEAgLTQ3LDkgKzQ3LDkgQEAgV0tfV0VC Q09OVEVOVF9TRVJWSUNFX05FRURTX1ZFUlNJT05FRF9GUkFNRVdPUktfUEFUSF9MREZMQUdfID0g JChXS19XRUJDT05URU5UX1MKIFdLX1dFQkNPTlRFTlRfU0VSVklDRV9ORUVEU19WRVJTSU9ORURf RlJBTUVXT1JLX1BBVEhfTERGTEFHX05PID0gJChXS19XRUJDT05URU5UX1NFUlZJQ0VfTkVFRFNf VkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIX0xERkxBRyk7CiBXS19XRUJDT05URU5UX1NFUlZJQ0Vf TkVFRFNfVkVSU0lPTkVEX0ZSQU1FV09SS19QQVRIX0xERkxBR19ZRVMgPSAkKFVTRV9TVEFHSU5H X0lOU1RBTExfUEFUSCk7CiAKLVJVTkxPT1BfVFlQRSA9ICQoUlVOTE9PUF9UWVBFJChXS19NQUNP U18xMDE0KSk7Ci1SVU5MT09QX1RZUEVfTUFDT1NfQkVGT1JFXzEwMTQgPSBfTlNBcHBsaWNhdGlv bk1haW47Ci1SVU5MT09QX1RZUEVfTUFDT1NfU0lOQ0VfMTAxNCA9IF9XZWJLaXQ7CitSVU5MT09Q X1RZUEUgPSAkKFJVTkxPT1BfVFlQRSQoV0tfTUFDT1NfMTAxNikpOworUlVOTE9PUF9UWVBFX01B Q09TX0JFRk9SRV8xMDE2ID0gX1dlYktpdDsKK1JVTkxPT1BfVFlQRV9NQUNPU19TSU5DRV8xMDE2 ID0gTlNSdW5Mb29wOwogCiBFTlRJVExFTUVOVFNfUkVRVUlSRUQgPSAkKEVOVElUTEVNRU5UU19S RVFVSVJFRF9VU0VfSU5URVJOQUxfU0RLXyQoVVNFX0lOVEVSTkFMX1NESykpCiBFTlRJVExFTUVO VFNfUkVRVUlSRURfVVNFX0lOVEVSTkFMX1NES18gPSBOTzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvV2ViQ29udGVudFNl cnZpY2UvSW5mby1PU1gucGxpc3QgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvRW50cnlQb2lu dC9Db2NvYS9YUENTZXJ2aWNlL1dlYkNvbnRlbnRTZXJ2aWNlL0luZm8tT1NYLnBsaXN0CmluZGV4 IDNhZGYwOTg2MDQ2NDZhYTcxOGZjOTFjZjcyZTJhOTY5OWI3Mjk0NzMuLmM5ZjE3NzFiYzc1MTEy YTE2YjA5YzM1YmE0NzY1MmNmOGNmOGFlNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9FbnRyeVBvaW50L0NvY29hL1hQQ1NlcnZpY2UvV2ViQ29udGVudFNlcnZpY2UvSW5m by1PU1gucGxpc3QKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0VudHJ5UG9pbnQvQ29j b2EvWFBDU2VydmljZS9XZWJDb250ZW50U2VydmljZS9JbmZvLU9TWC5wbGlzdApAQCAtNDYsNiAr NDYsOCBAQAogCQk8c3RyaW5nPkFwcGxpY2F0aW9uPC9zdHJpbmc+CiAJCTxrZXk+UnVuTG9vcFR5 cGU8L2tleT4KIAkJPHN0cmluZz4ke1JVTkxPT1BfVFlQRX08L3N0cmluZz4KKyAgICAgICAgICAg ICAgICA8a2V5Pl9Qcm9jZXNzVHlwZTwva2V5PgorICAgICAgICAgICAgICAgIDxzdHJpbmc+QXBw PC9zdHJpbmc+CiAJCTxrZXk+X011bHRpcGxlSW5zdGFuY2VzPC9rZXk+CiAJCTx0cnVlLz4KIAkJ PGtleT5fSGlnaEJpdHNBU0xSPC9rZXk+Cg==