219043 2020-11-17 11:32:17 -0800 [CMake] generate_offset_extractor.rb missing build dependency for llint/WebAssembly.asm 2020-11-17 16:07:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen don.olmstead ews-watchlist gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff ryuan.choi saam sergio tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1708311 0 mcatanzaro 2020-11-17 11:32:17 -0800 Trying to guess why EWS is failing in bug #210302, I noticed that generate_offset_extractor.rb is missing a build dependency for llint/WebAssembly.asm. Sadly, this doesn't explain the build failure in that bug, because that patch modifies several other files that should cause this script to run. But let's fix it anyway. 1708317 1 mcatanzaro 2020-11-17 11:38:17 -0800 My working dir is pretty dirty right now. The fix I will upload when ready is: diff --git a/Source/JavaScriptCore/CMakeLists.txt b/Source/JavaScriptCore/CMakeLists.txt index 38ae6ce11a89..82311f380df2 100644 --- a/Source/JavaScriptCore/CMakeLists.txt +++ b/Source/JavaScriptCore/CMakeLists.txt @@ -192,6 +192,7 @@ set(LLINT_ASM llint/LowLevelInterpreter.asm llint/LowLevelInterpreter32_64.asm llint/LowLevelInterpreter64.asm + llint/WebAssembly.asm ) set(OFFLINE_ASM 1708415 2 414392 mcatanzaro 2020-11-17 15:34:45 -0800 Created attachment 414392 Patch 1708424 3 ews-feeder 2020-11-17 16:04:39 -0800 Committed r269933: <https://trac.webkit.org/changeset/269933> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414392. 1708426 4 webkit-bug-importer 2020-11-17 16:07:53 -0800 <rdar://problem/71510500> 414392 2020-11-17 15:34:45 -0800 2020-11-17 16:04:40 -0800 Patch bug-219043-20201117173455.patch text/plain 1334 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MWYyMjM3NWQzZDk3MTFmODM5ODlhZjFmZDZjZjNlMmVlMzQ3MGQyLi4yMzBlYjk1NzUwNGFhMTI5 YTgxYmFhNWRlNjNiNDQ3MjY4NTk0OWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0xMS0xNyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBbQ01ha2VdIGdlbmVyYXRlX29mZnNldF9leHRyYWN0b3IucmIg bWlzc2luZyBidWlsZCBkZXBlbmRlbmN5IGZvciBsbGludC9XZWJBc3NlbWJseS5hc20KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTA0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGdlbmVyYXRlX29mZnNl dF9leHRyYWN0b3IucmIgaXMgbWlzc2luZyBhIGJ1aWxkIGRlcGVuZGVuY3kgZm9yIGxsaW50L1dl YkFzc2VtYmx5LmFzbS4gSWYKKyAgICAgICAgV2ViQXNzZW1ibHkuYXNtIGlzIG1vZGlmaWVkLCBn ZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdGVyLnJiIG5lZWRzIHRvIGJlIHJ1biBhZ2Fpbi4KKworICAg ICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDIwLTExLTE3ICBYYW4gTMOzcGV6ICA8eGFuQGln YWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10gQWRkIHN1cHBvcnQgZm9yIHN0YXRpYyBwdWJsaWMg Y2xhc3MgZmllbGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0 cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggMzhhZTZj ZTExYTg5YmIyY2E2NTdjNThjZjgyZDdlNDc1MThhOTk1MS4uODIzMTFmMzgwZGYyMWVlYzM3NmNl ZmYyODI2OTM2ZDE4ODZkNTdkYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NN YWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApA QCAtMTkyLDYgKzE5Miw3IEBAIHNldChMTElOVF9BU00KICAgICBsbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbQogICAgIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KICAgICBs bGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCisgICAgbGxpbnQvV2ViQXNzZW1ibHkuYXNt CiApCiAKIHNldChPRkZMSU5FX0FTTQo=