219002 2020-11-16 13:17:26 -0800 [GPUProcess] Update GPUProcess process assertion based on active WebProcesses 2020-11-16 16:15:39 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin ggaren simon.fraser thorton webkit-bug-importer oldest_to_newest 1707966 0 cdumez 2020-11-16 13:17:26 -0800 Update GPUProcess process assertion based on active WebProcesses, similarly to what we do for the network process. 1707970 1 414274 cdumez 2020-11-16 13:19:36 -0800 Created attachment 414274 Patch 1707990 2 ews-feeder 2020-11-16 14:17:46 -0800 Committed r269879: <https://trac.webkit.org/changeset/269879> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414274. 1707992 3 webkit-bug-importer 2020-11-16 14:18:18 -0800 <rdar://problem/71459123> 1708031 4 414274 darin 2020-11-16 16:15:39 -0800 Comment on attachment 414274 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414274&action=review > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:288 > + // Use std::exchange() instead of a simple nullptr assignment to avoid re-entering this > + // function during the destructor of the ProcessThrottler activity, before setting > + // m_activityFromWebProcesses. > + std::exchange(m_activityFromWebProcesses, nullptr); Could this be fixed by changing the Variant implementation instead? I remember something similar for our smart pointers and we fixed that in the smart pointer class rather than at call sites. 414274 2020-11-16 13:19:36 -0800 2020-11-16 14:17:47 -0800 Patch bug-219002-20201116131936.patch text/plain 2766 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4MmQ4OGY4NGNmNjcxNzRi NzQyNTMzOGU0OWNmZTE0MmMyNDI4YmUuLjE0ZjhlZGM4MGM4MGI1MzExZjM1ODczNjZkZWNlZDNl YTVmY2E3OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMTEtMTYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUHJvY2Vzc10gVXBkYXRlIEdQ VVByb2Nlc3MgcHJvY2VzcyBhc3NlcnRpb24gYmFzZWQgb24gYWN0aXZlIFdlYlByb2Nlc3Nlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MDAyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIEdQ VVByb2Nlc3MgcHJvY2VzcyBhc3NlcnRpb24gYmFzZWQgb24gYWN0aXZlIFdlYlByb2Nlc3Nlcywg c2ltaWxhcmx5IHRvIHdoYXQKKyAgICAgICAgd2UgZG8gZm9yIHRoZSBuZXR3b3JrIHByb2Nlc3Mu IFByZXZpb3VzbHksIHdlIHdvdWxkIG5ldmVyIHJlbGVhc2UgdGhlIEdQVVByb2Nlc3MKKyAgICAg ICAgcHJvY2VzcyBhc3NlcnRpb24gYW5kIGl0IHdvdWxkIHRpbWUgb3V0IGFmdGVyIDMwIHNlY29u ZHMgaW4gdGhlIGJhY2tncm91bmQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvR1BVL0dQVVByb2Nl c3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkdQVVByb2Nlc3NQcm94eTo6dXBkYXRlUHJv Y2Vzc0Fzc2VydGlvbik6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnVwZGF0ZVByb2Nlc3NBc3NlcnRpb25z KToKKwogMjAyMC0xMS0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgV2ViRHJpdmVyOiBkbyBub3QgZm9jdXMgdGhlIG1haW4gZnJhbWUgd2hl biBzd2l0Y2hpbmcgdG8gYSB3aW5kb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0dQVS9HUFVQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BV L0dQVVByb2Nlc3NQcm94eS5jcHAKaW5kZXggMTRkMTk1MThkN2ZkMzg2ZDQyODM5ZjExYjQ0ZDUw NWVlMjMxODkyYS4uMGI2MzY0ODQyYjI3MTUxMDYxMTMxOTJlN2M4YWI5OGIzOTk1NmZkZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvR1BVL0dQVVByb2Nlc3NQcm94eS5jcHAKQEAg LTI4MSw3ICsyODEsMTEgQEAgdm9pZCBHUFVQcm9jZXNzUHJveHk6OnVwZGF0ZVByb2Nlc3NBc3Nl cnRpb24oKQogICAgICAgICB9CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgbV9hY3Rpdml0 eUZyb21XZWJQcm9jZXNzZXMgPSBudWxscHRyOworCisgICAgLy8gVXNlIHN0ZDo6ZXhjaGFuZ2Uo KSBpbnN0ZWFkIG9mIGEgc2ltcGxlIG51bGxwdHIgYXNzaWdubWVudCB0byBhdm9pZCByZS1lbnRl cmluZyB0aGlzCisgICAgLy8gZnVuY3Rpb24gZHVyaW5nIHRoZSBkZXN0cnVjdG9yIG9mIHRoZSBQ cm9jZXNzVGhyb3R0bGVyIGFjdGl2aXR5LCBiZWZvcmUgc2V0dGluZworICAgIC8vIG1fYWN0aXZp dHlGcm9tV2ViUHJvY2Vzc2VzLgorICAgIHN0ZDo6ZXhjaGFuZ2UobV9hY3Rpdml0eUZyb21XZWJQ cm9jZXNzZXMsIG51bGxwdHIpOwogfQogCiBzdGF0aWMgaW5saW5lIEdQVVByb2Nlc3NTZXNzaW9u UGFyYW1ldGVycyBncHVQcm9jZXNzU2Vzc2lvblBhcmFtZXRlcnMoY29uc3QgV2Vic2l0ZURhdGFT dG9yZSYgc3RvcmUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9j ZXNzUG9vbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAK aW5kZXggM2QyNDRmZWVlN2JkNTA4MTQxMzc1ZjFkMmI5YjExODBmNDAzY2IxZS4uMzZiMmQ2Zjdh NzVhNTZiODU0YzY5ZTYyMGFiNzk4Zjc2ZTYwYTUxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcApAQCAtMTcxNSw2ICsxNzE1LDEwIEBAIHZvaWQgV2ViUHJv Y2Vzc1Bvb2w6OnVwZGF0ZVByb2Nlc3NBc3NlcnRpb25zKCkKICAgICBXZWJzaXRlRGF0YVN0b3Jl Ojpmb3JFYWNoV2Vic2l0ZURhdGFTdG9yZShbXSAoV2Vic2l0ZURhdGFTdG9yZSYgZGF0YVN0b3Jl KSB7CiAgICAgICAgIGRhdGFTdG9yZS5uZXR3b3JrUHJvY2VzcygpLnVwZGF0ZVByb2Nlc3NBc3Nl cnRpb24oKTsKICAgICB9KTsKKyNpZiBFTkFCTEUoR1BVX1BST0NFU1MpCisgICAgaWYgKGF1dG8q IGdwdVByb2Nlc3MgPSBHUFVQcm9jZXNzUHJveHk6OnNpbmdsZXRvbklmQ3JlYXRlZCgpKQorICAg ICAgICBncHVQcm9jZXNzLT51cGRhdGVQcm9jZXNzQXNzZXJ0aW9uKCk7CisjZW5kaWYKICNpZiBF TkFCTEUoU0VSVklDRV9XT1JLRVIpCiAgICAgLy8gQ2hlY2sgb24gbmV4dCBydW4gbG9vcCBzaW5j ZSB0aGUgd2ViIHByb2Nlc3MgcHJveHkgdG9rZW5zIGFyZSBwcm9iYWJseSBiZWluZyB1cGRhdGVk LgogICAgIGNhbGxPbk1haW5SdW5Mb29wKFtdIHsK