218997 2020-11-16 12:18:33 -0800 NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds 2020-11-16 15:52:11 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander webkit-bug-importer oldest_to_newest 1707943 0 wilander 2020-11-16 12:18:33 -0800 NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds. We should change the format specifier from %s to %{public}s. Note that this logging is just for ITP Debug Mode which is off by default, logs in-memory only, and is disabled again on browser quit. 1708006 1 webkit-bug-importer 2020-11-16 14:53:45 -0800 <rdar://problem/71460604> 1708010 2 414281 wilander 2020-11-16 15:01:28 -0800 Created attachment 414281 Patch for landing 1708025 3 ews-feeder 2020-11-16 15:52:11 -0800 Committed r269885: <https://trac.webkit.org/changeset/269885> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414281. 414281 2020-11-16 15:01:28 -0800 2020-11-16 15:52:11 -0800 Patch for landing bug-218997-20201116150127.patch text/plain 2350 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjY5ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU4MWUxNzE1ZDdiMDBhYmYz NDViNTVkODFkMDkzNmRmNDJiNjg1ZWIuLjdiZGJlY2EzOGMwOGE3NjI4OTRkM2U2MDY3MTVhOGU0 YmE4NTI0NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMTEtMTYgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgTmV0d29ya0RhdGFUYXNrQ29j b2E6OmFwcGx5Q29va2llUG9saWN5Rm9yVGhpcmRQYXJ0eUNOQU1FQ2xvYWtpbmcoKSByZWRhY3Rz IHRoZSBjb29raWUgbmFtZSBpbiBsb2cgb3V0cHV0IG9uIGN1c3RvbWVyIGJ1aWxkcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE4OTk3CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS83MTQ2MDYwND4KKworICAgICAgICBVbnJldmlld2VkIG1pbm9yIGNo YW5nZSB0byBsb2dnaW5nLgorCisgICAgICAgIE5ldHdvcmtEYXRhVGFza0NvY29hOjphcHBseUNv b2tpZVBvbGljeUZvclRoaXJkUGFydHlDTkFNRUNsb2FraW5nKCkgcmVkYWN0cyB0aGUKKyAgICAg ICAgY29va2llIG5hbWUgaW4gbG9nIG91dHB1dCBvbiBjdXN0b21lciBidWlsZHMuIFRoaXMgcGF0 Y2ggY2hhbmdlcyB0aGUgZm9ybWF0CisgICAgICAgIHNwZWNpZmllciBmcm9tICVzIHRvICV7cHVi bGljfXMuCisKKyAgICAgICAgTm90ZSB0aGF0IHRoaXMgbG9nZ2luZyBpcyBqdXN0IGZvciBJVFAg RGVidWcgTW9kZSB3aGljaCBpcyBvZmYgYnkgZGVmYXVsdCwgbG9ncworICAgICAgICBpbi1tZW1v cnkgb25seSwgYW5kIGlzIGRpc2FibGVkIGFnYWluIG9uIGJyb3dzZXIgcXVpdC4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIFRoaXMganVzdCBjaGFuZ2VzIGxvZyBvdXRwdXQgb24gY3VzdG9tZXIg YnVpbGRzLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNr Q29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFza0NvY29hOjphcHBseUNv b2tpZVBvbGljeUZvclRoaXJkUGFydHlDTkFNRUNsb2FraW5nKToKKwogMjAyMC0xMS0xNiAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtHUFVQcm9jZXNzXSBVcGRh dGUgR1BVUHJvY2VzcyBwcm9jZXNzIGFzc2VydGlvbiBiYXNlZCBvbiBhY3RpdmUgV2ViUHJvY2Vz c2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdv cmtEYXRhVGFza0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9O ZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQppbmRleCBhODRiYWQ0ZDZmZjQ3Zjg5OTQyN2ViYzAxYmY3 MGZiOGQ4NDdhNjc2Li42Y2M0NWFiMWIzNmRlNDY2ZjZkZTJiMTI4NWUzZjc0M2ExMjY5ZWMwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRh VGFza0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0 d29ya0RhdGFUYXNrQ29jb2EubW0KQEAgLTIwNSw3ICsyMDUsNyBAQCB2b2lkIE5ldHdvcmtEYXRh VGFza0NvY29hOjphcHBseUNvb2tpZVBvbGljeUZvclRoaXJkUGFydHlDTkFNRUNsb2FraW5nKGNv bnN0IFdlYgogICAgICAgICAgICAgICAgIGNvb2tpZSA9IFdlYkNvcmU6Ok5ldHdvcmtTdG9yYWdl U2Vzc2lvbjo6Y2FwRXhwaXJ5T2ZQZXJzaXN0ZW50Q29va2llKGNvb2tpZSwgYWdlQ2FwRm9yQ05B TUVDbG9ha2VkQ29va2llcyk7CiAgICAgICAgICAgICAgICAgW2NhcHBlZENvb2tpZXMgYWRkT2Jq ZWN0OmNvb2tpZV07CiAgICAgICAgICAgICAgICAgaWYgKGRlYnVnTG9nZ2luZ0VuYWJsZWQpCi0g ICAgICAgICAgICAgICAgICAgIFJFTEVBU0VfTE9HX0lORk8oSVRQRGVidWcsICJDYXBwZWQgdGhl IGV4cGlyeSBvZiB0aGlyZC1wYXJ0eSBDTkFNRSBjbG9ha2VkIGNvb2tpZSBuYW1lZCAlcy4iLCBb W2Nvb2tpZSBuYW1lXSBVVEY4U3RyaW5nXSk7CisgICAgICAgICAgICAgICAgICAgIFJFTEVBU0Vf TE9HX0lORk8oSVRQRGVidWcsICJDYXBwZWQgdGhlIGV4cGlyeSBvZiB0aGlyZC1wYXJ0eSBDTkFN RSBjbG9ha2VkIGNvb2tpZSBuYW1lZCAle3B1YmxpY31zLiIsIFtbY29va2llIG5hbWVdIFVURjhT dHJpbmddKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHJldHVybiBjYXBwZWRDb29raWVz OwogICAgICAgICB9Cg==