21898 2008-10-27 09:07:28 -0700 Remove unused TextDrawingMode flags from GraphicsContext 2012-08-22 07:54:23 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 brettw cmarcelo benjamin cmarcelo eric senorblanco webkit.review.bot oldest_to_newest 96740 0 brettw 2008-10-27 09:07:28 -0700 I could not figure out how to handle this text drawing mode looking at the header. It appears that this value is never used, so it should be removed. 700674 1 cmarcelo 2012-08-21 05:56:55 -0700 This was also suggested in this other bug comment https://bugs.webkit.org/show_bug.cgi?id=42110#c2 700676 2 cmarcelo 2012-08-21 05:57:20 -0700 This was also suggested in comment https://bugs.webkit.org/show_bug.cgi?id=42110#c2 700682 3 159673 cmarcelo 2012-08-21 06:04:54 -0700 Created attachment 159673 Patch 700702 4 159678 cmarcelo 2012-08-21 06:38:43 -0700 Created attachment 159678 Patch 701345 5 159678 benjamin 2012-08-21 17:15:30 -0700 Comment on attachment 159678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159678&action=review Looks good, grep does not find those values used anywhere. > Source/WebCore/platform/graphics/GraphicsContext.h:-134 > - TextModeInvisible = 0, > TextModeFill = 1 << 0, > TextModeStroke = 1 << 1, > - TextModeClip = 1 << 2 Why not shift the values? TextModeFill = 0, TextModeStroke = 1 << 0 701373 6 159678 cmarcelo 2012-08-21 17:36:49 -0700 Comment on attachment 159678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159678&action=review Thanks for the review. >> Source/WebCore/platform/graphics/GraphicsContext.h:-134 >> - TextModeClip = 1 << 2 > > Why not shift the values? > TextModeFill = 0, > TextModeStroke = 1 << 0 These values are used as bitflags in existing code. TextModeFill can't be zero wouldn't because we wouldn't be able to identify its presence using & binary operator. 701375 7 159678 cmarcelo 2012-08-21 17:38:04 -0700 Comment on attachment 159678 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159678&action=review >>> Source/WebCore/platform/graphics/GraphicsContext.h:-134 >>> - TextModeClip = 1 << 2 >> >> Why not shift the values? >> TextModeFill = 0, >> TextModeStroke = 1 << 0 > > These values are used as bitflags in existing code. TextModeFill can't be zero wouldn't because we wouldn't be able to identify its presence using & binary operator. Oh my, s/wouldn't//. :-P 701386 8 159678 benjamin 2012-08-21 17:46:41 -0700 Comment on attachment 159678 Patch > > Why not shift the values? > > TextModeFill = 0, > > TextModeStroke = 1 << 0 > > These values are used as bitflags in existing code. TextModeFill can't be zero because we wouldn't be able to identify its presence using & binary operator. Yep, that sounds ok. Feel free to cq+ if you haven't committed already. 701899 9 cmarcelo 2012-08-22 07:54:23 -0700 Committed r126302: <http://trac.webkit.org/changeset/126302> 159673 2012-08-21 06:04:54 -0700 2012-08-21 06:38:37 -0700 Patch bug-21898-20120821100415.patch text/plain 5072 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg1MGFkOWI3YTE0NDUx ZDU0NDE5NzBlMTBkNmJlOGQwNTQ1OTkyNS4uODQwMDkyNDMwMTIxNjAwNTJhNzRjZGVmMTgwZGQx ODliZmE4NTZjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTIxICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBUZXh0RHJhd2luZ01vZGUgZmxhZ3MgZnJvbSBHcmFw aGljc0NvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxODk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIFRleHRNb2RlQ2xpcCBhbmQgVGV4dE1vZGVJbnZpc2libGUuIFRoZXNlIGFyZSBu b3QgdXNlZCBieSBhbnkgcG9ydCwgYW5kCisgICAgICAgIGFjY29yZGluZyB0byBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMTAjYzIgdGhlc2Ugd2VyZSBhZGRlZAor ICAgICAgICBqdXN0IHRvIG1hcCBDRyBleGlzdGluZyBmbGFncywgYnV0IGFyZSBub3QgdXNlZC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1UZXh0RHJhd2luZ01vZGUpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9QYWludGVyT3BlblZHLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhaW50ZXJPcGVuVkc6OmRyYXdUZXh0KToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGxhdGZvcm1Db250ZXh0U2tpYTo6c2V0VGV4dERyYXdpbmdNb2RlKToKKwogMjAxMi0w OC0yMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4 XSBNb3ZlIFN0cmluZyByZWxhdGVkIGNvZGUgaW4gVjhCaW5kaW5nIHRvIGEgc2VwYXJhdGUgZmls ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQuaAppbmRleCBhMmY0ZDY4NjcyZWJkZmUwYThkMDE1MWU5ODI0YmYyODBmYTY4YzMwLi4xYzFi NjczYTA1ZTEyOGUzOTNkMjk3ZTQxZGRkOTJjNjM5OWFjZWVmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApAQCAtMTI4LDEwICsx MjgsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3MgVHJhbnNmb3JtYXRpb25NYXRy aXg7CiAKICAgICBlbnVtIFRleHREcmF3aW5nTW9kZSB7Ci0gICAgICAgIFRleHRNb2RlSW52aXNp YmxlID0gMCwKLSAgICAgICAgVGV4dE1vZGVGaWxsICAgICAgPSAxIDw8IDAsCi0gICAgICAgIFRl eHRNb2RlU3Ryb2tlICAgID0gMSA8PCAxLAotICAgICAgICBUZXh0TW9kZUNsaXAgICAgICA9IDEg PDwgMgorICAgICAgICBUZXh0TW9kZUZpbGwgICAgICA9IDAsCisgICAgICAgIFRleHRNb2RlU3Ry b2tlICAgID0gMSA8PCAwLAogICAgIH07CiAgICAgdHlwZWRlZiB1bnNpZ25lZCBUZXh0RHJhd2lu Z01vZGVGbGFnczsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCmluZGV4IGJlZmFkYjk0MDAxNWE2NWJjOWY0 MmU5ZTQyM2E1Y2E2OGU0NDI3OTYuLjJlZWQ5Y2Q2YmQyNDE2NTMyODAyOGZjODhlZDM4YmNhYzNj MGU3MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dy YXBoaWNzQ29udGV4dENHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKQEAgLTE2NDYsMTIgKzE2NDYsOCBAQCB2b2lkIEdy YXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1UZXh0RHJhd2luZ01vZGUoVGV4dERyYXdpbmdNb2Rl RmxhZ3MgbW9kZSkKICAgICBpZiAocGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47 CiAKLSAgICAvLyBXb3csIHdpc2ggQ0cgaGFkIHVzZWQgYml0cyBoZXJlLgogICAgIENHQ29udGV4 dFJlZiBjb250ZXh0ID0gcGxhdGZvcm1Db250ZXh0KCk7CiAgICAgc3dpdGNoIChtb2RlKSB7Ci0g ICAgY2FzZSBUZXh0TW9kZUludmlzaWJsZToKLSAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdp bmdNb2RlKGNvbnRleHQsIGtDR1RleHRJbnZpc2libGUpOwotICAgICAgICBicmVhazsKICAgICBj YXNlIFRleHRNb2RlRmlsbDoKICAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNv bnRleHQsIGtDR1RleHRGaWxsKTsKICAgICAgICAgYnJlYWs7CkBAIC0xNjYxLDE4ICsxNjU3LDYg QEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldFBsYXRmb3JtVGV4dERyYXdpbmdNb2RlKFRleHRE cmF3aW5nTW9kZUZsYWdzIG1vZGUpCiAgICAgY2FzZSBUZXh0TW9kZUZpbGwgfCBUZXh0TW9kZVN0 cm9rZToKICAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNvbnRleHQsIGtDR1Rl eHRGaWxsU3Ryb2tlKTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBUZXh0TW9kZUNsaXA6Ci0g ICAgICAgIENHQ29udGV4dFNldFRleHREcmF3aW5nTW9kZShjb250ZXh0LCBrQ0dUZXh0Q2xpcCk7 Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2UgVGV4dE1vZGVGaWxsIHwgVGV4dE1vZGVDbGlwOgot ICAgICAgICBDR0NvbnRleHRTZXRUZXh0RHJhd2luZ01vZGUoY29udGV4dCwga0NHVGV4dEZpbGxD bGlwKTsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBUZXh0TW9kZVN0cm9rZSB8IFRleHRNb2Rl Q2xpcDoKLSAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNvbnRleHQsIGtDR1Rl eHRTdHJva2VDbGlwKTsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBUZXh0TW9kZUZpbGwgfCBU ZXh0TW9kZVN0cm9rZSB8IFRleHRNb2RlQ2xpcDoKLSAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERy YXdpbmdNb2RlKGNvbnRleHQsIGtDR1RleHRGaWxsU3Ryb2tlQ2xpcCk7Ci0gICAgICAgIGJyZWFr OwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGJyZWFrOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9QYWludGVyT3BlblZHLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9QYWludGVyT3BlblZHLmNwcApp bmRleCA4MDI5NzgzNDNlN2VjNTc4NjU5OGExOGQ0ZGU0MWE2YzcxNDlmNDQ2Li4xMjNhMmZjYmZh Y2RhMTcwN2JiMDI2ZmQ4MWY5M2JlYmUyNzQ5OTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVudmcvUGFpbnRlck9wZW5WRy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL1BhaW50ZXJPcGVuVkcuY3BwCkBAIC0x MTE0LDggKzExMTQsNiBAQCB2b2lkIFBhaW50ZXJPcGVuVkc6OmRyYXdUZXh0KFZHRm9udCB2Z0Zv bnQsIFZlY3RvcjxWR3VpbnQ+JiBjaGFyYWN0ZXJzLCBWR2Zsb2F0KgogCiAgICAgVkdiaXRmaWVs ZCBwYWludE1vZGVzID0gMDsKIAotICAgIGlmIChtX3N0YXRlLT50ZXh0RHJhd2luZ01vZGUgJiBU ZXh0TW9kZUNsaXApCi0gICAgICAgIHJldHVybjsgLy8gdW5zdXBwb3J0ZWQgZm9yIGV2ZXJ5IHBv cnQgZXhjZXB0IENHIGF0IHRoZSB0aW1lIG9mIHdyaXRpbmcKICAgICBpZiAobV9zdGF0ZS0+dGV4 dERyYXdpbmdNb2RlICYgVGV4dE1vZGVGaWxsICYmICFtX3N0YXRlLT5maWxsRGlzYWJsZWQoKSkK ICAgICAgICAgcGFpbnRNb2RlcyB8PSBWR19GSUxMX1BBVEg7CiAgICAgaWYgKG1fc3RhdGUtPnRl eHREcmF3aW5nTW9kZSAmIFRleHRNb2RlU3Ryb2tlICYmICFtX3N0YXRlLT5zdHJva2VEaXNhYmxl ZCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Q bGF0Zm9ybUNvbnRleHRTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKaW5kZXggMzk0Njg4ZjRhOWJlNGMzYTMxZDBi ZjBlM2M1NjJlODhmMmRjY2YwZi4uM2NmYmQzNWViMzEzZjdhNmViYTNmZDc5ODA3NTA1ZjMwYzNm NGI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Q bGF0Zm9ybUNvbnRleHRTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCkBAIC01MjksOSArNTI5LDYgQEAgU2tY ZmVybW9kZTo6TW9kZSBQbGF0Zm9ybUNvbnRleHRTa2lhOjpnZXRYZmVybW9kZU1vZGUoKSBjb25z dAogCiB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OnNldFRleHREcmF3aW5nTW9kZShUZXh0RHJh d2luZ01vZGVGbGFncyBtb2RlKQogewotICAgIC8vIFRleHRNb2RlQ2xpcCBpcyBuZXZlciB1c2Vk LCBzbyB3ZSBhc3NlcnQgdGhhdCBpdCBpc24ndCBzZXQ6Ci0gICAgLy8gaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxODk4Ci0gICAgQVNTRVJUKCEobW9kZSAmIFRleHRN b2RlQ2xpcCkpOwogICAgIG1fc3RhdGUtPm1fdGV4dERyYXdpbmdNb2RlID0gbW9kZTsKIH0KIAo= 159678 2012-08-21 06:38:43 -0700 2012-08-21 17:46:41 -0700 Patch bug-21898-20120821103803.patch text/plain 5003 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg1MGFkOWI3YTE0NDUx ZDU0NDE5NzBlMTBkNmJlOGQwNTQ1OTkyNS4uODQwMDkyNDMwMTIxNjAwNTJhNzRjZGVmMTgwZGQx ODliZmE4NTZjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTIxICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBUZXh0RHJhd2luZ01vZGUgZmxhZ3MgZnJvbSBHcmFw aGljc0NvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxODk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIFRleHRNb2RlQ2xpcCBhbmQgVGV4dE1vZGVJbnZpc2libGUuIFRoZXNlIGFyZSBu b3QgdXNlZCBieSBhbnkgcG9ydCwgYW5kCisgICAgICAgIGFjY29yZGluZyB0byBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMTAjYzIgdGhlc2Ugd2VyZSBhZGRlZAor ICAgICAgICBqdXN0IHRvIG1hcCBDRyBleGlzdGluZyBmbGFncywgYnV0IGFyZSBub3QgdXNlZC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1UZXh0RHJhd2luZ01vZGUpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9QYWludGVyT3BlblZHLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhaW50ZXJPcGVuVkc6OmRyYXdUZXh0KToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGxhdGZvcm1Db250ZXh0U2tpYTo6c2V0VGV4dERyYXdpbmdNb2RlKToKKwogMjAxMi0w OC0yMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4 XSBNb3ZlIFN0cmluZyByZWxhdGVkIGNvZGUgaW4gVjhCaW5kaW5nIHRvIGEgc2VwYXJhdGUgZmls ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQuaAppbmRleCBhMmY0ZDY4NjcyZWJkZmUwYThkMDE1MWU5ODI0YmYyODBmYTY4YzMwLi4wMzY5 YjIwYTc2YjMwN2ZkMzJmMTFkNThmNmI1NjVhNjhhMWNjYTYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApAQCAtMTI4LDEwICsx MjgsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3MgVHJhbnNmb3JtYXRpb25NYXRy aXg7CiAKICAgICBlbnVtIFRleHREcmF3aW5nTW9kZSB7Ci0gICAgICAgIFRleHRNb2RlSW52aXNp YmxlID0gMCwKICAgICAgICAgVGV4dE1vZGVGaWxsICAgICAgPSAxIDw8IDAsCiAgICAgICAgIFRl eHRNb2RlU3Ryb2tlICAgID0gMSA8PCAxLAotICAgICAgICBUZXh0TW9kZUNsaXAgICAgICA9IDEg PDwgMgogICAgIH07CiAgICAgdHlwZWRlZiB1bnNpZ25lZCBUZXh0RHJhd2luZ01vZGVGbGFnczsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhp Y3NDb250ZXh0Q0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3Jh cGhpY3NDb250ZXh0Q0cuY3BwCmluZGV4IGJlZmFkYjk0MDAxNWE2NWJjOWY0MmU5ZTQyM2E1Y2E2 OGU0NDI3OTYuLjJlZWQ5Y2Q2YmQyNDE2NTMyODAyOGZjODhlZDM4YmNhYzNjMGU3MTkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4 dENHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGlj c0NvbnRleHRDRy5jcHAKQEAgLTE2NDYsMTIgKzE2NDYsOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6c2V0UGxhdGZvcm1UZXh0RHJhd2luZ01vZGUoVGV4dERyYXdpbmdNb2RlRmxhZ3MgbW9kZSkK ICAgICBpZiAocGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBX b3csIHdpc2ggQ0cgaGFkIHVzZWQgYml0cyBoZXJlLgogICAgIENHQ29udGV4dFJlZiBjb250ZXh0 ID0gcGxhdGZvcm1Db250ZXh0KCk7CiAgICAgc3dpdGNoIChtb2RlKSB7Ci0gICAgY2FzZSBUZXh0 TW9kZUludmlzaWJsZToKLSAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNvbnRl eHQsIGtDR1RleHRJbnZpc2libGUpOwotICAgICAgICBicmVhazsKICAgICBjYXNlIFRleHRNb2Rl RmlsbDoKICAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNvbnRleHQsIGtDR1Rl eHRGaWxsKTsKICAgICAgICAgYnJlYWs7CkBAIC0xNjYxLDE4ICsxNjU3LDYgQEAgdm9pZCBHcmFw aGljc0NvbnRleHQ6OnNldFBsYXRmb3JtVGV4dERyYXdpbmdNb2RlKFRleHREcmF3aW5nTW9kZUZs YWdzIG1vZGUpCiAgICAgY2FzZSBUZXh0TW9kZUZpbGwgfCBUZXh0TW9kZVN0cm9rZToKICAgICAg ICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNvbnRleHQsIGtDR1RleHRGaWxsU3Ryb2tl KTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBUZXh0TW9kZUNsaXA6Ci0gICAgICAgIENHQ29u dGV4dFNldFRleHREcmF3aW5nTW9kZShjb250ZXh0LCBrQ0dUZXh0Q2xpcCk7Ci0gICAgICAgIGJy ZWFrOwotICAgIGNhc2UgVGV4dE1vZGVGaWxsIHwgVGV4dE1vZGVDbGlwOgotICAgICAgICBDR0Nv bnRleHRTZXRUZXh0RHJhd2luZ01vZGUoY29udGV4dCwga0NHVGV4dEZpbGxDbGlwKTsKLSAgICAg ICAgYnJlYWs7Ci0gICAgY2FzZSBUZXh0TW9kZVN0cm9rZSB8IFRleHRNb2RlQ2xpcDoKLSAgICAg ICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNvbnRleHQsIGtDR1RleHRTdHJva2VDbGlw KTsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBUZXh0TW9kZUZpbGwgfCBUZXh0TW9kZVN0cm9r ZSB8IFRleHRNb2RlQ2xpcDoKLSAgICAgICAgQ0dDb250ZXh0U2V0VGV4dERyYXdpbmdNb2RlKGNv bnRleHQsIGtDR1RleHRGaWxsU3Ryb2tlQ2xpcCk7Ci0gICAgICAgIGJyZWFrOwogICAgIGRlZmF1 bHQ6CiAgICAgICAgIGJyZWFrOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL29wZW52Zy9QYWludGVyT3BlblZHLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9QYWludGVyT3BlblZHLmNwcAppbmRleCA4MDI5Nzgz NDNlN2VjNTc4NjU5OGExOGQ0ZGU0MWE2YzcxNDlmNDQ2Li4xMjNhMmZjYmZhY2RhMTcwN2JiMDI2 ZmQ4MWY5M2JlYmUyNzQ5OTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9vcGVudmcvUGFpbnRlck9wZW5WRy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL1BhaW50ZXJPcGVuVkcuY3BwCkBAIC0xMTE0LDggKzExMTQs NiBAQCB2b2lkIFBhaW50ZXJPcGVuVkc6OmRyYXdUZXh0KFZHRm9udCB2Z0ZvbnQsIFZlY3RvcjxW R3VpbnQ+JiBjaGFyYWN0ZXJzLCBWR2Zsb2F0KgogCiAgICAgVkdiaXRmaWVsZCBwYWludE1vZGVz ID0gMDsKIAotICAgIGlmIChtX3N0YXRlLT50ZXh0RHJhd2luZ01vZGUgJiBUZXh0TW9kZUNsaXAp Ci0gICAgICAgIHJldHVybjsgLy8gdW5zdXBwb3J0ZWQgZm9yIGV2ZXJ5IHBvcnQgZXhjZXB0IENH IGF0IHRoZSB0aW1lIG9mIHdyaXRpbmcKICAgICBpZiAobV9zdGF0ZS0+dGV4dERyYXdpbmdNb2Rl ICYgVGV4dE1vZGVGaWxsICYmICFtX3N0YXRlLT5maWxsRGlzYWJsZWQoKSkKICAgICAgICAgcGFp bnRNb2RlcyB8PSBWR19GSUxMX1BBVEg7CiAgICAgaWYgKG1fc3RhdGUtPnRleHREcmF3aW5nTW9k ZSAmIFRleHRNb2RlU3Ryb2tlICYmICFtX3N0YXRlLT5zdHJva2VEaXNhYmxlZCgpKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRl eHRTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZv cm1Db250ZXh0U2tpYS5jcHAKaW5kZXggMzk0Njg4ZjRhOWJlNGMzYTMxZDBiZjBlM2M1NjJlODhm MmRjY2YwZi4uM2NmYmQzNWViMzEzZjdhNmViYTNmZDc5ODA3NTA1ZjMwYzNmNGI2NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRl eHRTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1Bs YXRmb3JtQ29udGV4dFNraWEuY3BwCkBAIC01MjksOSArNTI5LDYgQEAgU2tYZmVybW9kZTo6TW9k ZSBQbGF0Zm9ybUNvbnRleHRTa2lhOjpnZXRYZmVybW9kZU1vZGUoKSBjb25zdAogCiB2b2lkIFBs YXRmb3JtQ29udGV4dFNraWE6OnNldFRleHREcmF3aW5nTW9kZShUZXh0RHJhd2luZ01vZGVGbGFn cyBtb2RlKQogewotICAgIC8vIFRleHRNb2RlQ2xpcCBpcyBuZXZlciB1c2VkLCBzbyB3ZSBhc3Nl cnQgdGhhdCBpdCBpc24ndCBzZXQ6Ci0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxODk4Ci0gICAgQVNTRVJUKCEobW9kZSAmIFRleHRNb2RlQ2xpcCkpOwog ICAgIG1fc3RhdGUtPm1fdGV4dERyYXdpbmdNb2RlID0gbW9kZTsKIH0KIAo=